yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

feat(queue): add JIRA task links for TODOs

This commit is contained in:
Ilya Averyanov 2024-06-20 15:38:16 +03:00
parent a9c976b6c1
commit be175d205c
4 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_agent.erl
View File

@ -57,7 +57,7 @@ renew_streams(#{} = State) ->
fetch_stream_events(State). fetch_stream_events(State).
on_stream_progress(State, _StreamProgress) -> on_stream_progress(State, _StreamProgress) ->
%% TODO %% TODO https://emqx.atlassian.net/browse/EMQX-12572
%% Send to leader %% Send to leader
State. State.
@ -98,7 +98,7 @@ init_state(Opts) ->
}. }.
delete_group_subscription(State, _ShareTopicFilter) -> delete_group_subscription(State, _ShareTopicFilter) ->
%% TODO %% TODO https://emqx.atlassian.net/browse/EMQX-12572
State. State.
add_group_subscription( add_group_subscription(

14
apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_leader.erl
View File

@ -39,9 +39,9 @@
topic := emqx_types:topic(), topic := emqx_types:topic(),
%% For ds router, not an actual session_id %% For ds router, not an actual session_id
router_id := binary(), router_id := binary(),
%% TODO %% TODO https://emqx.atlassian.net/browse/EMQX-12307
%% Persist progress %% Persist progress
%% TODO %% TODO https://emqx.atlassian.net/browse/EMQX-12575
%% Implement some stats to assign evenly? %% Implement some stats to assign evenly?
stream_progresses := #{ stream_progresses := #{
emqx_ds:stream() => emqx_ds:iterator() emqx_ds:stream() => emqx_ds:iterator()
@ -74,7 +74,7 @@
%% Constants %% Constants
%% TODO %% TODO https://emqx.atlassian.net/browse/EMQX-12574
%% Move to settings %% Move to settings
-define(RENEW_LEASE_INTERVAL, 5000). -define(RENEW_LEASE_INTERVAL, 5000).
-define(RENEW_STREAMS_INTERVAL, 5000). -define(RENEW_STREAMS_INTERVAL, 5000).
@ -181,7 +181,7 @@ renew_streams(#{stream_progresses := Progresses, topic := Topic} = Data0) ->
{_, Streams} = lists:unzip( {_, Streams} = lists:unzip(
emqx_ds:get_streams(?PERSISTENT_MESSAGE_DB, TopicFilter, now_ms()) emqx_ds:get_streams(?PERSISTENT_MESSAGE_DB, TopicFilter, now_ms())
), ),
%% TODO %% TODO https://emqx.atlassian.net/browse/EMQX-12572
%% Handle stream removal %% Handle stream removal
NewProgresses = lists:foldl( NewProgresses = lists:foldl(
fun(Stream, ProgressesAcc) -> fun(Stream, ProgressesAcc) ->
@ -198,7 +198,7 @@ renew_streams(#{stream_progresses := Progresses, topic := Topic} = Data0) ->
Progresses, Progresses,
Streams Streams
), ),
%% TODO %% TODO https://emqx.atlassian.net/browse/EMQX-12572
%% Initiate reassigment %% Initiate reassigment
?SLOG(info, #{ ?SLOG(info, #{
msg => leader_renew_streams, msg => leader_renew_streams,
@ -207,7 +207,7 @@ renew_streams(#{stream_progresses := Progresses, topic := Topic} = Data0) ->
}), }),
Data0#{stream_progresses => NewProgresses}. Data0#{stream_progresses => NewProgresses}.
%% TODO %% TODO https://emqx.atlassian.net/browse/EMQX-12572
%% This just gives unassigned streams to the connecting agent, %% This just gives unassigned streams to the connecting agent,
%% we need to implement actual stream (re)assignment. %% we need to implement actual stream (re)assignment.
connect_agent( connect_agent(
@ -301,7 +301,7 @@ update_agent_stream_states(
), ),
case AgentVersion == Version orelse AgentPrevVersion == Version of case AgentVersion == Version orelse AgentPrevVersion == Version of
false -> false ->
%% TODO %% TODO https://emqx.atlassian.net/browse/EMQX-12572
%% send invalidate to agent %% send invalidate to agent
Data0; Data0;
true -> true ->

2
apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_proto.erl
View File

@ -2,7 +2,7 @@
%% Copyright (c) 2024 EMQ Technologies Co., Ltd. All Rights Reserved. %% Copyright (c) 2024 EMQ Technologies Co., Ltd. All Rights Reserved.
%%-------------------------------------------------------------------- %%--------------------------------------------------------------------
%% TODO %% TODO https://emqx.atlassian.net/browse/EMQX-12573
%% This should be wrapped with a proto_v1 module. %% This should be wrapped with a proto_v1 module.
%% For simplicity, send as simple OTP messages for now. %% For simplicity, send as simple OTP messages for now.

2
apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_registry.erl
View File

@ -80,7 +80,7 @@ terminate(_Reason, _State) ->
%%-------------------------------------------------------------------- %%--------------------------------------------------------------------
do_lookup_leader(Agent, TopicFilter, State) -> do_lookup_leader(Agent, TopicFilter, State) ->
%% TODO %% TODO https://emqx.atlassian.net/browse/EMQX-12309
%% Cluster-wide unique leader election should be implemented %% Cluster-wide unique leader election should be implemented
Id = emqx_ds_shared_sub_leader:id(TopicFilter), Id = emqx_ds_shared_sub_leader:id(TopicFilter),
LeaderPid = LeaderPid =