From be175d205c0704be9abc701ac8aed62f6d30b76e Mon Sep 17 00:00:00 2001
From: Ilya Averyanov <av@rubybox.dev>
Date: Thu, 20 Jun 2024 15:38:16 +0300
Subject: [PATCH] feat(queue): add JIRA task links for TODOs

---
 .../src/emqx_ds_shared_sub_agent.erl               |  4 ++--
 .../src/emqx_ds_shared_sub_leader.erl              | 14 +++++++-------
 .../src/emqx_ds_shared_sub_proto.erl               |  2 +-
 .../src/emqx_ds_shared_sub_registry.erl            |  2 +-
 4 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_agent.erl b/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_agent.erl
index 0c66759fd..29745aa4a 100644
--- a/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_agent.erl
+++ b/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_agent.erl
@@ -57,7 +57,7 @@ renew_streams(#{} = State) ->
     fetch_stream_events(State).
 
 on_stream_progress(State, _StreamProgress) ->
-    %% TODO
+    %% TODO https://emqx.atlassian.net/browse/EMQX-12572
     %% Send to leader
     State.
 
@@ -98,7 +98,7 @@ init_state(Opts) ->
     }.
 
 delete_group_subscription(State, _ShareTopicFilter) ->
-    %% TODO
+    %% TODO https://emqx.atlassian.net/browse/EMQX-12572
     State.
 
 add_group_subscription(
diff --git a/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_leader.erl b/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_leader.erl
index 0199b0eed..2081f7a49 100644
--- a/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_leader.erl
+++ b/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_leader.erl
@@ -39,9 +39,9 @@
     topic := emqx_types:topic(),
     %% For ds router, not an actual session_id
     router_id := binary(),
-    %% TODO
+    %% TODO https://emqx.atlassian.net/browse/EMQX-12307
     %% Persist progress
-    %% TODO
+    %% TODO https://emqx.atlassian.net/browse/EMQX-12575
     %% Implement some stats to assign evenly?
     stream_progresses := #{
         emqx_ds:stream() => emqx_ds:iterator()
@@ -74,7 +74,7 @@
 
 %% Constants
 
-%% TODO
+%% TODO https://emqx.atlassian.net/browse/EMQX-12574
 %% Move to settings
 -define(RENEW_LEASE_INTERVAL, 5000).
 -define(RENEW_STREAMS_INTERVAL, 5000).
@@ -181,7 +181,7 @@ renew_streams(#{stream_progresses := Progresses, topic := Topic} = Data0) ->
     {_, Streams} = lists:unzip(
         emqx_ds:get_streams(?PERSISTENT_MESSAGE_DB, TopicFilter, now_ms())
     ),
-    %% TODO
+    %% TODO https://emqx.atlassian.net/browse/EMQX-12572
     %% Handle stream removal
     NewProgresses = lists:foldl(
         fun(Stream, ProgressesAcc) ->
@@ -198,7 +198,7 @@ renew_streams(#{stream_progresses := Progresses, topic := Topic} = Data0) ->
         Progresses,
         Streams
     ),
-    %% TODO
+    %% TODO https://emqx.atlassian.net/browse/EMQX-12572
     %% Initiate reassigment
     ?SLOG(info, #{
         msg => leader_renew_streams,
@@ -207,7 +207,7 @@ renew_streams(#{stream_progresses := Progresses, topic := Topic} = Data0) ->
     }),
     Data0#{stream_progresses => NewProgresses}.
 
-%% TODO
+%% TODO https://emqx.atlassian.net/browse/EMQX-12572
 %% This just gives unassigned streams to the connecting agent,
 %% we need to implement actual stream (re)assignment.
 connect_agent(
@@ -301,7 +301,7 @@ update_agent_stream_states(
     ),
     case AgentVersion == Version orelse AgentPrevVersion == Version of
         false ->
-            %% TODO
+            %% TODO https://emqx.atlassian.net/browse/EMQX-12572
             %% send invalidate to agent
             Data0;
         true ->
diff --git a/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_proto.erl b/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_proto.erl
index c9609a773..d9a0b994f 100644
--- a/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_proto.erl
+++ b/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_proto.erl
@@ -2,7 +2,7 @@
 %% Copyright (c) 2024 EMQ Technologies Co., Ltd. All Rights Reserved.
 %%--------------------------------------------------------------------
 
-%% TODO
+%% TODO https://emqx.atlassian.net/browse/EMQX-12573
 %% This should be wrapped with a proto_v1 module.
 %% For simplicity, send as simple OTP messages for now.
 
diff --git a/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_registry.erl b/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_registry.erl
index d2d0c1747..637222fc8 100644
--- a/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_registry.erl
+++ b/apps/emqx_ds_shared_sub/src/emqx_ds_shared_sub_registry.erl
@@ -80,7 +80,7 @@ terminate(_Reason, _State) ->
 %%--------------------------------------------------------------------
 
 do_lookup_leader(Agent, TopicFilter, State) ->
-    %% TODO
+    %% TODO https://emqx.atlassian.net/browse/EMQX-12309
     %% Cluster-wide unique leader election should be implemented
     Id = emqx_ds_shared_sub_leader:id(TopicFilter),
     LeaderPid =