yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(emqx_modules): Swallow errors when write modules

This commit is contained in:
Zaiming Shi 2020-11-06 15:20:38 +01:00
parent d47a2294ca
commit adc9cc30f6
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/emqx_modules.erl
View File

@ -125,7 +125,7 @@ load_module(ModuleName, Persistent) ->
case ModuleName:load(Env) of case ModuleName:load(Env) of
ok -> ok ->
ets:insert(?MODULE, {ModuleName, true}), ets:insert(?MODULE, {ModuleName, true}),
write_loaded(Persistent), ok = write_loaded(Persistent),
?LOG(info, "Load ~s module successfully.", [ModuleName]); ?LOG(info, "Load ~s module successfully.", [ModuleName]);
{error, Error} -> {error, Error} ->
?LOG(error, "Load module ~s failed, cannot load for ~0p", [ModuleName, Error]), ?LOG(error, "Load module ~s failed, cannot load for ~0p", [ModuleName, Error]),
@ -152,7 +152,7 @@ unload_module(ModuleName, Persistent) ->
case ModuleName:unload(Env) of case ModuleName:unload(Env) of
ok -> ok ->
ets:insert(?MODULE, {ModuleName, false}), ets:insert(?MODULE, {ModuleName, false}),
write_loaded(Persistent), ok = write_loaded(Persistent),
?LOG(info, "Unload ~s module successfully.", [ModuleName]); ?LOG(info, "Unload ~s module successfully.", [ModuleName]);
{error, Error} -> {error, Error} ->
?LOG(error, "Unload module ~s failed, cannot unload for ~0p", [ModuleName, Error]) ?LOG(error, "Unload module ~s failed, cannot unload for ~0p", [ModuleName, Error])
@ -164,6 +164,6 @@ write_loaded(true) ->
ok -> ok; ok -> ok;
{error, Error} -> {error, Error} ->
?LOG(error, "Write File ~p Error: ~p", [FilePath, Error]), ?LOG(error, "Write File ~p Error: ~p", [FilePath, Error]),
{error, Error} ok
end; end;
write_loaded(false) -> ok. write_loaded(false) -> ok.