From adc9cc30f684216907ef665fd25e27ae716ecce2 Mon Sep 17 00:00:00 2001
From: Zaiming Shi <zmstone@gmail.com>
Date: Fri, 6 Nov 2020 15:20:38 +0100
Subject: [PATCH] refactor(emqx_modules): Swallow errors when write modules

---
 src/emqx_modules.erl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/emqx_modules.erl b/src/emqx_modules.erl
index 55fb44001..f683ab1dd 100644
--- a/src/emqx_modules.erl
+++ b/src/emqx_modules.erl
@@ -125,7 +125,7 @@ load_module(ModuleName, Persistent) ->
     case ModuleName:load(Env) of
         ok ->
             ets:insert(?MODULE, {ModuleName, true}),
-            write_loaded(Persistent),
+            ok = write_loaded(Persistent),
             ?LOG(info, "Load ~s module successfully.", [ModuleName]);
         {error, Error} ->
             ?LOG(error, "Load module ~s failed, cannot load for ~0p", [ModuleName, Error]),
@@ -152,7 +152,7 @@ unload_module(ModuleName, Persistent) ->
     case ModuleName:unload(Env) of
         ok ->
             ets:insert(?MODULE, {ModuleName, false}),
-            write_loaded(Persistent),
+            ok = write_loaded(Persistent),
             ?LOG(info, "Unload ~s module successfully.", [ModuleName]);
         {error, Error} ->
             ?LOG(error, "Unload module ~s failed, cannot unload for ~0p", [ModuleName, Error])
@@ -164,6 +164,6 @@ write_loaded(true) ->
         ok -> ok;
         {error, Error} ->
             ?LOG(error, "Write File ~p Error: ~p", [FilePath, Error]),
-            {error, Error}
+            ok
     end;
 write_loaded(false) -> ok.