yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #10324 from kjellwinblad/kjell/fix/EMQX-9374 

fix: check Clickhouse connection after creation
This commit is contained in:
Kjell Winblad 2023-04-13 16:31:35 +02:00 committed by GitHub
parent e7c42956b3 0cec52d5e4
commit 601564fa0a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changes/ee/fix-10324.en.md Normal file
View File

@ -0,0 +1 @@
Previously, when attempting to reconnect to a misconfigured Clickhouse bridge through the dashboard, users would not receive an error message. This issue is now resolved, and error messages will now be displayed

1
changes/ee/fix-10324.zh.md Normal file
View File

@ -0,0 +1 @@

11
lib-ee/emqx_ee_connector/src/emqx_ee_connector_clickhouse.erl
View File

@ -270,8 +270,15 @@ connect(Options) ->
{pool_size, PoolSize} {pool_size, PoolSize}
], ],
case clickhouse:start_link(FixedOptions) of case clickhouse:start_link(FixedOptions) of
{ok, _Conn} = Ok -> {ok, Connection} ->
Ok; %% Check if we can connect and send a query
case clickhouse:detailed_status(Connection) of
ok ->
{ok, Connection};
Error ->
ok = clickhouse:stop(Connection),
Error
end;
{error, Reason} -> {error, Reason} ->
{error, Reason} {error, Reason}
end. end.