yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: check Clickhouse connection after creation 

When pressing reconnect on a badly configured Clickhouse bridge in the
dashboard, no error message was shown. This commit fixes this issue by
testing the connection after creation and returning an error tuple if
the connection is not working.

Fixes:
https://emqx.atlassian.net/browse/EMQX-9374
This commit is contained in:
Kjell Winblad 2023-04-04 12:01:41 +02:00
parent e186477531
commit 0cec52d5e4
3 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
changes/ee/fix-10324.en.md Normal file
View File

@ -0,0 +1 @@
Previously, when attempting to reconnect to a misconfigured Clickhouse bridge through the dashboard, users would not receive an error message. This issue is now resolved, and error messages will now be displayed

1
changes/ee/fix-10324.zh.md Normal file
View File

@ -0,0 +1 @@

11
lib-ee/emqx_ee_connector/src/emqx_ee_connector_clickhouse.erl
View File

@ -270,8 +270,15 @@ connect(Options) ->
{pool_size, PoolSize}
],
case clickhouse:start_link(FixedOptions) of
{ok, _Conn} = Ok ->
Ok;
{ok, Connection} ->
%% Check if we can connect and send a query
case clickhouse:detailed_status(Connection) of
ok ->
{ok, Connection};
Error ->
ok = clickhouse:stop(Connection),
Error
end;
{error, Reason} ->
{error, Reason}
end.