yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(ds): Apply review remarks 

Co-authored-by: Thales Macedo Garitezi <thalesmg@gmail.com>
This commit is contained in:
ieQu1 2023-11-09 21:16:20 +01:00
parent b812db1e3c
commit 5aa9d026df
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/emqx/src/emqx_persistent_message_ds_replayer.erl
View File

@ -242,8 +242,10 @@ packet_id_to_seqno_test() ->
?assertEqual(1, packet_id_to_seqno(1, 1)), ?assertEqual(1, packet_id_to_seqno(1, 1)),
?assertEqual(1, packet_id_to_seqno(10, 1)), ?assertEqual(1, packet_id_to_seqno(10, 1)),
?assertEqual(1, packet_id_to_seqno(1 bsl 16 - 1, 1)), ?assertEqual(1, packet_id_to_seqno(1 bsl 16 - 1, 1)),
?assertEqual(1, packet_id_to_seqno(1 bsl 16, 1)),
%% Packet ID = 1; second and 3rd epochs: %% Packet ID = 1; second and 3rd epochs:
?assertEqual(1 bsl 16 + 1, packet_id_to_seqno(1 bsl 16 + 1, 1)), ?assertEqual(1 bsl 16 + 1, packet_id_to_seqno(1 bsl 16 + 1, 1)),
?assertEqual(1 bsl 16 + 1, packet_id_to_seqno(2 bsl 16, 1)),
?assertEqual(2 bsl 16 + 1, packet_id_to_seqno(2 bsl 16 + 1, 1)), ?assertEqual(2 bsl 16 + 1, packet_id_to_seqno(2 bsl 16 + 1, 1)),
%% Packet ID = 16#ffff: %% Packet ID = 16#ffff:
PID = 1 bsl 16 - 1, PID = 1 bsl 16 - 1,
@ -279,7 +281,7 @@ next_seqno_gen() ->
). ).
seqno_gen(NextSeqNo) -> seqno_gen(NextSeqNo) ->
WindowSize = 1 bsl 16 - 2, WindowSize = 1 bsl 16 - 1,
Min = max(0, NextSeqNo - WindowSize), Min = max(0, NextSeqNo - WindowSize),
Max = max(0, NextSeqNo - 1), Max = max(0, NextSeqNo - 1),
range(Min, Max). range(Min, Max).