From 5aa9d026df82b8515ee5a3807c3c24979369701a Mon Sep 17 00:00:00 2001 From: ieQu1 <99872536+ieQu1@users.noreply.github.com> Date: Thu, 9 Nov 2023 21:16:20 +0100 Subject: [PATCH] fix(ds): Apply review remarks Co-authored-by: Thales Macedo Garitezi --- apps/emqx/src/emqx_persistent_message_ds_replayer.erl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/apps/emqx/src/emqx_persistent_message_ds_replayer.erl b/apps/emqx/src/emqx_persistent_message_ds_replayer.erl index bd64db8b8..3e8aa71cf 100644 --- a/apps/emqx/src/emqx_persistent_message_ds_replayer.erl +++ b/apps/emqx/src/emqx_persistent_message_ds_replayer.erl @@ -242,8 +242,10 @@ packet_id_to_seqno_test() -> ?assertEqual(1, packet_id_to_seqno(1, 1)), ?assertEqual(1, packet_id_to_seqno(10, 1)), ?assertEqual(1, packet_id_to_seqno(1 bsl 16 - 1, 1)), + ?assertEqual(1, packet_id_to_seqno(1 bsl 16, 1)), %% Packet ID = 1; second and 3rd epochs: ?assertEqual(1 bsl 16 + 1, packet_id_to_seqno(1 bsl 16 + 1, 1)), + ?assertEqual(1 bsl 16 + 1, packet_id_to_seqno(2 bsl 16, 1)), ?assertEqual(2 bsl 16 + 1, packet_id_to_seqno(2 bsl 16 + 1, 1)), %% Packet ID = 16#ffff: PID = 1 bsl 16 - 1, @@ -279,7 +281,7 @@ next_seqno_gen() -> ). seqno_gen(NextSeqNo) -> - WindowSize = 1 bsl 16 - 2, + WindowSize = 1 bsl 16 - 1, Min = max(0, NextSeqNo - WindowSize), Max = max(0, NextSeqNo - 1), range(Min, Max).