yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(dashboard): provide full context in startup errors

This commit is contained in:
Andrew Mayorov 2024-02-08 22:49:20 +01:00
parent 802c760406
commit 2a4e37869e
No known key found for this signature in database
GPG Key ID: 2837C62ACFBFED5D
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/emqx_dashboard/src/emqx_dashboard_swagger.erl
View File

@ -364,8 +364,8 @@ parse_spec_ref(Module, Path, Options) ->
-ifdef(TEST). -ifdef(TEST).
-spec failed_to_generate_swagger_spec(_, _, _, _, _) -> no_return(). -spec failed_to_generate_swagger_spec(_, _, _, _, _) -> no_return().
failed_to_generate_swagger_spec(Module, Path, _Error, _Reason, _Stacktrace) -> failed_to_generate_swagger_spec(Module, Path, Error, Reason, Stacktrace) ->
error({failed_to_generate_swagger_spec, Module, Path}). error({failed_to_generate_swagger_spec, Module, Path, Error, Reason, Stacktrace}).
-else. -else.
-spec failed_to_generate_swagger_spec(_, _, _, _, _) -> no_return(). -spec failed_to_generate_swagger_spec(_, _, _, _, _) -> no_return().
failed_to_generate_swagger_spec(Module, Path, Error, Reason, Stacktrace) -> failed_to_generate_swagger_spec(Module, Path, Error, Reason, Stacktrace) ->

2
apps/emqx_dashboard/test/emqx_swagger_requestBody_SUITE.erl
View File

@ -310,7 +310,7 @@ t_nest_ref(_Config) ->
t_none_ref(_Config) -> t_none_ref(_Config) ->
Path = "/ref/none", Path = "/ref/none",
?assertError( ?assertError(
{failed_to_generate_swagger_spec, ?MODULE, Path}, {failed_to_generate_swagger_spec, ?MODULE, Path, error, _FunctionClause, _Stacktrace},
emqx_dashboard_swagger:parse_spec_ref(?MODULE, Path, #{}) emqx_dashboard_swagger:parse_spec_ref(?MODULE, Path, #{})
), ),
ok. ok.

2
apps/emqx_dashboard/test/emqx_swagger_response_SUITE.erl
View File

@ -282,7 +282,7 @@ t_bad_ref(_Config) ->
t_none_ref(_Config) -> t_none_ref(_Config) ->
Path = "/ref/none", Path = "/ref/none",
?assertError( ?assertError(
{failed_to_generate_swagger_spec, ?MODULE, Path}, {failed_to_generate_swagger_spec, ?MODULE, Path, error, _FunctionClause, _Stacktrace},
validate(Path, #{}, []) validate(Path, #{}, [])
), ),
ok. ok.