From 2a4e37869e4fce62ccb76d6862ff9b6836686211 Mon Sep 17 00:00:00 2001 From: Andrew Mayorov Date: Thu, 8 Feb 2024 22:49:20 +0100 Subject: [PATCH] fix(dashboard): provide full context in startup errors --- apps/emqx_dashboard/src/emqx_dashboard_swagger.erl | 4 ++-- apps/emqx_dashboard/test/emqx_swagger_requestBody_SUITE.erl | 2 +- apps/emqx_dashboard/test/emqx_swagger_response_SUITE.erl | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/emqx_dashboard/src/emqx_dashboard_swagger.erl b/apps/emqx_dashboard/src/emqx_dashboard_swagger.erl index 56ca4acb0..e5810dcc5 100644 --- a/apps/emqx_dashboard/src/emqx_dashboard_swagger.erl +++ b/apps/emqx_dashboard/src/emqx_dashboard_swagger.erl @@ -364,8 +364,8 @@ parse_spec_ref(Module, Path, Options) -> -ifdef(TEST). -spec failed_to_generate_swagger_spec(_, _, _, _, _) -> no_return(). -failed_to_generate_swagger_spec(Module, Path, _Error, _Reason, _Stacktrace) -> - error({failed_to_generate_swagger_spec, Module, Path}). +failed_to_generate_swagger_spec(Module, Path, Error, Reason, Stacktrace) -> + error({failed_to_generate_swagger_spec, Module, Path, Error, Reason, Stacktrace}). -else. -spec failed_to_generate_swagger_spec(_, _, _, _, _) -> no_return(). failed_to_generate_swagger_spec(Module, Path, Error, Reason, Stacktrace) -> diff --git a/apps/emqx_dashboard/test/emqx_swagger_requestBody_SUITE.erl b/apps/emqx_dashboard/test/emqx_swagger_requestBody_SUITE.erl index 1bb42f324..0e1264aeb 100644 --- a/apps/emqx_dashboard/test/emqx_swagger_requestBody_SUITE.erl +++ b/apps/emqx_dashboard/test/emqx_swagger_requestBody_SUITE.erl @@ -310,7 +310,7 @@ t_nest_ref(_Config) -> t_none_ref(_Config) -> Path = "/ref/none", ?assertError( - {failed_to_generate_swagger_spec, ?MODULE, Path}, + {failed_to_generate_swagger_spec, ?MODULE, Path, error, _FunctionClause, _Stacktrace}, emqx_dashboard_swagger:parse_spec_ref(?MODULE, Path, #{}) ), ok. diff --git a/apps/emqx_dashboard/test/emqx_swagger_response_SUITE.erl b/apps/emqx_dashboard/test/emqx_swagger_response_SUITE.erl index 85cc4b16b..5ccb01b3e 100644 --- a/apps/emqx_dashboard/test/emqx_swagger_response_SUITE.erl +++ b/apps/emqx_dashboard/test/emqx_swagger_response_SUITE.erl @@ -282,7 +282,7 @@ t_bad_ref(_Config) -> t_none_ref(_Config) -> Path = "/ref/none", ?assertError( - {failed_to_generate_swagger_spec, ?MODULE, Path}, + {failed_to_generate_swagger_spec, ?MODULE, Path, error, _FunctionClause, _Stacktrace}, validate(Path, #{}, []) ), ok.