yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(shared): ACK header compatability

This commit is contained in:
Georgy Sychev 2022-05-24 21:17:55 +04:00
parent b96c7f40e5
commit 187630b900
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/emqx_shared_sub.erl
View File

@ -229,7 +229,9 @@ is_ack_required(Msg) -> ?NO_ACK =/= get_group_ack(Msg).
maybe_nack_dropped(Msg) -> maybe_nack_dropped(Msg) ->
case get_group_ack(Msg) of case get_group_ack(Msg) of
?NO_ACK -> false; ?NO_ACK -> false;
{_Group, Sender, Ref} -> ok == nack(Sender, Ref, dropped) {_Group, Sender, Ref} -> ok == nack(Sender, Ref, dropped);
%% Backward compatability
{Sender, Ref} -> ok == nack(Sender, Ref, dropped)
end. end.
%% @doc Negative ack message due to connection down. %% @doc Negative ack message due to connection down.
@ -251,6 +253,10 @@ maybe_ack(Msg) ->
?NO_ACK -> ?NO_ACK ->
Msg; Msg;
{_Group, Sender, Ref} -> {_Group, Sender, Ref} ->
Sender ! {Ref, ?ACK},
without_group_ack(Msg);
%% Backward compatability
{Sender, Ref} ->
Sender ! {Ref, ?ACK}, Sender ! {Ref, ?ACK},
without_group_ack(Msg) without_group_ack(Msg)
end. end.