From 187630b90024a40bfb5c86cf93a05ccc33f6aec3 Mon Sep 17 00:00:00 2001 From: Georgy Sychev Date: Tue, 24 May 2022 21:17:55 +0400 Subject: [PATCH] fix(shared): ACK header compatability --- src/emqx_shared_sub.erl | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/emqx_shared_sub.erl b/src/emqx_shared_sub.erl index a19e884ae..2aca2e8fa 100644 --- a/src/emqx_shared_sub.erl +++ b/src/emqx_shared_sub.erl @@ -229,7 +229,9 @@ is_ack_required(Msg) -> ?NO_ACK =/= get_group_ack(Msg). maybe_nack_dropped(Msg) -> case get_group_ack(Msg) of ?NO_ACK -> false; - {_Group, Sender, Ref} -> ok == nack(Sender, Ref, dropped) + {_Group, Sender, Ref} -> ok == nack(Sender, Ref, dropped); + %% Backward compatability + {Sender, Ref} -> ok == nack(Sender, Ref, dropped) end. %% @doc Negative ack message due to connection down. @@ -251,6 +253,10 @@ maybe_ack(Msg) -> ?NO_ACK -> Msg; {_Group, Sender, Ref} -> + Sender ! {Ref, ?ACK}, + without_group_ack(Msg); + %% Backward compatability + {Sender, Ref} -> Sender ! {Ref, ?ACK}, without_group_ack(Msg) end.