fix(dsrepl): Retry sending ra commands to the leader

.ci/docker-compose-file/docker-compose-azurite.yaml

@@ -1,24 +0,0 @@
-version: '3.9'
-
-services:
-  azurite:
-    container_name: azurite
-    image: mcr.microsoft.com/azure-storage/azurite:3.30.0
-    restart: always
-    expose:
-      - "10000"
-    # ports:
-    #   - "10000:10000"
-    networks:
-      - emqx_bridge
-    healthcheck:
-      test: ["CMD", "curl", "-f", "http://localhost:10000"]
-      interval: 30s
-      timeout: 5s
-      retries: 4
-    command:
-      - azurite-blob
-      - "--blobHost"
-      - 0.0.0.0
-      - "-d"
-      - debug.log

.ci/docker-compose-file/docker-compose-couchbase.yaml

@@ -1,30 +0,0 @@
-version: '3.9'
-
-services:
-  couchbase:
-    container_name: couchbase
-    hostname: couchbase
-    image: ghcr.io/emqx/couchbase:1.0.0
-    restart: always
-    expose:
-      - 8091-8093
-    # ports:
-    #   - "8091-8093:8091-8093"
-    networks:
-      - emqx_bridge
-    healthcheck:
-      test: ["CMD", "curl", "-f", "http://localhost:8093/admin/ping"]
-      interval: 30s
-      timeout: 5s
-      retries: 4
-    environment:
-      - CLUSTER=localhost
-      - USER=admin
-      - PASS=public
-      - PORT=8091
-      - RAMSIZEMB=2048
-      - RAMSIZEINDEXMB=512
-      - RAMSIZEFTSMB=512
-      - BUCKETS=mqtt
-      - BUCKETSIZES=100
-      - AUTOREBALANCE=true

.ci/docker-compose-file/docker-compose-kafka.yaml

@@ -18,7 +18,7 @@ services:
       - /tmp/emqx-ci/emqx-shared-secret:/var/lib/secret
   kdc:
     hostname: kdc.emqx.net
-    image:  ghcr.io/emqx/emqx-builder/5.3-9:1.15.7-26.2.5-3-ubuntu22.04
+    image:  ghcr.io/emqx/emqx-builder/5.3-5:1.15.7-26.2.1-2-ubuntu22.04
     container_name: kdc.emqx.net
     expose:
       - 88 # kdc

.ci/docker-compose-file/docker-compose-ldap.yaml

@@ -10,7 +10,7 @@ services:
       nofile: 1024
     image: openldap
     #ports:
-    #  - "389:389"
+    #  - 389:389
     volumes:
       - ./certs/ca.crt:/etc/certs/ca.crt
     restart: always

.ci/docker-compose-file/docker-compose-rocketmq-ssl.yaml

@@ -1,41 +0,0 @@
-version: '3.9'
-
-services:
-  mqnamesrvssl:
-    image: apache/rocketmq:4.9.4
-    container_name: rocketmq_namesrv_ssl
-#    ports:
-#      - 9876:9876
-    volumes:
-      - ./rocketmq/logs_ssl:/opt/logs
-      - ./rocketmq/store_ssl:/opt/store
-    environment:
-      JAVA_OPT: "-Dtls.server.mode=enforcing"
-    command: ./mqnamesrv
-    networks:
-      - emqx_bridge
-
-  mqbrokerssl:
-    image: apache/rocketmq:4.9.4
-    container_name: rocketmq_broker_ssl
-#    ports:
-#      - 10909:10909
-#      - 10911:10911
-    volumes:
-      - ./rocketmq/logs_ssl:/opt/logs
-      - ./rocketmq/store_ssl:/opt/store
-      - ./rocketmq/conf_ssl/broker.conf:/etc/rocketmq/broker.conf
-      - ./rocketmq/conf_ssl/plain_acl.yml:/home/rocketmq/rocketmq-4.9.4/conf/plain_acl.yml
-    environment:
-        NAMESRV_ADDR: "rocketmq_namesrv_ssl:9876"
-        JAVA_OPTS: " -Duser.home=/opt -Drocketmq.broker.diskSpaceWarningLevelRatio=0.99"
-        JAVA_OPT_EXT: "-server -Xms512m -Xmx512m -Xmn512m -Dtls.server.mode=enforcing"
-    command: ./mqbroker -c /etc/rocketmq/broker.conf
-    depends_on:
-      - mqnamesrvssl
-    networks:
-      - emqx_bridge
-
-networks:
-  emqx_bridge:
-    driver: bridge

.ci/docker-compose-file/docker-compose.yaml

@@ -3,7 +3,7 @@ version: '3.9'
 services:
   erlang:
     container_name: erlang
-    image: ${DOCKER_CT_RUNNER_IMAGE:-ghcr.io/emqx/emqx-builder/5.3-9:1.15.7-26.2.5-3-ubuntu22.04}
+    image: ${DOCKER_CT_RUNNER_IMAGE:-ghcr.io/emqx/emqx-builder/5.3-5:1.15.7-26.2.1-2-ubuntu22.04}
     env_file:
       - credentials.env
       - conf.env

.ci/docker-compose-file/kafka/kafka-entrypoint.sh

@@ -49,9 +49,6 @@ echo "+++++++ Creating Kafka Topics ++++++++"
 # there seem to be a race condition when creating the topics (too early)
 env KAFKA_CREATE_TOPICS="$KAFKA_CREATE_TOPICS_NG" KAFKA_PORT="$PORT1" create-topics.sh
 
-# create a topic with max.message.bytes=100
-/opt/kafka/bin/kafka-topics.sh --create --bootstrap-server "${SERVER}:${PORT1}" --topic max-100-bytes --partitions 1 --replication-factor 1 --config max.message.bytes=100
-
 echo "+++++++ Wait until Kafka ports are down ++++++++"
 
 bash -c 'while printf "" 2>>/dev/null >>/dev/tcp/$0/$1; do sleep 1; done' $SERVER $PORT1

.ci/docker-compose-file/openldap/README.md

@@ -1,61 +0,0 @@
-# LDAP authentication
-
-To run manual tests with the default docker-compose files.
-
-Expose openldap container port by uncommenting the `ports` config in `docker-compose-ldap.yaml `
-
-To start openldap:
-
-```
-docker-compose -f ./.ci/docker-compose-file/docker-compose.yaml -f ./.ci/docker-compose-file/docker-compose-ldap.yaml up -docker
-```
-
-## LDAP database
-
-LDAP database is populated from below files:
-```
-apps/emqx_ldap/test/data/emqx.io.ldif /usr/local/etc/openldap/schema/emqx.io.ldif
-apps/emqx_ldap/test/data/emqx.schema /usr/local/etc/openldap/schema/emqx.schema
-```
-
-## Minimal EMQX config
-
-```
-authentication = [
-  {
-    backend = ldap
-    base_dn = "uid=${username},ou=testdevice,dc=emqx,dc=io"
-    filter = "(& (objectClass=mqttUser) (uid=${username}))"
-    mechanism = password_based
-    method {
-      is_superuser_attribute = isSuperuser
-      password_attribute = userPassword
-      type = hash
-    }
-    password = public
-    pool_size = 8
-    query_timeout = "5s"
-    request_timeout = "10s"
-    server = "localhost:1389"
-    username = "cn=root,dc=emqx,dc=io"
-  }
-]
-```
-
-## Example ldapsearch command
-
-```
-ldapsearch -x -H ldap://localhost:389 -D "cn=root,dc=emqx,dc=io" -W -b "uid=mqttuser0007,ou=testdevice,dc=emqx,dc=io" "(&(objectClass=mqttUser)(uid=mqttuser0007))"
-```
-
-## Example mqttx command
-
-The client password hashes are generated from their username.
-
-```
-# disabled user
-mqttx pub -t 't/1' -h localhost -p 1883 -m x -u mqttuser0006 -P mqttuser0006
-
-# enabled super-user
-mqttx pub -t 't/1' -h localhost -p 1883 -m x -u mqttuser0007 -P mqttuser0007
-```

.ci/docker-compose-file/rocketmq/conf_ssl/broker.conf

@@ -1,24 +0,0 @@
-brokerClusterName=DefaultClusterSSL
-brokerName=broker-a
-brokerId=0
-
-brokerIP1=rocketmq_broker_ssl
-
-defaultTopicQueueNums=4
-autoCreateTopicEnable=true
-autoCreateSubscriptionGroup=true
-
-listenPort=10911
-deleteWhen=04
-
-fileReservedTime=120
-mapedFileSizeCommitLog=1073741824
-mapedFileSizeConsumeQueue=300000
-diskMaxUsedSpaceRatio=100
-maxMessageSize=65536
-
-brokerRole=ASYNC_MASTER
-
-flushDiskType=ASYNC_FLUSH
-
-aclEnable=true

.ci/docker-compose-file/rocketmq/conf_ssl/plain_acl.yml

@@ -1,12 +0,0 @@
-globalWhiteRemoteAddresses:
-
-accounts:
-  - accessKey: RocketMQ
-    secretKey: 12345678
-    whiteRemoteAddress:
-    admin: false
-    defaultTopicPerm: DENY
-    defaultGroupPerm: PUB|SUB
-    topicPerms:
-      - TopicTest=PUB|SUB
-      - Topic2=PUB|SUB

.ci/docker-compose-file/toxiproxy.json

@@ -215,17 +215,5 @@
     "listen": "0.0.0.0:9200",
     "upstream": "elasticsearch:9200",
     "enabled": true
-  },
-  {
-    "name": "azurite_plain",
-    "listen": "0.0.0.0:10000",
-    "upstream": "azurite:10000",
-    "enabled": true
-  },
-  {
-    "name": "couchbase",
-    "listen": "0.0.0.0:8093",
-    "upstream": "couchbase:8093",
-    "enabled": true
   }
 ]

.ci/fvt_tests/http_server/src/http_server.app.src

@@ -1,12 +1,12 @@
 %% -*- mode: erlang -*-
-{application, http_server, [
-    {description, "An HTTP server application"},
+{application, http_server,
+ [{description, "An HTTP server application"},
   {vsn, "0.2.0"},
   {registered, []},
   % {mod, {http_server_app, []}},
   {modules, []},
-    {applications, [
-        kernel,
+  {applications,
+   [kernel,
     stdlib,
     minirest
    ]},

.github/actions/package-macos/action.yaml

@@ -33,7 +33,7 @@ runs:
         HOMEBREW_NO_INSTALL_UPGRADE: 1
         HOMEBREW_NO_INSTALLED_DEPENDENTS_CHECK: 1
       run: |
-        brew install curl zip unzip coreutils openssl@1.1 unixodbc
+        brew install curl zip unzip coreutils openssl@1.1
         echo "/usr/local/opt/bison/bin" >> $GITHUB_PATH
         echo "/usr/local/bin" >> $GITHUB_PATH
         echo "emqx_name=${emqx_name}" >> $GITHUB_OUTPUT
@@ -51,12 +51,12 @@ runs:
             echo "SELF_HOSTED=false" >> $GITHUB_OUTPUT
             ;;
         esac
-    - uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
+    - uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 # v4.0.1
       id: cache
       if: steps.prepare.outputs.SELF_HOSTED != 'true'
       with:
         path: ${{ steps.prepare.outputs.OTP_INSTALL_PATH }}
-        key: otp-install-${{ inputs.otp }}-${{ inputs.os }}-static-ssl-disable-hipe-disable-jit-20240524-1
+        key: otp-install-${{ inputs.otp }}-${{ inputs.os }}-static-ssl-disable-hipe-disable-jit
     - name: build erlang
       if: steps.cache.outputs.cache-hit != 'true'
       shell: bash
@@ -80,10 +80,9 @@ runs:
         git clone --depth 1 --branch OTP-${{ inputs.otp }} https://github.com/emqx/otp.git "$OTP_SOURCE_PATH"
         cd "$OTP_SOURCE_PATH"
         if [ "$(arch)" = arm64 ]; then
-            ODBCHOME="$(brew --prefix unixodbc)"
-            export CFLAGS="-O2 -g -I${ODBCHOME}/include"
-            export LDFLAGS="-L${ODBCHOME}/lib"
-            WITH_ODBC="--with-odbc=${ODBCHOME}"
+            export CFLAGS="-O2 -g -I$(brew --prefix unixodbc)/include"
+            export LDFLAGS="-L$(brew --prefix unixodbc)/lib"
+            WITH_ODBC="--with-odbc=$(brew --prefix unixodbc)"
         else
             WITH_ODBC=""
         fi

.github/actions/prepare-jmeter/action.yaml

@@ -1,8 +1,24 @@
 name: 'Prepare jmeter'
 
+inputs:
+  version-emqx:
+    required: true
+    type: string
+
 runs:
   using: composite
   steps:
+    - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
+      with:
+        name: emqx-docker
+        path: /tmp
+    - name: load docker image
+      shell: bash
+      env:
+        PKG_VSN: ${{ inputs.version-emqx }}
+      run: |
+        EMQX_DOCKER_IMAGE_TAG=$(docker load < /tmp/emqx-docker-${PKG_VSN}.tar.gz | sed 's/Loaded image: //g')
+        echo "_EMQX_DOCKER_IMAGE_TAG=$EMQX_DOCKER_IMAGE_TAG" >> $GITHUB_ENV
     - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         repository: emqx/emqx-fvt

.github/workflows/.zipignore2

@@ -1 +0,0 @@
-*/.github/*

.github/workflows/_pr_entrypoint.yaml

@@ -11,48 +11,29 @@ on:
       ref:
         required: false
 
-defaults:
-  run:
-    shell: bash
-
 env:
   IS_CI: "yes"
 
 jobs:
-  init:
-    runs-on: ubuntu-22.04
-    outputs:
-      BUILDER_VSN: ${{ steps.env.outputs.BUILDER_VSN }}
-      OTP_VSN: ${{ steps.env.outputs.OTP_VSN }}
-      ELIXIR_VSN: ${{ steps.env.outputs.ELIXIR_VSN }}
-      BUILDER: ${{ steps.env.outputs.BUILDER }}
-    steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-        with:
-          ref: ${{ github.event.inputs.ref }}
-      - name: Set up environment
-        id: env
-        run: |
-          source ./env.sh
-          echo "BUILDER_VSN=$EMQX_BUILDER_VSN" | tee -a "$GITHUB_OUTPUT"
-          echo "OTP_VSN=$OTP_VSN" | tee -a "$GITHUB_OUTPUT"
-          echo "ELIXIR_VSN=$ELIXIR_VSN" | tee -a "$GITHUB_OUTPUT"
-          echo "BUILDER=$EMQX_BUILDER" | tee -a "$GITHUB_OUTPUT"
-
   sanity-checks:
     runs-on: ubuntu-22.04
-    needs: init
-    container: ${{ needs.init.outputs.BUILDER }}
+    container: "ghcr.io/emqx/emqx-builder/5.3-5:1.15.7-26.2.1-2-ubuntu22.04"
     outputs:
       ct-matrix: ${{ steps.matrix.outputs.ct-matrix }}
       ct-host: ${{ steps.matrix.outputs.ct-host }}
       ct-docker: ${{ steps.matrix.outputs.ct-docker }}
+      version-emqx: ${{ steps.matrix.outputs.version-emqx }}
+      version-emqx-enterprise: ${{ steps.matrix.outputs.version-emqx-enterprise }}
+      builder: "ghcr.io/emqx/emqx-builder/5.3-5:1.15.7-26.2.1-2-ubuntu22.04"
+      builder_vsn: "5.3-5"
+      otp_vsn: "26.2.1-2"
+      elixir_vsn: "1.15.7"
 
     permissions:
       contents: read
 
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
         with:
           ref: ${{ github.event.inputs.ref }}
           fetch-depth: 0
@@ -111,20 +92,35 @@ jobs:
       - name: Generate CT Matrix
         id: matrix
         run: |
-          MATRIX="$(./scripts/find-apps.sh --ci)"
+          APPS="$(./scripts/find-apps.sh --ci)"
+          MATRIX="$(echo "${APPS}" | jq -c '
+            [
+              (.[] | select(.profile == "emqx") | . + {
+                builder: "5.3-5",
+                otp: "26.2.1-2",
+                elixir: "1.15.7"
+              }),
+              (.[] | select(.profile == "emqx-enterprise") | . + {
+                builder: "5.3-5",
+                otp: ["26.2.1-2"][],
+                elixir: "1.15.7"
+              })
+            ]
+          ')"
           echo "${MATRIX}" | jq
-          CT_MATRIX="$(echo "${MATRIX}" | jq -c 'map({profile}) | unique')"
+          CT_MATRIX="$(echo "${MATRIX}" | jq -c 'map({profile, builder, otp, elixir}) | unique')"
           CT_HOST="$(echo "${MATRIX}"   | jq -c 'map(select(.runner == "host"))')"
           CT_DOCKER="$(echo "${MATRIX}" | jq -c 'map(select(.runner == "docker"))')"
           echo "ct-matrix=${CT_MATRIX}" | tee -a $GITHUB_OUTPUT
           echo "ct-host=${CT_HOST}"     | tee -a $GITHUB_OUTPUT
           echo "ct-docker=${CT_DOCKER}" | tee -a $GITHUB_OUTPUT
+          echo "version-emqx=$(./pkg-vsn.sh emqx)" | tee -a $GITHUB_OUTPUT
+          echo "version-emqx-enterprise=$(./pkg-vsn.sh emqx-enterprise)" | tee -a $GITHUB_OUTPUT
 
   compile:
     runs-on: ${{ endsWith(github.repository, '/emqx') && 'ubuntu-22.04' || fromJSON('["self-hosted","ephemeral-xl","linux","x64"]') }}
-    container: ${{ needs.init.outputs.BUILDER }}
+    container: ${{ needs.sanity-checks.outputs.builder }}
     needs:
-      - init
       - sanity-checks
     strategy:
       matrix:
@@ -136,7 +132,7 @@ jobs:
       contents: read
 
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
         with:
           fetch-depth: 0
       - name: Work around https://github.com/actions/checkout/issues/766
@@ -152,7 +148,7 @@ jobs:
           echo "PROFILE=${PROFILE}" | tee -a .env
           echo "PKG_VSN=$(./pkg-vsn.sh ${PROFILE})" | tee -a .env
           zip -ryq -x@.github/workflows/.zipignore $PROFILE.zip .
-      - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+      - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
         with:
           name: ${{ matrix.profile }}
           path: ${{ matrix.profile }}.zip
@@ -160,47 +156,53 @@ jobs:
 
   run_emqx_app_tests:
     needs:
-      - init
       - sanity-checks
       - compile
     uses: ./.github/workflows/run_emqx_app_tests.yaml
     with:
-      builder: ${{ needs.init.outputs.BUILDER }}
+      builder: ${{ needs.sanity-checks.outputs.builder }}
       before_ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.base.sha || github.event.before }}
       after_ref: ${{ github.sha }}
 
   run_test_cases:
     needs:
-      - init
       - sanity-checks
       - compile
     uses: ./.github/workflows/run_test_cases.yaml
     with:
-      builder: ${{ needs.init.outputs.BUILDER }}
+      builder: ${{ needs.sanity-checks.outputs.builder }}
       ct-matrix: ${{ needs.sanity-checks.outputs.ct-matrix }}
       ct-host: ${{ needs.sanity-checks.outputs.ct-host }}
       ct-docker: ${{ needs.sanity-checks.outputs.ct-docker }}
 
   static_checks:
     needs:
-      - init
       - sanity-checks
       - compile
     uses: ./.github/workflows/static_checks.yaml
     with:
-      builder: ${{ needs.init.outputs.BUILDER }}
+      builder: ${{ needs.sanity-checks.outputs.builder }}
       ct-matrix: ${{ needs.sanity-checks.outputs.ct-matrix }}
 
   build_slim_packages:
     needs:
       - sanity-checks
     uses: ./.github/workflows/build_slim_packages.yaml
+    with:
+      builder: ${{ needs.sanity-checks.outputs.builder }}
+      builder_vsn: ${{ needs.sanity-checks.outputs.builder_vsn }}
+      otp_vsn: ${{ needs.sanity-checks.outputs.otp_vsn }}
+      elixir_vsn: ${{ needs.sanity-checks.outputs.elixir_vsn }}
 
   build_docker_for_test:
     needs:
-      - init
       - sanity-checks
     uses: ./.github/workflows/build_docker_for_test.yaml
+    with:
+      otp_vsn: ${{ needs.sanity-checks.outputs.otp_vsn }}
+      elixir_vsn: ${{ needs.sanity-checks.outputs.elixir_vsn }}
+      version-emqx: ${{ needs.sanity-checks.outputs.version-emqx }}
+      version-emqx-enterprise: ${{ needs.sanity-checks.outputs.version-emqx-enterprise }}
 
   spellcheck:
     needs:
@@ -210,35 +212,41 @@ jobs:
 
   run_conf_tests:
     needs:
-      - init
       - sanity-checks
       - compile
     uses: ./.github/workflows/run_conf_tests.yaml
     with:
-      builder: ${{ needs.init.outputs.BUILDER }}
+      builder: ${{ needs.sanity-checks.outputs.builder }}
 
   check_deps_integrity:
     needs:
-      - init
       - sanity-checks
     uses: ./.github/workflows/check_deps_integrity.yaml
     with:
-      builder: ${{ needs.init.outputs.BUILDER }}
+      builder: ${{ needs.sanity-checks.outputs.builder }}
 
   run_jmeter_tests:
     needs:
       - sanity-checks
       - build_docker_for_test
     uses: ./.github/workflows/run_jmeter_tests.yaml
+    with:
+      version-emqx: ${{ needs.sanity-checks.outputs.version-emqx }}
 
   run_docker_tests:
     needs:
       - sanity-checks
       - build_docker_for_test
     uses: ./.github/workflows/run_docker_tests.yaml
+    with:
+      version-emqx: ${{ needs.sanity-checks.outputs.version-emqx }}
+      version-emqx-enterprise: ${{ needs.sanity-checks.outputs.version-emqx-enterprise }}
 
   run_helm_tests:
     needs:
       - sanity-checks
       - build_docker_for_test
     uses: ./.github/workflows/run_helm_tests.yaml
+    with:
+      version-emqx: ${{ needs.sanity-checks.outputs.version-emqx }}
+      version-emqx-enterprise: ${{ needs.sanity-checks.outputs.version-emqx-enterprise }}

.github/workflows/_push-entrypoint.yaml

@@ -8,6 +8,7 @@ on:
   push:
     tags:
       - 'v*'
+      - 'e*'
     branches:
       - 'master'
       - 'release-5[0-9]'
@@ -17,42 +18,13 @@ on:
       ref:
         required: false
 
-defaults:
-  run:
-    shell: bash
-
 env:
   IS_CI: 'yes'
 
 jobs:
-  init:
-    runs-on: ubuntu-22.04
-    outputs:
-      BUILDER_VSN: ${{ steps.env.outputs.BUILDER_VSN }}
-      OTP_VSN: ${{ steps.env.outputs.OTP_VSN }}
-      ELIXIR_VSN: ${{ steps.env.outputs.ELIXIR_VSN }}
-      BUILDER: ${{ steps.env.outputs.BUILDER }}
-      BUILD_FROM: ${{ steps.env.outputs.BUILD_FROM }}
-      RUN_FROM: ${{ steps.env.outputs.BUILD_FROM }}
-    steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-        with:
-          ref: ${{ github.event.inputs.ref }}
-      - name: Set up environment
-        id: env
-        run: |
-          source env.sh
-          echo "BUILDER_VSN=$EMQX_BUILDER_VSN" >> "$GITHUB_OUTPUT"
-          echo "OTP_VSN=$OTP_VSN" >> "$GITHUB_OUTPUT"
-          echo "ELIXIR_VSN=$ELIXIR_VSN" >> "$GITHUB_OUTPUT"
-          echo "BUILDER=$EMQX_BUILDER" >> "$GITHUB_OUTPUT"
-          echo "BUILD_FROM=$EMQX_DOCKER_BUILD_FROM" >> "$GITHUB_OUTPUT"
-          echo "RUN_FROM=$EMQX_DOCKER_RUN_FROM" >> "$GITHUB_OUTPUT"
-
   prepare:
     runs-on: ubuntu-22.04
-    needs: init
-    container: ${{ needs.init.outputs.BUILDER }}
+    container: 'ghcr.io/emqx/emqx-builder/5.3-5:1.15.7-26.2.1-2-ubuntu22.04'
     outputs:
       profile: ${{ steps.parse-git-ref.outputs.profile }}
       release: ${{ steps.parse-git-ref.outputs.release }}
@@ -60,12 +32,16 @@ jobs:
       ct-matrix: ${{ steps.matrix.outputs.ct-matrix }}
       ct-host: ${{ steps.matrix.outputs.ct-host }}
       ct-docker: ${{ steps.matrix.outputs.ct-docker }}
+      builder: 'ghcr.io/emqx/emqx-builder/5.3-5:1.15.7-26.2.1-2-ubuntu22.04'
+      builder_vsn: '5.3-5'
+      otp_vsn: '26.2.1-2'
+      elixir_vsn: '1.15.7'
 
     permissions:
       contents: read
 
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
         with:
           ref: ${{ github.event.inputs.ref }}
           fetch-depth: 0
@@ -86,9 +62,23 @@ jobs:
       - name: Build matrix
         id: matrix
         run: |
-          MATRIX="$(./scripts/find-apps.sh --ci)"
+          APPS="$(./scripts/find-apps.sh --ci)"
+          MATRIX="$(echo "${APPS}" | jq -c '
+            [
+              (.[] | select(.profile == "emqx") | . + {
+                builder: "5.3-5",
+                otp: "26.2.1-2",
+                elixir: "1.15.7"
+              }),
+              (.[] | select(.profile == "emqx-enterprise") | . + {
+                builder: "5.3-5",
+                otp: ["26.2.1-2"][],
+                elixir: "1.15.7"
+              })
+            ]
+          ')"
           echo "${MATRIX}" | jq
-          CT_MATRIX="$(echo "${MATRIX}" | jq -c 'map({profile}) | unique')"
+          CT_MATRIX="$(echo "${MATRIX}" | jq -c 'map({profile, builder, otp, elixir}) | unique')"
           CT_HOST="$(echo "${MATRIX}"   | jq -c 'map(select(.runner == "host"))')"
           CT_DOCKER="$(echo "${MATRIX}" | jq -c 'map(select(.runner == "docker"))')"
           echo "ct-matrix=${CT_MATRIX}" | tee -a $GITHUB_OUTPUT
@@ -98,44 +88,47 @@ jobs:
   build_packages:
     if: needs.prepare.outputs.release == 'true'
     needs:
-      - init
       - prepare
     uses: ./.github/workflows/build_packages.yaml
     with:
       profile: ${{ needs.prepare.outputs.profile }}
       publish: true
-      otp_vsn: ${{ needs.init.outputs.OTP_VSN }}
-      elixir_vsn: ${{ needs.init.outputs.ELIXIR_VSN }}
-      builder_vsn: ${{ needs.init.outputs.BUILDER_VSN }}
+      otp_vsn: ${{ needs.prepare.outputs.otp_vsn }}
+      elixir_vsn: ${{ needs.prepare.outputs.elixir_vsn }}
+      builder_vsn: ${{ needs.prepare.outputs.builder_vsn }}
     secrets: inherit
 
   build_and_push_docker_images:
     if: needs.prepare.outputs.release == 'true'
     needs:
-      - init
       - prepare
     uses: ./.github/workflows/build_and_push_docker_images.yaml
     with:
       profile: ${{ needs.prepare.outputs.profile }}
       publish: true
       latest: ${{ needs.prepare.outputs.latest }}
-      build_from: ${{ needs.init.outputs.BUILD_FROM }}
-      run_from: ${{ needs.init.outputs.RUN_FROM }}
+      # TODO: revert this back to needs.prepare.outputs.otp_vsn when OTP 26 bug is fixed
+      otp_vsn: 25.3.2-2
+      elixir_vsn: ${{ needs.prepare.outputs.elixir_vsn }}
+      builder_vsn: ${{ needs.prepare.outputs.builder_vsn }}
     secrets: inherit
 
   build_slim_packages:
     if: needs.prepare.outputs.release != 'true'
     needs:
-      - init
       - prepare
     uses: ./.github/workflows/build_slim_packages.yaml
+    with:
+      builder: ${{ needs.prepare.outputs.builder }}
+      builder_vsn: ${{ needs.prepare.outputs.builder_vsn }}
+      otp_vsn: ${{ needs.prepare.outputs.otp_vsn }}
+      elixir_vsn: ${{ needs.prepare.outputs.elixir_vsn }}
 
   compile:
     if: needs.prepare.outputs.release != 'true'
     runs-on: ${{ endsWith(github.repository, '/emqx') && 'ubuntu-22.04' || fromJSON('["self-hosted","ephemeral","linux","x64"]') }}
-    container: ${{ needs.init.outputs.BUILDER }}
+    container: ${{ needs.prepare.outputs.builder }}
     needs:
-      - init
       - prepare
     strategy:
       matrix:
@@ -147,7 +140,7 @@ jobs:
       contents: read
 
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
         with:
           ref: ${{ github.event.inputs.ref }}
           fetch-depth: 0
@@ -163,7 +156,7 @@ jobs:
           echo "PROFILE=${PROFILE}" | tee -a .env
           echo "PKG_VSN=$(./pkg-vsn.sh ${PROFILE})" | tee -a .env
           zip -ryq -x@.github/workflows/.zipignore $PROFILE.zip .
-      - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+      - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
         with:
           name: ${{ matrix.profile }}
           path: ${{ matrix.profile }}.zip
@@ -171,23 +164,22 @@ jobs:
 
   run_emqx_app_tests:
     needs:
-      - init
+      - prepare
       - compile
     uses: ./.github/workflows/run_emqx_app_tests.yaml
     with:
-      builder: ${{ needs.init.outputs.BUILDER }}
+      builder: ${{ needs.prepare.outputs.builder }}
       before_ref: ${{ github.event.before }}
       after_ref: ${{ github.sha }}
 
   run_test_cases:
     if: needs.prepare.outputs.release != 'true'
     needs:
-      - init
       - prepare
       - compile
     uses: ./.github/workflows/run_test_cases.yaml
     with:
-      builder: ${{ needs.init.outputs.BUILDER }}
+      builder: ${{ needs.prepare.outputs.builder }}
       ct-matrix: ${{ needs.prepare.outputs.ct-matrix }}
       ct-host: ${{ needs.prepare.outputs.ct-host }}
       ct-docker: ${{ needs.prepare.outputs.ct-docker }}
@@ -195,20 +187,18 @@ jobs:
   run_conf_tests:
     if: needs.prepare.outputs.release != 'true'
     needs:
-      - init
       - prepare
       - compile
     uses: ./.github/workflows/run_conf_tests.yaml
     with:
-      builder: ${{ needs.init.outputs.BUILDER }}
+      builder: ${{ needs.prepare.outputs.builder }}
 
   static_checks:
     if: needs.prepare.outputs.release != 'true'
     needs:
-      - init
       - prepare
       - compile
     uses: ./.github/workflows/static_checks.yaml
     with:
-      builder: ${{ needs.init.outputs.BUILDER }}
+      builder: ${{ needs.prepare.outputs.builder }}
       ct-matrix: ${{ needs.prepare.outputs.ct-matrix }}

.github/workflows/build_and_push_docker_images.yaml

@@ -16,10 +16,13 @@ on:
       publish:
         required: true
         type: boolean
-      build_from:
+      otp_vsn:
         required: true
         type: string
-      run_from:
+      elixir_vsn:
+        required: true
+        type: string
+      builder_vsn:
         required: true
         type: string
     secrets:
@@ -47,12 +50,18 @@ on:
         required: false
         type: boolean
         default: false
-      build_from:
+      otp_vsn:
         required: false
         type: string
-        default: ghcr.io/emqx/emqx-builder/5.3-9:1.15.7-26.2.5-3-debian12
-      run_from:
-        default: public.ecr.aws/debian/debian:stable-20240612-slim
+        default: '25.3.2-2'
+      elixir_vsn:
+        required: false
+        type: string
+        default: '1.15.7'
+      builder_vsn:
+        required: false
+        type: string
+        default: '5.3-5'
 
 permissions:
   contents: read
@@ -60,7 +69,7 @@ permissions:
 jobs:
   build:
     runs-on: ${{ github.repository_owner == 'emqx' && fromJSON(format('["self-hosted","ephemeral","linux","{0}"]', matrix.arch)) || 'ubuntu-22.04' }}
-    container: ${{ inputs.build_from }}
+    container: "ghcr.io/emqx/emqx-builder/${{ inputs.builder_vsn }}:${{ inputs.elixir_vsn }}-${{ inputs.otp_vsn }}-debian12"
     outputs:
       PKG_VSN: ${{ steps.build.outputs.PKG_VSN }}
 
@@ -75,7 +84,7 @@ jobs:
           - arm64
 
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
         with:
           ref: ${{ github.event.inputs.ref }}
       - run: git config --global --add safe.directory "$PWD"
@@ -83,7 +92,7 @@ jobs:
         id: build
         run: |
           make ${{ matrix.profile }}-tgz
-      - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+      - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
         with:
           name: "${{ matrix.profile }}-${{ matrix.arch }}.tar.gz"
           path: "_packages/emqx*/emqx-*.tar.gz"
@@ -107,10 +116,10 @@ jobs:
           - ["${{ inputs.profile }}-elixir", "${{ inputs.profile == 'emqx' && 'docker.io,public.ecr.aws' || 'docker.io' }}"]
 
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
         with:
           ref: ${{ github.event.inputs.ref }}
-      - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+      - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
         with:
           pattern: "${{ matrix.profile[0] }}-*.tar.gz"
           path: _packages
@@ -122,25 +131,24 @@ jobs:
         run: |
           ls -lR _packages/$PROFILE
           mv _packages/$PROFILE/*.tar.gz ./
-
       - name: Enable containerd image store on Docker Engine
         run: |
-          echo "$(sudo cat /etc/docker/daemon.json | jq '. += {"features": {"containerd-snapshotter": true}}')" > daemon.json
+          echo "$(jq '. += {"features": {"containerd-snapshotter": true}}' /etc/docker/daemon.json)" > daemon.json
           sudo mv daemon.json /etc/docker/daemon.json
           sudo systemctl restart docker
 
-      - uses: docker/setup-qemu-action@49b3bc8e6bdd4a60e6116a5414239cba5943d3cf # v3.2.0
-      - uses: docker/setup-buildx-action@988b5a0280414f521da01fcc63a27aeeb4b104db # v3.6.1
+      - uses: docker/setup-qemu-action@68827325e0b33c7199eb31dd4e31fbe9023e06e3 # v3.0.0
+      - uses: docker/setup-buildx-action@2b51285047da1547ffb1b2203d8be4c0af6b1f20 # v3.2.0
 
       - name: Login to hub.docker.com
-        uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0
+        uses: docker/login-action@e92390c5fb421da1463c202d546fed0ec5c39f20 # v3.1.0
         if: inputs.publish && contains(matrix.profile[1], 'docker.io')
         with:
           username: ${{ secrets.DOCKER_HUB_USER }}
           password: ${{ secrets.DOCKER_HUB_TOKEN }}
 
       - name: Login to AWS ECR
-        uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0
+        uses: docker/login-action@e92390c5fb421da1463c202d546fed0ec5c39f20 # v3.1.0
         if: inputs.publish && contains(matrix.profile[1], 'public.ecr.aws')
         with:
           registry: public.ecr.aws
@@ -148,7 +156,7 @@ jobs:
           password: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           ecr: true
 
-      - name: Build docker image for smoke test
+      - name: Build docker image
         env:
           PROFILE: ${{ matrix.profile[0] }}
           DOCKER_REGISTRY: ${{ matrix.profile[1] }}
@@ -156,9 +164,14 @@ jobs:
           DOCKER_LATEST: ${{ inputs.latest }}
           DOCKER_PUSH: false
           DOCKER_BUILD_NOCACHE: true
-          BUILD_FROM: ${{ inputs.build_from }}
-          RUN_FROM: ${{ inputs.run_from }}
+          DOCKER_PLATFORMS: linux/amd64,linux/arm64
+          DOCKER_LOAD: true
+          EMQX_RUNNER: 'public.ecr.aws/debian/debian:12-slim'
+          EMQX_DOCKERFILE: 'deploy/docker/Dockerfile'
           PKG_VSN: ${{ needs.build.outputs.PKG_VSN }}
+          EMQX_BUILDER_VERSION: ${{ inputs.builder_vsn }}
+          EMQX_BUILDER_OTP: ${{ inputs.otp_vsn }}
+          EMQX_BUILDER_ELIXIR: ${{ inputs.elixir_vsn }}
           EMQX_SOURCE_TYPE: tgz
         run: |
           ./build ${PROFILE} docker
@@ -172,7 +185,7 @@ jobs:
         timeout-minutes: 1
         run: |
           for tag in $(cat .emqx_docker_image_tags); do
-            CID=$(docker run -d -p 18083:18083 $tag)
+            CID=$(docker run -d -P $tag)
             HTTP_PORT=$(docker inspect --format='{{(index (index .NetworkSettings.Ports "18083/tcp") 0).HostPort}}' $CID)
             ./scripts/test/emqx-smoke-test.sh localhost $HTTP_PORT
             docker rm -f $CID
@@ -190,8 +203,7 @@ jobs:
           docker exec -t -u root -w /root $CID bash -c 'apt-get -y update && apt-get -y install net-tools'
           docker exec -t -u root $CID node_dump
           docker rm -f $CID
-
-      - name: Build and push docker image
+      - name: Push docker image
         if: inputs.publish || github.repository_owner != 'emqx'
         env:
           PROFILE: ${{ matrix.profile[0] }}
@@ -202,9 +214,12 @@ jobs:
           DOCKER_BUILD_NOCACHE: false
           DOCKER_PLATFORMS: linux/amd64,linux/arm64
           DOCKER_LOAD: false
-          BUILD_FROM: ${{ inputs.build_from }}
-          RUN_FROM: ${{ inputs.run_from }}
+          EMQX_RUNNER: 'public.ecr.aws/debian/debian:12-slim'
+          EMQX_DOCKERFILE: 'deploy/docker/Dockerfile'
           PKG_VSN: ${{ needs.build.outputs.PKG_VSN }}
+          EMQX_BUILDER_VERSION: ${{ inputs.builder_vsn }}
+          EMQX_BUILDER_OTP: ${{ inputs.otp_vsn }}
+          EMQX_BUILDER_ELIXIR: ${{ inputs.elixir_vsn }}
           EMQX_SOURCE_TYPE: tgz
         run: |
           ./build ${PROFILE} docker

.github/workflows/build_docker_for_test.yaml

@@ -6,6 +6,19 @@ concurrency:
 
 on:
   workflow_call:
+    inputs:
+      otp_vsn:
+        required: true
+        type: string
+      elixir_vsn:
+        required: true
+        type: string
+      version-emqx:
+        required: true
+        type: string
+      version-emqx-enterprise:
+        required: true
+        type: string
 
 permissions:
   contents: read
@@ -15,6 +28,9 @@ jobs:
     runs-on: ${{ endsWith(github.repository, '/emqx') && 'ubuntu-22.04' || fromJSON('["self-hosted","ephemeral","linux","x64"]') }}
     env:
       EMQX_NAME: ${{ matrix.profile }}
+      PKG_VSN: ${{ matrix.profile == 'emqx-enterprise' && inputs.version-emqx-enterprise || inputs.version-emqx }}
+      OTP_VSN: ${{ inputs.otp_vsn }}
+      ELIXIR_VSN: ${{ inputs.elixir_vsn }}
 
     strategy:
       fail-fast: false
@@ -26,13 +42,7 @@ jobs:
           - emqx-enterprise-elixir
 
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-      - name: Set up environment
-        id: env
-        run: |
-          source env.sh
-          PKG_VSN=$(docker run --rm -v $(pwd):$(pwd) -w $(pwd) -u $(id -u) "$EMQX_BUILDER" ./pkg-vsn.sh "$EMQX_NAME")
-          echo "PKG_VSN=$PKG_VSN" >> "$GITHUB_ENV"
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       - name: build and export to Docker
         id: build
         run: |
@@ -42,16 +52,12 @@ jobs:
         run: |
           CID=$(docker run -d --rm -P $_EMQX_DOCKER_IMAGE_TAG)
           HTTP_PORT=$(docker inspect --format='{{(index (index .NetworkSettings.Ports "18083/tcp") 0).HostPort}}' $CID)
-          ./scripts/test/emqx-smoke-test.sh localhost $HTTP_PORT || {
-            docker logs $CID
-            exit 1
-          }
+          ./scripts/test/emqx-smoke-test.sh localhost $HTTP_PORT
           docker stop $CID
       - name: export docker image
-        if: always()
         run: |
           docker save $_EMQX_DOCKER_IMAGE_TAG | gzip > $EMQX_NAME-docker-$PKG_VSN.tar.gz
-      - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+      - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
         with:
           name: "${{ env.EMQX_NAME }}-docker"
           path: "${{ env.EMQX_NAME }}-docker-${{ env.PKG_VSN }}.tar.gz"

.github/workflows/build_packages.yaml

@@ -55,7 +55,7 @@ on:
       otp_vsn:
         required: false
         type: string
-        default: '26.2.5-3'
+        default: '26.2.1-2'
       elixir_vsn:
         required: false
         type: string
@@ -63,7 +63,7 @@ on:
       builder_vsn:
         required: false
         type: string
-        default: '5.3-9'
+        default: '5.3-5'
 
 permissions:
   contents: read
@@ -82,7 +82,7 @@ jobs:
           - ${{ inputs.otp_vsn }}
     runs-on: ${{ matrix.os }}
     steps:
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         ref: ${{ github.event.inputs.ref }}
         fetch-depth: 0
@@ -95,7 +95,7 @@ jobs:
         apple_developer_identity: ${{ secrets.APPLE_DEVELOPER_IDENTITY }}
         apple_developer_id_bundle: ${{ secrets.APPLE_DEVELOPER_ID_BUNDLE }}
         apple_developer_id_bundle_password: ${{ secrets.APPLE_DEVELOPER_ID_BUNDLE_PASSWORD }}
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: success()
       with:
         name: ${{ matrix.profile }}-${{ matrix.os }}-${{ matrix.otp }}
@@ -113,11 +113,13 @@ jobs:
           - ubuntu24.04
           - ubuntu22.04
           - ubuntu20.04
+          - ubuntu18.04
           - debian12
           - debian11
           - debian10
           - el9
           - el8
+          - el7
           - amzn2
           - amzn2023
         arch:
@@ -145,7 +147,7 @@ jobs:
         shell: bash
 
     steps:
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         ref: ${{ github.event.inputs.ref }}
         fetch-depth: 0
@@ -180,7 +182,7 @@ jobs:
           --builder $BUILDER \
           --elixir $IS_ELIXIR \
           --pkgtype pkg
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       with:
         name: ${{ matrix.profile }}-${{ matrix.os }}-${{ matrix.arch }}${{ matrix.with_elixir == 'yes' && '-elixir' || '' }}-${{ matrix.builder }}-${{ matrix.otp }}-${{ matrix.elixir }}
         path: _packages/${{ matrix.profile }}/
@@ -198,11 +200,23 @@ jobs:
         profile:
           - ${{ inputs.profile }}
     steps:
-    - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+    - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
       with:
         pattern: "${{ matrix.profile }}-*"
         path: packages/${{ matrix.profile }}
         merge-multiple: true
+    - name: install dos2unix
+      run: sudo apt-get update -y && sudo apt install -y dos2unix
+    - name: get packages
+      run: |
+        set -eu
+        cd packages/${{ matrix.profile }}
+        # fix the .sha256 file format
+        for f in *.sha256; do
+          dos2unix $f
+          echo "$(cat $f) ${f%.*}" | sha256sum -c || exit 1
+        done
+        cd -
     - uses: aws-actions/configure-aws-credentials@e3dd6a429d7300a6a4c196c26e071d42e0343502 # v4.0.2
       with:
         aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}

.github/workflows/build_packages_cron.yaml

@@ -16,52 +16,63 @@ jobs:
   linux:
     if: github.repository_owner == 'emqx'
     runs-on: ${{ endsWith(github.repository, '/emqx') && 'ubuntu-22.04' || fromJSON('["self-hosted","ephemeral","linux","x64"]') }}
+    container:
+      image: "ghcr.io/emqx/emqx-builder/${{ matrix.profile[2] }}-${{ matrix.os }}"
 
     strategy:
       fail-fast: false
       matrix:
         profile:
-          - ['emqx', 'master']
-          - ['emqx', 'release-57']
-          - ['emqx', 'release-58']
+          - ['emqx', 'master', '5.3-5:1.15.7-26.2.1-2']
+          - ['emqx', 'release-57', '5.3-5:1.15.7-26.2.1-2']
         os:
           - ubuntu22.04
           - amzn2023
 
-    env:
-      PROFILE: ${{ matrix.profile[0] }}
-      OS: ${{ matrix.os }}
-      BUILDER_SYSTEM: force_docker
-
     defaults:
       run:
         shell: bash
 
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
         with:
           ref: ${{ matrix.profile[1] }}
           fetch-depth: 0
-      - name: Set up environment
-        id: env
+
+      - name: fix workdir
         run: |
-          source env.sh
-          BUILDER="ghcr.io/emqx/emqx-builder/${EMQX_BUILDER_VSN}:${ELIXIR_VSN}-${OTP_VSN}-${OS}"
-          echo "BUILDER=$BUILDER" >> "$GITHUB_ENV"
-      - name: build tgz
+          set -eu
+          git config --global --add safe.directory "$GITHUB_WORKSPACE"
+          # Align path for CMake caches
+          if [ ! "$PWD" = "/emqx" ]; then
+            ln -s $PWD /emqx
+            cd /emqx
+          fi
+          echo "pwd is $PWD"
+
+      - name: build emqx packages
+        env:
+          PROFILE: ${{ matrix.profile[0] }}
+          ACLOCAL_PATH: "/usr/share/aclocal:/usr/local/share/aclocal"
         run: |
-          ./scripts/buildx.sh --profile "$PROFILE" --pkgtype tgz --builder "$BUILDER"
-      - name: build pkg
+          set -eu
+          make "${PROFILE}-tgz"
+          make "${PROFILE}-pkg"
+      - name: test emqx packages
+        env:
+          PROFILE: ${{ matrix.profile[0] }}
         run: |
-          ./scripts/buildx.sh --profile "$PROFILE" --pkgtype pkg --builder "$BUILDER"
-      - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+          set -eu
+          ./scripts/pkg-tests.sh "${PROFILE}-tgz"
+          ./scripts/pkg-tests.sh "${PROFILE}-pkg"
+      - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
         if: success()
         with:
-          name: ${{ matrix.profile[0] }}-${{ matrix.profile[1] }}-${{ matrix.os }}
+          name: ${{ matrix.profile[0] }}-${{ matrix.os }}-${{ github.ref_name }}
           path: _packages/${{ matrix.profile[0] }}/
           retention-days: 7
       - name: Send notification to Slack
-        uses: slackapi/slack-github-action@70cd7be8e40a46e8b0eced40b0de447bdb42f68e # v1.26.0
+        uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001 # v1.25.0
         if: failure()
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
@@ -80,36 +91,33 @@ jobs:
           - emqx
         branch:
           - master
+        otp:
+          - 26.2.1-2
         os:
-          - macos-14-arm64
+          - macos-12-arm64
 
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
         with:
           ref: ${{ matrix.branch }}
           fetch-depth: 0
-      - name: Set up environment
-        id: env
-        run: |
-          source env.sh
-          echo "OTP_VSN=$OTP_VSN" >> "$GITHUB_OUTPUT"
       - uses: ./.github/actions/package-macos
         with:
           profile: ${{ matrix.profile }}
-          otp: ${{ steps.env.outputs.OTP_VSN }}
+          otp: ${{ matrix.otp }}
           os: ${{ matrix.os }}
           apple_id_password: ${{ secrets.APPLE_ID_PASSWORD }}
           apple_developer_identity: ${{ secrets.APPLE_DEVELOPER_IDENTITY }}
           apple_developer_id_bundle: ${{ secrets.APPLE_DEVELOPER_ID_BUNDLE }}
           apple_developer_id_bundle_password: ${{ secrets.APPLE_DEVELOPER_ID_BUNDLE_PASSWORD }}
-      - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+      - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
         if: success()
         with:
           name: ${{ matrix.profile }}-${{ matrix.os }}
           path: _packages/${{ matrix.profile }}/
           retention-days: 7
       - name: Send notification to Slack
-        uses: slackapi/slack-github-action@70cd7be8e40a46e8b0eced40b0de447bdb42f68e # v1.26.0
+        uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001 # v1.25.0
         if: failure()
         env:
           SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

.github/workflows/build_slim_packages.yaml

@@ -6,50 +6,97 @@ concurrency:
 
 on:
   workflow_call:
+    inputs:
+      builder:
+        required: true
+        type: string
+      builder_vsn:
+        required: true
+        type: string
+      otp_vsn:
+        required: true
+        type: string
+      elixir_vsn:
+        required: true
+        type: string
+
   workflow_dispatch:
     inputs:
       ref:
         required: false
+      builder:
+        required: false
+        type: string
+        default: 'ghcr.io/emqx/emqx-builder/5.3-5:1.15.7-26.2.1-2-ubuntu22.04'
+      builder_vsn:
+        required: false
+        type: string
+        default: '5.3-5'
+      otp_vsn:
+        required: false
+        type: string
+        default: '26.2.1-2'
+      elixir_vsn:
+        required: false
+        type: string
+        default: '1.15.7'
 
 permissions:
   contents: read
 
 jobs:
   linux:
-    runs-on: ${{ github.repository_owner == 'emqx' && fromJSON(format('["self-hosted","ephemeral","linux","{0}"]', matrix.profile[2])) || 'ubuntu-22.04' }}
+    runs-on: ${{ github.repository_owner == 'emqx' && fromJSON(format('["self-hosted","ephemeral","linux","{0}"]', matrix.profile[4])) || 'ubuntu-22.04' }}
     env:
-      PROFILE: ${{ matrix.profile[0] }}
-      ELIXIR: ${{ matrix.profile[1] == 'elixir' && 'yes' || 'no' }}
-      ARCH: ${{ matrix.profile[2] == 'x64' && 'amd64' || 'arm64' }}
-      BUILDER_SYSTEM: force_docker
+      EMQX_NAME: ${{ matrix.profile[0] }}
 
     strategy:
       fail-fast: false
       matrix:
         profile:
-          - ["emqx", "elixir", "x64"]
-          - ["emqx", "elixir", "arm64"]
-          - ["emqx-enterprise", "erlang", "x64"]
+          - ["emqx", "26.2.1-2", "ubuntu22.04", "elixir", "x64"]
+          - ["emqx", "26.2.1-2", "ubuntu22.04", "elixir", "arm64"]
+          - ["emqx-enterprise", "26.2.1-2", "ubuntu22.04", "erlang", "x64"]
+
+    container: "ghcr.io/emqx/emqx-builder/${{ inputs.builder_vsn }}:${{ inputs.elixir_vsn }}-${{ matrix.profile[1] }}-${{ matrix.profile[2] }}"
 
     steps:
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         fetch-depth: 0
-    - name: build tgz
+    - name: Work around https://github.com/actions/checkout/issues/766
       run: |
-        ./scripts/buildx.sh --profile $PROFILE --pkgtype tgz --elixir $ELIXIR --arch $ARCH
-    - name: build pkg
+        git config --global --add safe.directory "$GITHUB_WORKSPACE"
+        echo "CODE_PATH=$GITHUB_WORKSPACE" >> $GITHUB_ENV
+    - name: build and test tgz package
+      if: matrix.profile[3] == 'erlang'
       run: |
-        ./scripts/buildx.sh --profile $PROFILE --pkgtype pkg --elixir $ELIXIR --arch $ARCH
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+        make ${EMQX_NAME}-tgz
+        ./scripts/pkg-tests.sh ${EMQX_NAME}-tgz
+    - name: build and test deb/rpm packages
+      if: matrix.profile[3] == 'erlang'
+      run: |
+        make ${EMQX_NAME}-pkg
+        ./scripts/pkg-tests.sh ${EMQX_NAME}-pkg
+    - name: build and test tgz package (Elixir)
+      if: matrix.profile[3] == 'elixir'
+      run: |
+        make ${EMQX_NAME}-elixir-tgz
+        ./scripts/pkg-tests.sh ${EMQX_NAME}-elixir-tgz
+    - name: build and test deb/rpm packages (Elixir)
+      if: matrix.profile[3] == 'elixir'
+      run: |
+        make ${EMQX_NAME}-elixir-pkg
+        ./scripts/pkg-tests.sh ${EMQX_NAME}-elixir-pkg
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       with:
-        name: "${{ matrix.profile[0] }}-${{ matrix.profile[1] }}-${{ matrix.profile[2] }}"
+        name: "${{ matrix.profile[0] }}-${{ matrix.profile[1] }}-${{ matrix.profile[2] }}-${{ matrix.profile[3] }}-${{ matrix.profile[4] }}"
         path: _packages/${{ matrix.profile[0] }}/*
         retention-days: 7
         compression-level: 0
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       with:
-        name: "${{ matrix.profile[0] }}-schema-dump-${{ matrix.profile[1] }}-${{ matrix.profile[2] }}"
+        name: "${{ matrix.profile[0] }}-schema-dump-${{ matrix.profile[1] }}-${{ matrix.profile[2] }}-${{ matrix.profile[3] }}-${{ matrix.profile[4] }}"
         path: |
           scripts/spellcheck
           _build/docgen/${{ matrix.profile[0] }}/schema-en.json
@@ -61,30 +108,27 @@ jobs:
       matrix:
         profile:
         - emqx
+        otp:
+        - ${{ inputs.otp_vsn }}
         os:
-        - macos-14-arm64
+        - macos-14
 
     runs-on: ${{ matrix.os }}
     env:
       EMQX_NAME: ${{ matrix.profile }}
 
     steps:
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-    - name: Set up environment
-      id: env
-      run: |
-        source env.sh
-        echo "OTP_VSN=$OTP_VSN" >> "$GITHUB_OUTPUT"
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
     - uses: ./.github/actions/package-macos
       with:
         profile: ${{ matrix.profile }}
-        otp: ${{ steps.env.outputs.OTP_VSN }}
+        otp: ${{ matrix.otp }}
         os: ${{ matrix.os }}
         apple_id_password: ${{ secrets.APPLE_ID_PASSWORD }}
         apple_developer_identity: ${{ secrets.APPLE_DEVELOPER_IDENTITY }}
         apple_developer_id_bundle: ${{ secrets.APPLE_DEVELOPER_ID_BUNDLE }}
         apple_developer_id_bundle_password: ${{ secrets.APPLE_DEVELOPER_ID_BUNDLE_PASSWORD }}
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       with:
         name: ${{ matrix.os }}
         path: _packages/**/*

.github/workflows/check_deps_integrity.yaml

@@ -22,7 +22,7 @@ jobs:
         profile:
           - emqx-enterprise
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       - run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
       - run: make ensure-rebar3
       - run: ./scripts/check-deps-integrity.escript
@@ -37,7 +37,7 @@ jobs:
       - run: ./scripts/check-elixir-deps-discrepancies.exs
       - run: ./scripts/check-elixir-applications.exs
       - name: Upload produced lock files
-        uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+        uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
         if: failure()
         with:
           name: ${{ matrix.profile }}_produced_lock_files

.github/workflows/codeql.yaml

@@ -17,6 +17,8 @@ jobs:
     permissions:
       actions: read
       security-events: write
+    container:
+      image: ghcr.io/emqx/emqx-builder/5.3-5:1.15.7-26.2.1-2-ubuntu22.04
 
     strategy:
       fail-fast: false
@@ -24,17 +26,21 @@ jobs:
         branch:
           - master
           - release-57
-          - release-58
         language:
           - cpp
           - python
 
     steps:
     - name: Checkout repository
-      uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         ref: ${{ matrix.branch }}
 
+    - name: Ensure git safe dir
+      run: |
+        git config --global --add safe.directory "$GITHUB_WORKSPACE"
+        make ensure-rebar3
+
     - name: Initialize CodeQL
       uses: github/codeql-action/init@7e187e1c529d80bac7b87a16e7a792427f65cf02 # v2.15.5
       with:
@@ -45,7 +51,14 @@ jobs:
       env:
         PROFILE: emqx-enterprise
       run: |
-        ./scripts/buildx.sh --profile emqx-enterprise --pkgtype rel
+        make emqx-enterprise-compile
+
+    - name: Fetch deps
+      if: matrix.language == 'python'
+      env:
+        PROFILE: emqx-enterprise
+      run: |
+        make deps-emqx-enterprise
 
     - name: Perform CodeQL Analysis
       uses: github/codeql-action/analyze@7e187e1c529d80bac7b87a16e7a792427f65cf02 # v2.15.5

.github/workflows/green_master.yaml

@@ -7,6 +7,9 @@ on:
     # run hourly
     - cron: "0 * * * *"
   workflow_dispatch:
+    inputs:
+      ref:
+        required: false
 
 permissions:
   contents: read
@@ -14,21 +17,14 @@ permissions:
 jobs:
   rerun-failed-jobs:
     if: github.repository_owner == 'emqx'
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     permissions:
       checks: read
       actions: write
-    strategy:
-      fail-fast: false
-      matrix:
-        ref:
-          - master
-          - release-57
-          - release-58
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
         with:
-          ref: ${{ matrix.ref }}
+          ref: ${{ github.event.inputs.ref || 'master' }}
 
       - name: run script
         shell: bash

.github/workflows/performance_test.yaml

@@ -26,13 +26,13 @@ jobs:
   prepare:
     runs-on: ubuntu-latest
     if: github.repository_owner == 'emqx'
-    container: ghcr.io/emqx/emqx-builder/5.3-9:1.15.7-26.2.5-3-ubuntu20.04
+    container: ghcr.io/emqx/emqx-builder/5.3-5:1.15.7-26.2.1-2-ubuntu20.04
     outputs:
       BENCH_ID: ${{ steps.prepare.outputs.BENCH_ID }}
       PACKAGE_FILE: ${{ steps.package_file.outputs.PACKAGE_FILE }}
 
     steps:
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         fetch-depth: 0
         ref: ${{ github.event.inputs.ref }}
@@ -52,7 +52,7 @@ jobs:
       id: package_file
       run: |
         echo "PACKAGE_FILE=$(find _packages/emqx -name 'emqx-*.deb' | head -n 1 | xargs basename)" >> $GITHUB_OUTPUT
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       with:
         name: emqx-ubuntu20.04
         path: _packages/emqx/${{ steps.package_file.outputs.PACKAGE_FILE }}
@@ -72,17 +72,17 @@ jobs:
         aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY_PERF_TEST }}
         aws-region: eu-west-1
     - name: Checkout tf-emqx-performance-test
-      uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         repository: emqx/tf-emqx-performance-test
         path: tf-emqx-performance-test
         ref: v0.2.3
-    - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+    - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
       with:
         name: emqx-ubuntu20.04
         path: tf-emqx-performance-test/
     - name: Setup Terraform
-      uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8 # v3.1.1
+      uses: hashicorp/setup-terraform@a1502cd9e758c50496cc9ac5308c4843bcd56d36 # v3.0.0
       with:
         terraform_wrapper: false
     - name: run scenario
@@ -105,7 +105,7 @@ jobs:
         terraform destroy -auto-approve
         aws s3 sync --exclude '*' --include '*.tar.gz' s3://$TF_VAR_s3_bucket_name/$TF_VAR_bench_id .
     - name: Send notification to Slack
-      uses: slackapi/slack-github-action@70cd7be8e40a46e8b0eced40b0de447bdb42f68e # v1.26.0
+      uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001 # v1.25.0
       with:
         payload-file-path: "./tf-emqx-performance-test/slack-payload.json"
     - name: terraform destroy
@@ -113,13 +113,13 @@ jobs:
       working-directory: ./tf-emqx-performance-test
       run: |
         terraform destroy -auto-approve
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: success()
       with:
         name: metrics
         path: |
           "./tf-emqx-performance-test/*.tar.gz"
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: failure()
       with:
         name: terraform
@@ -143,17 +143,17 @@ jobs:
         aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY_PERF_TEST }}
         aws-region: eu-west-1
     - name: Checkout tf-emqx-performance-test
-      uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         repository: emqx/tf-emqx-performance-test
         path: tf-emqx-performance-test
         ref: v0.2.3
-    - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+    - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
       with:
         name: emqx-ubuntu20.04
         path: tf-emqx-performance-test/
     - name: Setup Terraform
-      uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8 # v3.1.1
+      uses: hashicorp/setup-terraform@a1502cd9e758c50496cc9ac5308c4843bcd56d36 # v3.0.0
       with:
         terraform_wrapper: false
     - name: run scenario
@@ -176,7 +176,7 @@ jobs:
         terraform destroy -auto-approve
         aws s3 sync --exclude '*' --include '*.tar.gz' s3://$TF_VAR_s3_bucket_name/$TF_VAR_bench_id .
     - name: Send notification to Slack
-      uses: slackapi/slack-github-action@70cd7be8e40a46e8b0eced40b0de447bdb42f68e # v1.26.0
+      uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001 # v1.25.0
       with:
         payload-file-path: "./tf-emqx-performance-test/slack-payload.json"
     - name: terraform destroy
@@ -184,13 +184,13 @@ jobs:
       working-directory: ./tf-emqx-performance-test
       run: |
         terraform destroy -auto-approve
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: success()
       with:
         name: metrics
         path: |
           "./tf-emqx-performance-test/*.tar.gz"
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: failure()
       with:
         name: terraform
@@ -215,17 +215,17 @@ jobs:
         aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY_PERF_TEST }}
         aws-region: eu-west-1
     - name: Checkout tf-emqx-performance-test
-      uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         repository: emqx/tf-emqx-performance-test
         path: tf-emqx-performance-test
         ref: v0.2.3
-    - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+    - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
       with:
         name: emqx-ubuntu20.04
         path: tf-emqx-performance-test/
     - name: Setup Terraform
-      uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8 # v3.1.1
+      uses: hashicorp/setup-terraform@a1502cd9e758c50496cc9ac5308c4843bcd56d36 # v3.0.0
       with:
         terraform_wrapper: false
     - name: run scenario
@@ -249,7 +249,7 @@ jobs:
         terraform destroy -auto-approve
         aws s3 sync --exclude '*' --include '*.tar.gz' s3://$TF_VAR_s3_bucket_name/$TF_VAR_bench_id .
     - name: Send notification to Slack
-      uses: slackapi/slack-github-action@70cd7be8e40a46e8b0eced40b0de447bdb42f68e # v1.26.0
+      uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001 # v1.25.0
       with:
         payload-file-path: "./tf-emqx-performance-test/slack-payload.json"
     - name: terraform destroy
@@ -257,13 +257,13 @@ jobs:
       working-directory: ./tf-emqx-performance-test
       run: |
         terraform destroy -auto-approve
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: success()
       with:
         name: metrics
         path: |
           "./tf-emqx-performance-test/*.tar.gz"
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: failure()
       with:
         name: terraform
@@ -289,17 +289,17 @@ jobs:
         aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY_PERF_TEST }}
         aws-region: eu-west-1
     - name: Checkout tf-emqx-performance-test
-      uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         repository: emqx/tf-emqx-performance-test
         path: tf-emqx-performance-test
         ref: v0.2.3
-    - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+    - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
       with:
         name: emqx-ubuntu20.04
         path: tf-emqx-performance-test/
     - name: Setup Terraform
-      uses: hashicorp/setup-terraform@651471c36a6092792c552e8b1bef71e592b462d8 # v3.1.1
+      uses: hashicorp/setup-terraform@a1502cd9e758c50496cc9ac5308c4843bcd56d36 # v3.0.0
       with:
         terraform_wrapper: false
     - name: run scenario
@@ -322,7 +322,7 @@ jobs:
         terraform destroy -auto-approve
         aws s3 sync --exclude '*' --include '*.tar.gz' s3://$TF_VAR_s3_bucket_name/$TF_VAR_bench_id .
     - name: Send notification to Slack
-      uses: slackapi/slack-github-action@70cd7be8e40a46e8b0eced40b0de447bdb42f68e # v1.26.0
+      uses: slackapi/slack-github-action@6c661ce58804a1a20f6dc5fbee7f0381b469e001 # v1.25.0
       with:
         payload-file-path: "./tf-emqx-performance-test/slack-payload.json"
     - name: terraform destroy
@@ -330,13 +330,13 @@ jobs:
       working-directory: ./tf-emqx-performance-test
       run: |
         terraform destroy -auto-approve
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: success()
       with:
         name: metrics
         path: |
           "./tf-emqx-performance-test/*.tar.gz"
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: failure()
       with:
         name: terraform

.github/workflows/release.yaml

@@ -8,7 +8,7 @@ on:
       tag:
         type: string
         required: true
-      publish_release_artifacts:
+      publish_release_artefacts:
         type: boolean
         required: true
         default: false
@@ -36,7 +36,7 @@ jobs:
           aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
           aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           aws-region: ${{ secrets.AWS_DEFAULT_REGION }}
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
         with:
           ref: ${{ github.event.inputs.tag }}
       - name: Detect profile
@@ -75,7 +75,7 @@ jobs:
           tag_name: "${{ env.ref_name }}"
           skip_existing: true
       - name: update to emqx.io
-        if: github.event_name == 'release' || inputs.publish_release_artifacts
+        if: startsWith(env.ref_name, 'v') && ((github.event_name == 'release' && !github.event.release.prerelease) || inputs.publish_release_artefacts)
         run: |
           set -eux
           curl -w %{http_code} \
@@ -86,7 +86,7 @@ jobs:
                -d "{\"repo\":\"emqx/emqx\", \"tag\": \"${{ env.ref_name }}\" }" \
                ${{ secrets.EMQX_IO_RELEASE_API }}
       - name: Push to packagecloud.io
-        if: (github.event_name == 'release' && !github.event.release.prerelease) || inputs.publish_release_artifacts
+        if: (github.event_name == 'release' && !github.event.release.prerelease) || inputs.publish_release_artefacts
         env:
           PROFILE: ${{ steps.profile.outputs.profile }}
           VERSION: ${{ steps.profile.outputs.version }}
@@ -106,12 +106,16 @@ jobs:
           push "debian/bullseye" "packages/$PROFILE-$VERSION-debian11-arm64.deb"
           push "debian/bookworm" "packages/$PROFILE-$VERSION-debian12-amd64.deb"
           push "debian/bookworm" "packages/$PROFILE-$VERSION-debian12-arm64.deb"
+          push "ubuntu/bionic" "packages/$PROFILE-$VERSION-ubuntu18.04-amd64.deb"
+          push "ubuntu/bionic" "packages/$PROFILE-$VERSION-ubuntu18.04-arm64.deb"
           push "ubuntu/focal" "packages/$PROFILE-$VERSION-ubuntu20.04-amd64.deb"
           push "ubuntu/focal" "packages/$PROFILE-$VERSION-ubuntu20.04-arm64.deb"
           push "ubuntu/jammy" "packages/$PROFILE-$VERSION-ubuntu22.04-amd64.deb"
           push "ubuntu/jammy" "packages/$PROFILE-$VERSION-ubuntu22.04-arm64.deb"
           push "ubuntu/noble" "packages/$PROFILE-$VERSION-ubuntu24.04-amd64.deb"
           push "ubuntu/noble" "packages/$PROFILE-$VERSION-ubuntu24.04-arm64.deb"
+          push "el/7" "packages/$PROFILE-$VERSION-el7-amd64.rpm"
+          push "el/7" "packages/$PROFILE-$VERSION-el7-arm64.rpm"
           push "el/8" "packages/$PROFILE-$VERSION-el8-amd64.rpm"
           push "el/8" "packages/$PROFILE-$VERSION-el8-arm64.rpm"
           push "el/9" "packages/$PROFILE-$VERSION-el9-amd64.rpm"
@@ -131,7 +135,7 @@ jobs:
       checks: write
       actions: write
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       - name: trigger re-run of app versions check on open PRs
         shell: bash
         env:

.github/workflows/run_conf_tests.yaml

@@ -25,7 +25,7 @@ jobs:
           - emqx
           - emqx-enterprise
     steps:
-      - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+      - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
         with:
           name: ${{ matrix.profile }}
       - name: extract artifact
@@ -39,10 +39,10 @@ jobs:
       - name: print erlang log
         if: failure()
         run: |
-          cat _build/${{ matrix.profile }}/rel/emqx/log/erlang.log.*
-      - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+          cat _build/${{ matrix.profile }}/rel/emqx/logs/erlang.log.*
+      - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
         if: failure()
         with:
           name: conftest-logs-${{ matrix.profile }}
-          path: _build/${{ matrix.profile }}/rel/emqx/log
+          path: _build/${{ matrix.profile }}/rel/emqx/logs
           retention-days: 7

.github/workflows/run_docker_tests.yaml

@@ -6,6 +6,13 @@ concurrency:
 
 on:
   workflow_call:
+    inputs:
+      version-emqx:
+        required: true
+        type: string
+      version-emqx-enterprise:
+        required: true
+        type: string
 
 permissions:
   contents: read
@@ -25,17 +32,12 @@ jobs:
 
     env:
       EMQX_NAME: ${{ matrix.profile[0] }}
+      PKG_VSN: ${{ matrix.profile[0] == 'emqx-enterprise' && inputs.version-emqx-enterprise || inputs.version-emqx }}
       EMQX_IMAGE_OLD_VERSION_TAG: ${{ matrix.profile[1] }}
 
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-      - name: Set up environment
-        id: env
-        run: |
-          source env.sh
-          PKG_VSN=$(docker run --rm -v $(pwd):$(pwd) -w $(pwd) -u $(id -u) "$EMQX_BUILDER" ./pkg-vsn.sh "$EMQX_NAME")
-          echo "PKG_VSN=$PKG_VSN" >> "$GITHUB_ENV"
-      - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
+      - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
         with:
           name: ${{ env.EMQX_NAME }}-docker
           path: /tmp
@@ -45,16 +47,17 @@ jobs:
           echo "_EMQX_DOCKER_IMAGE_TAG=$_EMQX_DOCKER_IMAGE_TAG" >> $GITHUB_ENV
       - name: dashboard tests
         working-directory: ./scripts/ui-tests
+        env:
+          EMQX_VERSION: ${{ inputs.version-emqx }}
+          EMQX_ENTERPRISE_VERSION: ${{ inputs.version-emqx-enterprise }}
         run: |
           set -eu
           docker compose up --abort-on-container-exit --exit-code-from selenium
       - name: test two nodes cluster with proto_dist=inet_tls in docker
         run: |
-          ## -d 1 means only put node 1 (latest version) behind haproxy
-          ./scripts/test/start-two-nodes-in-docker.sh -d 1 -P $_EMQX_DOCKER_IMAGE_TAG $EMQX_IMAGE_OLD_VERSION_TAG
+          ./scripts/test/start-two-nodes-in-docker.sh -P $_EMQX_DOCKER_IMAGE_TAG $EMQX_IMAGE_OLD_VERSION_TAG
           HTTP_PORT=$(docker inspect --format='{{(index (index .NetworkSettings.Ports "18083/tcp") 0).HostPort}}' haproxy)
           ./scripts/test/emqx-smoke-test.sh localhost $HTTP_PORT
-          ## -c menas 'cleanup'
           ./scripts/test/start-two-nodes-in-docker.sh -c
       - name: cleanup
         if: always()
@@ -69,6 +72,8 @@ jobs:
         shell: bash
     env:
       EMQX_NAME: ${{ matrix.profile }}
+      PKG_VSN: ${{ matrix.profile == 'emqx-enterprise' && inputs.version-emqx-enterprise || inputs.version-emqx }}
+      _EMQX_TEST_DB_BACKEND: ${{ matrix.cluster_db_backend }}
 
     strategy:
       fail-fast: false
@@ -77,20 +82,12 @@ jobs:
           - emqx
           - emqx-enterprise
           - emqx-elixir
+        cluster_db_backend:
+          - mnesia
+          - rlog
     steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-      - name: Set up environment
-        id: env
-        run: |
-          source env.sh
-          if [ "$EMQX_NAME" = "emqx-enterprise" ]; then
-            _EMQX_TEST_DB_BACKEND='rlog'
-          else
-            _EMQX_TEST_DB_BACKEND='mnesia'
-          fi
-          PKG_VSN=$(docker run --rm -v $(pwd):$(pwd) -w $(pwd) -u $(id -u) "$EMQX_BUILDER" ./pkg-vsn.sh "$EMQX_NAME")
-          echo "PKG_VSN=$PKG_VSN" >> "$GITHUB_ENV"
-      - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
+      - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
         with:
           name: ${{ env.EMQX_NAME }}-docker
           path: /tmp

.github/workflows/run_emqx_app_tests.yaml

@@ -37,7 +37,7 @@ jobs:
       matrix: ${{ steps.matrix.outputs.matrix }}
       skip: ${{ steps.matrix.outputs.skip }}
     steps:
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         fetch-depth: 0
     - name: prepare test matrix
@@ -72,7 +72,7 @@ jobs:
       run:
         shell: bash
     steps:
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         fetch-depth: 0
     - name: run
@@ -95,7 +95,7 @@ jobs:
             echo "Suites: $SUITES"
             ./rebar3 as standalone_test ct --name 'test@127.0.0.1' -v --readable=true --suite="$SUITES"
         fi
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: failure()
       with:
         name: logs-emqx-app-tests-${{ matrix.type }}

.github/workflows/run_helm_tests.yaml

@@ -6,6 +6,13 @@ concurrency:
 
 on:
   workflow_call:
+    inputs:
+      version-emqx:
+        required: true
+        type: string
+      version-emqx-enterprise:
+        required: true
+        type: string
 
 permissions:
   contents: read
@@ -18,6 +25,7 @@ jobs:
         shell: bash
     env:
       EMQX_NAME: ${{ matrix.profile }}
+      EMQX_TAG: ${{ matrix.profile == 'emqx-enterprise' && inputs.version-emqx-enterprise || inputs.version-emqx }}
       REPOSITORY: "emqx/${{ matrix.profile }}"
 
     strategy:
@@ -34,17 +42,10 @@ jobs:
         - ssl1.3
         - ssl1.2
     steps:
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         path: source
-    - name: Set up environment
-      id: env
-      run: |
-        cd source
-        source env.sh
-        PKG_VSN=$(docker run --rm -v $(pwd):$(pwd) -w $(pwd) -u $(id -u) "$EMQX_BUILDER" ./pkg-vsn.sh "$EMQX_NAME")
-        echo "EMQX_TAG=$PKG_VSN" >> "$GITHUB_ENV"
-    - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+    - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
       with:
         name: "${{ env.EMQX_NAME }}-docker"
         path: /tmp
@@ -164,7 +165,7 @@ jobs:
           fi
           sleep 1;
         done
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         repository: emqx/paho.mqtt.testing
         ref: develop-5.0

.github/workflows/run_jmeter_tests.yaml

@@ -2,6 +2,10 @@ name: JMeter integration tests
 
 on:
   workflow_call:
+    inputs:
+      version-emqx:
+        required: true
+        type: string
 
 permissions:
   contents: read
@@ -12,7 +16,7 @@ jobs:
     steps:
     - name: Cache Jmeter
       id: cache-jmeter
-      uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
+      uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 # v4.0.1
       with:
         path: /tmp/apache-jmeter.tgz
         key: apache-jmeter-5.4.3.tgz
@@ -31,7 +35,7 @@ jobs:
         else
           wget --no-verbose --no-check-certificate -O /tmp/apache-jmeter.tgz $ARCHIVE_URL
         fi
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       with:
         name: apache-jmeter.tgz
         path: /tmp/apache-jmeter.tgz
@@ -51,23 +55,10 @@ jobs:
 
     needs: jmeter_artifact
     steps:
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-    - name: Set up environment
-      id: env
-      run: |
-        source env.sh
-        PKG_VSN=$(docker run --rm -v $(pwd):$(pwd) -w $(pwd) -u $(id -u) "$EMQX_BUILDER" ./pkg-vsn.sh emqx)
-        echo "PKG_VSN=$PKG_VSN" >> "$GITHUB_ENV"
-    - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
-      with:
-        name: emqx-docker
-        path: /tmp
-    - name: load docker image
-      shell: bash
-      run: |
-        EMQX_DOCKER_IMAGE_TAG=$(docker load < /tmp/emqx-docker-${PKG_VSN}.tar.gz | sed 's/Loaded image: //g')
-        echo "_EMQX_DOCKER_IMAGE_TAG=$EMQX_DOCKER_IMAGE_TAG" >> $GITHUB_ENV
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
     - uses: ./.github/actions/prepare-jmeter
+      with:
+        version-emqx: ${{ inputs.version-emqx }}
     - name: docker compose up
       timeout-minutes: 5
       run: |
@@ -95,7 +86,7 @@ jobs:
           echo "check logs failed"
           exit 1
         fi
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: always()
       with:
         name: jmeter_logs-advanced_feat-${{ matrix.scripts_type }}
@@ -120,23 +111,10 @@ jobs:
 
     needs: jmeter_artifact
     steps:
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-    - name: Set up environment
-      id: env
-      run: |
-        source env.sh
-        PKG_VSN=$(docker run --rm -v $(pwd):$(pwd) -w $(pwd) -u $(id -u) "$EMQX_BUILDER" ./pkg-vsn.sh emqx)
-        echo "PKG_VSN=$PKG_VSN" >> "$GITHUB_ENV"
-    - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
-      with:
-        name: emqx-docker
-        path: /tmp
-    - name: load docker image
-      shell: bash
-      run: |
-        EMQX_DOCKER_IMAGE_TAG=$(docker load < /tmp/emqx-docker-${PKG_VSN}.tar.gz | sed 's/Loaded image: //g')
-        echo "_EMQX_DOCKER_IMAGE_TAG=$EMQX_DOCKER_IMAGE_TAG" >> $GITHUB_ENV
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
     - uses: ./.github/actions/prepare-jmeter
+      with:
+        version-emqx: ${{ inputs.version-emqx }}
     - name: docker compose up
       timeout-minutes: 5
       env:
@@ -175,7 +153,7 @@ jobs:
       if: failure()
       run: |
         docker compose -f .ci/docker-compose-file/docker-compose-emqx-cluster.yaml logs --no-color > ./jmeter_logs/emqx.log
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: always()
       with:
         name: jmeter_logs-pgsql_authn_authz-${{ matrix.scripts_type }}_${{ matrix.pgsql_tag }}
@@ -197,23 +175,10 @@ jobs:
 
     needs: jmeter_artifact
     steps:
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-    - name: Set up environment
-      id: env
-      run: |
-        source env.sh
-        PKG_VSN=$(docker run --rm -v $(pwd):$(pwd) -w $(pwd) -u $(id -u) "$EMQX_BUILDER" ./pkg-vsn.sh emqx)
-        echo "PKG_VSN=$PKG_VSN" >> "$GITHUB_ENV"
-    - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
-      with:
-        name: emqx-docker
-        path: /tmp
-    - name: load docker image
-      shell: bash
-      run: |
-        EMQX_DOCKER_IMAGE_TAG=$(docker load < /tmp/emqx-docker-${PKG_VSN}.tar.gz | sed 's/Loaded image: //g')
-        echo "_EMQX_DOCKER_IMAGE_TAG=$EMQX_DOCKER_IMAGE_TAG" >> $GITHUB_ENV
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
     - uses: ./.github/actions/prepare-jmeter
+      with:
+        version-emqx: ${{ inputs.version-emqx }}
     - name: docker compose up
       timeout-minutes: 5
       env:
@@ -248,7 +213,7 @@ jobs:
           echo "check logs failed"
           exit 1
         fi
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: always()
       with:
         name: jmeter_logs-mysql_authn_authz-${{ matrix.scripts_type }}_${{ matrix.mysql_tag }}
@@ -266,23 +231,10 @@ jobs:
 
     needs: jmeter_artifact
     steps:
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-    - name: Set up environment
-      id: env
-      run: |
-        source env.sh
-        PKG_VSN=$(docker run --rm -v $(pwd):$(pwd) -w $(pwd) -u $(id -u) "$EMQX_BUILDER" ./pkg-vsn.sh emqx)
-        echo "PKG_VSN=$PKG_VSN" >> "$GITHUB_ENV"
-    - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
-      with:
-        name: emqx-docker
-        path: /tmp
-    - name: load docker image
-      shell: bash
-      run: |
-        EMQX_DOCKER_IMAGE_TAG=$(docker load < /tmp/emqx-docker-${PKG_VSN}.tar.gz | sed 's/Loaded image: //g')
-        echo "_EMQX_DOCKER_IMAGE_TAG=$EMQX_DOCKER_IMAGE_TAG" >> $GITHUB_ENV
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
     - uses: ./.github/actions/prepare-jmeter
+      with:
+        version-emqx: ${{ inputs.version-emqx }}
     - name: docker compose up
       timeout-minutes: 5
       run: |
@@ -313,7 +265,7 @@ jobs:
           echo "check logs failed"
           exit 1
         fi
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: always()
       with:
         name: jmeter_logs-JWT_authn-${{ matrix.scripts_type }}
@@ -332,23 +284,10 @@ jobs:
 
     needs: jmeter_artifact
     steps:
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-    - name: Set up environment
-      id: env
-      run: |
-        source env.sh
-        PKG_VSN=$(docker run --rm -v $(pwd):$(pwd) -w $(pwd) -u $(id -u) "$EMQX_BUILDER" ./pkg-vsn.sh emqx)
-        echo "PKG_VSN=$PKG_VSN" >> "$GITHUB_ENV"
-    - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
-      with:
-        name: emqx-docker
-        path: /tmp
-    - name: load docker image
-      shell: bash
-      run: |
-        EMQX_DOCKER_IMAGE_TAG=$(docker load < /tmp/emqx-docker-${PKG_VSN}.tar.gz | sed 's/Loaded image: //g')
-        echo "_EMQX_DOCKER_IMAGE_TAG=$EMQX_DOCKER_IMAGE_TAG" >> $GITHUB_ENV
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
     - uses: ./.github/actions/prepare-jmeter
+      with:
+        version-emqx: ${{ inputs.version-emqx }}
     - name: docker compose up
       timeout-minutes: 5
       run: |
@@ -370,7 +309,7 @@ jobs:
           echo "check logs failed"
           exit 1
         fi
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       if: always()
       with:
         name: jmeter_logs-built_in_database_authn_authz-${{ matrix.scripts_type }}

.github/workflows/run_relup_tests.yaml

@@ -25,7 +25,7 @@ jobs:
       run:
         shell: bash
     steps:
-    - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+    - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
       with:
         name: emqx-enterprise
     - name: extract artifact
@@ -45,7 +45,7 @@ jobs:
       run: |
         export PROFILE='emqx-enterprise'
         make emqx-enterprise-tgz
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       name: Upload built emqx and test scenario
       with:
         name: relup_tests_emqx_built
@@ -72,10 +72,10 @@ jobs:
       run:
         shell: bash
     steps:
-    - uses: erlef/setup-beam@b9c58b0450cd832ccdb3c17cc156a47065d2114f # v1.18.1
+    - uses: erlef/setup-beam@2f0cc07b4b9bea248ae098aba9e1a8a1de5ec24c # v1.17.5
       with:
-        otp-version: 26.2.5
-    - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        otp-version: 26.2.1
+    - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
       with:
         repository: hawk/lux
         ref: lux-2.8.1
@@ -88,7 +88,7 @@ jobs:
         ./configure
         make
         echo "$(pwd)/bin" >> $GITHUB_PATH
-    - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+    - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
       name: Download built emqx and test scenario
       with:
         name: relup_tests_emqx_built
@@ -111,7 +111,7 @@ jobs:
           docker logs node2.emqx.io | tee lux_logs/emqx2.log
           exit 1
         fi
-    - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+    - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
       name: Save debug data
       if: failure()
       with:

.github/workflows/run_test_cases.yaml

@@ -35,18 +35,18 @@ jobs:
     defaults:
       run:
         shell: bash
-    container: ${{ inputs.builder }}
+    container: "ghcr.io/emqx/emqx-builder/${{ matrix.builder }}:${{ matrix.elixir }}-${{ matrix.otp }}-ubuntu22.04"
 
     env:
       PROFILE: ${{ matrix.profile }}
       ENABLE_COVER_COMPILE: 1
-      CT_COVER_EXPORT_PREFIX: ${{ matrix.profile }}
+      CT_COVER_EXPORT_PREFIX: ${{ matrix.profile }}-${{ matrix.otp }}
 
     permissions:
       contents: read
 
     steps:
-      - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+      - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
         with:
           name: ${{ matrix.profile }}
 
@@ -90,7 +90,7 @@ jobs:
       contents: read
 
     steps:
-      - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+      - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
         with:
           name: ${{ matrix.profile }}
       - name: extract artifact
@@ -100,7 +100,7 @@ jobs:
         # produces $PROFILE-<app-name>-<otp-vsn>-sg<suitegroup>.coverdata
       - name: run common tests
         env:
-          DOCKER_CT_RUNNER_IMAGE: ${{ inputs.builder }}
+          DOCKER_CT_RUNNER_IMAGE: "ghcr.io/emqx/emqx-builder/${{ matrix.builder }}:${{ matrix.elixir }}-${{ matrix.otp }}-ubuntu22.04"
           MONGO_TAG: "5"
           MYSQL_TAG: "8"
           PGSQL_TAG: "13"
@@ -111,7 +111,7 @@ jobs:
           MINIO_TAG: "RELEASE.2023-03-20T20-16-18Z"
           SUITEGROUP: ${{ matrix.suitegroup }}
           ENABLE_COVER_COMPILE: 1
-          CT_COVER_EXPORT_PREFIX: ${{ matrix.profile }}-sg${{ matrix.suitegroup }}
+          CT_COVER_EXPORT_PREFIX: ${{ matrix.profile }}-${{ matrix.otp }}-sg${{ matrix.suitegroup }}
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: ./scripts/ct/run.sh --ci --app ${{ matrix.app }} --keep-up
 
@@ -133,10 +133,10 @@ jobs:
         if: failure()
         run: tar -czf logs.tar.gz _build/test/logs
 
-      - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+      - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
         if: failure()
         with:
-          name: logs-${{ matrix.profile }}-${{ matrix.prefix }}-sg${{ matrix.suitegroup }}
+          name: logs-${{ matrix.profile }}-${{ matrix.prefix }}-${{ matrix.otp }}-sg${{ matrix.suitegroup }}
           path: logs.tar.gz
           compression-level: 0
           retention-days: 7
@@ -149,7 +149,7 @@ jobs:
       matrix:
         include: ${{ fromJson(inputs.ct-host) }}
 
-    container: ${{ inputs.builder }}
+    container: "ghcr.io/emqx/emqx-builder/${{ matrix.builder }}:${{ matrix.elixir }}-${{ matrix.otp }}-ubuntu22.04"
     defaults:
       run:
         shell: bash
@@ -161,10 +161,10 @@ jobs:
       PROFILE: ${{ matrix.profile }}
       SUITEGROUP: ${{ matrix.suitegroup }}
       ENABLE_COVER_COMPILE: 1
-      CT_COVER_EXPORT_PREFIX: ${{ matrix.profile }}-sg${{ matrix.suitegroup }}
+      CT_COVER_EXPORT_PREFIX: ${{ matrix.profile }}-${{ matrix.otp }}-sg${{ matrix.suitegroup }}
 
     steps:
-      - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+      - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
         with:
           name: ${{ matrix.profile }}
       - name: extract artifact
@@ -193,10 +193,10 @@ jobs:
         if: failure()
         run: tar -czf logs.tar.gz _build/test/logs
 
-      - uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+      - uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
         if: failure()
         with:
-          name: logs-${{ matrix.profile }}-${{ matrix.prefix }}-sg${{ matrix.suitegroup }}
+          name: logs-${{ matrix.profile }}-${{ matrix.prefix }}-${{ matrix.otp }}-sg${{ matrix.suitegroup }}
           path: logs.tar.gz
           compression-level: 0
           retention-days: 7
@@ -216,7 +216,7 @@ jobs:
     steps:
       - name: Coveralls finished
         if: github.repository == 'emqx/emqx'
-        uses: coverallsapp/github-action@643bc377ffa44ace6394b2b5d0d3950076de9f63 # v2.3.0
+        uses: coverallsapp/github-action@3dfc5567390f6fa9267c0ee9c251e4c8c3f18949 # v2.2.3
         with:
           parallel-finished: true
           git-branch: ${{ github.ref }}

.github/workflows/scorecard.yaml

@@ -25,12 +25,12 @@ jobs:
 
     steps:
       - name: "Checkout code"
-        uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+        uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
         with:
           persist-credentials: false
 
       - name: "Run analysis"
-        uses: ossf/scorecard-action@62b2cac7ed8198b15735ed49ab1e5cf35480ba46 # v2.4.0
+        uses: ossf/scorecard-action@0864cf19026789058feabb7e87baa5f140aac736 # v2.3.1
         with:
           results_file: results.sarif
           results_format: sarif
@@ -40,7 +40,7 @@ jobs:
           publish_results: true
 
       - name: "Upload artifact"
-        uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
+        uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # v4.3.1
         with:
           name: SARIF file
           path: results.sarif

.github/workflows/spellcheck.yaml

@@ -19,7 +19,7 @@ jobs:
         - emqx-enterprise
     runs-on: ${{ endsWith(github.repository, '/emqx') && 'ubuntu-22.04' || fromJSON('["self-hosted","ephemeral","linux","x64"]') }}
     steps:
-      - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+      - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
         with:
           pattern: "${{ matrix.profile }}-schema-dump-*-x64"
           merge-multiple: true

.github/workflows/static_checks.yaml

@@ -28,21 +28,21 @@ jobs:
       fail-fast: false
       matrix:
         include: ${{ fromJson(inputs.ct-matrix) }}
-    container: "${{ inputs.builder }}"
+    container: "ghcr.io/emqx/emqx-builder/${{ matrix.builder }}:${{ matrix.elixir }}-${{ matrix.otp }}-ubuntu22.04"
     steps:
-      - uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
+      - uses: actions/download-artifact@c850b930e6ba138125429b7e5c93fc707a7f8427 # v4.1.4
         with:
           name: ${{ matrix.profile }}
       - name: extract artifact
         run: |
           unzip -o -q ${{ matrix.profile }}.zip
           git config --global --add safe.directory "$GITHUB_WORKSPACE"
-      - uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
+      - uses: actions/cache@ab5e6d0c87105b4c9c2047343972218f562e4319 # v4.0.1
         with:
-          path: "emqx_dialyzer_${{ matrix.profile }}_plt"
-          key: rebar3-dialyzer-plt-${{ matrix.profile }}-${{ hashFiles('rebar.*', 'apps/*/rebar.*') }}
+          path: "emqx_dialyzer_${{ matrix.otp }}_plt"
+          key: rebar3-dialyzer-plt-${{ matrix.profile }}-${{ matrix.otp }}-${{ hashFiles('rebar.*', 'apps/*/rebar.*') }}
           restore-keys: |
-            rebar3-dialyzer-plt-${{ matrix.profile }}-
+            rebar3-dialyzer-plt-${{ matrix.profile }}-${{ matrix.otp }}-
       - run: cat .env | tee -a $GITHUB_ENV
       - name: run static checks
         run: make static_checks

.github/workflows/sync-release-branch.yaml

@@ -1,88 +0,0 @@
-name: Sync release branch
-
-concurrency:
-  group: sync-release-branch-${{ github.event_name }}-${{ github.ref }}
-  cancel-in-progress: true
-
-on:
-  schedule:
-    - cron:  '0 2 * * *'
-  workflow_dispatch:
-
-permissions:
-  contents: read
-
-jobs:
-  create-pr:
-    runs-on: ${{ endsWith(github.repository, '/emqx') && 'ubuntu-22.04' || fromJSON('["self-hosted","ephemeral","linux","x64"]') }}
-
-    strategy:
-      fail-fast: false
-      matrix:
-        branch:
-          - release-57
-
-    env:
-      SYNC_BRANCH: ${{ matrix.branch }}
-
-    defaults:
-      run:
-        shell: bash
-
-    permissions:
-      contents: write
-      pull-requests: write
-
-    steps:
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
-        with:
-          fetch-depth: 0
-
-      - name: create new branch
-        run: |
-          set -euxo pipefail
-          NEW_BRANCH_NAME=sync-${SYNC_BRANCH}-$(date +"%Y%m%d-%H%M%S")
-          echo "NEW_BRANCH_NAME=${NEW_BRANCH_NAME}" >> $GITHUB_ENV
-          git config --global user.name "${GITHUB_ACTOR}"
-          git config --global user.email "${GITHUB_ACTOR}@users.noreply.github.com"
-          git checkout -b ${NEW_BRANCH_NAME}
-          git merge origin/${SYNC_BRANCH} 2>&1 | tee merge.log
-          git push origin ${NEW_BRANCH_NAME}:${NEW_BRANCH_NAME}
-
-      - name: create pull request
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        run: |
-          set -euxo pipefail
-          for pr in $(gh pr list --state open --base master --label sync-release-branch --search "Sync ${SYNC_BRANCH} in:title" --repo ${{ github.repository }} --json number --jq '.[] | .number'); do
-            gh pr close $pr --repo ${{ github.repository }} --delete-branch || true
-          done
-          gh pr create --title "Sync ${SYNC_BRANCH}" --body "Sync ${SYNC_BRANCH}" --base master --head ${NEW_BRANCH_NAME} --label sync-release-branch --repo ${{ github.repository }}
-
-      - name: Send notification to Slack
-        if: failure()
-        env:
-          SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
-        run: |
-          awk '{printf "%s\\n", $0}' merge.log > merge.log.1
-          cat <<EOF > payload.json
-          {
-            "blocks": [
-              {
-                "type": "section",
-                "text": {
-                  "type": "mrkdwn",
-                  "text": "Automatic sync of ${SYNC_BRANCH} branch failed: https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }}"
-                }
-              },
-              {
-                "type": "section",
-                "text": {
-                  "type": "mrkdwn",
-                  "text": "\`\`\`$(cat merge.log.1)\`\`\`"
-                }
-              }
-            ]
-          }
-          EOF
-          curl -X POST -H 'Content-type: application/json' --data @payload.json "$SLACK_WEBHOOK_URL"

.github/workflows/upload-helm-charts.yaml

@@ -23,7 +23,7 @@ jobs:
           aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
           aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
           aws-region: ${{ secrets.AWS_DEFAULT_REGION }}
-      - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
+      - uses: actions/checkout@9bb56186c3b09b4f86b1c65136769dd318469633 # v4.1.2
         with:
           ref: ${{ github.event.inputs.tag }}
       - name: Detect profile

.tool-versions

@@ -1,2 +1,2 @@
-erlang 26.2.5-3
+erlang 26.2.1-2
 elixir 1.15.7-otp-26

Makefile

@@ -6,15 +6,22 @@ endif
 REBAR = $(CURDIR)/rebar3
 BUILD = $(CURDIR)/build
 SCRIPTS = $(CURDIR)/scripts
-include env.sh
+export EMQX_RELUP ?= true
+export EMQX_DEFAULT_BUILDER = ghcr.io/emqx/emqx-builder/5.3-5:1.15.7-26.2.1-2-debian12
+export EMQX_DEFAULT_RUNNER = public.ecr.aws/debian/debian:12-slim
+export EMQX_REL_FORM ?= tgz
+export QUICER_DOWNLOAD_FROM_RELEASE = 1
+ifeq ($(OS),Windows_NT)
+	export REBAR_COLOR=none
+	FIND=/usr/bin/find
+else
+	FIND=find
+endif
 
 # Dashboard version
 # from https://github.com/emqx/emqx-dashboard5
-export EMQX_DASHBOARD_VERSION ?= v1.10.0-beta.1
-export EMQX_EE_DASHBOARD_VERSION ?= e1.8.0-beta.1
-
-export EMQX_RELUP ?= true
-export EMQX_REL_FORM ?= tgz
+export EMQX_DASHBOARD_VERSION ?= v1.9.0-beta.1
+export EMQX_EE_DASHBOARD_VERSION ?= e1.7.0-beta.9
 
 -include default-profile.mk
 PROFILE ?= emqx
@@ -28,8 +35,6 @@ CT_COVER_EXPORT_PREFIX ?= $(PROFILE)
 
 export REBAR_GIT_CLONE_OPTIONS += --depth=1
 
-ELIXIR_COMMON_DEPS := ensure-hex ensure-mix-rebar3 ensure-mix-rebar
-
 .PHONY: default
 default: $(REBAR) $(PROFILE)
 
@@ -60,12 +65,8 @@ ensure-mix-rebar3: $(REBAR)
 ensure-mix-rebar: $(REBAR)
 	@mix local.rebar --if-missing --force
 
-
-.PHONY: elixir-common-deps
-elixir-common-deps: $(ELIXIR_COMMON_DEPS)
-
 .PHONY: mix-deps-get
-mix-deps-get: elixir-common-deps
+mix-deps-get: $(ELIXIR_COMMON_DEPS)
 	@mix deps.get
 
 .PHONY: eunit
@@ -195,8 +196,8 @@ $(PROFILES:%=clean-%):
 	@if [ -d _build/$(@:clean-%=%) ]; then \
 		rm -f rebar.lock; \
 		rm -rf _build/$(@:clean-%=%)/rel; \
-		find _build/$(@:clean-%=%) -name '*.beam' -o -name '*.so' -o -name '*.app' -o -name '*.appup' -o -name '*.o' -o -name '*.d' -type f | xargs rm -f; \
-		find _build/$(@:clean-%=%) -type l -delete; \
+		$(FIND) _build/$(@:clean-%=%) -name '*.beam' -o -name '*.so' -o -name '*.app' -o -name '*.appup' -o -name '*.o' -o -name '*.d' -type f | xargs rm -f; \
+		$(FIND) _build/$(@:clean-%=%) -type l -delete; \
 	fi
 
 .PHONY: clean-all
@@ -244,7 +245,7 @@ $(foreach zt,$(ALL_ZIPS),$(eval $(call download-relup-packages,$(zt))))
 ## relup target is to create relup instructions
 .PHONY: $(REL_PROFILES:%=%-relup)
 define gen-relup-target
-$1-relup: $(COMMON_DEPS)
+$1-relup: $1-relup-downloads $(COMMON_DEPS)
 	@$(BUILD) $1 relup
 endef
 ALL_TGZS = $(REL_PROFILES)
@@ -253,7 +254,7 @@ $(foreach zt,$(ALL_TGZS),$(eval $(call gen-relup-target,$(zt))))
 ## tgz target is to create a release package .tar.gz with relup
 .PHONY: $(REL_PROFILES:%=%-tgz)
 define gen-tgz-target
-$1-tgz: $(COMMON_DEPS)
+$1-tgz: $1-relup
 	@$(BUILD) $1 tgz
 endef
 ALL_TGZS = $(REL_PROFILES)
@@ -316,20 +317,10 @@ $(foreach tt,$(ALL_ELIXIR_TGZS),$(eval $(call gen-elixir-tgz-target,$(tt))))
 
 .PHONY: fmt
 fmt: $(REBAR)
-	@find . \( -name '*.app.src' -o \
-						 -name '*.erl' -o \
-					   -name '*.hrl' -o \
-			  		 -name 'rebar.config' -o \
-			  		 -name '*.eterm' -o \
-			  		 -name '*.escript' \) \
-	                          -not -path '*/_build/*' \
-	                          -not -path '*/deps/*' \
-	                          -not -path '*/_checkouts/*' \
-	                          -type f \
-		| xargs $(SCRIPTS)/erlfmt -w
-	@$(SCRIPTS)/erlfmt -w 'apps/emqx/rebar.config.script'
-	@$(SCRIPTS)/erlfmt -w 'elvis.config'
-	@$(SCRIPTS)/erlfmt -w 'bin/nodetool'
+	@$(SCRIPTS)/erlfmt -w 'apps/*/{src,include,priv,test,integration_test}/**/*.{erl,hrl,app.src,eterm}'
+	@$(SCRIPTS)/erlfmt -w 'apps/*/rebar.config' 'apps/emqx/rebar.config.script' '.ci/fvt_tests/http_server/rebar.config'
+	@$(SCRIPTS)/erlfmt -w 'rebar.config' 'rebar.config.erl'
+	@$(SCRIPTS)/erlfmt -w 'scripts/*.escript' 'bin/*.escript' 'bin/nodetool'
 	@mix format
 
 .PHONY: clean-test-cluster-config

README-CN.md

@@ -1,5 +1,3 @@
-简体中文 | [English](./README.md) | [Русский](./README-RU.md)
-
 # EMQX
 
 [![GitHub Release](https://img.shields.io/github/release/emqx/emqx?color=brightgreen&label=Release)](https://github.com/emqx/emqx/releases)

README-RU.md

@@ -1,5 +1,3 @@
-Русский | [简体中文](./README-CN.md) | [English](./README.md)
-
 # Брокер EMQX
 
 [![GitHub Release](https://img.shields.io/github/release/emqx/emqx?color=brightgreen&label=Release)](https://github.com/emqx/emqx/releases)

README.md

@@ -1,5 +1,3 @@
-English | [简体中文](./README-CN.md) | [Русский](./README-RU.md)
-
 # EMQX
 
 [![GitHub Release](https://img.shields.io/github/release/emqx/emqx?color=brightgreen&label=Release)](https://github.com/emqx/emqx/releases)

apps/emqx/include/asserts.hrl

@@ -45,10 +45,6 @@
 ).
 
 -define(assertReceive(PATTERN, TIMEOUT),
-    ?assertReceive(PATTERN, TIMEOUT, #{})
-).
-
--define(assertReceive(PATTERN, TIMEOUT, EXTRA),
     (fun() ->
         receive
             X__V = PATTERN -> X__V
@@ -58,8 +54,7 @@
                     {module, ?MODULE},
                     {line, ?LINE},
                     {expression, (??PATTERN)},
-                    {mailbox, ?drainMailbox()},
-                    {extra_info, EXTRA}
+                    {mailbox, ?drainMailbox()}
                 ]}
             )
         end

apps/emqx/include/emqx.hrl

@@ -65,20 +65,9 @@
 %% Route
 %%--------------------------------------------------------------------
 
--record(share_dest, {
-    session_id :: emqx_session:session_id(),
-    group :: emqx_types:group()
-}).
-
 -record(route, {
     topic :: binary(),
-    dest ::
-        node()
-        | {binary(), node()}
-        | emqx_session:session_id()
-        %% One session can also have multiple subscriptions to the same topic through different groups
-        | #share_dest{}
-        | emqx_external_broker:dest()
+    dest :: node() | {binary(), node()} | emqx_session:session_id()
 }).
 
 %%--------------------------------------------------------------------
@@ -106,10 +95,4 @@
     until :: integer()
 }).
 
-%%--------------------------------------------------------------------
-%% Configurations
-%%--------------------------------------------------------------------
--define(KIND_REPLICATE, replicate).
--define(KIND_INITIATE, initiate).
-
 -endif.

apps/emqx/include/emqx_durable_session_metadata.hrl

@@ -1,35 +0,0 @@
-%%--------------------------------------------------------------------
-%% Copyright (c) 2022, 2024 EMQ Technologies Co., Ltd. All Rights Reserved.
-%%
-%% Licensed under the Apache License, Version 2.0 (the "License");
-%% you may not use this file except in compliance with the License.
-%% You may obtain a copy of the License at
-%%
-%%     http://www.apache.org/licenses/LICENSE-2.0
-%%
-%% Unless required by applicable law or agreed to in writing, software
-%% distributed under the License is distributed on an "AS IS" BASIS,
-%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-%% See the License for the specific language governing permissions and
-%% limitations under the License.
-%%--------------------------------------------------------------------
-
-%% @doc This header contains definitions of durable session metadata
-%% keys, that can be consumed by the external code.
--ifndef(EMQX_DURABLE_SESSION_META_HRL).
--define(EMQX_DURABLE_SESSION_META_HRL, true).
-
-%% Session metadata keys:
--define(created_at, created_at).
--define(last_alive_at, last_alive_at).
--define(expiry_interval, expiry_interval).
-%% Unique integer used to create unique identities:
--define(last_id, last_id).
-%% Connection info (relevent for the dashboard):
--define(peername, peername).
--define(will_message, will_message).
--define(clientinfo, clientinfo).
--define(protocol, protocol).
--define(offline_info, offline_info).
-
--endif.

apps/emqx/include/emqx_hooks.hrl

@@ -25,8 +25,7 @@
 -define(HP_AUTHN, 970).
 -define(HP_AUTHZ, 960).
 -define(HP_SYS_MSGS, 950).
--define(HP_SCHEMA_VALIDATION, 945).
--define(HP_MESSAGE_TRANSFORMATION, 943).
+-define(HP_MSG_VALIDATION, 945).
 -define(HP_TOPIC_METRICS, 940).
 -define(HP_RETAINER, 930).
 -define(HP_AUTO_SUB, 920).

apps/emqx/include/emqx_metrics.hrl

@@ -1,258 +0,0 @@
-%%--------------------------------------------------------------------
-%% Copyright (c) 2024 EMQ Technologies Co., Ltd. All Rights Reserved.
-%%
-%% Licensed under the Apache License, Version 2.0 (the "License");
-%% you may not use this file except in compliance with the License.
-%% You may obtain a copy of the License at
-%%
-%%     http://www.apache.org/licenses/LICENSE-2.0
-%%
-%% Unless required by applicable law or agreed to in writing, software
-%% distributed under the License is distributed on an "AS IS" BASIS,
-%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-%% See the License for the specific language governing permissions and
-%% limitations under the License.
-%%--------------------------------------------------------------------
-
--ifndef(EMQX_METRICS_HRL).
--define(EMQX_METRICS_HRL, true).
-
-%% Bytes sent and received
--define(BYTES_METRICS, [
-    {counter, 'bytes.received', <<"Number of bytes received ">>},
-    {counter, 'bytes.sent', <<"Number of bytes sent on this connection">>}
-]).
-
-%% Packets sent and received
--define(PACKET_METRICS, [
-    {counter, 'packets.received', <<"Number of received packet">>},
-    {counter, 'packets.sent', <<"Number of sent packet">>},
-    {counter, 'packets.connect.received', <<"Number of received CONNECT packet">>},
-    {counter, 'packets.connack.sent', <<"Number of sent CONNACK packet">>},
-    {counter, 'packets.connack.error',
-        <<"Number of received CONNECT packet with unsuccessful connections">>},
-    {counter, 'packets.connack.auth_error',
-        <<"Number of received CONNECT packet with failed Authentication">>},
-    {counter, 'packets.publish.received', <<"Number of received PUBLISH packet">>},
-    %% PUBLISH packets sent
-    {counter, 'packets.publish.sent', <<"Number of sent PUBLISH packet">>},
-    %% PUBLISH packet_id inuse
-    {counter, 'packets.publish.inuse',
-        <<"Number of received PUBLISH packet with occupied identifiers">>},
-    %% PUBLISH failed for error
-    {counter, 'packets.publish.error',
-        <<"Number of received PUBLISH packet that cannot be published">>},
-    %% PUBLISH failed for auth error
-    {counter, 'packets.publish.auth_error',
-        <<"Number of received PUBLISH packets with failed the Authorization check">>},
-    %% PUBLISH(QoS2) packets dropped
-    {counter, 'packets.publish.dropped',
-        <<"Number of messages discarded due to the receiving limit">>},
-    %% PUBACK packets received
-    {counter, 'packets.puback.received', <<"Number of received PUBACK packet">>},
-    %% PUBACK packets sent
-    {counter, 'packets.puback.sent', <<"Number of sent PUBACK packet">>},
-    %% PUBACK packet_id inuse
-    {counter, 'packets.puback.inuse',
-        <<"Number of received PUBACK packet with occupied identifiers">>},
-    %% PUBACK packets missed
-    {counter, 'packets.puback.missed', <<"Number of received packet with identifiers.">>},
-    %% PUBREC packets received
-    {counter, 'packets.pubrec.received', <<"Number of received PUBREC packet">>},
-    %% PUBREC packets sent
-    {counter, 'packets.pubrec.sent', <<"Number of sent PUBREC packet">>},
-    %% PUBREC packet_id inuse
-    {counter, 'packets.pubrec.inuse',
-        <<"Number of received PUBREC packet with occupied identifiers">>},
-    %% PUBREC packets missed
-    {counter, 'packets.pubrec.missed',
-        <<"Number of received PUBREC packet with unknown identifiers">>},
-    %% PUBREL packets received
-    {counter, 'packets.pubrel.received', <<"Number of received PUBREL packet">>},
-    %% PUBREL packets sent
-    {counter, 'packets.pubrel.sent', <<"Number of sent PUBREL packet">>},
-    %% PUBREL packets missed
-    {counter, 'packets.pubrel.missed',
-        <<"Number of received PUBREC packet with unknown identifiers">>},
-    %% PUBCOMP packets received
-    {counter, 'packets.pubcomp.received', <<"Number of received PUBCOMP packet">>},
-    %% PUBCOMP packets sent
-    {counter, 'packets.pubcomp.sent', <<"Number of sent PUBCOMP packet">>},
-    %% PUBCOMP packet_id inuse
-    {counter, 'packets.pubcomp.inuse',
-        <<"Number of received PUBCOMP packet with occupied identifiers">>},
-    %% PUBCOMP packets missed
-    {counter, 'packets.pubcomp.missed', <<"Number of missed PUBCOMP packet">>},
-    %% SUBSCRIBE Packets received
-    {counter, 'packets.subscribe.received', <<"Number of received SUBSCRIBE packet">>},
-    %% SUBSCRIBE error
-    {counter, 'packets.subscribe.error',
-        <<"Number of received SUBSCRIBE packet with failed subscriptions">>},
-    %% SUBSCRIBE failed for not auth
-    {counter, 'packets.subscribe.auth_error',
-        <<"Number of received SUBACK packet with failed Authorization check">>},
-    %% SUBACK packets sent
-    {counter, 'packets.suback.sent', <<"Number of sent SUBACK packet">>},
-    %% UNSUBSCRIBE Packets received
-    {counter, 'packets.unsubscribe.received', <<"Number of received UNSUBSCRIBE packet">>},
-    %% UNSUBSCRIBE error
-    {counter, 'packets.unsubscribe.error',
-        <<"Number of received UNSUBSCRIBE packet with failed unsubscriptions">>},
-    %% UNSUBACK Packets sent
-    {counter, 'packets.unsuback.sent', <<"Number of sent UNSUBACK packet">>},
-    %% PINGREQ packets received
-    {counter, 'packets.pingreq.received', <<"Number of received PINGREQ packet">>},
-    %% PINGRESP Packets sent
-    {counter, 'packets.pingresp.sent', <<"Number of sent PUBRESP packet">>},
-    %% DISCONNECT Packets received
-    {counter, 'packets.disconnect.received', <<"Number of received DISCONNECT packet">>},
-    %% DISCONNECT Packets sent
-    {counter, 'packets.disconnect.sent', <<"Number of sent DISCONNECT packet">>},
-    %% Auth Packets received
-    {counter, 'packets.auth.received', <<"Number of received AUTH packet">>},
-    %% Auth Packets sent
-    {counter, 'packets.auth.sent', <<"Number of sent AUTH packet">>}
-]).
-
-%% Messages sent/received and pubsub
--define(MESSAGE_METRICS, [
-    %% All Messages received
-    {counter, 'messages.received', <<
-        "Number of messages received from the client, equal to the sum of "
-        "messages.qos0.received, messages.qos1.received and messages.qos2.received"
-    >>},
-    %% All Messages sent
-    {counter, 'messages.sent', <<
-        "Number of messages sent to the client, equal to the sum of "
-        "messages.qos0.sent, messages.qos1.sent and messages.qos2.sent"
-    >>},
-    %% QoS0 Messages received
-    {counter, 'messages.qos0.received', <<"Number of QoS 0 messages received from clients">>},
-    %% QoS0 Messages sent
-    {counter, 'messages.qos0.sent', <<"Number of QoS 0 messages sent to clients">>},
-    %% QoS1 Messages received
-    {counter, 'messages.qos1.received', <<"Number of QoS 1 messages received from clients">>},
-    %% QoS1 Messages sent
-    {counter, 'messages.qos1.sent', <<"Number of QoS 1 messages sent to clients">>},
-    %% QoS2 Messages received
-    {counter, 'messages.qos2.received', <<"Number of QoS 2 messages received from clients">>},
-    %% QoS2 Messages sent
-    {counter, 'messages.qos2.sent', <<"Number of QoS 2 messages sent to clients">>},
-    %% PubSub Metrics
-
-    %% Messages Publish
-    {counter, 'messages.publish',
-        <<"Number of messages published in addition to system messages">>},
-    %% Messages dropped due to no subscribers
-    {counter, 'messages.dropped',
-        <<"Number of messages dropped before forwarding to the subscription process">>},
-    %% Messages that failed validations
-    {counter, 'messages.validation_failed', <<"Number of message validation failed">>},
-    %% Messages that passed validations
-    {counter, 'messages.validation_succeeded', <<"Number of message validation successful">>},
-    %% % Messages that failed transformations
-    {counter, 'messages.transformation_failed', <<"Number fo message transformation failed">>},
-    %% % Messages that passed transformations
-    {counter, 'messages.transformation_succeeded',
-        <<"Number fo message transformation succeeded">>},
-    %% QoS2 Messages expired
-    {counter, 'messages.dropped.await_pubrel_timeout',
-        <<"Number of messages dropped due to waiting PUBREL timeout">>},
-    %% Messages dropped
-    {counter, 'messages.dropped.no_subscribers',
-        <<"Number of messages dropped due to no subscribers">>},
-    %% Messages forward
-    {counter, 'messages.forward', <<"Number of messages forwarded to other nodes">>},
-    %% Messages delayed
-    {counter, 'messages.delayed', <<"Number of delay-published messages">>},
-    %% Messages delivered
-    {counter, 'messages.delivered',
-        <<"Number of messages forwarded to the subscription process internally">>},
-    %% Messages acked
-    {counter, 'messages.acked', <<"Number of received PUBACK and PUBREC packet">>},
-    %% Messages persistently stored
-    {counter, 'messages.persisted', <<"Number of message persisted">>}
-]).
-
-%% Delivery metrics
--define(DELIVERY_METRICS, [
-    %% All Dropped during delivery
-    {counter, 'delivery.dropped', <<"Total number of discarded messages when sending">>},
-    %% Dropped due to no_local
-    {counter, 'delivery.dropped.no_local', <<
-        "Number of messages that were dropped due to the No Local subscription "
-        "option when sending"
-    >>},
-    %% Dropped due to message too large
-    {counter, 'delivery.dropped.too_large', <<
-        "The number of messages that were dropped because the length exceeded "
-        "the limit when sending"
-    >>},
-    %% Dropped qos0 message
-    {counter, 'delivery.dropped.qos0_msg', <<
-        "Number of messages with QoS 0 that were dropped because the message "
-        "queue was full when sending"
-    >>},
-    %% Dropped due to queue full
-    {counter, 'delivery.dropped.queue_full', <<
-        "Number of messages with a non-zero QoS that were dropped because the "
-        "message queue was full when sending"
-    >>},
-    %% Dropped due to expired
-    {counter, 'delivery.dropped.expired',
-        <<"Number of messages dropped due to message expiration on sending">>}
-]).
-
-%% Client Lifecircle metrics
--define(CLIENT_METRICS, [
-    {counter, 'client.connect', <<"Number of client connections">>},
-    {counter, 'client.connack', <<"Number of CONNACK packet sent">>},
-    {counter, 'client.connected', <<"Number of successful client connected">>},
-    {counter, 'client.authenticate', <<"Number of client Authentication">>},
-    {counter, 'client.auth.anonymous', <<"Number of clients who log in anonymously">>},
-    {counter, 'client.authorize', <<"Number of Authorization rule checks">>},
-    {counter, 'client.subscribe', <<"Number of client subscriptions">>},
-    {counter, 'client.unsubscribe', <<"Number of client unsubscriptions">>},
-    {counter, 'client.disconnected', <<"Number of client disconnects">>}
-]).
-
-%% Session Lifecircle metrics
--define(SESSION_METRICS, [
-    {counter, 'session.created', <<"Number of sessions created">>},
-    {counter, 'session.resumed',
-        <<"Number of sessions resumed because Clean Session or Clean Start is false">>},
-    {counter, 'session.takenover',
-        <<"Number of sessions takenover because Clean Session or Clean Start is false">>},
-    {counter, 'session.discarded',
-        <<"Number of sessions dropped because Clean Session or Clean Start is true">>},
-    {counter, 'session.terminated', <<"Number of terminated sessions">>}
-]).
-
-%% Statistic metrics for ACL checking
--define(STASTS_ACL_METRICS, [
-    {counter, 'authorization.allow', <<"Number of Authorization allow">>},
-    {counter, 'authorization.deny', <<"Number of Authorization deny">>},
-    {counter, 'authorization.cache_hit', <<"Number of Authorization hits the cache">>},
-    {counter, 'authorization.cache_miss', <<"Number of Authorization cache missing">>}
-]).
-
-%% Statistic metrics for auth checking
--define(STASTS_AUTHN_METRICS, [
-    {counter, 'authentication.success', <<"Number of successful client Authentication">>},
-    {counter, 'authentication.success.anonymous',
-        <<"Number of successful client Authentication due to anonymous">>},
-    {counter, 'authentication.failure', <<"Number of failed client Authentication">>}
-]).
-
-%% Overload protection counters
--define(OLP_METRICS, [
-    {counter, 'overload_protection.delay.ok', <<"Number of overload protection delayed">>},
-    {counter, 'overload_protection.delay.timeout',
-        <<"Number of overload protection delay timeout">>},
-    {counter, 'overload_protection.hibernation', <<"Number of overload protection hibernation">>},
-    {counter, 'overload_protection.gc', <<"Number of overload protection garbage collection">>},
-    {counter, 'overload_protection.new_conn',
-        <<"Number of overload protection close new incoming connection">>}
-]).
-
--endif.

apps/emqx/include/emqx_mqtt.hrl

@@ -683,7 +683,6 @@ end).
 
 -define(FRAME_PARSE_ERROR, frame_parse_error).
 -define(FRAME_SERIALIZE_ERROR, frame_serialize_error).
-
 -define(THROW_FRAME_ERROR(Reason), erlang:throw({?FRAME_PARSE_ERROR, Reason})).
 -define(THROW_SERIALIZE_ERROR(Reason), erlang:throw({?FRAME_SERIALIZE_ERROR, Reason})).
 

apps/emqx/include/emqx_placeholder.hrl

@@ -28,10 +28,8 @@
 %% cert
 -define(VAR_CERT_SUBJECT, "cert_subject").
 -define(VAR_CERT_CN_NAME, "cert_common_name").
--define(VAR_CERT_PEM, "cert_pem").
 -define(PH_CERT_SUBJECT, ?PH(?VAR_CERT_SUBJECT)).
 -define(PH_CERT_CN_NAME, ?PH(?VAR_CERT_CN_NAME)).
--define(PH_CERT_PEM, ?PH(?VAR_CERT_PEM)).
 
 %% MQTT/Gateway
 -define(VAR_PASSWORD, "password").

apps/emqx/include/emqx_release.hrl

@@ -32,7 +32,7 @@
 %% `apps/emqx/src/bpapi/README.md'
 
 %% Opensource edition
--define(EMQX_RELEASE_CE, "5.8.0-alpha.1").
+-define(EMQX_RELEASE_CE, "5.7.0-alpha.1").
 
 %% Enterprise edition
--define(EMQX_RELEASE_EE, "5.8.0-alpha.1").
+-define(EMQX_RELEASE_EE, "5.7.0-alpha.1").

apps/emqx/include/emqx_schema.hrl

@@ -21,9 +21,4 @@
 -define(TOMBSTONE_CONFIG_CHANGE_REQ, mark_it_for_deletion).
 -define(CONFIG_NOT_FOUND_MAGIC, '$0tFound').
 
-%%--------------------------------------------------------------------
-%% EE injections
-%%--------------------------------------------------------------------
--define(EMQX_SSL_FUN_MFA(Name), {emqx_ssl_fun_mfa, Name}).
-
 -endif.

apps/emqx/include/emqx_session.hrl

@@ -20,11 +20,4 @@
 -define(IS_SESSION_IMPL_MEM(S), (is_tuple(S) andalso element(1, S) =:= session)).
 -define(IS_SESSION_IMPL_DS(S), (is_map_key(id, S))).
 
-%% (Erlang) messages that a connection process should forward to the
-%% session handler.
--record(session_message, {
-    message :: term()
-}).
--define(session_message(MSG), #session_message{message = MSG}).
-
 -endif.

apps/emqx/include/http_api.hrl

@@ -86,6 +86,5 @@
     {'SOURCE_ERROR', <<"Source error">>},
     {'UPDATE_FAILED', <<"Update failed">>},
     {'REST_FAILED', <<"Reset source or config failed">>},
-    {'CLIENT_NOT_RESPONSE', <<"Client not responding">>},
-    {'UNSUPPORTED_MEDIA_TYPE', <<"Unsupported media type">>}
+    {'CLIENT_NOT_RESPONSE', <<"Client not responding">>}
 ]).

apps/emqx/include/logger.hrl

@@ -30,10 +30,7 @@
             logger:log(
                 Level,
                 (Data),
-                maps:merge(Meta, #{
-                    mfa => {?MODULE, ?FUNCTION_NAME, ?FUNCTION_ARITY},
-                    line => ?LINE
-                })
+                Meta
             );
         false ->
             ok
@@ -41,20 +38,16 @@
 ).
 
 %% NOTE: do not forget to use atom for msg and add every used msg to
-%% the default value of `log.throttling.msgs` list.
+%% the default value of `log.thorttling.msgs` list.
 -define(SLOG_THROTTLE(Level, Data),
     ?SLOG_THROTTLE(Level, Data, #{})
 ).
 
 -define(SLOG_THROTTLE(Level, Data, Meta),
-    ?SLOG_THROTTLE(Level, undefined, Data, Meta)
-).
-
--define(SLOG_THROTTLE(Level, UniqueKey, Data, Meta),
     case logger:allow(Level, ?MODULE) of
         true ->
             (fun(#{msg := __Msg} = __Data) ->
-                case emqx_log_throttler:allow(__Msg, UniqueKey) of
+                case emqx_log_throttler:allow(__Msg) of
                     true ->
                         logger:log(Level, __Data, Meta);
                     false ->
@@ -91,7 +84,7 @@
     ?_DO_TRACE(Tag, Msg, Meta),
     ?SLOG(
         Level,
-        (Meta)#{msg => Msg, tag => Tag},
+        (emqx_trace_formatter:format_meta_map(Meta))#{msg => Msg, tag => Tag},
         #{is_trace => false}
     )
 end).

apps/emqx/integration_test/emqx_persistent_session_ds_SUITE.erl

@@ -25,16 +25,11 @@ all() ->
     emqx_common_test_helpers:all(?MODULE).
 
 init_per_suite(Config) ->
-    case emqx_ds_test_helpers:skip_if_norepl() of
-        false ->
     TCApps = emqx_cth_suite:start(
         app_specs(),
         #{work_dir => emqx_cth_suite:work_dir(Config)}
     ),
-            [{tc_apps, TCApps} | Config];
-        Yes ->
-            Yes
-    end.
+    [{tc_apps, TCApps} | Config].
 
 end_per_suite(Config) ->
     TCApps = ?config(tc_apps, Config),
@@ -90,11 +85,9 @@ end_per_testcase(TestCase, Config) when
     Nodes = ?config(nodes, Config),
     emqx_common_test_helpers:call_janitor(60_000),
     ok = emqx_cth_cluster:stop(Nodes),
-    snabbkaffe:stop(),
     ok;
 end_per_testcase(_TestCase, _Config) ->
     emqx_common_test_helpers:call_janitor(60_000),
-    snabbkaffe:stop(),
     ok.
 
 %%------------------------------------------------------------------------------
@@ -163,7 +156,7 @@ mk_clientid(Prefix, ID) ->
 
 restart_node(Node, NodeSpec) ->
     ?tp(will_restart_node, #{}),
-    emqx_cth_cluster:restart(NodeSpec),
+    emqx_cth_cluster:restart(Node, NodeSpec),
     wait_nodeup(Node),
     ?tp(restarted_node, #{}),
     ok.
@@ -258,7 +251,7 @@ t_session_subscription_idempotency(Config) ->
 
             ok
         end,
-        fun(_Trace) ->
+        fun(Trace) ->
             Session = session_open(Node1, ClientId),
             ?assertMatch(
                 #{SubTopicFilter := #{}},
@@ -331,7 +324,7 @@ t_session_unsubscription_idempotency(Config) ->
 
             ok
         end,
-        fun(_Trace) ->
+        fun(Trace) ->
             Session = session_open(Node1, ClientId),
             ?assertEqual(
                 #{},

apps/emqx/mix.exs

@@ -1,74 +0,0 @@
-defmodule EMQX.MixProject do
-  use Mix.Project
-
-  alias EMQXUmbrella.MixProject, as: UMP
-
-  def project do
-    [
-      app: :emqx,
-      version: "0.1.0",
-      build_path: "../../_build",
-      erlc_paths: erlc_paths(),
-      erlc_options: [
-        {:i, "src"}
-        | UMP.erlc_options()
-      ],
-      compilers: Mix.compilers() ++ [:copy_srcs],
-      # used by our `Mix.Tasks.Compile.CopySrcs` compiler
-      extra_dirs: extra_dirs(),
-      deps_path: "../../deps",
-      lockfile: "../../mix.lock",
-      elixir: "~> 1.14",
-      start_permanent: Mix.env() == :prod,
-      deps: deps()
-    ]
-  end
-
-  # Run "mix help compile.app" to learn about applications
-  def application do
-    [
-      ## FIXME!!! go though emqx.app.src and add missing stuff...
-      extra_applications: [:public_key, :ssl, :os_mon, :logger, :mnesia, :sasl] ++ UMP.extra_applications(),
-      mod: {:emqx_app, []}
-    ]
-  end
-
-  def deps() do
-    ## FIXME!!! go though emqx.app.src and add missing stuff...
-    [
-      {:emqx_mix_utils, in_umbrella: true, runtime: false},
-      {:emqx_utils, in_umbrella: true},
-      {:emqx_ds_backends, in_umbrella: true},
-
-      UMP.common_dep(:gproc),
-      UMP.common_dep(:gen_rpc),
-      UMP.common_dep(:ekka),
-      UMP.common_dep(:esockd),
-      UMP.common_dep(:cowboy),
-      UMP.common_dep(:lc),
-      UMP.common_dep(:hocon),
-      UMP.common_dep(:ranch),
-      UMP.common_dep(:bcrypt),
-      UMP.common_dep(:pbkdf2),
-      UMP.common_dep(:emqx_http_lib),
-    ] ++ UMP.quicer_dep()
-  end
-
-  defp erlc_paths() do
-    paths = UMP.erlc_paths()
-    if UMP.test_env?() do
-      ["integration_test" | paths]
-    else
-      paths
-    end
-  end
-
-  defp extra_dirs() do
-    dirs = ["src", "etc"]
-    if UMP.test_env?() do
-      ["test", "integration_test" | dirs]
-    else
-      dirs
-    end
-  end
-end

apps/emqx/priv/bpapi.versions

@@ -10,14 +10,12 @@
 {emqx_bridge,5}.
 {emqx_bridge,6}.
 {emqx_broker,1}.
-{emqx_cluster_link,1}.
 {emqx_cm,1}.
 {emqx_cm,2}.
 {emqx_cm,3}.
 {emqx_conf,1}.
 {emqx_conf,2}.
 {emqx_conf,3}.
-{emqx_conf,4}.
 {emqx_connector,1}.
 {emqx_dashboard,1}.
 {emqx_delayed,1}.
@@ -27,7 +25,6 @@
 {emqx_ds,2}.
 {emqx_ds,3}.
 {emqx_ds,4}.
-{emqx_ds_shared_sub,1}.
 {emqx_eviction_agent,1}.
 {emqx_eviction_agent,2}.
 {emqx_eviction_agent,3}.
@@ -50,7 +47,6 @@
 {emqx_mgmt_api_plugins,1}.
 {emqx_mgmt_api_plugins,2}.
 {emqx_mgmt_api_plugins,3}.
-{emqx_mgmt_api_relup,1}.
 {emqx_mgmt_cluster,1}.
 {emqx_mgmt_cluster,2}.
 {emqx_mgmt_cluster,3}.
@@ -63,6 +59,7 @@
 {emqx_node_rebalance_api,1}.
 {emqx_node_rebalance_api,2}.
 {emqx_node_rebalance_evacuation,1}.
+{emqx_node_rebalance_purge,1}.
 {emqx_node_rebalance_status,1}.
 {emqx_node_rebalance_status,2}.
 {emqx_persistent_session_ds,1}.

apps/emqx/rebar.config

@@ -24,18 +24,18 @@
 {deps, [
     {emqx_utils, {path, "../emqx_utils"}},
     {emqx_durable_storage, {path, "../emqx_durable_storage"}},
-    {emqx_ds_backends, {path, "../emqx_ds_backends"}},
     {lc, {git, "https://github.com/emqx/lc.git", {tag, "0.3.2"}}},
     {gproc, {git, "https://github.com/emqx/gproc", {tag, "0.9.0.1"}}},
     {cowboy, {git, "https://github.com/emqx/cowboy", {tag, "2.9.2"}}},
-    {esockd, {git, "https://github.com/emqx/esockd", {tag, "5.12.0"}}},
-    {ekka, {git, "https://github.com/emqx/ekka", {tag, "0.19.5"}}},
+    {esockd, {git, "https://github.com/emqx/esockd", {tag, "5.11.2"}}},
+    {ekka, {git, "https://github.com/emqx/ekka", {tag, "0.19.3"}}},
     {gen_rpc, {git, "https://github.com/emqx/gen_rpc", {tag, "3.3.1"}}},
-    {hocon, {git, "https://github.com/emqx/hocon.git", {tag, "0.43.2"}}},
+    {hocon, {git, "https://github.com/emqx/hocon.git", {tag, "0.42.2"}}},
     {emqx_http_lib, {git, "https://github.com/emqx/emqx_http_lib.git", {tag, "0.5.3"}}},
     {pbkdf2, {git, "https://github.com/emqx/erlang-pbkdf2.git", {tag, "2.0.4"}}},
     {recon, {git, "https://github.com/ferd/recon", {tag, "2.5.1"}}},
-    {snabbkaffe, {git, "https://github.com/kafka4beam/snabbkaffe.git", {tag, "1.0.10"}}}
+    {snabbkaffe, {git, "https://github.com/kafka4beam/snabbkaffe.git", {tag, "1.0.10"}}},
+    {ra, "2.7.3"}
 ]}.
 
 {plugins, [{rebar3_proper, "0.12.1"}, rebar3_path_deps]}.

apps/emqx/rebar.config.script

@@ -24,8 +24,7 @@ IsQuicSupp = fun() ->
 end,
 
 Bcrypt = {bcrypt, {git, "https://github.com/emqx/erlang-bcrypt.git", {tag, "0.6.0"}}},
-Quicer =
-    {quicer, {git, "https://github.com/emqx/quic.git", {tag, "0.0.500"}}}.
+Quicer = {quicer, {git, "https://github.com/emqx/quic.git", {tag, "0.0.313"}}}.
 
 Dialyzer = fun(Config) ->
     {dialyzer, OldDialyzerConfig} = lists:keyfind(dialyzer, 1, Config),

apps/emqx/src/bhvrs/emqx_db_backup.erl

@@ -18,8 +18,6 @@
 
 -type traverse_break_reason() :: over | migrate.
 
--type opts() :: #{print_fun => fun((io:format(), [term()]) -> ok)}.
-
 -callback backup_tables() -> [mria:table()].
 
 %% validate the backup
@@ -33,9 +31,6 @@
 
 -callback migrate_mnesia_backup(tuple()) -> {ok, tuple()} | {error, term()}.
 
-%% NOTE: currently, this is called only when the table has been restored successfully.
--callback on_backup_table_imported(mria:table(), opts()) -> ok | {error, term()}.
-
--optional_callbacks([validate_mnesia_backup/1, migrate_mnesia_backup/1, on_backup_table_imported/2]).
+-optional_callbacks([validate_mnesia_backup/1, migrate_mnesia_backup/1]).
 
 -export_type([traverse_break_reason/0]).

apps/emqx/src/config/emqx_config_logger.erl

@@ -237,38 +237,32 @@ log_formatter(HandlerName, Conf) ->
             _ ->
                 conf_get("formatter", Conf)
         end,
-    TsFormat = timestamp_format(Conf),
-    WithMfa = conf_get("with_mfa", Conf),
-    PayloadEncode = conf_get("payload_encode", Conf, text),
+    TsFormat = timstamp_format(Conf),
     do_formatter(
-        Format, CharsLimit, SingleLine, TimeOffSet, Depth, TsFormat, WithMfa, PayloadEncode
+        Format, CharsLimit, SingleLine, TimeOffSet, Depth, TsFormat
     ).
 
 %% auto | epoch | rfc3339
-timestamp_format(Conf) ->
+timstamp_format(Conf) ->
     conf_get("timestamp_format", Conf).
 
 %% helpers
-do_formatter(json, CharsLimit, SingleLine, TimeOffSet, Depth, TsFormat, WithMfa, PayloadEncode) ->
+do_formatter(json, CharsLimit, SingleLine, TimeOffSet, Depth, TsFormat) ->
     {emqx_logger_jsonfmt, #{
         chars_limit => CharsLimit,
         single_line => SingleLine,
         time_offset => TimeOffSet,
         depth => Depth,
-        timestamp_format => TsFormat,
-        with_mfa => WithMfa,
-        payload_encode => PayloadEncode
+        timestamp_format => TsFormat
     }};
-do_formatter(text, CharsLimit, SingleLine, TimeOffSet, Depth, TsFormat, WithMfa, PayloadEncode) ->
+do_formatter(text, CharsLimit, SingleLine, TimeOffSet, Depth, TsFormat) ->
     {emqx_logger_textfmt, #{
         template => ["[", level, "] ", msg, "\n"],
         chars_limit => CharsLimit,
         single_line => SingleLine,
         time_offset => TimeOffSet,
         depth => Depth,
-        timestamp_format => TsFormat,
-        with_mfa => WithMfa,
-        payload_encode => PayloadEncode
+        timestamp_format => TsFormat
     }}.
 
 %% Don't record all logger message

apps/emqx/src/emqx.app.src

@@ -2,7 +2,7 @@
 {application, emqx, [
     {id, "emqx"},
     {description, "EMQX Core"},
-    {vsn, "5.3.4"},
+    {vsn, "5.3.0"},
     {modules, []},
     {registered, []},
     {applications, [
@@ -18,7 +18,7 @@
         sasl,
         lc,
         hocon,
-        emqx_ds_backends,
+        emqx_durable_storage,
         bcrypt,
         pbkdf2,
         emqx_http_lib,

apps/emqx/src/emqx.erl

@@ -61,12 +61,9 @@
     get_raw_config/2,
     update_config/2,
     update_config/3,
-    update_config/4,
     remove_config/1,
     remove_config/2,
-    remove_config/3,
     reset_config/2,
-    reset_config/3,
     data_dir/0,
     etc_file/1,
     cert_file/1,
@@ -198,7 +195,7 @@ get_raw_config(KeyPath, Default) ->
 -spec update_config(emqx_utils_maps:config_key_path(), emqx_config:update_request()) ->
     {ok, emqx_config:update_result()} | {error, emqx_config:update_error()}.
 update_config(KeyPath, UpdateReq) ->
-    update_config(KeyPath, UpdateReq, #{}, #{}).
+    update_config(KeyPath, UpdateReq, #{}).
 
 -spec update_config(
     emqx_utils_maps:config_key_path(),
@@ -206,56 +203,30 @@ update_config(KeyPath, UpdateReq) ->
     emqx_config:update_opts()
 ) ->
     {ok, emqx_config:update_result()} | {error, emqx_config:update_error()}.
-update_config(KeyPath, UpdateReq, Opts) ->
-    update_config(KeyPath, UpdateReq, Opts, #{}).
-
--spec update_config(
-    emqx_utils_maps:config_key_path(),
-    emqx_config:update_request(),
-    emqx_config:update_opts(),
-    emqx_config:cluster_rpc_opts()
-) ->
-    {ok, emqx_config:update_result()} | {error, emqx_config:update_error()}.
-update_config([RootName | _] = KeyPath, UpdateReq, Opts, ClusterRpcOpts) ->
+update_config([RootName | _] = KeyPath, UpdateReq, Opts) ->
     emqx_config_handler:update_config(
         emqx_config:get_schema_mod(RootName),
         KeyPath,
-        {{update, UpdateReq}, Opts},
-        ClusterRpcOpts
+        {{update, UpdateReq}, Opts}
     ).
 
 -spec remove_config(emqx_utils_maps:config_key_path()) ->
     {ok, emqx_config:update_result()} | {error, emqx_config:update_error()}.
 remove_config(KeyPath) ->
-    remove_config(KeyPath, #{}, #{}).
+    remove_config(KeyPath, #{}).
 
 -spec remove_config(emqx_utils_maps:config_key_path(), emqx_config:update_opts()) ->
     {ok, emqx_config:update_result()} | {error, emqx_config:update_error()}.
-remove_config([_RootName | _] = KeyPath, Opts) ->
-    remove_config(KeyPath, Opts, #{}).
-
--spec remove_config(
-    emqx_utils_maps:config_key_path(), emqx_config:update_opts(), emqx_config:cluster_rpc_opts()
-) ->
-    {ok, emqx_config:update_result()} | {error, emqx_config:update_error()}.
-remove_config([RootName | _] = KeyPath, Opts, ClusterRpcOpts) ->
+remove_config([RootName | _] = KeyPath, Opts) ->
     emqx_config_handler:update_config(
         emqx_config:get_schema_mod(RootName),
         KeyPath,
-        {remove, Opts},
-        ClusterRpcOpts
+        {remove, Opts}
     ).
 
 -spec reset_config(emqx_utils_maps:config_key_path(), emqx_config:update_opts()) ->
     {ok, emqx_config:update_result()} | {error, emqx_config:update_error()}.
 reset_config([RootName | SubKeys] = KeyPath, Opts) ->
-    reset_config([RootName | SubKeys] = KeyPath, Opts, #{}).
-
--spec reset_config(
-    emqx_utils_maps:config_key_path(), emqx_config:update_opts(), emqx_config:cluster_rpc_opts()
-) ->
-    {ok, emqx_config:update_result()} | {error, emqx_config:update_error()}.
-reset_config([RootName | SubKeys] = KeyPath, Opts, ClusterRpcOpts) ->
     case emqx_config:get_default_value(KeyPath) of
         {ok, Default} ->
             Mod = emqx_config:get_schema_mod(RootName),
@@ -264,8 +235,7 @@ reset_config([RootName | SubKeys] = KeyPath, Opts, ClusterRpcOpts) ->
                     emqx_config_handler:update_config(
                         Mod,
                         KeyPath,
-                        {{update, Default}, Opts},
-                        ClusterRpcOpts
+                        {{update, Default}, Opts}
                     );
                 false ->
                     NewConf =
@@ -277,8 +247,7 @@ reset_config([RootName | SubKeys] = KeyPath, Opts, ClusterRpcOpts) ->
                     emqx_config_handler:update_config(
                         Mod,
                         [RootName],
-                        {{update, NewConf}, Opts},
-                        ClusterRpcOpts
+                        {{update, NewConf}, Opts}
                     )
             end;
         {error, _} = Error ->

apps/emqx/src/emqx_access_control.erl

@@ -56,31 +56,31 @@ authenticate(Credential) ->
     NotSuperUser = #{is_superuser => false},
     case pre_hook_authenticate(Credential) of
         ok ->
-            on_authentication_complete(Credential, NotSuperUser, anonymous),
+            inc_authn_metrics(anonymous),
             {ok, NotSuperUser};
         continue ->
             case run_hooks('client.authenticate', [Credential], ignore) of
                 ignore ->
-                    on_authentication_complete(Credential, NotSuperUser, anonymous),
+                    inc_authn_metrics(anonymous),
                     {ok, NotSuperUser};
                 ok ->
-                    on_authentication_complete(Credential, NotSuperUser, ok),
+                    inc_authn_metrics(ok),
                     {ok, NotSuperUser};
-                {ok, AuthResult} = OkResult ->
-                    on_authentication_complete(Credential, AuthResult, ok),
+                {ok, _AuthResult} = OkResult ->
+                    inc_authn_metrics(ok),
                     OkResult;
-                {ok, AuthResult, _AuthData} = OkResult ->
-                    on_authentication_complete(Credential, AuthResult, ok),
+                {ok, _AuthResult, _AuthData} = OkResult ->
+                    inc_authn_metrics(ok),
                     OkResult;
-                {error, Reason} = Error ->
-                    on_authentication_complete(Credential, Reason, error),
+                {error, _Reason} = Error ->
+                    inc_authn_metrics(error),
                     Error;
                 %% {continue, AuthCache} | {continue, AuthData, AuthCache}
                 Other ->
                     Other
             end;
-        {error, Reason} = Error ->
-            on_authentication_complete(Credential, Reason, error),
+        {error, _Reason} = Error ->
+            inc_authn_metrics(error),
             Error
     end.
 
@@ -238,30 +238,5 @@ inc_authn_metrics(error) ->
 inc_authn_metrics(ok) ->
     emqx_metrics:inc('authentication.success');
 inc_authn_metrics(anonymous) ->
-    emqx_metrics:inc('client.auth.anonymous'),
     emqx_metrics:inc('authentication.success.anonymous'),
     emqx_metrics:inc('authentication.success').
-
-on_authentication_complete(Credential, Reason, error) ->
-    emqx_hooks:run(
-        'client.check_authn_complete',
-        [
-            Credential,
-            #{
-                reason_code => Reason
-            }
-        ]
-    ),
-    inc_authn_metrics(error);
-on_authentication_complete(Credential, Result, Type) ->
-    emqx_hooks:run(
-        'client.check_authn_complete',
-        [
-            Credential,
-            Result#{
-                reason_code => success,
-                is_anonymous => (Type =:= anonymous)
-            }
-        ]
-    ),
-    inc_authn_metrics(Type).

apps/emqx/src/emqx_banned.erl

@@ -16,8 +16,6 @@
 
 -module(emqx_banned).
 
--feature(maybe_expr, enable).
-
 -behaviour(gen_server).
 -behaviour(emqx_db_backup).
 
@@ -33,7 +31,6 @@
 
 -export([
     check/1,
-    check_clientid/1,
     create/1,
     look_up/1,
     delete/1,
@@ -51,7 +48,6 @@
     handle_call/3,
     handle_cast/2,
     handle_info/2,
-    handle_continue/2,
     terminate/2,
     code_change/3
 ]).
@@ -118,10 +114,6 @@ check(ClientInfo) ->
         do_check({peerhost, maps:get(peerhost, ClientInfo, undefined)}) orelse
         do_check_rules(ClientInfo).
 
--spec check_clientid(emqx_types:clientid()) -> boolean().
-check_clientid(ClientId) ->
-    do_check({clientid, ClientId}) orelse do_check_rules(#{clientid => ClientId}).
-
 -spec format(emqx_types:banned()) -> map().
 format(#banned{
     who = Who0,
@@ -140,7 +132,7 @@ format(#banned{
         until => to_rfc3339(Until)
     }.
 
--spec parse(map()) -> {ok, emqx_types:banned()} | {error, term()}.
+-spec parse(map()) -> emqx_types:banned() | {error, term()}.
 parse(Params) ->
     case parse_who(Params) of
         {error, Reason} ->
@@ -152,13 +144,13 @@ parse(Params) ->
             Until = maps:get(<<"until">>, Params, At + ?EXPIRATION_TIME),
             case Until > erlang:system_time(second) of
                 true ->
-                    {ok, #banned{
+                    #banned{
                         who = Who,
                         by = By,
                         reason = Reason,
                         at = At,
                         until = Until
-                    }};
+                    };
                 false ->
                     ErrorReason =
                         io_lib:format("Cannot create expired banned, ~p to ~p", [At, Until]),
@@ -242,139 +234,12 @@ who(peerhost_net, CIDR) when is_tuple(CIDR) -> {peerhost_net, CIDR};
 who(peerhost_net, CIDR) when is_binary(CIDR) ->
     {peerhost_net, esockd_cidr:parse(binary_to_list(CIDR), true)}.
 
-%%--------------------------------------------------------------------
-%% Import From CSV
-%%--------------------------------------------------------------------
-init_from_csv(undefined) ->
-    ok;
-init_from_csv(File) ->
-    maybe
-        core ?= mria_rlog:role(),
-        '$end_of_table' ?= mnesia:dirty_first(?BANNED_RULE_TAB),
-        '$end_of_table' ?= mnesia:dirty_first(?BANNED_INDIVIDUAL_TAB),
-        {ok, Bin} ?= file:read_file(File),
-        Stream = emqx_utils_stream:csv(Bin, #{nullable => true, filter_null => true}),
-        {ok, List} ?= parse_stream(Stream),
-        import_from_stream(List),
-        ?SLOG(info, #{
-            msg => "load_banned_bootstrap_file_succeeded",
-            file => File
-        })
-    else
-        replicant ->
-            ok;
-        {Name, _} when
-            Name == peerhost;
-            Name == peerhost_net;
-            Name == clientid_re;
-            Name == username_re;
-            Name == clientid;
-            Name == username
-        ->
-            ok;
-        {error, Reason} = Error ->
-            ?SLOG(error, #{
-                msg => "load_banned_bootstrap_file_failed",
-                reason => Reason,
-                file => File
-            }),
-            Error
-    end.
-
-import_from_stream(Stream) ->
-    Groups = maps:groups_from_list(
-        fun(#banned{who = Who}) -> table(Who) end, Stream
-    ),
-    maps:foreach(
-        fun(Tab, Items) ->
-            Trans = fun() ->
-                lists:foreach(
-                    fun(Item) ->
-                        mnesia:write(Tab, Item, write)
-                    end,
-                    Items
-                )
-            end,
-
-            case trans(Trans) of
-                {ok, _} ->
-                    ?SLOG(info, #{
-                        msg => "import_banned_from_stream_succeeded",
-                        items => Items
-                    });
-                {error, Reason} ->
-                    ?SLOG(error, #{
-                        msg => "import_banned_from_stream_failed",
-                        reason => Reason,
-                        items => Items
-                    })
-            end
-        end,
-        Groups
-    ).
-
-parse_stream(Stream) ->
-    try
-        List = emqx_utils_stream:consume(Stream),
-        parse_stream(List, [], [])
-    catch
-        error:Reason ->
-            {error, Reason}
-    end.
-
-parse_stream([Item | List], Ok, Error) ->
-    maybe
-        {ok, Item1} ?= normalize_parse_item(Item),
-        {ok, Banned} ?= parse(Item1),
-        parse_stream(List, [Banned | Ok], Error)
-    else
-        {error, _} ->
-            parse_stream(List, Ok, [Item | Error])
-    end;
-parse_stream([], Ok, []) ->
-    {ok, Ok};
-parse_stream([], Ok, Error) ->
-    ?SLOG(warning, #{
-        msg => "invalid_banned_items",
-        items => Error
-    }),
-    {ok, Ok}.
-
-normalize_parse_item(#{<<"as">> := As} = Item) ->
-    ParseTime = fun(Name, Input) ->
-        maybe
-            #{Name := Time} ?= Input,
-            {ok, Epoch} ?= emqx_utils_calendar:to_epoch_second(emqx_utils_conv:str(Time)),
-            {ok, Input#{Name := Epoch}}
-        else
-            {error, _} = Error ->
-                Error;
-            NoTime when is_map(NoTime) ->
-                {ok, NoTime}
-        end
-    end,
-
-    maybe
-        {ok, Type} ?= emqx_utils:safe_to_existing_atom(As),
-        {ok, Item1} ?= ParseTime(<<"at">>, Item#{<<"as">> := Type}),
-        ParseTime(<<"until">>, Item1)
-    end;
-normalize_parse_item(_Item) ->
-    {error, invalid_item}.
-
 %%--------------------------------------------------------------------
 %% gen_server callbacks
 %%--------------------------------------------------------------------
 
 init([]) ->
-    {ok, ensure_expiry_timer(#{expiry_timer => undefined}), {continue, init_from_csv}}.
-
-handle_continue(init_from_csv, State) ->
-    File = emqx_schema:naive_env_interpolation(
-        emqx:get_config([banned, bootstrap_file], undefined)
-    ),
-    _ = init_from_csv(File),
-    {noreply, State}.
+    {ok, ensure_expiry_timer(#{expiry_timer => undefined})}.
 
 handle_call(Req, _From, State) ->
     ?SLOG(error, #{msg => "unexpected_call", call => Req}),
@@ -385,7 +250,7 @@ handle_cast(Msg, State) ->
     {noreply, State}.
 
 handle_info({timeout, TRef, expire}, State = #{expiry_timer := TRef}) ->
-    _ = trans(fun ?MODULE:expire_banned_items/1, [
+    _ = mria:transaction(?COMMON_SHARD, fun ?MODULE:expire_banned_items/1, [
         erlang:system_time(second)
     ]),
     {noreply, ensure_expiry_timer(State), hibernate};
@@ -526,15 +391,3 @@ on_banned(_) ->
 
 all_rules() ->
     ets:tab2list(?BANNED_RULE_TAB).
-
-trans(Fun) ->
-    case mria:transaction(?COMMON_SHARD, Fun) of
-        {atomic, Res} -> {ok, Res};
-        {aborted, Reason} -> {error, Reason}
-    end.
-
-trans(Fun, Args) ->
-    case mria:transaction(?COMMON_SHARD, Fun, Args) of
-        {atomic, Res} -> {ok, Res};
-        {aborted, Reason} -> {error, Reason}
-    end.

apps/emqx/src/emqx_broker.erl

@@ -244,24 +244,11 @@ publish(Msg) when is_record(Msg, message) ->
                 topic => Topic
             }),
             [];
-        Msg1 = #message{} ->
-            do_publish(Msg1);
-        Msgs when is_list(Msgs) ->
-            do_publish_many(Msgs)
+        Msg1 = #message{topic = Topic} ->
+            PersistRes = persist_publish(Msg1),
+            route(aggre(emqx_router:match_routes(Topic)), delivery(Msg1), PersistRes)
     end.
 
-do_publish_many([]) ->
-    [];
-do_publish_many([Msg | T]) ->
-    do_publish(Msg) ++ do_publish_many(T).
-
-do_publish(#message{topic = Topic} = Msg) ->
-    PersistRes = persist_publish(Msg),
-    Routes = aggre(emqx_router:match_routes(Topic)),
-    Delivery = delivery(Msg),
-    RouteRes = route(Routes, Delivery, PersistRes),
-    do_forward_external(Delivery, RouteRes).
-
 persist_publish(Msg) ->
     case emqx_persistent_message:persist(Msg) of
         ok ->
@@ -345,9 +332,6 @@ aggre([], false, Acc) ->
 aggre([], true, Acc) ->
     lists:usort(Acc).
 
-do_forward_external(Delivery, RouteRes) ->
-    emqx_external_broker:forward(Delivery) ++ RouteRes.
-
 %% @doc Forward message to another node.
 -spec forward(
     node(), emqx_types:topic() | emqx_types:share(), emqx_types:delivery(), RpcMode :: sync | async
@@ -659,7 +643,6 @@ maybe_delete_route(Topic) ->
 
 sync_route(Action, Topic, ReplyTo) ->
     EnabledOn = emqx_config:get([broker, routing, batch_sync, enable_on]),
-    Res =
     case EnabledOn of
         all ->
             push_sync_route(Action, Topic, ReplyTo);
@@ -672,14 +655,7 @@ sync_route(Action, Topic, ReplyTo) ->
                 false ->
                     regular_sync_route(Action, Topic)
             end
-        end,
-    _ = external_sync_route(Action, Topic),
-    Res.
-
-external_sync_route(add, Topic) ->
-    emqx_external_broker:add_route(Topic);
-external_sync_route(delete, Topic) ->
-    emqx_external_broker:delete_route(Topic).
+    end.
 
 push_sync_route(Action, Topic, Opts) ->
     emqx_router_syncer:push(Action, Topic, node(), Opts).

apps/emqx/src/emqx_broker_sup.erl

@@ -47,7 +47,7 @@ init([]) ->
         router_syncer_pool,
         hash,
         PoolSize,
-        {emqx_router_syncer, start_link_pooled, []}
+        {emqx_router_syncer, start_link, []}
     ]),
 
     %% Shared subscription

apps/emqx/src/emqx_channel.erl

@@ -19,7 +19,6 @@
 
 -include("emqx.hrl").
 -include("emqx_channel.hrl").
--include("emqx_session.hrl").
 -include("emqx_mqtt.hrl").
 -include("emqx_access_control.hrl").
 -include("logger.hrl").
@@ -146,9 +145,7 @@
 -type replies() :: emqx_types:packet() | reply() | [reply()].
 
 -define(IS_MQTT_V5, #channel{conninfo = #{proto_ver := ?MQTT_PROTO_V5}}).
--define(IS_CONNECTED_OR_REAUTHENTICATING(ConnState),
-    ((ConnState == connected) orelse (ConnState == reauthenticating))
-).
+
 -define(IS_COMMON_SESSION_TIMER(N),
     ((N == retry_delivery) orelse (N == expire_awaiting_rel))
 ).
@@ -237,7 +234,7 @@ caps(#channel{clientinfo = #{zone := Zone}}) ->
 -spec init(emqx_types:conninfo(), opts()) -> channel().
 init(
     ConnInfo = #{
-        peername := {PeerHost, PeerPort} = PeerName,
+        peername := {PeerHost, PeerPort},
         sockname := {_Host, SockPort}
     },
     #{
@@ -261,9 +258,6 @@ init(
             listener => ListenerId,
             protocol => Protocol,
             peerhost => PeerHost,
-            %% We copy peername to clientinfo because some event contexts only have access
-            %% to client info (e.g.: authn/authz).
-            peername => PeerName,
             peerport => PeerPort,
             sockport => SockPort,
             clientid => undefined,
@@ -275,7 +269,7 @@ init(
         },
         Zone
     ),
-    {NClientInfo, NConnInfo} = take_conn_info_fields([ws_cookie, peersni], ClientInfo, ConnInfo),
+    {NClientInfo, NConnInfo} = take_ws_cookie(ClientInfo, ConnInfo),
     #channel{
         conninfo = NConnInfo,
         clientinfo = NClientInfo,
@@ -315,19 +309,13 @@ set_peercert_infos(Peercert, ClientInfo, Zone) ->
     ClientId = PeercetAs(peer_cert_as_clientid),
     ClientInfo#{username => Username, clientid => ClientId, dn => DN, cn => CN}.
 
-take_conn_info_fields(Fields, ClientInfo, ConnInfo) ->
-    lists:foldl(
-        fun(Field, {ClientInfo0, ConnInfo0}) ->
-            case maps:take(Field, ConnInfo0) of
-                {Value, NConnInfo} ->
-                    {ClientInfo0#{Field => Value}, NConnInfo};
+take_ws_cookie(ClientInfo, ConnInfo) ->
+    case maps:take(ws_cookie, ConnInfo) of
+        {WsCookie, NConnInfo} ->
+            {ClientInfo#{ws_cookie => WsCookie}, NConnInfo};
         _ ->
-                    {ClientInfo0, ConnInfo0}
-            end
-        end,
-        {ClientInfo, ConnInfo},
-        Fields
-    ).
+            {ClientInfo, ConnInfo}
+    end.
 
 %%--------------------------------------------------------------------
 %% Handle incoming packet
@@ -339,7 +327,7 @@ take_conn_info_fields(Fields, ClientInfo, ConnInfo) ->
     | {shutdown, Reason :: term(), channel()}
     | {shutdown, Reason :: term(), replies(), channel()}.
 handle_in(?CONNECT_PACKET(), Channel = #channel{conn_state = ConnState}) when
-    ?IS_CONNECTED_OR_REAUTHENTICATING(ConnState)
+    ConnState =:= connected orelse ConnState =:= reauthenticating
 ->
     handle_out(disconnect, ?RC_PROTOCOL_ERROR, Channel);
 handle_in(?CONNECT_PACKET(), Channel = #channel{conn_state = connecting}) ->
@@ -556,10 +544,8 @@ handle_in(
         {error, ReasonCode} ->
             handle_out(disconnect, ReasonCode, Channel)
     end;
-handle_in(?PACKET(?PINGREQ), Channel = #channel{keepalive = Keepalive}) ->
-    {ok, NKeepalive} = emqx_keepalive:check(Keepalive),
-    NChannel = Channel#channel{keepalive = NKeepalive},
-    {ok, ?PACKET(?PINGRESP), reset_timer(keepalive, NChannel)};
+handle_in(?PACKET(?PINGREQ), Channel) ->
+    {ok, ?PACKET(?PINGRESP), Channel};
 handle_in(
     ?DISCONNECT_PACKET(ReasonCode, Properties),
     Channel = #channel{conninfo = ConnInfo}
@@ -569,8 +555,29 @@ handle_in(
     process_disconnect(ReasonCode, Properties, NChannel);
 handle_in(?AUTH_PACKET(), Channel) ->
     handle_out(disconnect, ?RC_IMPLEMENTATION_SPECIFIC_ERROR, Channel);
-handle_in({frame_error, Reason}, Channel) ->
-    handle_frame_error(Reason, Channel);
+handle_in({frame_error, Reason}, Channel = #channel{conn_state = idle}) ->
+    shutdown(shutdown_count(frame_error, Reason), Channel);
+handle_in(
+    {frame_error, #{cause := frame_too_large} = R}, Channel = #channel{conn_state = connecting}
+) ->
+    shutdown(
+        shutdown_count(frame_error, R), ?CONNACK_PACKET(?RC_PACKET_TOO_LARGE), Channel
+    );
+handle_in({frame_error, Reason}, Channel = #channel{conn_state = connecting}) ->
+    shutdown(shutdown_count(frame_error, Reason), ?CONNACK_PACKET(?RC_MALFORMED_PACKET), Channel);
+handle_in(
+    {frame_error, #{cause := frame_too_large}}, Channel = #channel{conn_state = ConnState}
+) when
+    ConnState =:= connected orelse ConnState =:= reauthenticating
+->
+    handle_out(disconnect, {?RC_PACKET_TOO_LARGE, frame_too_large}, Channel);
+handle_in({frame_error, Reason}, Channel = #channel{conn_state = ConnState}) when
+    ConnState =:= connected orelse ConnState =:= reauthenticating
+->
+    handle_out(disconnect, {?RC_MALFORMED_PACKET, Reason}, Channel);
+handle_in({frame_error, Reason}, Channel = #channel{conn_state = disconnected}) ->
+    ?SLOG(error, #{msg => "malformed_mqtt_message", reason => Reason}),
+    {ok, Channel};
 handle_in(Packet, Channel) ->
     ?SLOG(error, #{msg => "disconnecting_due_to_unexpected_message", packet => Packet}),
     handle_out(disconnect, ?RC_PROTOCOL_ERROR, Channel).
@@ -677,28 +684,21 @@ process_publish(Packet = ?PUBLISH_PACKET(QoS, Topic, PacketId), Channel) ->
     end.
 
 packet_to_message(Packet, #channel{
-    conninfo = #{
-        peername := PeerName,
-        proto_ver := ProtoVer
-    },
-    clientinfo =
-        #{
+    conninfo = #{proto_ver := ProtoVer},
+    clientinfo = #{
         protocol := Protocol,
         clientid := ClientId,
         username := Username,
         peerhost := PeerHost,
         mountpoint := MountPoint
-        } = ClientInfo
+    }
 }) ->
-    ClientAttrs = maps:get(client_attrs, ClientInfo, #{}),
     emqx_mountpoint:mount(
         MountPoint,
         emqx_packet:to_message(
             Packet,
             ClientId,
             #{
-                client_attrs => ClientAttrs,
-                peername => PeerName,
                 proto_ver => ProtoVer,
                 protocol => Protocol,
                 username => Username,
@@ -1002,68 +1002,6 @@ not_nacked({deliver, _Topic, Msg}) ->
             true
     end.
 
-%%--------------------------------------------------------------------
-%% Handle Frame Error
-%%--------------------------------------------------------------------
-
-handle_frame_error(
-    Reason = #{cause := frame_too_large},
-    Channel = #channel{conn_state = ConnState, conninfo = ConnInfo}
-) when
-    ?IS_CONNECTED_OR_REAUTHENTICATING(ConnState)
-->
-    ShutdownCount = shutdown_count(frame_error, Reason),
-    case proto_ver(Reason, ConnInfo) of
-        ?MQTT_PROTO_V5 ->
-            handle_out(disconnect, {?RC_PACKET_TOO_LARGE, frame_too_large}, Channel);
-        _ ->
-            shutdown(ShutdownCount, Channel)
-    end;
-%% Only send CONNACK with reason code `frame_too_large` for MQTT-v5.0 when connecting,
-%% otherwise DONOT send any CONNACK or DISCONNECT packet.
-handle_frame_error(
-    Reason,
-    Channel = #channel{conn_state = ConnState, conninfo = ConnInfo}
-) when
-    is_map(Reason) andalso
-        (ConnState == idle orelse ConnState == connecting)
-->
-    ShutdownCount = shutdown_count(frame_error, Reason),
-    ProtoVer = proto_ver(Reason, ConnInfo),
-    NChannel = Channel#channel{conninfo = ConnInfo#{proto_ver => ProtoVer}},
-    case ProtoVer of
-        ?MQTT_PROTO_V5 ->
-            shutdown(ShutdownCount, ?CONNACK_PACKET(?RC_PACKET_TOO_LARGE), NChannel);
-        _ ->
-            shutdown(ShutdownCount, NChannel)
-    end;
-handle_frame_error(
-    Reason,
-    Channel = #channel{conn_state = connecting}
-) ->
-    shutdown(
-        shutdown_count(frame_error, Reason),
-        ?CONNACK_PACKET(?RC_MALFORMED_PACKET),
-        Channel
-    );
-handle_frame_error(
-    Reason,
-    Channel = #channel{conn_state = ConnState}
-) when
-    ?IS_CONNECTED_OR_REAUTHENTICATING(ConnState)
-->
-    handle_out(
-        disconnect,
-        {?RC_MALFORMED_PACKET, Reason},
-        Channel
-    );
-handle_frame_error(
-    Reason,
-    Channel = #channel{conn_state = disconnected}
-) ->
-    ?SLOG(error, #{msg => "malformed_mqtt_message", reason => Reason}),
-    {ok, Channel}.
-
 %%--------------------------------------------------------------------
 %% Handle outgoing packet
 %%--------------------------------------------------------------------
@@ -1284,12 +1222,11 @@ handle_call(
     {keepalive, Interval},
     Channel = #channel{
         keepalive = KeepAlive,
-        conninfo = ConnInfo,
-        clientinfo = #{zone := Zone}
+        conninfo = ConnInfo
     }
 ) ->
     ClientId = info(clientid, Channel),
-    NKeepalive = emqx_keepalive:update(Zone, Interval, KeepAlive),
+    NKeepalive = emqx_keepalive:update(timer:seconds(Interval), KeepAlive),
     NConnInfo = maps:put(keepalive, Interval, ConnInfo),
     NChannel = Channel#channel{keepalive = NKeepalive, conninfo = NConnInfo},
     SockInfo = maps:get(sockinfo, emqx_cm:get_chan_info(ClientId), #{}),
@@ -1332,7 +1269,7 @@ handle_info(
             session = Session
         }
 ) when
-    ?IS_CONNECTED_OR_REAUTHENTICATING(ConnState)
+    ConnState =:= connected orelse ConnState =:= reauthenticating
 ->
     {Intent, Session1} = session_disconnect(ClientInfo, ConnInfo, Session),
     Channel1 = ensure_disconnected(Reason, maybe_publish_will_msg(sock_closed, Channel)),
@@ -1362,9 +1299,6 @@ handle_info({'DOWN', Ref, process, Pid, Reason}, Channel) ->
         [] -> {ok, Channel};
         Msgs -> {ok, Msgs, Channel}
     end;
-handle_info(?session_message(Message), #channel{session = Session} = Channel) ->
-    NSession = emqx_session:handle_info(Message, Session),
-    {ok, Channel#channel{session = NSession}};
 handle_info(Info, Channel) ->
     ?SLOG(error, #{msg => "unexpected_info", info => Info}),
     {ok, Channel}.
@@ -1392,22 +1326,22 @@ die_if_test_compiled() ->
     | {shutdown, Reason :: term(), channel()}.
 handle_timeout(
     _TRef,
-    keepalive,
+    {keepalive, _StatVal},
     Channel = #channel{keepalive = undefined}
 ) ->
     {ok, Channel};
 handle_timeout(
     _TRef,
-    keepalive,
+    {keepalive, _StatVal},
     Channel = #channel{conn_state = disconnected}
 ) ->
     {ok, Channel};
 handle_timeout(
     _TRef,
-    keepalive,
+    {keepalive, StatVal},
     Channel = #channel{keepalive = Keepalive}
 ) ->
-    case emqx_keepalive:check(Keepalive) of
+    case emqx_keepalive:check(StatVal, Keepalive) of
         {ok, NKeepalive} ->
             NChannel = Channel#channel{keepalive = NKeepalive},
             {ok, reset_timer(keepalive, NChannel)};
@@ -1518,16 +1452,10 @@ reset_timer(Name, Time, Channel) ->
     ensure_timer(Name, Time, clean_timer(Name, Channel)).
 
 clean_timer(Name, Channel = #channel{timers = Timers}) ->
-    case maps:take(Name, Timers) of
-        error ->
-            Channel;
-        {TRef, NTimers} ->
-            ok = emqx_utils:cancel_timer(TRef),
-            Channel#channel{timers = NTimers}
-    end.
+    Channel#channel{timers = maps:remove(Name, Timers)}.
 
 interval(keepalive, #channel{keepalive = KeepAlive}) ->
-    emqx_keepalive:info(check_interval, KeepAlive);
+    emqx_keepalive:info(interval, KeepAlive);
 interval(retry_delivery, #channel{session = Session}) ->
     emqx_session:info(retry_interval, Session);
 interval(expire_awaiting_rel, #channel{session = Session}) ->
@@ -1794,16 +1722,6 @@ count_flapping_event(_ConnPkt, #channel{clientinfo = ClientInfo}) ->
 %%--------------------------------------------------------------------
 %% Authenticate
 
-%% If peercert exists, add it as `cert_pem` credential field.
-maybe_add_cert(Map, #channel{conninfo = ConnInfo}) ->
-    maybe_add_cert(Map, ConnInfo);
-maybe_add_cert(Map, #{peercert := PeerCert}) when is_binary(PeerCert) ->
-    %% NOTE: it's raw binary at this point,
-    %% encoding to PEM (base64) is done lazy in emqx_auth_utils:render_var
-    Map#{cert_pem => PeerCert};
-maybe_add_cert(Map, _) ->
-    Map.
-
 authenticate(
     ?CONNECT_PACKET(
         #mqtt_packet_connect{
@@ -1816,23 +1734,20 @@ authenticate(
         auth_cache = AuthCache
     } = Channel
 ) ->
-    %% Auth with CONNECT packet for MQTT v5
     AuthData = emqx_mqtt_props:get('Authentication-Data', Properties, undefined),
-    Credential0 =
+    do_authenticate(
         ClientInfo#{
             auth_method => AuthMethod,
             auth_data => AuthData,
             auth_cache => AuthCache
         },
-    Credential = maybe_add_cert(Credential0, Channel),
-    do_authenticate(Credential, Channel);
+        Channel
+    );
 authenticate(
     ?CONNECT_PACKET(#mqtt_packet_connect{password = Password}),
     #channel{clientinfo = ClientInfo} = Channel
 ) ->
-    %% Auth with CONNECT packet for MQTT v3
-    Credential = maybe_add_cert(ClientInfo#{password => Password}, Channel),
-    do_authenticate(Credential, Channel);
+    do_authenticate(ClientInfo#{password => Password}, Channel);
 authenticate(
     ?AUTH_PACKET(_, #{'Authentication-Method' := AuthMethod} = Properties),
     #channel{
@@ -1841,7 +1756,6 @@ authenticate(
         auth_cache = AuthCache
     } = Channel
 ) ->
-    %% Enhanced auth
     case emqx_mqtt_props:get('Authentication-Method', ConnProps, undefined) of
         AuthMethod ->
             AuthData = emqx_mqtt_props:get('Authentication-Data', Properties, undefined),
@@ -2385,7 +2299,9 @@ ensure_keepalive_timer(0, Channel) ->
 ensure_keepalive_timer(disabled, Channel) ->
     Channel;
 ensure_keepalive_timer(Interval, Channel = #channel{clientinfo = #{zone := Zone}}) ->
-    Keepalive = emqx_keepalive:init(Zone, Interval),
+    Multiplier = get_mqtt_conf(Zone, keepalive_multiplier),
+    RecvCnt = emqx_pd:get_counter(recv_pkt),
+    Keepalive = emqx_keepalive:init(RecvCnt, round(timer:seconds(Interval) * Multiplier)),
     ensure_timer(keepalive, Channel#channel{keepalive = Keepalive}).
 
 clear_keepalive(Channel = #channel{timers = Timers}) ->
@@ -2679,7 +2595,8 @@ save_alias(outbound, AliasId, Topic, TopicAliases = #{outbound := Aliases}) ->
     NAliases = maps:put(Topic, AliasId, Aliases),
     TopicAliases#{outbound => NAliases}.
 
--compile({inline, [reply/2, shutdown/2, shutdown/3]}).
+-compile({inline, [reply/2, shutdown/2, shutdown/3, sp/1, flag/1]}).
+
 reply(Reply, Channel) ->
     {reply, Reply, Channel}.
 
@@ -2715,13 +2632,13 @@ disconnect_and_shutdown(
         ?IS_MQTT_V5 =
         #channel{conn_state = ConnState}
 ) when
-    ?IS_CONNECTED_OR_REAUTHENTICATING(ConnState)
+    ConnState =:= connected orelse ConnState =:= reauthenticating
 ->
     NChannel = ensure_disconnected(Reason, Channel),
     shutdown(Reason, Reply, ?DISCONNECT_PACKET(reason_code(Reason)), NChannel);
 %% mqtt v3/v4 connected sessions
 disconnect_and_shutdown(Reason, Reply, Channel = #channel{conn_state = ConnState}) when
-    ?IS_CONNECTED_OR_REAUTHENTICATING(ConnState)
+    ConnState =:= connected orelse ConnState =:= reauthenticating
 ->
     NChannel = ensure_disconnected(Reason, Channel),
     shutdown(Reason, Reply, NChannel);
@@ -2764,13 +2681,6 @@ is_durable_session(#channel{session = Session}) ->
             false
     end.
 
-proto_ver(#{proto_ver := ProtoVer}, _ConnInfo) ->
-    ProtoVer;
-proto_ver(_Reason, #{proto_ver := ProtoVer}) ->
-    ProtoVer;
-proto_ver(_, _) ->
-    ?MQTT_PROTO_V4.
-
 %%--------------------------------------------------------------------
 %% For CT tests
 %%--------------------------------------------------------------------

apps/emqx/src/emqx_config.erl

@@ -118,7 +118,6 @@
     config/0,
     app_envs/0,
     update_opts/0,
-    cluster_rpc_opts/0,
     update_cmd/0,
     update_args/0,
     update_error/0,
@@ -148,7 +147,6 @@
     raw_config => emqx_config:raw_config(),
     post_config_update => #{module() => any()}
 }.
--type cluster_rpc_opts() :: #{kind => ?KIND_INITIATE | ?KIND_REPLICATE}.
 
 %% raw_config() is the config that is NOT parsed and translated by hocon schema
 -type raw_config() :: #{binary() => term()} | list() | undefined.
@@ -499,14 +497,15 @@ fill_defaults(RawConf, Opts) ->
     ).
 
 -spec fill_defaults(module(), raw_config(), hocon_tconf:opts()) -> map().
-fill_defaults(SchemaMod, RawConf = #{<<"durable_storage">> := Ds}, Opts) ->
+fill_defaults(_SchemaMod, RawConf = #{<<"durable_storage">> := _}, _) ->
     %% FIXME: kludge to prevent `emqx_config' module from filling in
     %% the default values for backends and layouts. These records are
     %% inside unions, and adding default values there will add
     %% incompatible fields.
-    RawConf1 = maps:remove(<<"durable_storage">>, RawConf),
-    Conf = fill_defaults(SchemaMod, RawConf1, Opts),
-    Conf#{<<"durable_storage">> => Ds};
+    %%
+    %% Note: this function is called for each individual conf root, so
+    %% this clause only affects this particular subtree.
+    RawConf;
 fill_defaults(SchemaMod, RawConf, Opts0) ->
     Opts = maps:merge(#{required => false, make_serializable => true}, Opts0),
     hocon_tconf:check_plain(

apps/emqx/src/emqx_config_handler.erl

@@ -18,7 +18,6 @@
 -module(emqx_config_handler).
 
 -include("logger.hrl").
--include("emqx.hrl").
 -include("emqx_schema.hrl").
 -include_lib("hocon/include/hocon_types.hrl").
 
@@ -31,7 +30,6 @@
     add_handler/2,
     remove_handler/1,
     update_config/3,
-    update_config/4,
     get_raw_cluster_override_conf/0,
     info/0
 ]).
@@ -55,13 +53,9 @@
 
 -optional_callbacks([
     pre_config_update/3,
-    pre_config_update/4,
     propagated_pre_config_update/3,
-    propagated_pre_config_update/4,
     post_config_update/5,
-    post_config_update/6,
-    propagated_post_config_update/5,
-    propagated_post_config_update/6
+    propagated_post_config_update/5
 ]).
 
 -callback pre_config_update([atom()], emqx_config:update_request(), emqx_config:raw_config()) ->
@@ -89,38 +83,6 @@
 ) ->
     ok | {ok, Result :: any()} | {error, Reason :: term()}.
 
--callback pre_config_update(
-    [atom()], emqx_config:update_request(), emqx_config:raw_config(), emqx_config:cluster_rpc_opts()
-) ->
-    ok | {ok, emqx_config:update_request()} | {error, term()}.
--callback propagated_pre_config_update(
-    [binary()],
-    emqx_config:update_request(),
-    emqx_config:raw_config(),
-    emqx_config:cluster_rpc_opts()
-) ->
-    ok | {ok, emqx_config:update_request()} | {error, term()}.
-
--callback post_config_update(
-    [atom()],
-    emqx_config:update_request(),
-    emqx_config:config(),
-    emqx_config:config(),
-    emqx_config:app_envs(),
-    emqx_config:cluster_rpc_opts()
-) ->
-    ok | {ok, Result :: any()} | {error, Reason :: term()}.
-
--callback propagated_post_config_update(
-    [atom()],
-    emqx_config:update_request(),
-    emqx_config:config(),
-    emqx_config:config(),
-    emqx_config:app_envs(),
-    emqx_config:cluster_rpc_opts()
-) ->
-    ok | {ok, Result :: any()} | {error, Reason :: term()}.
-
 -type state() :: #{handlers := any()}.
 -type config_key_path() :: emqx_utils_maps:config_key_path().
 
@@ -130,17 +92,12 @@ start_link() ->
 stop() ->
     gen_server:stop(?MODULE).
 
-update_config(SchemaModule, ConfKeyPath, UpdateArgs) ->
-    update_config(SchemaModule, ConfKeyPath, UpdateArgs, #{}).
-
--spec update_config(module(), config_key_path(), emqx_config:update_args(), map()) ->
+-spec update_config(module(), config_key_path(), emqx_config:update_args()) ->
     {ok, emqx_config:update_result()} | {error, emqx_config:update_error()}.
-update_config(SchemaModule, ConfKeyPath, UpdateArgs, ClusterOpts) ->
+update_config(SchemaModule, ConfKeyPath, UpdateArgs) ->
     %% force convert the path to a list of atoms, as there maybe some wildcard names/ids in the path
     AtomKeyPath = [atom(Key) || Key <- ConfKeyPath],
-    gen_server:call(
-        ?MODULE, {change_config, SchemaModule, AtomKeyPath, UpdateArgs, ClusterOpts}, infinity
-    ).
+    gen_server:call(?MODULE, {change_config, SchemaModule, AtomKeyPath, UpdateArgs}, infinity).
 
 -spec add_handler(config_key_path(), handler_name()) ->
     ok | {error, {conflict, list()}}.
@@ -173,11 +130,11 @@ handle_call({add_handler, ConfKeyPath, HandlerName}, _From, State = #{handlers :
         {error, _Reason} = Error -> {reply, Error, State}
     end;
 handle_call(
-    {change_config, SchemaModule, ConfKeyPath, UpdateArgs, ClusterRpcOpts},
+    {change_config, SchemaModule, ConfKeyPath, UpdateArgs},
     _From,
     #{handlers := Handlers} = State
 ) ->
-    Result = handle_update_request(SchemaModule, ConfKeyPath, Handlers, UpdateArgs, ClusterRpcOpts),
+    Result = handle_update_request(SchemaModule, ConfKeyPath, Handlers, UpdateArgs),
     {reply, Result, State};
 handle_call(get_raw_cluster_override_conf, _From, State) ->
     Reply = emqx_config:read_override_conf(#{override_to => cluster}),
@@ -246,9 +203,9 @@ filter_top_level_handlers(Handlers) ->
         Handlers
     ).
 
-handle_update_request(SchemaModule, ConfKeyPath, Handlers, UpdateArgs, ClusterRpcOpts) ->
+handle_update_request(SchemaModule, ConfKeyPath, Handlers, UpdateArgs) ->
     try
-        do_handle_update_request(SchemaModule, ConfKeyPath, Handlers, UpdateArgs, ClusterRpcOpts)
+        do_handle_update_request(SchemaModule, ConfKeyPath, Handlers, UpdateArgs)
     catch
         throw:Reason ->
             {error, Reason};
@@ -260,14 +217,13 @@ handle_update_request(SchemaModule, ConfKeyPath, Handlers, UpdateArgs, ClusterRp
                 update_req => UpdateArgs,
                 module => SchemaModule,
                 key_path => ConfKeyPath,
-                cluster_rpc_opts => ClusterRpcOpts,
                 stacktrace => ST
             }),
             {error, {config_update_crashed, Reason}}
     end.
 
-do_handle_update_request(SchemaModule, ConfKeyPath, Handlers, UpdateArgs, ClusterOpts) ->
-    case process_update_request(ConfKeyPath, Handlers, UpdateArgs, ClusterOpts) of
+do_handle_update_request(SchemaModule, ConfKeyPath, Handlers, UpdateArgs) ->
+    case process_update_request(ConfKeyPath, Handlers, UpdateArgs) of
         {ok, NewRawConf, OverrideConf, Opts} ->
             check_and_save_configs(
                 SchemaModule,
@@ -276,24 +232,23 @@ do_handle_update_request(SchemaModule, ConfKeyPath, Handlers, UpdateArgs, Cluste
                 NewRawConf,
                 OverrideConf,
                 UpdateArgs,
-                Opts,
-                ClusterOpts
+                Opts
             );
         {error, Result} ->
             {error, Result}
     end.
 
-process_update_request([_], _Handlers, {remove, _Opts}, _ClusterRpcOpts) ->
+process_update_request([_], _Handlers, {remove, _Opts}) ->
     {error, "remove_root_is_forbidden"};
-process_update_request(ConfKeyPath, _Handlers, {remove, Opts}, _ClusterRpcOpts) ->
+process_update_request(ConfKeyPath, _Handlers, {remove, Opts}) ->
     OldRawConf = emqx_config:get_root_raw(ConfKeyPath),
     BinKeyPath = bin_path(ConfKeyPath),
     NewRawConf = emqx_utils_maps:deep_remove(BinKeyPath, OldRawConf),
     OverrideConf = remove_from_override_config(BinKeyPath, Opts),
     {ok, NewRawConf, OverrideConf, Opts};
-process_update_request(ConfKeyPath, Handlers, {{update, UpdateReq}, Opts}, ClusterRpcOpts) ->
+process_update_request(ConfKeyPath, Handlers, {{update, UpdateReq}, Opts}) ->
     OldRawConf = emqx_config:get_root_raw(ConfKeyPath),
-    case do_update_config(ConfKeyPath, Handlers, OldRawConf, UpdateReq, ClusterRpcOpts) of
+    case do_update_config(ConfKeyPath, Handlers, OldRawConf, UpdateReq) of
         {ok, NewRawConf} ->
             OverrideConf = merge_to_override_config(NewRawConf, Opts),
             {ok, NewRawConf, OverrideConf, Opts};
@@ -301,16 +256,15 @@ process_update_request(ConfKeyPath, Handlers, {{update, UpdateReq}, Opts}, Clust
             Error
     end.
 
-do_update_config(ConfKeyPath, Handlers, OldRawConf, UpdateReq, ClusterRpcOpts) ->
-    do_update_config(ConfKeyPath, Handlers, OldRawConf, UpdateReq, ClusterRpcOpts, []).
+do_update_config(ConfKeyPath, Handlers, OldRawConf, UpdateReq) ->
+    do_update_config(ConfKeyPath, Handlers, OldRawConf, UpdateReq, []).
 
-do_update_config([], Handlers, OldRawConf, UpdateReq, ClusterRpcOpts, ConfKeyPath) ->
+do_update_config([], Handlers, OldRawConf, UpdateReq, ConfKeyPath) ->
     call_pre_config_update(#{
         handlers => Handlers,
         old_raw_conf => OldRawConf,
         update_req => UpdateReq,
         conf_key_path => ConfKeyPath,
-        cluster_rpc_opts => ClusterRpcOpts,
         callback => pre_config_update,
         is_propagated => false
     });
@@ -319,18 +273,13 @@ do_update_config(
     Handlers,
     OldRawConf,
     UpdateReq,
-    ClusterRpcOpts,
     ConfKeyPath0
 ) ->
     ConfKeyPath = ConfKeyPath0 ++ [ConfKey],
     ConfKeyBin = bin(ConfKey),
     SubOldRawConf = get_sub_config(ConfKeyBin, OldRawConf),
     SubHandlers = get_sub_handlers(ConfKey, Handlers),
-    case
-        do_update_config(
-            SubConfKeyPath, SubHandlers, SubOldRawConf, UpdateReq, ClusterRpcOpts, ConfKeyPath
-        )
-    of
+    case do_update_config(SubConfKeyPath, SubHandlers, SubOldRawConf, UpdateReq, ConfKeyPath) of
         {ok, NewUpdateReq} ->
             merge_to_old_config(#{ConfKeyBin => NewUpdateReq}, OldRawConf);
         Error ->
@@ -344,18 +293,12 @@ check_and_save_configs(
     NewRawConf,
     OverrideConf,
     UpdateArgs,
-    Opts,
-    ClusterOpts
+    Opts
 ) ->
     Schema = schema(SchemaModule, ConfKeyPath),
-    Kind = maps:get(kind, ClusterOpts, ?KIND_INITIATE),
     {AppEnvs, NewConf} = emqx_config:check_config(Schema, NewRawConf),
     OldConf = emqx_config:get_root(ConfKeyPath),
-    case
-        do_post_config_update(
-            ConfKeyPath, Handlers, OldConf, NewConf, AppEnvs, UpdateArgs, ClusterOpts, #{}
-        )
-    of
+    case do_post_config_update(ConfKeyPath, Handlers, OldConf, NewConf, AppEnvs, UpdateArgs, #{}) of
         {ok, Result0} ->
             post_update_ok(
                 AppEnvs,
@@ -367,12 +310,9 @@ check_and_save_configs(
                 UpdateArgs,
                 Result0
             );
-        {error, {post_config_update, HandlerName, Reason}} when Kind =/= ?KIND_INITIATE ->
-            ?SLOG(critical, #{
-                msg => "post_config_update_failed_but_save_the_config_anyway",
-                handler => HandlerName,
-                reason => Reason
-            }),
+        {error, {post_config_update, HandlerName, Reason}} ->
+            HandlePostFailureFun =
+                fun() ->
                     post_update_ok(
                         AppEnvs,
                         NewConf,
@@ -382,9 +322,9 @@ check_and_save_configs(
                         ConfKeyPath,
                         UpdateArgs,
                         #{}
-            );
-        {error, _} = Error ->
-            Error
+                    )
+                end,
+            {error, {post_config_update, HandlerName, {Reason, HandlePostFailureFun}}}
     end.
 
 post_update_ok(AppEnvs, NewConf, NewRawConf, OverrideConf, Opts, ConfKeyPath, UpdateArgs, Result0) ->
@@ -392,9 +332,7 @@ post_update_ok(AppEnvs, NewConf, NewRawConf, OverrideConf, Opts, ConfKeyPath, Up
     Result1 = return_change_result(ConfKeyPath, UpdateArgs),
     {ok, Result1#{post_config_update => Result0}}.
 
-do_post_config_update(
-    ConfKeyPath, Handlers, OldConf, NewConf, AppEnvs, UpdateArgs, ClusterOpts, Result
-) ->
+do_post_config_update(ConfKeyPath, Handlers, OldConf, NewConf, AppEnvs, UpdateArgs, Result) ->
     do_post_config_update(
         ConfKeyPath,
         Handlers,
@@ -402,7 +340,6 @@ do_post_config_update(
         NewConf,
         AppEnvs,
         UpdateArgs,
-        ClusterOpts,
         Result,
         []
     ).
@@ -415,7 +352,6 @@ do_post_config_update(
     AppEnvs,
     UpdateArgs,
     Result,
-    ClusterOpts,
     ConfKeyPath
 ) ->
     call_post_config_update(#{
@@ -426,7 +362,6 @@ do_post_config_update(
         update_req => up_req(UpdateArgs),
         result => Result,
         conf_key_path => ConfKeyPath,
-        cluster_rpc_opts => ClusterOpts,
         callback => post_config_update
     });
 do_post_config_update(
@@ -436,7 +371,6 @@ do_post_config_update(
     NewConf,
     AppEnvs,
     UpdateArgs,
-    ClusterOpts,
     Result,
     ConfKeyPath0
 ) ->
@@ -451,7 +385,6 @@ do_post_config_update(
         SubNewConf,
         AppEnvs,
         UpdateArgs,
-        ClusterOpts,
         Result,
         ConfKeyPath
     ).
@@ -495,11 +428,13 @@ call_proper_pre_config_update(
     #{
         handlers := #{?MOD := Module},
         callback := Callback,
-        update_req := UpdateReq
+        update_req := UpdateReq,
+        old_raw_conf := OldRawConf
     } = Ctx
 ) ->
-    Arity = get_function_arity(Module, Callback, [3, 4]),
-    case apply_pre_config_update(Module, Callback, Arity, Ctx) of
+    case erlang:function_exported(Module, Callback, 3) of
+        true ->
+            case apply_pre_config_update(Module, Ctx) of
                 {ok, NewUpdateReq} ->
                     {ok, NewUpdateReq};
                 ok ->
@@ -507,29 +442,23 @@ call_proper_pre_config_update(
                 {error, Reason} ->
                     {error, {pre_config_update, Module, Reason}}
             end;
+        false ->
+            merge_to_old_config(UpdateReq, OldRawConf)
+    end;
 call_proper_pre_config_update(
     #{update_req := UpdateReq}
 ) ->
     {ok, UpdateReq}.
 
-apply_pre_config_update(Module, Callback, 3, #{
-    conf_key_path := ConfKeyPath,
-    update_req := UpdateReq,
-    old_raw_conf := OldRawConf
-}) ->
-    Module:Callback(ConfKeyPath, UpdateReq, OldRawConf);
-apply_pre_config_update(Module, Callback, 4, #{
+apply_pre_config_update(Module, #{
     conf_key_path := ConfKeyPath,
     update_req := UpdateReq,
     old_raw_conf := OldRawConf,
-    cluster_rpc_opts := ClusterRpcOpts
+    callback := Callback
 }) ->
-    Module:Callback(ConfKeyPath, UpdateReq, OldRawConf, ClusterRpcOpts);
-apply_pre_config_update(_Module, _Callback, false, #{
-    update_req := UpdateReq,
-    old_raw_conf := OldRawConf
-}) ->
-    merge_to_old_config(UpdateReq, OldRawConf).
+    Module:Callback(
+        ConfKeyPath, UpdateReq, OldRawConf
+    ).
 
 propagate_pre_config_updates_to_subconf(
     #{handlers := #{?WKEY := _}} = Ctx
@@ -631,23 +560,28 @@ call_proper_post_config_update(
         result := Result
     } = Ctx
 ) ->
-    Arity = get_function_arity(Module, Callback, [5, 6]),
-    case apply_post_config_update(Module, Callback, Arity, Ctx) of
+    case erlang:function_exported(Module, Callback, 5) of
+        true ->
+            case apply_post_config_update(Module, Ctx) of
                 ok -> {ok, Result};
                 {ok, Result1} -> {ok, Result#{Module => Result1}};
                 {error, Reason} -> {error, {post_config_update, Module, Reason}}
             end;
+        false ->
+            {ok, Result}
+    end;
 call_proper_post_config_update(
     #{result := Result} = _Ctx
 ) ->
     {ok, Result}.
 
-apply_post_config_update(Module, Callback, 5, #{
+apply_post_config_update(Module, #{
     conf_key_path := ConfKeyPath,
     update_req := UpdateReq,
     new_conf := NewConf,
     old_conf := OldConf,
-    app_envs := AppEnvs
+    app_envs := AppEnvs,
+    callback := Callback
 }) ->
     Module:Callback(
         ConfKeyPath,
@@ -655,25 +589,7 @@ apply_post_config_update(Module, Callback, 5, #{
         NewConf,
         OldConf,
         AppEnvs
-    );
-apply_post_config_update(Module, Callback, 6, #{
-    conf_key_path := ConfKeyPath,
-    update_req := UpdateReq,
-    cluster_rpc_opts := ClusterRpcOpts,
-    new_conf := NewConf,
-    old_conf := OldConf,
-    app_envs := AppEnvs
-}) ->
-    Module:Callback(
-        ConfKeyPath,
-        UpdateReq,
-        NewConf,
-        OldConf,
-        AppEnvs,
-        ClusterRpcOpts
-    );
-apply_post_config_update(_Module, _Callback, false, _Ctx) ->
-    ok.
+    ).
 
 propagate_post_config_updates_to_subconf(
     #{handlers := #{?WKEY := _}} = Ctx
@@ -852,9 +768,7 @@ assert_callback_function(Mod) ->
     _ = apply(Mod, module_info, []),
     case
         erlang:function_exported(Mod, pre_config_update, 3) orelse
-            erlang:function_exported(Mod, post_config_update, 5) orelse
-            erlang:function_exported(Mod, pre_config_update, 4) orelse
-            erlang:function_exported(Mod, post_config_update, 6)
+            erlang:function_exported(Mod, post_config_update, 5)
     of
         true -> ok;
         false -> error(#{msg => "bad_emqx_config_handler_callback", module => Mod})
@@ -897,13 +811,3 @@ load_prev_handlers() ->
 
 save_handlers(Handlers) ->
     application:set_env(emqx, ?MODULE, Handlers).
-
-get_function_arity(_Module, _Callback, []) ->
-    false;
-get_function_arity(Module, Callback, [Arity | Opts]) ->
-    %% ensure module is loaded
-    Module = Module:module_info(module),
-    case erlang:function_exported(Module, Callback, Arity) of
-        true -> Arity;
-        false -> get_function_arity(Module, Callback, Opts)
-    end.

apps/emqx/src/emqx_connection.erl

@@ -158,6 +158,31 @@
 
 -define(ENABLED(X), (X =/= undefined)).
 
+-define(ALARM_TCP_CONGEST(Channel),
+    list_to_binary(
+        io_lib:format(
+            "mqtt_conn/congested/~ts/~ts",
+            [
+                emqx_channel:info(clientid, Channel),
+                emqx_channel:info(username, Channel)
+            ]
+        )
+    )
+).
+
+-define(ALARM_CONN_INFO_KEYS, [
+    socktype,
+    sockname,
+    peername,
+    clientid,
+    username,
+    proto_name,
+    proto_ver,
+    connected_at
+]).
+-define(ALARM_SOCK_STATS_KEYS, [send_pend, recv_cnt, recv_oct, send_cnt, send_oct]).
+-define(ALARM_SOCK_OPTS_KEYS, [high_watermark, high_msgq_watermark, sndbuf, recbuf, buffer]).
+
 -define(LIMITER_BYTES_IN, bytes).
 -define(LIMITER_MESSAGE_IN, messages).
 
@@ -173,9 +198,7 @@
         system_code_change/4
     ]}
 ).
--dialyzer({no_missing_calls, [handle_msg/2]}).
 
--ifndef(BUILD_WITHOUT_QUIC).
 -spec start_link
     (esockd:transport(), esockd:socket(), emqx_channel:opts()) ->
         {ok, pid()};
@@ -185,9 +208,6 @@
         emqx_quic_connection:cb_state()
     ) ->
         {ok, pid()}.
--else.
--spec start_link(esockd:transport(), esockd:socket(), emqx_channel:opts()) -> {ok, pid()}.
--endif.
 
 start_link(Transport, Socket, Options) ->
     Args = [self(), Transport, Socket, Options],
@@ -310,13 +330,11 @@ init_state(
     {ok, Peername} = Transport:ensure_ok_or_exit(peername, [Socket]),
     {ok, Sockname} = Transport:ensure_ok_or_exit(sockname, [Socket]),
     Peercert = Transport:ensure_ok_or_exit(peercert, [Socket]),
-    PeerSNI = Transport:ensure_ok_or_exit(peersni, [Socket]),
     ConnInfo = #{
         socktype => Transport:type(Socket),
         peername => Peername,
         sockname => Sockname,
         peercert => Peercert,
-        peersni => PeerSNI,
         conn_mod => ?MODULE
     },
 
@@ -328,7 +346,7 @@ init_state(
         max_size => emqx_config:get_zone_conf(Zone, [mqtt, max_packet_size])
     },
     ParseState = emqx_frame:initial_parse_state(FrameOpts),
-    Serialize = emqx_frame:initial_serialize_opts(FrameOpts),
+    Serialize = emqx_frame:serialize_opts(),
     %% Init Channel
     Channel = emqx_channel:init(ConnInfo, Opts),
     GcState =
@@ -473,7 +491,8 @@ cancel_stats_timer(State) ->
 process_msg([], State) ->
     {ok, State};
 process_msg([Msg | More], State) ->
-    try handle_msg(Msg, State) of
+    try
+        case handle_msg(Msg, State) of
             ok ->
                 process_msg(More, State);
             {ok, NState} ->
@@ -484,6 +503,7 @@ process_msg([Msg | More], State) ->
                 {stop, Reason, NState};
             {stop, Reason} ->
                 {stop, Reason, State}
+        end
     catch
         exit:normal ->
             {stop, normal, State};
@@ -569,10 +589,12 @@ handle_msg({Closed, _Sock}, State) when
 handle_msg({Passive, _Sock}, State) when
     Passive == tcp_passive; Passive == ssl_passive; Passive =:= quic_passive
 ->
+    %% In Stats
     Pubs = emqx_pd:reset_counter(incoming_pubs),
     Bytes = emqx_pd:reset_counter(incoming_bytes),
+    InStats = #{cnt => Pubs, oct => Bytes},
     %% Run GC and Check OOM
-    NState1 = check_oom(Pubs, Bytes, run_gc(Pubs, Bytes, State)),
+    NState1 = check_oom(run_gc(InStats, State)),
     handle_info(activate_socket, NState1);
 handle_msg(
     Deliver = {deliver, _Topic, _Msg},
@@ -581,6 +603,17 @@ handle_msg(
     ActiveN = get_active_n(Type, Listener),
     Delivers = [Deliver | emqx_utils:drain_deliver(ActiveN)],
     with_channel(handle_deliver, [Delivers], State);
+%% Something sent
+handle_msg({inet_reply, _Sock, ok}, State = #state{listener = {Type, Listener}}) ->
+    case emqx_pd:get_counter(outgoing_pubs) > get_active_n(Type, Listener) of
+        true ->
+            Pubs = emqx_pd:reset_counter(outgoing_pubs),
+            Bytes = emqx_pd:reset_counter(outgoing_bytes),
+            OutStats = #{cnt => Pubs, oct => Bytes},
+            {ok, check_oom(run_gc(OutStats, State))};
+        false ->
+            ok
+    end;
 handle_msg({inet_reply, _Sock, {error, Reason}}, State) ->
     handle_info({sock_error, Reason}, State);
 handle_msg({connack, ConnAck}, State) ->
@@ -696,9 +729,9 @@ handle_call(_From, Req, State = #state{channel = Channel}) ->
             shutdown(Reason, Reply, State#state{channel = NChannel});
         {shutdown, Reason, Reply, OutPacket, NChannel} ->
             NState = State#state{channel = NChannel},
-            {ok, NState2} = handle_outgoing(OutPacket, NState),
-            NState3 = graceful_shutdown_transport(Reason, NState2),
-            shutdown(Reason, Reply, NState3)
+            ok = handle_outgoing(OutPacket, NState),
+            NState2 = graceful_shutdown_transport(Reason, NState),
+            shutdown(Reason, Reply, NState2)
     end.
 
 %%--------------------------------------------------------------------
@@ -732,7 +765,9 @@ handle_timeout(
         disconnected ->
             {ok, State};
         _ ->
-            with_channel(handle_timeout, [TRef, keepalive], State)
+            %% recv_pkt: valid MQTT message
+            RecvCnt = emqx_pd:get_counter(recv_pkt),
+            handle_timeout(TRef, {keepalive, RecvCnt}, State)
     end;
 handle_timeout(TRef, Msg, State) ->
     with_channel(handle_timeout, [TRef, Msg], State).
@@ -783,8 +818,7 @@ parse_incoming(Data, Packets, State = #state{parse_state = ParseState}) ->
                 input_bytes => Data,
                 parsed_packets => Packets
             }),
-            NState = enrich_state(Reason, State),
-            {[{frame_error, Reason} | Packets], NState};
+            {[{frame_error, Reason} | Packets], State};
         error:Reason:Stacktrace ->
             ?LOG(error, #{
                 at_state => emqx_frame:describe_state(ParseState),
@@ -820,8 +854,8 @@ with_channel(Fun, Args, State = #state{channel = Channel}) ->
             shutdown(Reason, State#state{channel = NChannel});
         {shutdown, Reason, Packet, NChannel} ->
             NState = State#state{channel = NChannel},
-            {ok, NState2} = handle_outgoing(Packet, NState),
-            shutdown(Reason, NState2)
+            ok = handle_outgoing(Packet, NState),
+            shutdown(Reason, NState)
     end.
 
 %%--------------------------------------------------------------------
@@ -875,35 +909,20 @@ serialize_and_inc_stats_fun(#state{serialize = Serialize}) ->
 %%--------------------------------------------------------------------
 %% Send data
 
--spec send(iodata(), state()) -> {ok, state()}.
-send(IoData, #state{transport = Transport, socket = Socket} = State) ->
+-spec send(iodata(), state()) -> ok.
+send(IoData, #state{transport = Transport, socket = Socket, channel = Channel}) ->
     Oct = iolist_size(IoData),
-    emqx_metrics:inc('bytes.sent', Oct),
+    ok = emqx_metrics:inc('bytes.sent', Oct),
     inc_counter(outgoing_bytes, Oct),
-    case Transport:send(Socket, IoData) of
+    emqx_congestion:maybe_alarm_conn_congestion(Socket, Transport, Channel),
+    case Transport:async_send(Socket, IoData, []) of
         ok ->
-            %% NOTE: for Transport=emqx_quic_stream, it's actually an
-            %% async_send, sent/1 should technically be called when
-            %% {quic, send_complete, _Stream, true | false} is received,
-            %% but it is handled early for simplicity
-            sent(State);
+            ok;
         Error = {error, _Reason} ->
-            %% Defer error handling
-            %% so it's handled the same as tcp_closed or ssl_closed
+            %% Send an inet_reply to postpone handling the error
+            %% @FIXME: why not just return error?
             self() ! {inet_reply, Socket, Error},
-            {ok, State}
-    end.
-
-%% Some bytes sent
-sent(#state{listener = {Type, Listener}} = State) ->
-    %% Run GC and check OOM after certain amount of messages or bytes sent.
-    case emqx_pd:get_counter(outgoing_pubs) > get_active_n(Type, Listener) of
-        true ->
-            Pubs = emqx_pd:reset_counter(outgoing_pubs),
-            Bytes = emqx_pd:reset_counter(outgoing_bytes),
-            {ok, check_oom(Pubs, Bytes, run_gc(Pubs, Bytes, State))};
-        false ->
-            {ok, State}
+            ok
     end.
 
 %%--------------------------------------------------------------------
@@ -994,23 +1013,17 @@ check_limiter(
     Data,
     WhenOk,
     Msgs,
-    #state{channel = Channel, limiter_timer = undefined, limiter = Limiter} = State
+    #state{limiter_timer = undefined, limiter = Limiter} = State
 ) ->
     case emqx_limiter_container:check_list(Needs, Limiter) of
         {ok, Limiter2} ->
             WhenOk(Data, Msgs, State#state{limiter = Limiter2});
         {pause, Time, Limiter2} ->
-            ?SLOG_THROTTLE(
-                warning,
-                #{
-                    msg => socket_receive_paused_by_rate_limit,
-                    paused_ms => Time
-                },
-                #{
-                    tag => "RATE",
-                    clientid => emqx_channel:info(clientid, Channel)
-                }
-            ),
+            ?SLOG(debug, #{
+                msg => "pause_time_due_to_rate_limit",
+                needs => Needs,
+                time_in_ms => Time
+            }),
 
             Retry = #retry{
                 types = [Type || {_, Type} <- Needs],
@@ -1044,7 +1057,7 @@ check_limiter(
 
 %% try to perform a retry
 -spec retry_limiter(state()) -> _.
-retry_limiter(#state{channel = Channel, limiter = Limiter} = State) ->
+retry_limiter(#state{limiter = Limiter} = State) ->
     #retry{types = Types, data = Data, next = Next} =
         emqx_limiter_container:get_retry_context(Limiter),
     case emqx_limiter_container:retry_list(Types, Limiter) of
@@ -1058,17 +1071,11 @@ retry_limiter(#state{channel = Channel, limiter = Limiter} = State) ->
                 }
             );
         {pause, Time, Limiter2} ->
-            ?SLOG_THROTTLE(
-                warning,
-                #{
-                    msg => socket_receive_paused_by_rate_limit,
-                    paused_ms => Time
-                },
-                #{
-                    tag => "RATE",
-                    clientid => emqx_channel:info(clientid, Channel)
-                }
-            ),
+            ?SLOG(debug, #{
+                msg => "pause_time_due_to_rate_limit",
+                types => Types,
+                time_in_ms => Time
+            }),
 
             TRef = start_timer(Time, limit_timeout),
 
@@ -1081,36 +1088,25 @@ retry_limiter(#state{channel = Channel, limiter = Limiter} = State) ->
 %%--------------------------------------------------------------------
 %% Run GC and Check OOM
 
-run_gc(Pubs, Bytes, State = #state{gc_state = GcSt, zone = Zone}) ->
+run_gc(Stats, State = #state{gc_state = GcSt, zone = Zone}) ->
     case
         ?ENABLED(GcSt) andalso not emqx_olp:backoff_gc(Zone) andalso
-            emqx_gc:run(Pubs, Bytes, GcSt)
+            emqx_gc:run(Stats, GcSt)
     of
         false -> State;
         {_IsGC, GcSt1} -> State#state{gc_state = GcSt1}
     end.
 
-check_oom(Pubs, Bytes, State = #state{channel = Channel}) ->
+check_oom(State = #state{channel = Channel}) ->
     ShutdownPolicy = emqx_config:get_zone_conf(
         emqx_channel:info(zone, Channel), [force_shutdown]
     ),
+    ?tp(debug, check_oom, #{policy => ShutdownPolicy}),
     case emqx_utils:check_oom(ShutdownPolicy) of
         {shutdown, Reason} ->
             %% triggers terminate/2 callback immediately
-            ?tp(warning, check_oom_shutdown, #{
-                policy => ShutdownPolicy,
-                incoming_pubs => Pubs,
-                incoming_bytes => Bytes,
-                shutdown => Reason
-            }),
             erlang:exit({shutdown, Reason});
-        Result ->
-            ?tp(debug, check_oom_ok, #{
-                policy => ShutdownPolicy,
-                incoming_pubs => Pubs,
-                incoming_bytes => Bytes,
-                result => Result
-            }),
+        _ ->
             ok
     end,
     State.
@@ -1228,12 +1224,6 @@ inc_counter(Key, Inc) ->
     _ = emqx_pd:inc_counter(Key, Inc),
     ok.
 
-enrich_state(#{parse_state := NParseState}, State) ->
-    Serialize = emqx_frame:serialize_opts(NParseState),
-    State#state{parse_state = NParseState, serialize = Serialize};
-enrich_state(_, State) ->
-    State.
-
 set_tcp_keepalive({quic, _Listener}) ->
     ok;
 set_tcp_keepalive({Type, Id}) ->

apps/emqx/src/emqx_ds_schema.erl

@@ -18,7 +18,7 @@
 -module(emqx_ds_schema).
 
 %% API:
--export([schema/0, translate_builtin_raft/1, translate_builtin_local/1]).
+-export([schema/0, translate_builtin/1]).
 
 %% Behavior callbacks:
 -export([fields/1, desc/1, namespace/0]).
@@ -32,51 +32,42 @@
 %% Type declarations
 %%================================================================================
 
--ifndef(EMQX_RELEASE_EDITION).
--define(EMQX_RELEASE_EDITION, ce).
--endif.
-
--if(?EMQX_RELEASE_EDITION == ee).
--define(DEFAULT_BACKEND, builtin_raft).
--define(BUILTIN_BACKENDS, [ref(builtin_raft), ref(builtin_local)]).
--else.
--define(DEFAULT_BACKEND, builtin_local).
--define(BUILTIN_BACKENDS, [ref(builtin_local)]).
--endif.
-
 %%================================================================================
 %% API
 %%================================================================================
 
-translate_builtin_raft(
+translate_builtin(
     Backend = #{
-        backend := builtin_raft,
+        backend := builtin,
         n_shards := NShards,
         n_sites := NSites,
         replication_factor := ReplFactor,
         layout := Layout
     }
 ) ->
+    Storage =
+        case Layout of
             #{
-        backend => builtin_raft,
+                type := wildcard_optimized,
+                bits_per_topic_level := BitsPerTopicLevel,
+                epoch_bits := EpochBits,
+                topic_index_bytes := TIBytes
+            } ->
+                {emqx_ds_storage_bitfield_lts, #{
+                    bits_per_topic_level => BitsPerTopicLevel,
+                    topic_index_bytes => TIBytes,
+                    epoch_bits => EpochBits
+                }};
+            #{type := reference} ->
+                {emqx_ds_storage_reference, #{}}
+        end,
+    #{
+        backend => builtin,
         n_shards => NShards,
         n_sites => NSites,
         replication_factor => ReplFactor,
         replication_options => maps:get(replication_options, Backend, #{}),
-        storage => translate_layout(Layout)
-    }.
-
-translate_builtin_local(
-    #{
-        backend := builtin_local,
-        n_shards := NShards,
-        layout := Layout
-    }
-) ->
-    #{
-        backend => builtin_local,
-        n_shards => NShards,
-        storage => translate_layout(Layout)
+        storage => Storage
     }.
 
 %%================================================================================
@@ -92,24 +83,24 @@ schema() ->
             ds_schema(#{
                 default =>
                     #{
-                        <<"backend">> => ?DEFAULT_BACKEND
+                        <<"backend">> => builtin
                     },
                 importance => ?IMPORTANCE_MEDIUM,
                 desc => ?DESC(messages)
             })}
     ].
 
-fields(builtin_local) ->
-    %% Schema for the builtin_raft backend:
+fields(builtin) ->
+    %% Schema for the builtin backend:
     [
         {backend,
             sc(
-                builtin_local,
+                builtin,
                 #{
                     'readOnly' => true,
-                    default => builtin_local,
+                    default => builtin,
                     importance => ?IMPORTANCE_MEDIUM,
-                    desc => ?DESC(backend_type)
+                    desc => ?DESC(builtin_backend)
                 }
             )},
         {'_config_handler',
@@ -117,32 +108,27 @@ fields(builtin_local) ->
                 {module(), atom()},
                 #{
                     'readOnly' => true,
-                    default => {?MODULE, translate_builtin_local},
+                    default => {?MODULE, translate_builtin},
                     importance => ?IMPORTANCE_HIDDEN
                 }
-            )}
-        | common_builtin_fields()
-    ];
-fields(builtin_raft) ->
-    %% Schema for the builtin_raft backend:
-    [
-        {backend,
-            sc(
-                builtin_raft,
-                #{
-                    'readOnly' => true,
-                    default => builtin_raft,
-                    importance => ?IMPORTANCE_MEDIUM,
-                    desc => ?DESC(backend_type)
-                }
             )},
-        {'_config_handler',
+        {data_dir,
             sc(
-                {module(), atom()},
+                string(),
                 #{
-                    'readOnly' => true,
-                    default => {?MODULE, translate_builtin_raft},
-                    importance => ?IMPORTANCE_HIDDEN
+                    mapping => "emqx_durable_storage.db_data_dir",
+                    required => false,
+                    importance => ?IMPORTANCE_MEDIUM,
+                    desc => ?DESC(builtin_data_dir)
+                }
+            )},
+        {n_shards,
+            sc(
+                pos_integer(),
+                #{
+                    default => 12,
+                    importance => ?IMPORTANCE_MEDIUM,
+                    desc => ?DESC(builtin_n_shards)
                 }
             )},
         %% TODO: Deprecate once cluster management and rebalancing is implemented.
@@ -171,10 +157,29 @@ fields(builtin_raft) ->
                     default => #{},
                     importance => ?IMPORTANCE_HIDDEN
                 }
+            )},
+        {local_write_buffer,
+            sc(
+                ref(builtin_local_write_buffer),
+                #{
+                    importance => ?IMPORTANCE_HIDDEN,
+                    desc => ?DESC(builtin_local_write_buffer)
+                }
+            )},
+        {layout,
+            sc(
+                hoconsc:union(builtin_layouts()),
+                #{
+                    desc => ?DESC(builtin_layout),
+                    importance => ?IMPORTANCE_MEDIUM,
+                    default =>
+                        #{
+                            <<"type">> => wildcard_optimized
+                        }
+                }
             )}
-        | common_builtin_fields()
     ];
-fields(builtin_write_buffer) ->
+fields(builtin_local_write_buffer) ->
     [
         {max_items,
             sc(
@@ -183,7 +188,7 @@ fields(builtin_write_buffer) ->
                     default => 1000,
                     mapping => "emqx_durable_storage.egress_batch_size",
                     importance => ?IMPORTANCE_HIDDEN,
-                    desc => ?DESC(builtin_write_buffer_max_items)
+                    desc => ?DESC(builtin_local_write_buffer_max_items)
                 }
             )},
         {flush_interval,
@@ -193,7 +198,7 @@ fields(builtin_write_buffer) ->
                     default => 100,
                     mapping => "emqx_durable_storage.egress_flush_interval",
                     importance => ?IMPORTANCE_HIDDEN,
-                    desc => ?DESC(builtin_write_buffer_flush_interval)
+                    desc => ?DESC(builtin_local_write_buffer_flush_interval)
                 }
             )}
     ];
@@ -234,42 +239,6 @@ fields(layout_builtin_wildcard_optimized) ->
                 }
             )}
     ];
-fields(layout_builtin_wildcard_optimized_v2) ->
-    [
-        {type,
-            sc(
-                wildcard_optimized_v2,
-                #{
-                    'readOnly' => true,
-                    default => wildcard_optimized_v2,
-                    desc => ?DESC(layout_builtin_wildcard_optimized_type)
-                }
-            )},
-        {bytes_per_topic_level,
-            sc(
-                range(1, 16),
-                #{
-                    default => 8,
-                    importance => ?IMPORTANCE_HIDDEN
-                }
-            )},
-        {topic_index_bytes,
-            sc(
-                pos_integer(),
-                #{
-                    default => 8,
-                    importance => ?IMPORTANCE_HIDDEN
-                }
-            )},
-        {serialization_schema,
-            sc(
-                emqx_ds_msg_serializer:schema(),
-                #{
-                    default => v1,
-                    importance => ?IMPORTANCE_HIDDEN
-                }
-            )}
-    ];
 fields(layout_builtin_reference) ->
     [
         {type,
@@ -278,65 +247,17 @@ fields(layout_builtin_reference) ->
                 #{
                     'readOnly' => true,
                     importance => ?IMPORTANCE_LOW,
-                    default => reference,
                     desc => ?DESC(layout_builtin_reference_type)
                 }
             )}
     ].
 
-common_builtin_fields() ->
-    [
-        {data_dir,
-            sc(
-                string(),
-                #{
-                    mapping => "emqx_durable_storage.db_data_dir",
-                    required => false,
-                    importance => ?IMPORTANCE_MEDIUM,
-                    desc => ?DESC(builtin_data_dir)
-                }
-            )},
-        {n_shards,
-            sc(
-                pos_integer(),
-                #{
-                    default => 16,
-                    importance => ?IMPORTANCE_MEDIUM,
-                    desc => ?DESC(builtin_n_shards)
-                }
-            )},
-        {local_write_buffer,
-            sc(
-                ref(builtin_write_buffer),
-                #{
-                    importance => ?IMPORTANCE_HIDDEN,
-                    desc => ?DESC(builtin_write_buffer)
-                }
-            )},
-        {layout,
-            sc(
-                hoconsc:union(builtin_layouts()),
-                #{
-                    desc => ?DESC(builtin_layout),
-                    importance => ?IMPORTANCE_MEDIUM,
-                    default =>
-                        #{
-                            <<"type">> => wildcard_optimized_v2
-                        }
-                }
-            )}
-    ].
-
-desc(builtin_raft) ->
-    ?DESC(builtin_raft);
-desc(builtin_local) ->
-    ?DESC(builtin_local);
-desc(builtin_write_buffer) ->
-    ?DESC(builtin_write_buffer);
+desc(builtin) ->
+    ?DESC(builtin);
+desc(builtin_local_write_buffer) ->
+    ?DESC(builtin_local_write_buffer);
 desc(layout_builtin_wildcard_optimized) ->
     ?DESC(layout_builtin_wildcard_optimized);
-desc(layout_builtin_wildcard_optimized_v2) ->
-    ?DESC(layout_builtin_wildcard_optimized);
 desc(layout_builtin_reference) ->
     ?DESC(layout_builtin_reference);
 desc(_) ->
@@ -346,40 +267,12 @@ desc(_) ->
 %% Internal functions
 %%================================================================================
 
-translate_layout(
-    #{
-        type := wildcard_optimized_v2,
-        bytes_per_topic_level := BytesPerTopicLevel,
-        topic_index_bytes := TopicIndexBytes,
-        serialization_schema := SSchema
-    }
-) ->
-    {emqx_ds_storage_skipstream_lts, #{
-        wildcard_hash_bytes => BytesPerTopicLevel,
-        topic_index_bytes => TopicIndexBytes,
-        serialization_schema => SSchema
-    }};
-translate_layout(
-    #{
-        type := wildcard_optimized,
-        bits_per_topic_level := BitsPerTopicLevel,
-        epoch_bits := EpochBits,
-        topic_index_bytes := TIBytes
-    }
-) ->
-    {emqx_ds_storage_bitfield_lts, #{
-        bits_per_topic_level => BitsPerTopicLevel,
-        topic_index_bytes => TIBytes,
-        epoch_bits => EpochBits
-    }};
-translate_layout(#{type := reference}) ->
-    {emqx_ds_storage_reference, #{}}.
-
 ds_schema(Options) ->
     sc(
-        hoconsc:union(
-            ?BUILTIN_BACKENDS ++ emqx_schema_hooks:injection_point('durable_storage.backends', [])
-        ),
+        hoconsc:union([
+            ref(builtin)
+            | emqx_schema_hooks:injection_point('durable_storage.backends', [])
+        ]),
         Options
     ).
 
@@ -388,11 +281,7 @@ builtin_layouts() ->
     %% suitable for production use. However, it's very simple and
     %% produces a very predictabale replay order, which can be useful
     %% for testing and debugging:
-    [
-        ref(layout_builtin_wildcard_optimized_v2),
-        ref(layout_builtin_wildcard_optimized),
-        ref(layout_builtin_reference)
-    ].
+    [ref(layout_builtin_wildcard_optimized), ref(layout_builtin_reference)].
 
 sc(Type, Meta) -> hoconsc:mk(Type, Meta).
 

apps/emqx/src/emqx_exclusive_subscription.erl

@@ -117,13 +117,6 @@ try_subscribe(ClientId, Topic) ->
                 write
             ),
             allow;
-        [#exclusive_subscription{clientid = ClientId, topic = Topic}] ->
-            %% Fixed the issue-13476
-            %% In this feature, the user must manually call `unsubscribe` to release the lock,
-            %% but sometimes the node may go down for some reason,
-            %% then the client will reconnect to this node and resubscribe.
-            %% We need to allow resubscription, otherwise the lock will never be released.
-            allow;
         [_] ->
             deny
     end.

apps/emqx/src/emqx_external_broker.erl

@@ -1,148 +0,0 @@
-%%--------------------------------------------------------------------
-%% Copyright (c) 2024 EMQ Technologies Co., Ltd. All Rights Reserved.
-%%
-%% Licensed under the Apache License, Version 2.0 (the "License");
-%% you may not use this file except in compliance with the License.
-%% You may obtain a copy of the License at
-%%
-%%     http://www.apache.org/licenses/LICENSE-2.0
-%%
-%% Unless required by applicable law or agreed to in writing, software
-%% distributed under the License is distributed on an "AS IS" BASIS,
-%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-%% See the License for the specific language governing permissions and
-%% limitations under the License.
-%%--------------------------------------------------------------------
-
--module(emqx_external_broker).
-
--callback forward(emqx_types:delivery()) ->
-    emqx_types:publish_result().
-
--callback add_route(emqx_types:topic()) -> ok.
--callback delete_route(emqx_types:topic()) -> ok.
-
--callback add_shared_route(emqx_types:topic(), emqx_types:group()) -> ok.
--callback delete_shared_route(emqx_types:topic(), emqx_types:group()) -> ok.
-
--callback add_persistent_route(emqx_types:topic(), emqx_persistent_session_ds:id()) -> ok.
--callback delete_persistent_route(emqx_types:topic(), emqx_persistent_session_ds:id()) -> ok.
-
--type dest() :: term().
-
--export([
-    %% Registration
-    provider/0,
-    register_provider/1,
-    unregister_provider/1,
-    %% Forwarding
-    forward/1,
-    %% Routing updates
-    add_route/1,
-    delete_route/1,
-    add_shared_route/2,
-    delete_shared_route/2,
-    add_persistent_route/2,
-    delete_persistent_route/2,
-    add_persistent_shared_route/3,
-    delete_persistent_shared_route/3
-]).
-
--export_type([dest/0]).
-
--include("logger.hrl").
-
--define(PROVIDER, {?MODULE, external_broker}).
-
--define(safe_with_provider(IfRegistered, IfNotRegistered),
-    case persistent_term:get(?PROVIDER, undefined) of
-        undefined ->
-            IfNotRegistered;
-        Provider ->
-            try
-                Provider:IfRegistered
-            catch
-                Err:Reason:St ->
-                    ?SLOG_THROTTLE(error, #{
-                        msg => external_broker_crashed,
-                        provider => Provider,
-                        callback => ?FUNCTION_NAME,
-                        stacktrace => St,
-                        error => Err,
-                        reason => Reason
-                    }),
-                    {error, Reason}
-            end
-    end
-).
-
-%% TODO: provider API copied from emqx_external_traces,
-%% but it can be moved to a common module.
-
-%%--------------------------------------------------------------------
-%% Provider API
-%%--------------------------------------------------------------------
-
--spec register_provider(module()) -> ok | {error, term()}.
-register_provider(Module) when is_atom(Module) ->
-    case is_valid_provider(Module) of
-        true ->
-            persistent_term:put(?PROVIDER, Module);
-        false ->
-            {error, invalid_provider}
-    end.
-
--spec unregister_provider(module()) -> ok | {error, term()}.
-unregister_provider(Module) ->
-    case persistent_term:get(?PROVIDER, undefined) of
-        Module ->
-            persistent_term:erase(?PROVIDER),
-            ok;
-        _ ->
-            {error, not_registered}
-    end.
-
--spec provider() -> module() | undefined.
-provider() ->
-    persistent_term:get(?PROVIDER, undefined).
-
-%%--------------------------------------------------------------------
-%% Broker API
-%%--------------------------------------------------------------------
-
-forward(Delivery) ->
-    ?safe_with_provider(?FUNCTION_NAME(Delivery), []).
-
-add_route(Topic) ->
-    ?safe_with_provider(?FUNCTION_NAME(Topic), ok).
-
-delete_route(Topic) ->
-    ?safe_with_provider(?FUNCTION_NAME(Topic), ok).
-
-add_shared_route(Topic, Group) ->
-    ?safe_with_provider(?FUNCTION_NAME(Topic, Group), ok).
-
-delete_shared_route(Topic, Group) ->
-    ?safe_with_provider(?FUNCTION_NAME(Topic, Group), ok).
-
-add_persistent_route(Topic, ID) ->
-    ?safe_with_provider(?FUNCTION_NAME(Topic, ID), ok).
-
-delete_persistent_route(Topic, ID) ->
-    ?safe_with_provider(?FUNCTION_NAME(Topic, ID), ok).
-
-add_persistent_shared_route(Topic, Group, ID) ->
-    ?safe_with_provider(?FUNCTION_NAME(Topic, Group, ID), ok).
-
-delete_persistent_shared_route(Topic, Group, ID) ->
-    ?safe_with_provider(?FUNCTION_NAME(Topic, Group, ID), ok).
-
-%%--------------------------------------------------------------------
-%% Internal functions
-%%--------------------------------------------------------------------
-
-is_valid_provider(Module) ->
-    lists:all(
-        fun({F, A}) -> erlang:function_exported(Module, F, A) end,
-        ?MODULE:behaviour_info(callbacks)
-    ).

apps/emqx/src/emqx_frame.erl

@@ -29,12 +29,11 @@
     parse/2,
     serialize_fun/0,
     serialize_fun/1,
-    initial_serialize_opts/1,
+    serialize_opts/0,
     serialize_opts/1,
     serialize_pkt/2,
     serialize/1,
-    serialize/2,
-    serialize/3
+    serialize/2
 ]).
 
 -export([describe_state/1]).
@@ -85,7 +84,7 @@
 
 -define(MULTIPLIER_MAX, 16#200000).
 
--dialyzer({no_match, [serialize_utf8_string/3]}).
+-dialyzer({no_match, [serialize_utf8_string/2]}).
 
 %% @doc Describe state for logging.
 describe_state(?NONE(_Opts)) ->
@@ -267,76 +266,47 @@ packet(Header, Variable) ->
 packet(Header, Variable, Payload) ->
     #mqtt_packet{header = Header, variable = Variable, payload = Payload}.
 
-parse_connect(FrameBin, Options = #{strict_mode := StrictMode}) ->
-    {ProtoName, Rest0} = parse_utf8_string_with_cause(FrameBin, StrictMode, invalid_proto_name),
-    %% No need to parse and check proto_ver if proto_name is invalid, check it first
-    %% And the matching check of `proto_name` and `proto_ver` fields will be done in `emqx_packet:check_proto_ver/2`
-    _ = validate_proto_name(ProtoName),
-    {IsBridge, ProtoVer, Rest2} = parse_connect_proto_ver(Rest0),
-    NOptions = Options#{version => ProtoVer},
-    try
-        do_parse_connect(ProtoName, IsBridge, ProtoVer, Rest2, StrictMode)
-    catch
-        throw:{?FRAME_PARSE_ERROR, ReasonM} when is_map(ReasonM) ->
-            ?PARSE_ERR(
-                ReasonM#{
-                    proto_ver => ProtoVer,
-                    proto_name => ProtoName,
-                    parse_state => ?NONE(NOptions)
-                }
-            );
-        throw:{?FRAME_PARSE_ERROR, Reason} ->
-            ?PARSE_ERR(
-                #{
-                    cause => Reason,
-                    proto_ver => ProtoVer,
-                    proto_name => ProtoName,
-                    parse_state => ?NONE(NOptions)
-                }
-            )
-    end.
+parse_connect(FrameBin, StrictMode) ->
+    {ProtoName, Rest} = parse_utf8_string_with_cause(FrameBin, StrictMode, invalid_proto_name),
+    case ProtoName of
+        <<"MQTT">> ->
+            ok;
+        <<"MQIsdp">> ->
+            ok;
+        _ ->
+            %% from spec: the server MAY send disconnect with reason code 0x84
+            %% we chose to close socket because the client is likely not talking MQTT anyway
+            ?PARSE_ERR(#{
+                cause => invalid_proto_name,
+                expected => <<"'MQTT' or 'MQIsdp'">>,
+                received => ProtoName
+            })
+    end,
+    parse_connect2(ProtoName, Rest, StrictMode).
 
-do_parse_connect(
+% Note: return malformed if reserved flag is not 0.
+parse_connect2(
     ProtoName,
-    IsBridge,
-    ProtoVer,
-    <<
-        UsernameFlagB:1,
-        PasswordFlagB:1,
-        WillRetainB:1,
-        WillQoS:2,
-        WillFlagB:1,
-        CleanStart:1,
-        Reserved:1,
-        KeepAlive:16/big,
-        Rest/binary
-    >>,
+    <<BridgeTag:4, ProtoVer:4, UsernameFlag:1, PasswordFlag:1, WillRetain:1, WillQoS:2, WillFlag:1,
+        CleanStart:1, Reserved:1, KeepAlive:16/big, Rest2/binary>>,
     StrictMode
 ) ->
-    _ = validate_connect_reserved(Reserved),
-    _ = validate_connect_will(
-        WillFlag = bool(WillFlagB),
-        WillRetain = bool(WillRetainB),
-        WillQoS
-    ),
-    _ = validate_connect_password_flag(
-        StrictMode,
-        ProtoVer,
-        UsernameFlag = bool(UsernameFlagB),
-        PasswordFlag = bool(PasswordFlagB)
-    ),
-    {Properties, Rest3} = parse_properties(Rest, ProtoVer, StrictMode),
+    case Reserved of
+        0 -> ok;
+        1 -> ?PARSE_ERR(reserved_connect_flag)
+    end,
+    {Properties, Rest3} = parse_properties(Rest2, ProtoVer, StrictMode),
     {ClientId, Rest4} = parse_utf8_string_with_cause(Rest3, StrictMode, invalid_clientid),
     ConnPacket = #mqtt_packet_connect{
         proto_name = ProtoName,
         proto_ver = ProtoVer,
         %% For bridge mode, non-standard implementation
         %% Invented by mosquitto, named 'try_private': https://mosquitto.org/man/mosquitto-conf-5.html
-        is_bridge = IsBridge,
+        is_bridge = (BridgeTag =:= 8),
         clean_start = bool(CleanStart),
-        will_flag = WillFlag,
+        will_flag = bool(WillFlag),
         will_qos = WillQoS,
-        will_retain = WillRetain,
+        will_retain = bool(WillRetain),
         keepalive = KeepAlive,
         properties = Properties,
         clientid = ClientId
@@ -347,14 +317,14 @@ do_parse_connect(
         fun(Bin) ->
             parse_utf8_string_with_cause(Bin, StrictMode, invalid_username)
         end,
-        UsernameFlag
+        bool(UsernameFlag)
     ),
     {Password, Rest7} = parse_optional(
         Rest6,
         fun(Bin) ->
             parse_utf8_string_with_cause(Bin, StrictMode, invalid_password)
         end,
-        PasswordFlag
+        bool(PasswordFlag)
     ),
     case Rest7 of
         <<>> ->
@@ -365,16 +335,16 @@ do_parse_connect(
                 unexpected_trailing_bytes => size(Rest7)
             })
     end;
-do_parse_connect(_ProtoName, _IsBridge, _ProtoVer, Bin, _StrictMode) ->
-    %% sent less than 24 bytes
+parse_connect2(_ProtoName, Bin, _StrictMode) ->
+    %% sent less than 32 bytes
     ?PARSE_ERR(#{cause => malformed_connect, header_bytes => Bin}).
 
 parse_packet(
     #mqtt_packet_header{type = ?CONNECT},
     FrameBin,
-    Options
+    #{strict_mode := StrictMode}
 ) ->
-    parse_connect(FrameBin, Options);
+    parse_connect(FrameBin, StrictMode);
 parse_packet(
     #mqtt_packet_header{type = ?CONNACK},
     <<AckFlags:8, ReasonCode:8, Rest/binary>>,
@@ -538,12 +508,6 @@ parse_packet_id(<<PacketId:16/big, Rest/binary>>) ->
 parse_packet_id(_) ->
     ?PARSE_ERR(invalid_packet_id).
 
-parse_connect_proto_ver(<<BridgeTag:4, ProtoVer:4, Rest/binary>>) ->
-    {_IsBridge = (BridgeTag =:= 8), ProtoVer, Rest};
-parse_connect_proto_ver(Bin) ->
-    %% sent less than 1 bytes or empty
-    ?PARSE_ERR(#{cause => malformed_connect, header_bytes => Bin}).
-
 parse_properties(Bin, Ver, _StrictMode) when Ver =/= ?MQTT_PROTO_V5 ->
     {#{}, Bin};
 %% TODO: version mess?
@@ -754,53 +718,43 @@ serialize_fun() -> serialize_fun(?DEFAULT_OPTIONS).
 
 serialize_fun(#mqtt_packet_connect{proto_ver = ProtoVer, properties = ConnProps}) ->
     MaxSize = get_property('Maximum-Packet-Size', ConnProps, ?MAX_PACKET_SIZE),
-    serialize_fun(#{version => ProtoVer, max_size => MaxSize, strict_mode => false});
-serialize_fun(#{version := Ver, max_size := MaxSize, strict_mode := StrictMode}) ->
+    serialize_fun(#{version => ProtoVer, max_size => MaxSize});
+serialize_fun(#{version := Ver, max_size := MaxSize}) ->
     fun(Packet) ->
-        IoData = serialize(Packet, Ver, StrictMode),
+        IoData = serialize(Packet, Ver),
         case is_too_large(IoData, MaxSize) of
             true -> <<>>;
             false -> IoData
         end
     end.
 
-initial_serialize_opts(Opts) ->
-    maps:merge(?DEFAULT_OPTIONS, Opts).
+serialize_opts() ->
+    ?DEFAULT_OPTIONS.
 
-serialize_opts(?NONE(Options)) ->
-    maps:merge(?DEFAULT_OPTIONS, Options);
 serialize_opts(#mqtt_packet_connect{proto_ver = ProtoVer, properties = ConnProps}) ->
     MaxSize = get_property('Maximum-Packet-Size', ConnProps, ?MAX_PACKET_SIZE),
-    #{version => ProtoVer, max_size => MaxSize, strict_mode => false}.
+    #{version => ProtoVer, max_size => MaxSize}.
 
-serialize_pkt(Packet, #{version := Ver, max_size := MaxSize, strict_mode := StrictMode}) ->
-    IoData = serialize(Packet, Ver, StrictMode),
+serialize_pkt(Packet, #{version := Ver, max_size := MaxSize}) ->
+    IoData = serialize(Packet, Ver),
     case is_too_large(IoData, MaxSize) of
         true -> <<>>;
         false -> IoData
     end.
 
 -spec serialize(emqx_types:packet()) -> iodata().
-serialize(Packet) -> serialize(Packet, ?MQTT_PROTO_V4, false).
+serialize(Packet) -> serialize(Packet, ?MQTT_PROTO_V4).
 
-serialize(Packet, Ver) -> serialize(Packet, Ver, false).
-
--spec serialize(emqx_types:packet(), emqx_types:proto_ver(), boolean()) -> iodata().
+-spec serialize(emqx_types:packet(), emqx_types:proto_ver()) -> iodata().
 serialize(
     #mqtt_packet{
         header = Header,
         variable = Variable,
         payload = Payload
     },
-    Ver,
-    StrictMode
+    Ver
 ) ->
-    serialize(
-        Header,
-        serialize_variable(Variable, Ver, StrictMode),
-        serialize_payload(Payload),
-        StrictMode
-    ).
+    serialize(Header, serialize_variable(Variable, Ver), serialize_payload(Payload)).
 
 serialize(
     #mqtt_packet_header{
@@ -810,8 +764,7 @@ serialize(
         retain = Retain
     },
     VariableBin,
-    PayloadBin,
-    _StrictMode
+    PayloadBin
 ) when
     ?CONNECT =< Type andalso Type =< ?AUTH
 ->
@@ -843,8 +796,7 @@ serialize_variable(
         username = Username,
         password = Password
     },
-    _Ver,
-    StrictMode
+    _Ver
 ) ->
     [
         serialize_binary_data(ProtoName),
@@ -862,20 +814,20 @@ serialize_variable(
             0:1,
             KeepAlive:16/big-unsigned-integer
         >>,
-        serialize_properties(Properties, ProtoVer, StrictMode),
-        serialize_utf8_string(ClientId, StrictMode),
+        serialize_properties(Properties, ProtoVer),
+        serialize_utf8_string(ClientId),
         case WillFlag of
             true ->
                 [
-                    serialize_properties(WillProps, ProtoVer, StrictMode),
-                    serialize_utf8_string(WillTopic, StrictMode),
+                    serialize_properties(WillProps, ProtoVer),
+                    serialize_utf8_string(WillTopic),
                     serialize_binary_data(WillPayload)
                 ];
             false ->
                 <<>>
         end,
-        serialize_utf8_string(Username, true, StrictMode),
-        serialize_utf8_string(Password, true, StrictMode)
+        serialize_utf8_string(Username, true),
+        serialize_utf8_string(Password, true)
     ];
 serialize_variable(
     #mqtt_packet_connack{
@@ -883,28 +835,26 @@ serialize_variable(
         reason_code = ReasonCode,
         properties = Properties
     },
-    Ver,
-    StrictMode
+    Ver
 ) ->
-    [AckFlags, ReasonCode, serialize_properties(Properties, Ver, StrictMode)];
+    [AckFlags, ReasonCode, serialize_properties(Properties, Ver)];
 serialize_variable(
     #mqtt_packet_publish{
         topic_name = TopicName,
         packet_id = PacketId,
         properties = Properties
     },
-    Ver,
-    StrictMode
+    Ver
 ) ->
     [
-        serialize_utf8_string(TopicName, StrictMode),
+        serialize_utf8_string(TopicName),
         case PacketId of
             undefined -> <<>>;
             _ -> <<PacketId:16/big-unsigned-integer>>
         end,
-        serialize_properties(Properties, Ver, StrictMode)
+        serialize_properties(Properties, Ver)
     ];
-serialize_variable(#mqtt_packet_puback{packet_id = PacketId}, Ver, _StrictMode) when
+serialize_variable(#mqtt_packet_puback{packet_id = PacketId}, Ver) when
     Ver == ?MQTT_PROTO_V3; Ver == ?MQTT_PROTO_V4
 ->
     <<PacketId:16/big-unsigned-integer>>;
@@ -914,13 +864,12 @@ serialize_variable(
         reason_code = ReasonCode,
         properties = Properties
     },
-    Ver = ?MQTT_PROTO_V5,
-    StrictMode
+    Ver = ?MQTT_PROTO_V5
 ) ->
     [
         <<PacketId:16/big-unsigned-integer>>,
         ReasonCode,
-        serialize_properties(Properties, Ver, StrictMode)
+        serialize_properties(Properties, Ver)
     ];
 serialize_variable(
     #mqtt_packet_subscribe{
@@ -928,13 +877,12 @@ serialize_variable(
         properties = Properties,
         topic_filters = TopicFilters
     },
-    Ver,
-    StrictMode
+    Ver
 ) ->
     [
         <<PacketId:16/big-unsigned-integer>>,
-        serialize_properties(Properties, Ver, StrictMode),
-        serialize_topic_filters(subscribe, TopicFilters, Ver, StrictMode)
+        serialize_properties(Properties, Ver),
+        serialize_topic_filters(subscribe, TopicFilters, Ver)
     ];
 serialize_variable(
     #mqtt_packet_suback{
@@ -942,12 +890,11 @@ serialize_variable(
         properties = Properties,
         reason_codes = ReasonCodes
     },
-    Ver,
-    StrictMode
+    Ver
 ) ->
     [
         <<PacketId:16/big-unsigned-integer>>,
-        serialize_properties(Properties, Ver, StrictMode),
+        serialize_properties(Properties, Ver),
         serialize_reason_codes(ReasonCodes)
     ];
 serialize_variable(
@@ -956,13 +903,12 @@ serialize_variable(
         properties = Properties,
         topic_filters = TopicFilters
     },
-    Ver,
-    StrictMode
+    Ver
 ) ->
     [
         <<PacketId:16/big-unsigned-integer>>,
-        serialize_properties(Properties, Ver, StrictMode),
-        serialize_topic_filters(unsubscribe, TopicFilters, Ver, StrictMode)
+        serialize_properties(Properties, Ver),
+        serialize_topic_filters(unsubscribe, TopicFilters, Ver)
     ];
 serialize_variable(
     #mqtt_packet_unsuback{
@@ -970,15 +916,14 @@ serialize_variable(
         properties = Properties,
         reason_codes = ReasonCodes
     },
-    Ver,
-    StrictMode
+    Ver
 ) ->
     [
         <<PacketId:16/big-unsigned-integer>>,
-        serialize_properties(Properties, Ver, StrictMode),
+        serialize_properties(Properties, Ver),
         serialize_reason_codes(ReasonCodes)
     ];
-serialize_variable(#mqtt_packet_disconnect{}, Ver, _StrictMode) when
+serialize_variable(#mqtt_packet_disconnect{}, Ver) when
     Ver == ?MQTT_PROTO_V3; Ver == ?MQTT_PROTO_V4
 ->
     <<>>;
@@ -987,115 +932,110 @@ serialize_variable(
         reason_code = ReasonCode,
         properties = Properties
     },
-    Ver = ?MQTT_PROTO_V5,
-    StrictMode
+    Ver = ?MQTT_PROTO_V5
 ) ->
-    [ReasonCode, serialize_properties(Properties, Ver, StrictMode)];
-serialize_variable(#mqtt_packet_disconnect{}, _Ver, _StrictMode) ->
+    [ReasonCode, serialize_properties(Properties, Ver)];
+serialize_variable(#mqtt_packet_disconnect{}, _Ver) ->
     <<>>;
 serialize_variable(
     #mqtt_packet_auth{
         reason_code = ReasonCode,
         properties = Properties
     },
-    Ver = ?MQTT_PROTO_V5,
-    StrictMode
+    Ver = ?MQTT_PROTO_V5
 ) ->
-    [ReasonCode, serialize_properties(Properties, Ver, StrictMode)];
-serialize_variable(PacketId, ?MQTT_PROTO_V3, _StrictMode) when is_integer(PacketId) ->
+    [ReasonCode, serialize_properties(Properties, Ver)];
+serialize_variable(PacketId, ?MQTT_PROTO_V3) when is_integer(PacketId) ->
     <<PacketId:16/big-unsigned-integer>>;
-serialize_variable(PacketId, ?MQTT_PROTO_V4, _StrictMode) when is_integer(PacketId) ->
+serialize_variable(PacketId, ?MQTT_PROTO_V4) when is_integer(PacketId) ->
     <<PacketId:16/big-unsigned-integer>>;
-serialize_variable(undefined, _Ver, _StrictMode) ->
+serialize_variable(undefined, _Ver) ->
     <<>>.
 
 serialize_payload(undefined) -> <<>>;
 serialize_payload(Bin) -> Bin.
 
-serialize_properties(_Props, Ver, _StrictMode) when Ver =/= ?MQTT_PROTO_V5 ->
+serialize_properties(_Props, Ver) when Ver =/= ?MQTT_PROTO_V5 ->
     <<>>;
-serialize_properties(Props, ?MQTT_PROTO_V5, StrictMode) ->
-    serialize_properties(Props, StrictMode).
+serialize_properties(Props, ?MQTT_PROTO_V5) ->
+    serialize_properties(Props).
 
-serialize_properties(undefined, _StrictMode) ->
+serialize_properties(undefined) ->
     <<0>>;
-serialize_properties(Props, _StrictMode) when map_size(Props) == 0 ->
+serialize_properties(Props) when map_size(Props) == 0 ->
     <<0>>;
-serialize_properties(Props, StrictMode) when is_map(Props) ->
-    Bin = <<
-        <<(serialize_property(Prop, Val, StrictMode))/binary>>
-     || {Prop, Val} <- maps:to_list(Props)
-    >>,
+serialize_properties(Props) when is_map(Props) ->
+    Bin = <<<<(serialize_property(Prop, Val))/binary>> || {Prop, Val} <- maps:to_list(Props)>>,
     [serialize_variable_byte_integer(byte_size(Bin)), Bin].
 
-serialize_property(_, Disabled, _StrictMode) when Disabled =:= disabled; Disabled =:= undefined ->
+serialize_property(_, Disabled) when Disabled =:= disabled; Disabled =:= undefined ->
     <<>>;
-serialize_property(internal_extra, _, _StrictMode) ->
+serialize_property(internal_extra, _) ->
     <<>>;
-serialize_property('Payload-Format-Indicator', Val, _StrictMode) ->
+serialize_property('Payload-Format-Indicator', Val) ->
     <<16#01, Val>>;
-serialize_property('Message-Expiry-Interval', Val, _StrictMode) ->
+serialize_property('Message-Expiry-Interval', Val) ->
     <<16#02, Val:32/big>>;
-serialize_property('Content-Type', Val, StrictMode) ->
-    <<16#03, (serialize_utf8_string(Val, StrictMode))/binary>>;
-serialize_property('Response-Topic', Val, StrictMode) ->
-    <<16#08, (serialize_utf8_string(Val, StrictMode))/binary>>;
-serialize_property('Correlation-Data', Val, _StrictMode) ->
+serialize_property('Content-Type', Val) ->
+    <<16#03, (serialize_utf8_string(Val))/binary>>;
+serialize_property('Response-Topic', Val) ->
+    <<16#08, (serialize_utf8_string(Val))/binary>>;
+serialize_property('Correlation-Data', Val) ->
     <<16#09, (byte_size(Val)):16, Val/binary>>;
-serialize_property('Subscription-Identifier', Val, _StrictMode) ->
+serialize_property('Subscription-Identifier', Val) ->
     <<16#0B, (serialize_variable_byte_integer(Val))/binary>>;
-serialize_property('Session-Expiry-Interval', Val, _StrictMode) ->
+serialize_property('Session-Expiry-Interval', Val) ->
     <<16#11, Val:32/big>>;
-serialize_property('Assigned-Client-Identifier', Val, StrictMode) ->
-    <<16#12, (serialize_utf8_string(Val, StrictMode))/binary>>;
-serialize_property('Server-Keep-Alive', Val, _StrictMode) ->
+serialize_property('Assigned-Client-Identifier', Val) ->
+    <<16#12, (serialize_utf8_string(Val))/binary>>;
+serialize_property('Server-Keep-Alive', Val) ->
     <<16#13, Val:16/big>>;
-serialize_property('Authentication-Method', Val, StrictMode) ->
-    <<16#15, (serialize_utf8_string(Val, StrictMode))/binary>>;
-serialize_property('Authentication-Data', Val, _StrictMode) ->
+serialize_property('Authentication-Method', Val) ->
+    <<16#15, (serialize_utf8_string(Val))/binary>>;
+serialize_property('Authentication-Data', Val) ->
     <<16#16, (iolist_size(Val)):16, Val/binary>>;
-serialize_property('Request-Problem-Information', Val, _StrictMode) ->
+serialize_property('Request-Problem-Information', Val) ->
     <<16#17, Val>>;
-serialize_property('Will-Delay-Interval', Val, _StrictMode) ->
+serialize_property('Will-Delay-Interval', Val) ->
     <<16#18, Val:32/big>>;
-serialize_property('Request-Response-Information', Val, _StrictMode) ->
+serialize_property('Request-Response-Information', Val) ->
     <<16#19, Val>>;
-serialize_property('Response-Information', Val, StrictMode) ->
-    <<16#1A, (serialize_utf8_string(Val, StrictMode))/binary>>;
-serialize_property('Server-Reference', Val, StrictMode) ->
-    <<16#1C, (serialize_utf8_string(Val, StrictMode))/binary>>;
-serialize_property('Reason-String', Val, StrictMode) ->
-    <<16#1F, (serialize_utf8_string(Val, StrictMode))/binary>>;
-serialize_property('Receive-Maximum', Val, _StrictMode) ->
+serialize_property('Response-Information', Val) ->
+    <<16#1A, (serialize_utf8_string(Val))/binary>>;
+serialize_property('Server-Reference', Val) ->
+    <<16#1C, (serialize_utf8_string(Val))/binary>>;
+serialize_property('Reason-String', Val) ->
+    <<16#1F, (serialize_utf8_string(Val))/binary>>;
+serialize_property('Receive-Maximum', Val) ->
     <<16#21, Val:16/big>>;
-serialize_property('Topic-Alias-Maximum', Val, _StrictMode) ->
+serialize_property('Topic-Alias-Maximum', Val) ->
     <<16#22, Val:16/big>>;
-serialize_property('Topic-Alias', Val, _StrictMode) ->
+serialize_property('Topic-Alias', Val) ->
     <<16#23, Val:16/big>>;
-serialize_property('Maximum-QoS', Val, _StrictMode) ->
+serialize_property('Maximum-QoS', Val) ->
     <<16#24, Val>>;
-serialize_property('Retain-Available', Val, _StrictMode) ->
+serialize_property('Retain-Available', Val) ->
     <<16#25, Val>>;
-serialize_property('User-Property', {Key, Val}, StrictMode) ->
-    <<16#26, (serialize_utf8_pair(Key, Val, StrictMode))/binary>>;
-serialize_property('User-Property', Props, StrictMode) when is_list(Props) ->
+serialize_property('User-Property', {Key, Val}) ->
+    <<16#26, (serialize_utf8_pair({Key, Val}))/binary>>;
+serialize_property('User-Property', Props) when is_list(Props) ->
     <<
-        <<(serialize_property('User-Property', {Key, Val}, StrictMode))/binary>>
+        <<(serialize_property('User-Property', {Key, Val}))/binary>>
      || {Key, Val} <- Props
     >>;
-serialize_property('Maximum-Packet-Size', Val, _StrictMode) ->
+serialize_property('Maximum-Packet-Size', Val) ->
     <<16#27, Val:32/big>>;
-serialize_property('Wildcard-Subscription-Available', Val, _StrictMode) ->
+serialize_property('Wildcard-Subscription-Available', Val) ->
     <<16#28, Val>>;
-serialize_property('Subscription-Identifier-Available', Val, _StrictMode) ->
+serialize_property('Subscription-Identifier-Available', Val) ->
     <<16#29, Val>>;
-serialize_property('Shared-Subscription-Available', Val, _StrictMode) ->
+serialize_property('Shared-Subscription-Available', Val) ->
     <<16#2A, Val>>.
 
-serialize_topic_filters(subscribe, TopicFilters, ?MQTT_PROTO_V5, StrictMode) ->
+serialize_topic_filters(subscribe, TopicFilters, ?MQTT_PROTO_V5) ->
     <<
         <<
-            (serialize_utf8_string(Topic, StrictMode))/binary,
+            (serialize_utf8_string(Topic))/binary,
             ?RESERVED:2,
             Rh:2,
             (flag(Rap)):1,
@@ -1104,42 +1044,37 @@ serialize_topic_filters(subscribe, TopicFilters, ?MQTT_PROTO_V5, StrictMode) ->
         >>
      || {Topic, #{rh := Rh, rap := Rap, nl := Nl, qos := QoS}} <- TopicFilters
     >>;
-serialize_topic_filters(subscribe, TopicFilters, _Ver, StrictMode) ->
+serialize_topic_filters(subscribe, TopicFilters, _Ver) ->
     <<
-        <<(serialize_utf8_string(Topic, StrictMode))/binary, ?RESERVED:6, QoS:2>>
+        <<(serialize_utf8_string(Topic))/binary, ?RESERVED:6, QoS:2>>
      || {Topic, #{qos := QoS}} <- TopicFilters
     >>;
-serialize_topic_filters(unsubscribe, TopicFilters, _Ver, StrictMode) ->
-    <<<<(serialize_utf8_string(Topic, StrictMode))/binary>> || Topic <- TopicFilters>>.
+serialize_topic_filters(unsubscribe, TopicFilters, _Ver) ->
+    <<<<(serialize_utf8_string(Topic))/binary>> || Topic <- TopicFilters>>.
 
 serialize_reason_codes(undefined) ->
     <<>>;
 serialize_reason_codes(ReasonCodes) when is_list(ReasonCodes) ->
     <<<<Code>> || Code <- ReasonCodes>>.
 
-serialize_utf8_pair(Name, Value, StrictMode) ->
-    <<
-        (serialize_utf8_string(Name, StrictMode))/binary,
-        (serialize_utf8_string(Value, StrictMode))/binary
-    >>.
+serialize_utf8_pair({Name, Value}) ->
+    <<(serialize_utf8_string(Name))/binary, (serialize_utf8_string(Value))/binary>>.
 
 serialize_binary_data(Bin) ->
     [<<(byte_size(Bin)):16/big-unsigned-integer>>, Bin].
 
-serialize_utf8_string(undefined, false, _StrictMode) ->
+serialize_utf8_string(undefined, false) ->
     ?SERIALIZE_ERR(utf8_string_undefined);
-serialize_utf8_string(undefined, true, _StrictMode) ->
+serialize_utf8_string(undefined, true) ->
     <<>>;
-serialize_utf8_string(String, _AllowNull, StrictMode) ->
-    serialize_utf8_string(String, StrictMode).
+serialize_utf8_string(String, _AllowNull) ->
+    serialize_utf8_string(String).
 
-serialize_utf8_string(String, true) ->
+serialize_utf8_string(String) ->
     StringBin = unicode:characters_to_binary(String),
-    serialize_utf8_string(StringBin, false);
-serialize_utf8_string(String, false) ->
-    Len = byte_size(String),
+    Len = byte_size(StringBin),
     true = (Len =< 16#ffff),
-    <<Len:16/big, String/binary>>.
+    <<Len:16/big, StringBin/binary>>.
 
 serialize_remaining_len(I) ->
     serialize_variable_byte_integer(I).
@@ -1187,49 +1122,6 @@ validate_subqos([3 | _]) -> ?PARSE_ERR(bad_subqos);
 validate_subqos([_ | T]) -> validate_subqos(T);
 validate_subqos([]) -> ok.
 
-%% from spec: the server MAY send disconnect with reason code 0x84
-%% we chose to close socket because the client is likely not talking MQTT anyway
-validate_proto_name(<<"MQTT">>) ->
-    ok;
-validate_proto_name(<<"MQIsdp">>) ->
-    ok;
-validate_proto_name(ProtoName) ->
-    ?PARSE_ERR(#{
-        cause => invalid_proto_name,
-        expected => <<"'MQTT' or 'MQIsdp'">>,
-        received => ProtoName
-    }).
-
-%% MQTT-v3.1.1-[MQTT-3.1.2-3], MQTT-v5.0-[MQTT-3.1.2-3]
--compile({inline, [validate_connect_reserved/1]}).
-validate_connect_reserved(0) -> ok;
-validate_connect_reserved(1) -> ?PARSE_ERR(reserved_connect_flag).
-
--compile({inline, [validate_connect_will/3]}).
-%% MQTT-v3.1.1-[MQTT-3.1.2-13], MQTT-v5.0-[MQTT-3.1.2-11]
-validate_connect_will(false, _, WillQoS) when WillQoS > 0 -> ?PARSE_ERR(invalid_will_qos);
-%% MQTT-v3.1.1-[MQTT-3.1.2-14], MQTT-v5.0-[MQTT-3.1.2-12]
-validate_connect_will(true, _, WillQoS) when WillQoS > 2 -> ?PARSE_ERR(invalid_will_qos);
-%% MQTT-v3.1.1-[MQTT-3.1.2-15], MQTT-v5.0-[MQTT-3.1.2-13]
-validate_connect_will(false, WillRetain, _) when WillRetain -> ?PARSE_ERR(invalid_will_retain);
-validate_connect_will(_, _, _) -> ok.
-
--compile({inline, [validate_connect_password_flag/4]}).
-%% MQTT-v3.1
-%% Username flag and password flag are not strongly related
-%% https://public.dhe.ibm.com/software/dw/webservices/ws-mqtt/mqtt-v3r1.html#connect
-validate_connect_password_flag(true, ?MQTT_PROTO_V3, _, _) ->
-    ok;
-%% MQTT-v3.1.1-[MQTT-3.1.2-22]
-validate_connect_password_flag(true, ?MQTT_PROTO_V4, UsernameFlag, PasswordFlag) ->
-    %% BUG-FOR-BUG compatible, only check when `strict-mode`
-    UsernameFlag orelse PasswordFlag andalso ?PARSE_ERR(invalid_password_flag);
-validate_connect_password_flag(true, ?MQTT_PROTO_V5, _, _) ->
-    ok;
-validate_connect_password_flag(_, _, _, _) ->
-    ok.
-
--compile({inline, [bool/1]}).
 bool(0) -> false;
 bool(1) -> true.
 

apps/emqx/src/emqx_gc.erl

@@ -30,6 +30,7 @@
 
 -export([
     init/1,
+    run/2,
     run/3,
     info/1,
     reset/1
@@ -61,7 +62,12 @@ init(#{count := Count, bytes := Bytes}) ->
     Oct = [{oct, {Bytes, Bytes}} || ?ENABLED(Bytes)],
     ?GCS(maps:from_list(Cnt ++ Oct)).
 
-%% @doc Try to run GC based on reductions of count or bytes.
+%% @doc Try to run GC based on reduntions of count or bytes.
+-spec run(#{cnt := pos_integer(), oct := pos_integer()}, gc_state()) ->
+    {boolean(), gc_state()}.
+run(#{cnt := Cnt, oct := Oct}, GcSt) ->
+    run(Cnt, Oct, GcSt).
+
 -spec run(pos_integer(), pos_integer(), gc_state()) ->
     {boolean(), gc_state()}.
 run(Cnt, Oct, ?GCS(St)) ->

apps/emqx/src/emqx_hookpoints.erl

@@ -44,7 +44,6 @@
     'client.disconnected',
     'client.authorize',
     'client.check_authz_complete',
-    'client.check_authn_complete',
     'client.authenticate',
     'client.subscribe',
     'client.unsubscribe',
@@ -60,7 +59,6 @@
     'message.publish',
     'message.puback',
     'message.dropped',
-    'message.transformation_failed',
     'schema.validation_failed',
     'message.delivered',
     'message.acked',

apps/emqx/src/emqx_keepalive.erl

@@ -19,12 +19,10 @@
 -export([
     init/1,
     init/2,
-    init/3,
     info/1,
     info/2,
-    check/1,
     check/2,
-    update/3
+    update/2
 ]).
 
 -elvis([{elvis_style, no_if_expression, disable}]).
@@ -32,12 +30,8 @@
 -export_type([keepalive/0]).
 
 -record(keepalive, {
-    check_interval :: pos_integer(),
-    %% the received packets since last keepalive check
-    statval :: non_neg_integer(),
-    %% The number of idle intervals allowed before disconnecting the client.
-    idle_milliseconds = 0 :: non_neg_integer(),
-    max_idle_millisecond :: pos_integer()
+    interval :: pos_integer(),
+    statval :: non_neg_integer()
 }).
 
 -opaque keepalive() :: #keepalive{}.
@@ -45,11 +39,7 @@
 
 %% @doc Init keepalive.
 -spec init(Interval :: non_neg_integer()) -> keepalive().
-init(Interval) -> init(default, 0, Interval).
-
-init(Zone, Interval) ->
-    RecvCnt = emqx_pd:get_counter(recv_pkt),
-    init(Zone, RecvCnt, Interval).
+init(Interval) -> init(0, Interval).
 
 %% from mqtt-v3.1.1 specific
 %% A Keep Alive value of zero (0) has the effect of turning off the keep alive mechanism.
@@ -63,88 +53,42 @@ init(Zone, Interval) ->
 %% typically this is a few minutes.
 %% The maximum value is (65535s) 18 hours 12 minutes and 15 seconds.
 %% @doc Init keepalive.
--spec init(
-    Zone :: atom(),
-    StatVal :: non_neg_integer(),
-    Second :: non_neg_integer()
-) -> keepalive() | undefined.
-init(Zone, StatVal, Second) when Second > 0 andalso Second =< ?MAX_INTERVAL ->
-    #{keepalive_multiplier := Mul, keepalive_check_interval := CheckInterval} =
-        emqx_config:get_zone_conf(Zone, [mqtt]),
-    MilliSeconds = timer:seconds(Second),
-    Interval = emqx_utils:clamp(CheckInterval, 1000, max(MilliSeconds div 2, 1000)),
-    MaxIdleMs = ceil(MilliSeconds * Mul),
-    #keepalive{
-        check_interval = Interval,
-        statval = StatVal,
-        idle_milliseconds = 0,
-        max_idle_millisecond = MaxIdleMs
-    };
-init(_Zone, _, 0) ->
+-spec init(StatVal :: non_neg_integer(), Interval :: non_neg_integer()) -> keepalive() | undefined.
+init(StatVal, Interval) when Interval > 0 andalso Interval =< ?MAX_INTERVAL ->
+    #keepalive{interval = Interval, statval = StatVal};
+init(_, 0) ->
     undefined;
-init(Zone, StatVal, Interval) when Interval > ?MAX_INTERVAL -> init(Zone, StatVal, ?MAX_INTERVAL).
+init(StatVal, Interval) when Interval > ?MAX_INTERVAL -> init(StatVal, ?MAX_INTERVAL).
 
 %% @doc Get Info of the keepalive.
 -spec info(keepalive()) -> emqx_types:infos().
 info(#keepalive{
-    check_interval = Interval,
-    statval = StatVal,
-    idle_milliseconds = IdleIntervals,
-    max_idle_millisecond = MaxMs
+    interval = Interval,
+    statval = StatVal
 }) ->
     #{
-        check_interval => Interval,
-        statval => StatVal,
-        idle_milliseconds => IdleIntervals,
-        max_idle_millisecond => MaxMs
+        interval => Interval,
+        statval => StatVal
     }.
 
--spec info(check_interval | statval | idle_milliseconds, keepalive()) ->
+-spec info(interval | statval, keepalive()) ->
     non_neg_integer().
-info(check_interval, #keepalive{check_interval = Interval}) ->
+info(interval, #keepalive{interval = Interval}) ->
     Interval;
 info(statval, #keepalive{statval = StatVal}) ->
     StatVal;
-info(idle_milliseconds, #keepalive{idle_milliseconds = Val}) ->
-    Val;
-info(check_interval, undefined) ->
+info(interval, undefined) ->
     0.
 
-check(Keepalive = #keepalive{}) ->
-    RecvCnt = emqx_pd:get_counter(recv_pkt),
-    check(RecvCnt, Keepalive);
-check(Keepalive) ->
-    {ok, Keepalive}.
-
 %% @doc Check keepalive.
 -spec check(non_neg_integer(), keepalive()) ->
     {ok, keepalive()} | {error, timeout}.
-
-check(
-    NewVal,
-    #keepalive{
-        statval = NewVal,
-        idle_milliseconds = IdleAcc,
-        check_interval = Interval,
-        max_idle_millisecond = Max
-    }
-) when IdleAcc + Interval >= Max ->
-    {error, timeout};
-check(
-    NewVal,
-    #keepalive{
-        statval = NewVal,
-        idle_milliseconds = IdleAcc,
-        check_interval = Interval
-    } = KeepAlive
-) ->
-    {ok, KeepAlive#keepalive{statval = NewVal, idle_milliseconds = IdleAcc + Interval}};
-check(NewVal, #keepalive{} = KeepAlive) ->
-    {ok, KeepAlive#keepalive{statval = NewVal, idle_milliseconds = 0}}.
+check(Val, #keepalive{statval = Val}) -> {error, timeout};
+check(Val, KeepAlive) -> {ok, KeepAlive#keepalive{statval = Val}}.
 
 %% @doc Update keepalive.
 %% The statval of the previous keepalive will be used,
 %% and normal checks will begin from the next cycle.
--spec update(atom(), non_neg_integer(), keepalive() | undefined) -> keepalive() | undefined.
-update(Zone, Interval, undefined) -> init(Zone, 0, Interval);
-update(Zone, Interval, #keepalive{statval = StatVal}) -> init(Zone, StatVal, Interval).
+-spec update(non_neg_integer(), keepalive() | undefined) -> keepalive() | undefined.
+update(Interval, undefined) -> init(0, Interval);
+update(Interval, #keepalive{statval = StatVal}) -> init(StatVal, Interval).

apps/emqx/src/emqx_limiter/src/emqx_limiter_schema.erl

@@ -212,29 +212,16 @@ short_paths_fields() ->
 short_paths_fields(Importance) ->
     [
         {Name,
-            ?HOCON(
-                rate_type(),
-                maps:merge(
-                    #{
+            ?HOCON(rate_type(), #{
                 desc => ?DESC(Name),
                 required => false,
                 importance => Importance,
                 example => Example
-                    },
-                    short_paths_fields_extra(Name)
-                )
-            )}
+            })}
      || {Name, Example} <-
             lists:zip(short_paths(), [<<"1000/s">>, <<"1000/s">>, <<"100MB/s">>])
     ].
 
-short_paths_fields_extra(max_conn_rate) ->
-    #{
-        default => infinity
-    };
-short_paths_fields_extra(_Name) ->
-    #{}.
-
 desc(limiter) ->
     "Settings for the rate limiter.";
 desc(node_opts) ->

apps/emqx/src/emqx_listeners.erl

@@ -64,17 +64,6 @@
 
 -export_type([listener_id/0]).
 
--dialyzer(
-    {no_unknown, [
-        is_running/3,
-        current_conns/3,
-        do_stop_listener/3,
-        do_start_listener/4,
-        do_update_listener/4,
-        quic_listener_conf_rollback/3
-    ]}
-).
-
 -type listener_id() :: atom() | binary().
 -type listener_type() :: tcp | ssl | ws | wss | quic | dtls.
 
@@ -432,7 +421,7 @@ do_start_listener(Type, Name, Id, #{bind := ListenOn} = Opts) when ?ESOCKD_LISTE
     esockd:open(
         Id,
         ListenOn,
-        merge_default(esockd_opts(Id, Type, Name, Opts, _OldOpts = undefined))
+        merge_default(esockd_opts(Id, Type, Name, Opts))
     );
 %% Start MQTT/WS listener
 do_start_listener(Type, Name, Id, Opts) when ?COWBOY_LISTENER(Type) ->
@@ -476,7 +465,7 @@ do_update_listener(Type, Name, OldConf, NewConf = #{bind := ListenOn}) when
     Id = listener_id(Type, Name),
     case maps:get(bind, OldConf) of
         ListenOn ->
-            esockd:set_options({Id, ListenOn}, esockd_opts(Id, Type, Name, NewConf, OldConf));
+            esockd:set_options({Id, ListenOn}, esockd_opts(Id, Type, Name, NewConf));
         _Different ->
             %% TODO
             %% Again, we're not strictly required to drop live connections in this case.
@@ -588,7 +577,7 @@ perform_listener_change(update, {{Type, Name, ConfOld}, {_, _, ConfNew}}) ->
 perform_listener_change(stop, {Type, Name, Conf}) ->
     stop_listener(Type, Name, Conf).
 
-esockd_opts(ListenerId, Type, Name, Opts0, OldOpts) ->
+esockd_opts(ListenerId, Type, Name, Opts0) ->
     Opts1 = maps:with([acceptors, max_connections, proxy_protocol, proxy_protocol_timeout], Opts0),
     Limiter = limiter(Opts0),
     Opts2 =
@@ -620,11 +609,9 @@ esockd_opts(ListenerId, Type, Name, Opts0, OldOpts) ->
             tcp ->
                 Opts3#{tcp_options => tcp_opts(Opts0)};
             ssl ->
-                OptsWithCRL = inject_crl_config(Opts0, OldOpts),
+                OptsWithCRL = inject_crl_config(Opts0),
                 OptsWithSNI = inject_sni_fun(ListenerId, OptsWithCRL),
-                OptsWithRootFun = inject_root_fun(OptsWithSNI),
-                OptsWithVerifyFun = inject_verify_fun(OptsWithRootFun),
-                SSLOpts = ssl_opts(OptsWithVerifyFun),
+                SSLOpts = ssl_opts(OptsWithSNI),
                 Opts3#{ssl_options => SSLOpts, tcp_options => tcp_opts(Opts0)}
         end
     ).
@@ -648,18 +635,8 @@ ranch_opts(Type, Opts = #{bind := ListenOn}) ->
     MaxConnections = maps:get(max_connections, Opts, 1024),
     SocketOpts =
         case Type of
-            wss ->
-                tcp_opts(Opts) ++
-                    lists:filter(
-                        fun
-                            ({partial_chain, _}) -> false;
-                            ({handshake_timeout, _}) -> false;
-                            (_) -> true
-                        end,
-                        ssl_opts(Opts)
-                    );
-            ws ->
-                tcp_opts(Opts)
+            wss -> tcp_opts(Opts) ++ proplists:delete(handshake_timeout, ssl_opts(Opts));
+            ws -> tcp_opts(Opts)
         end,
     #{
         num_acceptors => NumAcceptors,
@@ -985,18 +962,13 @@ quic_listener_optional_settings() ->
         stateless_operation_expiration_ms
     ].
 
-inject_root_fun(#{ssl_options := SSLOpts} = Opts) ->
-    Opts#{ssl_options := emqx_tls_lib:maybe_inject_ssl_fun(root_fun, SSLOpts)}.
-inject_verify_fun(#{ssl_options := SSLOpts} = Opts) ->
-    Opts#{ssl_options := emqx_tls_lib:maybe_inject_ssl_fun(verify_fun, SSLOpts)}.
-
 inject_sni_fun(ListenerId, Conf = #{ssl_options := #{ocsp := #{enable_ocsp_stapling := true}}}) ->
     emqx_ocsp_cache:inject_sni_fun(ListenerId, Conf);
 inject_sni_fun(_ListenerId, Conf) ->
     Conf.
 
 inject_crl_config(
-    Conf = #{ssl_options := #{enable_crl_check := true} = SSLOpts}, _OldOpts
+    Conf = #{ssl_options := #{enable_crl_check := true} = SSLOpts}
 ) ->
     HTTPTimeout = emqx_config:get([crl_cache, http_timeout], timer:seconds(15)),
     Conf#{
@@ -1006,16 +978,7 @@ inject_crl_config(
             crl_cache => {emqx_ssl_crl_cache, {internal, [{http, HTTPTimeout}]}}
         }
     };
-inject_crl_config(#{ssl_options := SSLOpts0} = Conf0, #{} = OldOpts) ->
-    %% Note: we must set crl options to `undefined' to unset them.  Otherwise,
-    %% `esockd' will retain such options when `esockd:merge_opts/2' is called and the SSL
-    %% options were previously enabled.
-    WasEnabled = emqx_utils_maps:deep_get([ssl_options, enable_crl_check], OldOpts, false),
-    Undefine = fun(Acc, K) -> emqx_utils_maps:put_if(Acc, K, undefined, WasEnabled) end,
-    SSLOpts1 = Undefine(SSLOpts0, crl_check),
-    SSLOpts = Undefine(SSLOpts1, crl_cache),
-    Conf0#{ssl_options := SSLOpts};
-inject_crl_config(Conf, undefined = _OldOpts) ->
+inject_crl_config(Conf) ->
     Conf.
 
 maybe_unregister_ocsp_stapling_refresh(
@@ -1038,6 +1001,7 @@ ensure_max_conns(<<"infinity">>) -> <<"infinity">>;
 ensure_max_conns(MaxConn) when is_binary(MaxConn) -> binary_to_integer(MaxConn);
 ensure_max_conns(MaxConn) -> MaxConn.
 
+-spec quic_listen_on(X :: any()) -> quicer:listen_on().
 quic_listen_on(Bind) ->
     case Bind of
         {Addr, Port} when tuple_size(Addr) == 4 ->

apps/emqx/src/emqx_log_throttler.erl

@@ -25,7 +25,7 @@
 -export([start_link/0]).
 
 %% throttler API
--export([allow/2]).
+-export([allow/1]).
 
 %% gen_server callbacks
 -export([
@@ -40,29 +40,23 @@
 -define(SEQ_ID(Msg), {?MODULE, Msg}).
 -define(NEW_SEQ, atomics:new(1, [{signed, false}])).
 -define(GET_SEQ(Msg), persistent_term:get(?SEQ_ID(Msg), undefined)).
--define(ERASE_SEQ(Msg), persistent_term:erase(?SEQ_ID(Msg))).
 -define(RESET_SEQ(SeqRef), atomics:put(SeqRef, 1, 0)).
 -define(INC_SEQ(SeqRef), atomics:add(SeqRef, 1, 1)).
 -define(GET_DROPPED(SeqRef), atomics:get(SeqRef, 1) - 1).
 -define(IS_ALLOWED(SeqRef), atomics:add_get(SeqRef, 1, 1) =:= 1).
 
+-define(NEW_THROTTLE(Msg, SeqRef), persistent_term:put(?SEQ_ID(Msg), SeqRef)).
+
 -define(MSGS_LIST, emqx:get_config([log, throttling, msgs], [])).
 -define(TIME_WINDOW_MS, timer:seconds(emqx:get_config([log, throttling, time_window], 60))).
 
-%% @doc Check if a throttled log message is allowed to pass down to the logger this time.
-%% The Msg has to be an atom, and the second argument `UniqueKey' should be `undefined'
-%% for predefined message IDs.
-%% For relatively static resources created from configurations such as data integration
-%% resource IDs `UniqueKey' should be of `binary()' type.
--spec allow(atom(), undefined | binary()) -> boolean().
-allow(Msg, UniqueKey) when
-    is_atom(Msg) andalso (is_binary(UniqueKey) orelse UniqueKey =:= undefined)
-->
+-spec allow(atom()) -> boolean().
+allow(Msg) when is_atom(Msg) ->
     case emqx_logger:get_primary_log_level() of
         debug ->
             true;
         _ ->
-            do_allow(Msg, UniqueKey)
+            do_allow(Msg)
     end.
 
 -spec start_link() -> startlink_ret().
@@ -74,8 +68,7 @@ start_link() ->
 %%--------------------------------------------------------------------
 
 init([]) ->
-    process_flag(trap_exit, true),
-    ok = lists:foreach(fun new_throttler/1, ?MSGS_LIST),
+    ok = lists:foreach(fun(Msg) -> ?NEW_THROTTLE(Msg, ?NEW_SEQ) end, ?MSGS_LIST),
     CurrentPeriodMs = ?TIME_WINDOW_MS,
     TimerRef = schedule_refresh(CurrentPeriodMs),
     {ok, #{timer_ref => TimerRef, current_period_ms => CurrentPeriodMs}}.
@@ -93,22 +86,16 @@ handle_info(refresh, #{current_period_ms := PeriodMs} = State) ->
     DroppedStats = lists:foldl(
         fun(Msg, Acc) ->
             case ?GET_SEQ(Msg) of
-                undefined ->
                 %% Should not happen, unless the static ids list is updated at run-time.
-                    new_throttler(Msg),
+                undefined ->
+                    ?NEW_THROTTLE(Msg, ?NEW_SEQ),
                     ?tp(log_throttler_new_msg, #{throttled_msg => Msg}),
                     Acc;
-                SeqMap when is_map(SeqMap) ->
-                    maps:fold(
-                        fun(Key, Ref, Acc0) ->
-                            ID = iolist_to_binary([atom_to_binary(Msg), $:, Key]),
-                            drop_stats(Ref, ID, Acc0)
-                        end,
-                        Acc,
-                        SeqMap
-                    );
                 SeqRef ->
-                    drop_stats(SeqRef, Msg, Acc)
+                    Dropped = ?GET_DROPPED(SeqRef),
+                    ok = ?RESET_SEQ(SeqRef),
+                    ?tp(log_throttler_dropped, #{dropped_count => Dropped, throttled_msg => Msg}),
+                    maybe_add_dropped(Msg, Dropped, Acc)
             end
         end,
         #{},
@@ -125,16 +112,7 @@ handle_info(Info, State) ->
     ?SLOG(error, #{msg => "unxpected_info", info => Info}),
     {noreply, State}.
 
-drop_stats(SeqRef, Msg, Acc) ->
-    Dropped = ?GET_DROPPED(SeqRef),
-    ok = ?RESET_SEQ(SeqRef),
-    ?tp(log_throttler_dropped, #{dropped_count => Dropped, throttled_msg => Msg}),
-    maybe_add_dropped(Msg, Dropped, Acc).
-
 terminate(_Reason, _State) ->
-    %% atomics do not have delete/remove/release/deallocate API
-    %% after the reference is garbage-collected the resource is released
-    lists:foreach(fun(Msg) -> ?ERASE_SEQ(Msg) end, ?MSGS_LIST),
     ok.
 
 code_change(_OldVsn, State, _Extra) ->
@@ -144,27 +122,17 @@ code_change(_OldVsn, State, _Extra) ->
 %% internal functions
 %%--------------------------------------------------------------------
 
-do_allow(Msg, UniqueKey) ->
+do_allow(Msg) ->
     case persistent_term:get(?SEQ_ID(Msg), undefined) of
         undefined ->
             %% This is either a race condition (emqx_log_throttler is not started yet)
             %% or a developer mistake (msg used in ?SLOG_THROTTLE/2,3 macro is
             %% not added to the default value of `log.throttling.msgs`.
-            ?SLOG(debug, #{
-                msg => "log_throttle_disabled",
+            ?SLOG(info, #{
+                msg => "missing_log_throttle_sequence",
                 throttled_msg => Msg
             }),
             true;
-        %% e.g: unrecoverable msg throttle according resource_id
-        SeqMap when is_map(SeqMap) ->
-            case maps:find(UniqueKey, SeqMap) of
-                {ok, SeqRef} ->
-                    ?IS_ALLOWED(SeqRef);
-                error ->
-                    SeqRef = ?NEW_SEQ,
-                    new_throttler(Msg, SeqMap#{UniqueKey => SeqRef}),
-                    true
-            end;
         SeqRef ->
             ?IS_ALLOWED(SeqRef)
     end.
@@ -186,11 +154,3 @@ maybe_log_dropped(_DroppedStats, _PeriodMs) ->
 schedule_refresh(PeriodMs) ->
     ?tp(log_throttler_sched_refresh, #{new_period_ms => PeriodMs}),
     erlang:send_after(PeriodMs, ?MODULE, refresh).
-
-new_throttler(unrecoverable_resource_error = Msg) ->
-    new_throttler(Msg, #{});
-new_throttler(Msg) ->
-    new_throttler(Msg, ?NEW_SEQ).
-
-new_throttler(Msg, AtomicOrEmptyMap) ->
-    persistent_term:put(?SEQ_ID(Msg), AtomicOrEmptyMap).

apps/emqx/src/emqx_logger_jsonfmt.erl

@@ -55,8 +55,7 @@
     depth => pos_integer() | unlimited,
     report_cb => logger:report_cb(),
     single_line => boolean(),
-    chars_limit => unlimited | pos_integer(),
-    payload_encode => text | hidden | hex
+    chars_limit => unlimited | pos_integer()
 }.
 
 -define(IS_STRING(String), (is_list(String) orelse is_binary(String))).
@@ -104,8 +103,7 @@ format(Msg, Meta, Config) ->
 
 maybe_format_msg(undefined, _Meta, _Config) ->
     #{};
-maybe_format_msg({report, Report0} = Msg, #{report_cb := Cb} = Meta, Config) ->
-    Report = emqx_logger_textfmt:try_encode_meta(Report0, Config),
+maybe_format_msg({report, Report} = Msg, #{report_cb := Cb} = Meta, Config) ->
     case is_map(Report) andalso Cb =:= ?DEFAULT_FORMATTER of
         true ->
             %% reporting a map without a customised format function
@@ -272,8 +270,6 @@ json(L, Config) when is_list(L) ->
     end;
 json(Map, Config) when is_map(Map) ->
     best_effort_json_obj(Map, Config);
-json({'$array$', List}, Config) when is_list(List) ->
-    [json(I, Config) || I <- List];
 json(Term, Config) ->
     do_format_msg("~p", [Term], Config).
 
@@ -294,7 +290,6 @@ json_obj_root(Data0, Config) ->
             _ ->
                 json(Msg1, Config)
         end,
-    MFA = emqx_utils:format_mfal(Data0, Config),
     Data =
         maps:fold(
             fun(K, V, D) ->
@@ -303,12 +298,12 @@ json_obj_root(Data0, Config) ->
             end,
             [],
             maps:without(
-                [time, gl, file, report_cb, msg, '$kind', level, mfa, is_trace], Data0
+                [time, gl, file, report_cb, msg, '$kind', level, is_trace], Data0
             )
         ),
     lists:filter(
         fun({_, V}) -> V =/= undefined end,
-        [{time, format_ts(Time, Config)}, {level, Level}, {msg, Msg}, {mfa, MFA}]
+        [{time, format_ts(Time, Config)}, {level, Level}, {msg, Msg}]
     ) ++ Data.
 
 format_ts(Ts, #{timestamp_format := rfc3339, time_offset := Offset}) when is_integer(Ts) ->
@@ -453,36 +448,6 @@ best_effort_json_test() ->
         <<"[\n  {\n    \"key\" : [\n      \n    ]\n  }\n]">>,
         best_effort_json([#{key => []}])
     ),
-    %% List is IO Data
-    ?assertMatch(
-        #{<<"what">> := <<"hej\n">>},
-        emqx_utils_json:decode(emqx_logger_jsonfmt:best_effort_json(#{what => [<<"hej">>, 10]}))
-    ),
-    %% Force list to be interpreted as an array
-    ?assertMatch(
-        #{<<"what">> := [<<"hej">>, 10]},
-        emqx_utils_json:decode(
-            emqx_logger_jsonfmt:best_effort_json(#{what => {'$array$', [<<"hej">>, 10]}})
-        )
-    ),
-    %% IO Data inside an array
-    ?assertMatch(
-        #{<<"what">> := [<<"hej">>, 10, <<"hej\n">>]},
-        emqx_utils_json:decode(
-            emqx_logger_jsonfmt:best_effort_json(#{
-                what => {'$array$', [<<"hej">>, 10, [<<"hej">>, 10]]}
-            })
-        )
-    ),
-    %% Array inside an array
-    ?assertMatch(
-        #{<<"what">> := [<<"hej">>, 10, [<<"hej">>, 10]]},
-        emqx_utils_json:decode(
-            emqx_logger_jsonfmt:best_effort_json(#{
-                what => {'$array$', [<<"hej">>, 10, {'$array$', [<<"hej">>, 10]}]}
-            })
-        )
-    ),
     ok.
 
 config() ->

apps/emqx/src/emqx_logger_textfmt.erl

@@ -20,12 +20,11 @@
 
 -export([format/2]).
 -export([check_config/1]).
--export([try_format_unicode/1, try_encode_meta/2]).
+-export([try_format_unicode/1]).
 %% Used in the other log formatters
 -export([evaluate_lazy_values_if_dbg_level/1, evaluate_lazy_values/1]).
 
-check_config(X) ->
-    logger_formatter:check_config(maps:without([timestamp_format, with_mfa, payload_encode], X)).
+check_config(X) -> logger_formatter:check_config(maps:without([timestamp_format], X)).
 
 %% Principle here is to delegate the formatting to logger_formatter:format/2
 %% as much as possible, and only enrich the report with clientid, peername, topic, username
@@ -33,7 +32,7 @@ format(#{msg := {report, ReportMap0}, meta := _Meta} = Event0, Config) when is_m
     #{msg := {report, ReportMap}, meta := Meta} = Event = evaluate_lazy_values_if_dbg_level(Event0),
     %% The most common case, when entering from SLOG macro
     %% i.e. logger:log(Level, #{msg => "my_msg", foo => bar})
-    ReportList = enrich_report(ReportMap, Meta, Config),
+    ReportList = enrich_report(ReportMap, Meta),
     Report =
         case is_list_report_acceptable(Meta) of
             true ->
@@ -41,24 +40,18 @@ format(#{msg := {report, ReportMap0}, meta := _Meta} = Event0, Config) when is_m
             false ->
                 maps:from_list(ReportList)
         end,
-    fmt(Event#{msg := {report, Report}}, maps:remove(with_mfa, Config));
+    fmt(Event#{msg := {report, Report}}, Config);
 format(#{msg := {string, String}} = Event, Config) ->
     %% copied from logger_formatter:format/2
     %% unsure how this case is triggered
-    format(Event#{msg => {"~ts ", [String]}}, maps:remove(with_mfa, Config));
+    format(Event#{msg => {"~ts ", [String]}}, Config);
 format(#{msg := _Msg, meta := _Meta} = Event0, Config) ->
     #{msg := Msg0, meta := Meta} = Event1 = evaluate_lazy_values_if_dbg_level(Event0),
     %% For format strings like logger:log(Level, "~p", [Var])
     %% and logger:log(Level, "message", #{key => value})
     Msg1 = enrich_client_info(Msg0, Meta),
-    Msg2 = enrich_mfa(Msg1, Meta, Config),
-    Msg3 = enrich_topic(Msg2, Meta),
-    fmt(Event1#{msg := Msg3}, maps:remove(with_mfa, Config)).
-
-enrich_mfa({Fmt, Args}, Data, #{with_mfa := true} = Config) when is_list(Fmt) ->
-    {Fmt ++ " mfa: ~ts", Args ++ [emqx_utils:format_mfal(Data, Config)]};
-enrich_mfa(Msg, _, _) ->
-    Msg.
+    Msg2 = enrich_topic(Msg1, Meta),
+    fmt(Event1#{msg := Msg2}, Config).
 
 %% Most log entries with lazy values are trace events with level debug. So to
 %% be more efficient we only search for lazy values to evaluate in the entries
@@ -108,10 +101,9 @@ is_list_report_acceptable(#{report_cb := Cb}) ->
 is_list_report_acceptable(_) ->
     false.
 
-enrich_report(ReportRaw0, Meta, Config) ->
+enrich_report(ReportRaw, Meta) ->
     %% clientid and peername always in emqx_conn's process metadata.
     %% topic and username can be put in meta using ?SLOG/3, or put in msg's report by ?SLOG/2
-    ReportRaw = try_encode_meta(ReportRaw0, Config),
     Topic =
         case maps:get(topic, Meta, undefined) of
             undefined -> maps:get(topic, ReportRaw, undefined);
@@ -125,7 +117,6 @@ enrich_report(ReportRaw0, Meta, Config) ->
     ClientId = maps:get(clientid, Meta, undefined),
     Peer = maps:get(peername, Meta, undefined),
     Msg = maps:get(msg, ReportRaw, undefined),
-    MFA = emqx_utils:format_mfal(Meta, Config),
     %% TODO: move all tags to Meta so we can filter traces
     %% based on tags (currently not supported)
     Tag = maps:get(tag, ReportRaw, maps:get(tag, Meta, undefined)),
@@ -140,7 +131,6 @@ enrich_report(ReportRaw0, Meta, Config) ->
             {topic, try_format_unicode(Topic)},
             {username, try_format_unicode(Username)},
             {peername, Peer},
-            {mfa, try_format_unicode(MFA)},
             {msg, Msg},
             {clientid, try_format_unicode(ClientId)},
             {tag, Tag}
@@ -179,29 +169,3 @@ enrich_topic({Fmt, Args}, #{topic := Topic}) when is_list(Fmt) ->
     {" topic: ~ts" ++ Fmt, [Topic | Args]};
 enrich_topic(Msg, _) ->
     Msg.
-
-try_encode_meta(Report, Config) ->
-    lists:foldl(
-        fun(Meta, Acc) ->
-            try_encode_meta(Meta, Acc, Config)
-        end,
-        Report,
-        [payload, packet]
-    ).
-
-try_encode_meta(payload, #{payload := Payload} = Report, #{payload_encode := Encode}) ->
-    Report#{payload := encode_payload(Payload, Encode)};
-try_encode_meta(packet, #{packet := Packet} = Report, #{payload_encode := Encode}) when
-    is_tuple(Packet)
-->
-    Report#{packet := emqx_packet:format(Packet, Encode)};
-try_encode_meta(_, Report, _Config) ->
-    Report.
-
-encode_payload(Payload, text) ->
-    Payload;
-encode_payload(_Payload, hidden) ->
-    "******";
-encode_payload(Payload, hex) ->
-    Bin = emqx_utils_conv:bin(Payload),
-    binary:encode_hex(Bin).

apps/emqx/src/emqx_metrics.erl

@@ -22,7 +22,6 @@
 -include("logger.hrl").
 -include("types.hrl").
 -include("emqx_mqtt.hrl").
--include("emqx_metrics.hrl").
 
 -export([
     start_link/0,
@@ -87,8 +86,206 @@
 -define(TAB, ?MODULE).
 -define(SERVER, ?MODULE).
 
+%% Bytes sent and received
+-define(BYTES_METRICS,
+    % Total bytes received
+    [
+        {counter, 'bytes.received'},
+        % Total bytes sent
+        {counter, 'bytes.sent'}
+    ]
+).
+
+%% Packets sent and received
+-define(PACKET_METRICS,
+    % All Packets received
+    [
+        {counter, 'packets.received'},
+        % All Packets sent
+        {counter, 'packets.sent'},
+        % CONNECT Packets received
+        {counter, 'packets.connect.received'},
+        % CONNACK Packets sent
+        {counter, 'packets.connack.sent'},
+        % CONNACK error sent
+        {counter, 'packets.connack.error'},
+        % CONNACK auth_error sent
+        {counter, 'packets.connack.auth_error'},
+        % PUBLISH packets received
+        {counter, 'packets.publish.received'},
+        % PUBLISH packets sent
+        {counter, 'packets.publish.sent'},
+        % PUBLISH packet_id inuse
+        {counter, 'packets.publish.inuse'},
+        % PUBLISH failed for error
+        {counter, 'packets.publish.error'},
+        % PUBLISH failed for auth error
+        {counter, 'packets.publish.auth_error'},
+        % PUBLISH(QoS2) packets dropped
+        {counter, 'packets.publish.dropped'},
+        % PUBACK packets received
+        {counter, 'packets.puback.received'},
+        % PUBACK packets sent
+        {counter, 'packets.puback.sent'},
+        % PUBACK packet_id inuse
+        {counter, 'packets.puback.inuse'},
+        % PUBACK packets missed
+        {counter, 'packets.puback.missed'},
+        % PUBREC packets received
+        {counter, 'packets.pubrec.received'},
+        % PUBREC packets sent
+        {counter, 'packets.pubrec.sent'},
+        % PUBREC packet_id inuse
+        {counter, 'packets.pubrec.inuse'},
+        % PUBREC packets missed
+        {counter, 'packets.pubrec.missed'},
+        % PUBREL packets received
+        {counter, 'packets.pubrel.received'},
+        % PUBREL packets sent
+        {counter, 'packets.pubrel.sent'},
+        % PUBREL packets missed
+        {counter, 'packets.pubrel.missed'},
+        % PUBCOMP packets received
+        {counter, 'packets.pubcomp.received'},
+        % PUBCOMP packets sent
+        {counter, 'packets.pubcomp.sent'},
+        % PUBCOMP packet_id inuse
+        {counter, 'packets.pubcomp.inuse'},
+        % PUBCOMP packets missed
+        {counter, 'packets.pubcomp.missed'},
+        % SUBSCRIBE Packets received
+        {counter, 'packets.subscribe.received'},
+        % SUBSCRIBE error
+        {counter, 'packets.subscribe.error'},
+        % SUBSCRIBE failed for not auth
+        {counter, 'packets.subscribe.auth_error'},
+        % SUBACK packets sent
+        {counter, 'packets.suback.sent'},
+        % UNSUBSCRIBE Packets received
+        {counter, 'packets.unsubscribe.received'},
+        % UNSUBSCRIBE error
+        {counter, 'packets.unsubscribe.error'},
+        % UNSUBACK Packets sent
+        {counter, 'packets.unsuback.sent'},
+        % PINGREQ packets received
+        {counter, 'packets.pingreq.received'},
+        % PINGRESP Packets sent
+        {counter, 'packets.pingresp.sent'},
+        % DISCONNECT Packets received
+        {counter, 'packets.disconnect.received'},
+        % DISCONNECT Packets sent
+        {counter, 'packets.disconnect.sent'},
+        % Auth Packets received
+        {counter, 'packets.auth.received'},
+        % Auth Packets sent
+        {counter, 'packets.auth.sent'}
+    ]
+).
+
+%% Messages sent/received and pubsub
+-define(MESSAGE_METRICS,
+    % All Messages received
+    [
+        {counter, 'messages.received'},
+        % All Messages sent
+        {counter, 'messages.sent'},
+        % QoS0 Messages received
+        {counter, 'messages.qos0.received'},
+        % QoS0 Messages sent
+        {counter, 'messages.qos0.sent'},
+        % QoS1 Messages received
+        {counter, 'messages.qos1.received'},
+        % QoS1 Messages sent
+        {counter, 'messages.qos1.sent'},
+        % QoS2 Messages received
+        {counter, 'messages.qos2.received'},
+        % QoS2 Messages sent
+        {counter, 'messages.qos2.sent'},
+        %% PubSub Metrics
+
+        % Messages Publish
+        {counter, 'messages.publish'},
+        % Messages dropped due to no subscribers
+        {counter, 'messages.dropped'},
+        %% % Messages that failed validations
+        {counter, 'messages.validation_failed'},
+        %% % Messages that passed validations
+        {counter, 'messages.validation_succeeded'},
+        % QoS2 Messages expired
+        {counter, 'messages.dropped.await_pubrel_timeout'},
+        % Messages dropped
+        {counter, 'messages.dropped.no_subscribers'},
+        % Messages forward
+        {counter, 'messages.forward'},
+        % Messages delayed
+        {counter, 'messages.delayed'},
+        % Messages delivered
+        {counter, 'messages.delivered'},
+        % Messages acked
+        {counter, 'messages.acked'},
+        % Messages persistently stored
+        {counter, 'messages.persisted'}
+    ]
+).
+
+%% Delivery metrics
+-define(DELIVERY_METRICS, [
+    {counter, 'delivery.dropped'},
+    {counter, 'delivery.dropped.no_local'},
+    {counter, 'delivery.dropped.too_large'},
+    {counter, 'delivery.dropped.qos0_msg'},
+    {counter, 'delivery.dropped.queue_full'},
+    {counter, 'delivery.dropped.expired'}
+]).
+
+%% Client Lifecircle metrics
+-define(CLIENT_METRICS, [
+    {counter, 'client.connect'},
+    {counter, 'client.connack'},
+    {counter, 'client.connected'},
+    {counter, 'client.authenticate'},
+    {counter, 'client.auth.anonymous'},
+    {counter, 'client.authorize'},
+    {counter, 'client.subscribe'},
+    {counter, 'client.unsubscribe'},
+    {counter, 'client.disconnected'}
+]).
+
+%% Session Lifecircle metrics
+-define(SESSION_METRICS, [
+    {counter, 'session.created'},
+    {counter, 'session.resumed'},
+    {counter, 'session.takenover'},
+    {counter, 'session.discarded'},
+    {counter, 'session.terminated'}
+]).
+
+%% Statistic metrics for ACL checking
+-define(STASTS_ACL_METRICS, [
+    {counter, 'authorization.allow'},
+    {counter, 'authorization.deny'},
+    {counter, 'authorization.cache_hit'},
+    {counter, 'authorization.cache_miss'}
+]).
+
+%% Statistic metrics for auth checking
+-define(STASTS_AUTHN_METRICS, [
+    {counter, 'authentication.success'},
+    {counter, 'authentication.success.anonymous'},
+    {counter, 'authentication.failure'}
+]).
+
+%% Overload protection counters
+-define(OLP_METRICS, [
+    {counter, 'overload_protection.delay.ok'},
+    {counter, 'overload_protection.delay.timeout'},
+    {counter, 'overload_protection.hibernation'},
+    {counter, 'overload_protection.gc'},
+    {counter, 'overload_protection.new_conn'}
+]).
+
 olp_metrics() ->
-    lists:map(fun({_, Metric, _}) -> Metric end, ?OLP_METRICS).
+    lists:map(fun({_, Metric}) -> Metric end, ?OLP_METRICS).
 
 -record(state, {next_idx = 1}).
 
@@ -369,7 +566,7 @@ init([]) ->
     ]),
     % Store reserved indices
     ok = lists:foreach(
-        fun({Type, Name, _Desc}) ->
+        fun({Type, Name}) ->
             Idx = reserved_idx(Name),
             Metric = #metric{name = Name, type = Type, idx = Idx},
             true = ets:insert(?TAB, Metric),
@@ -487,7 +684,7 @@ reserved_idx('messages.forward') -> 112;
 reserved_idx('messages.delayed') -> 114;
 reserved_idx('messages.delivered') -> 115;
 reserved_idx('messages.acked') -> 116;
-%% reserved_idx('delivery.expired') -> 117; %% have never used
+reserved_idx('delivery.expired') -> 117;
 reserved_idx('delivery.dropped') -> 118;
 reserved_idx('delivery.dropped.no_local') -> 119;
 reserved_idx('delivery.dropped.too_large') -> 120;
@@ -498,7 +695,7 @@ reserved_idx('client.connect') -> 200;
 reserved_idx('client.connack') -> 201;
 reserved_idx('client.connected') -> 202;
 reserved_idx('client.authenticate') -> 203;
-%% reserved_idx('client.enhanced_authenticate') -> 204; %% have never used
+reserved_idx('client.enhanced_authenticate') -> 204;
 reserved_idx('client.auth.anonymous') -> 205;
 reserved_idx('client.authorize') -> 206;
 reserved_idx('client.subscribe') -> 207;
@@ -524,6 +721,4 @@ reserved_idx('overload_protection.new_conn') -> 404;
 reserved_idx('messages.validation_succeeded') -> 405;
 reserved_idx('messages.validation_failed') -> 406;
 reserved_idx('messages.persisted') -> 407;
-reserved_idx('messages.transformation_succeeded') -> 408;
-reserved_idx('messages.transformation_failed') -> 409;
 reserved_idx(_) -> undefined.

apps/emqx/src/emqx_packet.erl

@@ -51,6 +51,7 @@
 ]).
 
 -export([
+    format/1,
     format/2
 ]).
 
@@ -480,6 +481,10 @@ will_msg(#mqtt_packet_connect{
         headers = #{username => Username, properties => Props}
     }.
 
+%% @doc Format packet
+-spec format(emqx_types:packet()) -> iolist().
+format(Packet) -> format(Packet, emqx_trace_handler:payload_encode()).
+
 %% @doc Format packet
 -spec format(emqx_types:packet(), hex | text | hidden) -> iolist().
 format(#mqtt_packet{header = Header, variable = Variable, payload = Payload}, PayloadEncode) ->

apps/emqx/src/emqx_passwd.erl

@@ -102,11 +102,7 @@ hash({SimpleHash, _Salt, disable}, Password) when is_binary(Password) ->
 hash({SimpleHash, Salt, prefix}, Password) when is_binary(Password), is_binary(Salt) ->
     hash_data(SimpleHash, <<Salt/binary, Password/binary>>);
 hash({SimpleHash, Salt, suffix}, Password) when is_binary(Password), is_binary(Salt) ->
-    hash_data(SimpleHash, <<Password/binary, Salt/binary>>);
-hash({_SimpleHash, Salt, _SaltPos}, _Password) when not is_binary(Salt) ->
-    error({salt_not_string, Salt});
-hash({_SimpleHash, _Salt, _SaltPos}, Password) when not is_binary(Password) ->
-    error({password_not_string, Password}).
+    hash_data(SimpleHash, <<Password/binary, Salt/binary>>).
 
 -spec hash_data(hash_type(), binary()) -> binary().
 hash_data(plain, Data) when is_binary(Data) ->

apps/emqx/src/emqx_persistent_message_ds_gc_worker.erl

@@ -21,7 +21,7 @@
 -include_lib("stdlib/include/qlc.hrl").
 -include_lib("stdlib/include/ms_transform.hrl").
 
--include("session_internals.hrl").
+-include("emqx_persistent_session_ds.hrl").
 
 %% API
 -export([

apps/emqx/src/emqx_persistent_session_ds.erl

@@ -25,8 +25,7 @@
 
 -include("emqx_mqtt.hrl").
 
--include("emqx_session.hrl").
--include("emqx_persistent_session_ds/session_internals.hrl").
+-include("emqx_persistent_session_ds.hrl").
 
 -ifdef(TEST).
 -include_lib("proper/include/proper.hrl").
@@ -64,7 +63,6 @@
     deliver/3,
     replay/3,
     handle_timeout/3,
-    handle_info/2,
     disconnect/2,
     terminate/2
 ]).
@@ -108,7 +106,6 @@
     seqno/0,
     timestamp/0,
     topic_filter/0,
-    share_topic_filter/0,
     subscription_id/0,
     subscription/0,
     session/0,
@@ -120,8 +117,7 @@
 %% Currently, this is the clientid.  We avoid `emqx_types:clientid()' because that can be
 %% an atom, in theory (?).
 -type id() :: binary().
--type share_topic_filter() :: #share{}.
--type topic_filter() :: emqx_types:topic() | share_topic_filter().
+-type topic_filter() :: emqx_types:topic() | #share{}.
 
 %% Subscription and subscription states:
 %%
@@ -159,8 +155,6 @@
     subopts := map()
 }.
 
--type shared_sub_state() :: term().
-
 -define(TIMER_PULL, timer_pull).
 -define(TIMER_GET_STREAMS, timer_get_streams).
 -define(TIMER_BUMP_LAST_ALIVE_AT, timer_bump_last_alive_at).
@@ -178,13 +172,8 @@
     props := map(),
     %% Persistent state:
     s := emqx_persistent_session_ds_state:t(),
-    %% Shared subscription state:
-    shared_sub_s := shared_sub_state(),
     %% Buffer:
     inflight := emqx_persistent_session_ds_inflight:t(),
-    %% Last fetched stream:
-    %% Used as a continuation point for fair stream scheduling.
-    last_fetched_stream => emqx_persistent_session_ds_state:stream_key(),
     %% In-progress replay:
     %% List of stream replay states to be added to the inflight buffer.
     replay => [{_StreamKey, stream_state()}, ...],
@@ -288,11 +277,8 @@ info(created_at, #{s := S}) ->
     emqx_persistent_session_ds_state:get_created_at(S);
 info(is_persistent, #{}) ->
     true;
-info(subscriptions, #{s := S, shared_sub_s := SharedSubS}) ->
-    maps:merge(
-        emqx_persistent_session_ds_subs:to_map(S),
-        emqx_persistent_session_ds_shared_subs:to_map(S, SharedSubS)
-    );
+info(subscriptions, #{s := S}) ->
+    emqx_persistent_session_ds_subs:to_map(S);
 info(subscriptions_cnt, #{s := S}) ->
     emqx_persistent_session_ds_state:n_subscriptions(S);
 info(subscriptions_max, #{props := Conf}) ->
@@ -370,23 +356,15 @@ print_session(ClientId) ->
 %% Client -> Broker: SUBSCRIBE / UNSUBSCRIBE
 %%--------------------------------------------------------------------
 
-%% Suppress warnings about clauses handling unimplemented results
-%% of `emqx_persistent_session_ds_shared_subs:on_subscribe/3`
--dialyzer({nowarn_function, subscribe/3}).
 -spec subscribe(topic_filter(), emqx_types:subopts(), session()) ->
     {ok, session()} | {error, emqx_types:reason_code()}.
 subscribe(
-    #share{} = TopicFilter,
-    SubOpts,
-    Session
+    #share{},
+    _SubOpts,
+    _Session
 ) ->
-    case emqx_persistent_session_ds_shared_subs:on_subscribe(TopicFilter, SubOpts, Session) of
-        {ok, S0, SharedSubS} ->
-            S = emqx_persistent_session_ds_state:commit(S0),
-            {ok, Session#{s => S, shared_sub_s => SharedSubS}};
-        Error = {error, _} ->
-            Error
-    end;
+    %% TODO: Shared subscriptions are not supported yet:
+    {error, ?RC_SHARED_SUBSCRIPTIONS_NOT_SUPPORTED};
 subscribe(
     TopicFilter,
     SubOpts,
@@ -400,27 +378,8 @@ subscribe(
             Error
     end.
 
-%% Suppress warnings about clauses handling unimplemented results
-%% of `emqx_persistent_session_ds_shared_subs:on_unsubscribe/4`
--dialyzer({nowarn_function, unsubscribe/2}).
 -spec unsubscribe(topic_filter(), session()) ->
     {ok, session(), emqx_types:subopts()} | {error, emqx_types:reason_code()}.
-unsubscribe(
-    #share{} = TopicFilter,
-    Session = #{id := SessionId, s := S0, shared_sub_s := SharedSubS0}
-) ->
-    case
-        emqx_persistent_session_ds_shared_subs:on_unsubscribe(
-            SessionId, TopicFilter, S0, SharedSubS0
-        )
-    of
-        {ok, S1, SharedSubS1, #{id := SubId, subopts := SubOpts}} ->
-            S2 = emqx_persistent_session_ds_stream_scheduler:on_unsubscribe(SubId, S1),
-            S = emqx_persistent_session_ds_state:commit(S2),
-            {ok, Session#{s => S, shared_sub_s => SharedSubS1}, SubOpts};
-        Error = {error, _} ->
-            Error
-    end;
 unsubscribe(
     TopicFilter,
     Session = #{id := SessionId, s := S0}
@@ -581,8 +540,6 @@ pubcomp(_ClientInfo, PacketId, Session0) ->
     end.
 
 %%--------------------------------------------------------------------
-%% Delivers
-%%--------------------------------------------------------------------
 
 -spec deliver(clientinfo(), [emqx_types:deliver()], session()) ->
     {ok, replies(), session()}.
@@ -594,10 +551,6 @@ deliver(ClientInfo, Delivers, Session0) ->
     ),
     {ok, [], pull_now(Session)}.
 
-%%--------------------------------------------------------------------
-%% Timeouts
-%%--------------------------------------------------------------------
-
 -spec handle_timeout(clientinfo(), _Timeout, session()) ->
     {ok, replies(), session()} | {ok, replies(), timeout(), session()}.
 handle_timeout(ClientInfo, ?TIMER_PULL, Session0) ->
@@ -620,19 +573,14 @@ handle_timeout(ClientInfo, ?TIMER_PULL, Session0) ->
 handle_timeout(ClientInfo, ?TIMER_RETRY_REPLAY, Session0) ->
     Session = replay_streams(Session0, ClientInfo),
     {ok, [], Session};
-handle_timeout(ClientInfo, ?TIMER_GET_STREAMS, Session0 = #{s := S0, shared_sub_s := SharedSubS0}) ->
-    %% `gc` and `renew_streams` methods may drop unsubscribed streams.
-    %% Shared subscription handler must have a chance to see unsubscribed streams
-    %% in the fully replayed state.
-    {S1, SharedSubS1} = emqx_persistent_session_ds_shared_subs:pre_renew_streams(S0, SharedSubS0),
-    S2 = emqx_persistent_session_ds_subs:gc(S1),
-    S3 = emqx_persistent_session_ds_stream_scheduler:renew_streams(S2),
-    {S, SharedSubS} = emqx_persistent_session_ds_shared_subs:renew_streams(S3, SharedSubS1),
+handle_timeout(ClientInfo, ?TIMER_GET_STREAMS, Session0 = #{s := S0}) ->
+    S1 = emqx_persistent_session_ds_subs:gc(S0),
+    S = emqx_persistent_session_ds_stream_scheduler:renew_streams(S1),
     Interval = get_config(ClientInfo, [renew_streams_interval]),
     Session = emqx_session:ensure_timer(
         ?TIMER_GET_STREAMS,
         Interval,
-        Session0#{s => S, shared_sub_s => SharedSubS}
+        Session0#{s => S}
     ),
     {ok, [], Session};
 handle_timeout(_ClientInfo, ?TIMER_BUMP_LAST_ALIVE_AT, Session0 = #{s := S0}) ->
@@ -653,22 +601,6 @@ handle_timeout(_ClientInfo, Timeout, Session) ->
     ?SLOG(warning, #{msg => "unknown_ds_timeout", timeout => Timeout}),
     {ok, [], Session}.
 
-%%--------------------------------------------------------------------
-%% Generic messages
-%%--------------------------------------------------------------------
-
--spec handle_info(term(), session()) -> session().
-handle_info(?shared_sub_message(Msg), Session = #{s := S0, shared_sub_s := SharedSubS0}) ->
-    {S, SharedSubS} = emqx_persistent_session_ds_shared_subs:on_info(S0, SharedSubS0, Msg),
-    Session#{s => S, shared_sub_s => SharedSubS}.
-
-%%--------------------------------------------------------------------
-%% Shared subscription outgoing messages
-%%--------------------------------------------------------------------
-
-shared_sub_opts(SessionId) ->
-    #{session_id => SessionId}.
-
 bump_last_alive(S0) ->
     %% Note: we take a pessimistic approach here and assume that the client will be alive
     %% until the next bump timeout.  With this, we avoid garbage collecting this session
@@ -761,7 +693,7 @@ skip_batch(StreamKey, SRS0, Session = #{s := S0}, ClientInfo, Reason) ->
 %%--------------------------------------------------------------------
 
 -spec disconnect(session(), emqx_types:conninfo()) -> {shutdown, session()}.
-disconnect(Session = #{id := Id, s := S0, shared_sub_s := SharedSubS0}, ConnInfo) ->
+disconnect(Session = #{id := Id, s := S0}, ConnInfo) ->
     S1 = maybe_set_offline_info(S0, Id),
     S2 = emqx_persistent_session_ds_state:set_last_alive_at(now_ms(), S1),
     S3 =
@@ -771,9 +703,8 @@ disconnect(Session = #{id := Id, s := S0, shared_sub_s := SharedSubS0}, ConnInfo
             _ ->
                 S2
         end,
-    {S4, SharedSubS} = emqx_persistent_session_ds_shared_subs:on_disconnect(S3, SharedSubS0),
-    S = emqx_persistent_session_ds_state:commit(S4),
-    {shutdown, Session#{s => S, shared_sub_s => SharedSubS}}.
+    S = emqx_persistent_session_ds_state:commit(S3),
+    {shutdown, Session#{s => S}}.
 
 -spec terminate(Reason :: term(), session()) -> ok.
 terminate(_Reason, Session = #{id := Id, s := S}) ->
@@ -821,12 +752,10 @@ list_client_subscriptions(ClientId) ->
             {error, not_found}
     end.
 
--spec get_client_subscription(emqx_types:clientid(), topic_filter() | share_topic_filter()) ->
+-spec get_client_subscription(emqx_types:clientid(), emqx_types:topic()) ->
     subscription() | undefined.
-get_client_subscription(ClientId, #share{} = ShareTopicFilter) ->
-    emqx_persistent_session_ds_shared_subs:cold_get_subscription(ClientId, ShareTopicFilter);
-get_client_subscription(ClientId, TopicFilter) ->
-    emqx_persistent_session_ds_subs:cold_get_subscription(ClientId, TopicFilter).
+get_client_subscription(ClientId, Topic) ->
+    emqx_persistent_session_ds_subs:cold_get_subscription(ClientId, Topic).
 
 %%--------------------------------------------------------------------
 %% Session tables operations
@@ -885,17 +814,13 @@ session_open(
                     S4 = emqx_persistent_session_ds_state:set_will_message(MaybeWillMsg, S3),
                     S5 = set_clientinfo(ClientInfo, S4),
                     S6 = emqx_persistent_session_ds_state:set_protocol({ProtoName, ProtoVer}, S5),
-                    {ok, S7, SharedSubS} = emqx_persistent_session_ds_shared_subs:open(
-                        S6, shared_sub_opts(SessionId)
-                    ),
-                    S = emqx_persistent_session_ds_state:commit(S7),
+                    S = emqx_persistent_session_ds_state:commit(S6),
                     Inflight = emqx_persistent_session_ds_inflight:new(
                         receive_maximum(NewConnInfo)
                     ),
                     #{
                         id => SessionId,
                         s => S,
-                        shared_sub_s => SharedSubS,
                         inflight => Inflight,
                         props => #{}
                     }
@@ -944,7 +869,6 @@ session_ensure_new(
         id => Id,
         props => Conf,
         s => S,
-        shared_sub_s => emqx_persistent_session_ds_shared_subs:new(shared_sub_opts(Id)),
         inflight => emqx_persistent_session_ds_inflight:new(receive_maximum(ConnInfo))
     }.
 
@@ -955,8 +879,8 @@ session_drop(SessionId, Reason) ->
     case emqx_persistent_session_ds_state:open(SessionId) of
         {ok, S0} ->
             ?tp(debug, drop_persistent_session, #{client_id => SessionId, reason => Reason}),
-            ok = emqx_persistent_session_ds_subs:on_session_drop(SessionId, S0),
-            ok = emqx_persistent_session_ds_state:delete(SessionId);
+            emqx_persistent_session_ds_subs:on_session_drop(SessionId, S0),
+            emqx_persistent_session_ds_state:delete(SessionId);
         undefined ->
             ok
     end.
@@ -993,33 +917,24 @@ do_ensure_all_iterators_closed(_DSSessionID) ->
 %% Normal replay:
 %%--------------------------------------------------------------------
 
-fetch_new_messages(Session0 = #{s := S0, shared_sub_s := SharedSubS0}, ClientInfo) ->
-    {S1, SharedSubS1} = emqx_persistent_session_ds_shared_subs:on_streams_replay(S0, SharedSubS0),
-    Session1 = Session0#{s => S1, shared_sub_s => SharedSubS1},
-    LFS = maps:get(last_fetched_stream, Session1, beginning),
-    ItStream = emqx_persistent_session_ds_stream_scheduler:iter_next_streams(LFS, S1),
-    BatchSize = get_config(ClientInfo, [batch_size]),
-    Session2 = fetch_new_messages(ItStream, BatchSize, Session1, ClientInfo),
-    Session2#{shared_sub_s => SharedSubS1}.
+fetch_new_messages(Session = #{s := S}, ClientInfo) ->
+    Streams = emqx_persistent_session_ds_stream_scheduler:find_new_streams(S),
+    fetch_new_messages(Streams, Session, ClientInfo).
 
-fetch_new_messages(ItStream0, BatchSize, Session0, ClientInfo) ->
-    #{inflight := Inflight} = Session0,
+fetch_new_messages([], Session, _ClientInfo) ->
+    Session;
+fetch_new_messages([I | Streams], Session0 = #{inflight := Inflight}, ClientInfo) ->
+    BatchSize = get_config(ClientInfo, [batch_size]),
     case emqx_persistent_session_ds_inflight:n_buffered(all, Inflight) >= BatchSize of
         true ->
             %% Buffer is full:
             Session0;
         false ->
-            case emqx_persistent_session_ds_stream_scheduler:next_stream(ItStream0) of
-                {StreamKey, Srs, ItStream} ->
-                    Session1 = new_batch(StreamKey, Srs, BatchSize, Session0, ClientInfo),
-                    Session = Session1#{last_fetched_stream => StreamKey},
-                    fetch_new_messages(ItStream, BatchSize, Session, ClientInfo);
-                none ->
-                    Session0
-            end
+            Session = new_batch(I, BatchSize, Session0, ClientInfo),
+            fetch_new_messages(Streams, Session, ClientInfo)
     end.
 
-new_batch(StreamKey, Srs0, BatchSize, Session0 = #{s := S0}, ClientInfo) ->
+new_batch({StreamKey, Srs0}, BatchSize, Session0 = #{s := S0}, ClientInfo) ->
     SN1 = emqx_persistent_session_ds_state:get_seqno(?next(?QOS_1), S0),
     SN2 = emqx_persistent_session_ds_state:get_seqno(?next(?QOS_2), S0),
     Srs1 = Srs0#srs{

apps/emqx/src/emqx_persistent_session_ds.hrl

@@ -13,11 +13,10 @@
 %% See the License for the specific language governing permissions and
 %% limitations under the License.
 %%--------------------------------------------------------------------
--ifndef(EMQX_SESSION_DS_INTERNALS_HRL).
--define(EMQX_SESSION_DS_INTERNALS_HRL, true).
+-ifndef(EMQX_PERSISTENT_SESSION_DS_HRL_HRL).
+-define(EMQX_PERSISTENT_SESSION_DS_HRL_HRL, true).
 
 -include("emqx_persistent_message.hrl").
--include("emqx_durable_session_metadata.hrl").
 
 -define(SESSION_TAB, emqx_ds_session).
 -define(SESSION_SUBSCRIPTIONS_TAB, emqx_ds_session_subscriptions).
@@ -71,11 +70,17 @@
     sub_state_id :: emqx_persistent_session_ds_subs:subscription_state_id()
 }).
 
-%% (Erlang) messages that session should forward to the
-%% shared subscription handler.
--record(shared_sub_message, {
-    message :: term()
-}).
--define(shared_sub_message(MSG), #shared_sub_message{message = MSG}).
+%% Session metadata keys:
+-define(created_at, created_at).
+-define(last_alive_at, last_alive_at).
+-define(expiry_interval, expiry_interval).
+%% Unique integer used to create unique identities:
+-define(last_id, last_id).
+%% Connection info (relevent for the dashboard):
+-define(peername, peername).
+-define(will_message, will_message).
+-define(clientinfo, clientinfo).
+-define(protocol, protocol).
+-define(offline_info, offline_info).
 
 -endif.

apps/emqx/src/emqx_persistent_session_ds/emqx_persistent_session_ds_shared_subs.erl

@@ -1,791 +0,0 @@
-%%--------------------------------------------------------------------
-%% Copyright (c) 2024 EMQ Technologies Co., Ltd. All Rights Reserved.
-%%--------------------------------------------------------------------
-
-%% @doc This module
-%% * handles creation and management of _shared_ subscriptions for the session;
-%% * provides streams to the session;
-%% * handles progress of stream replay.
-%%
-%% The logic is quite straightforward; most of the parts resemble the logic of the
-%% `emqx_persistent_session_ds_subs` (subscribe/unsubscribe) and
-%% `emqx_persistent_session_ds_scheduler` (providing new streams),
-%% but some data is sent or received from the `emqx_persistent_session_ds_shared_subs_agent`
-%% which communicates with remote shared subscription leaders.
-%%
-%% A tricky part is the concept of "scheduled actions". When we unsubscribe from a topic
-%% we may have some streams that have unacked messages. So we do not have a reliable
-%% progress for them. Sending the current progress to the leader and disconnecting
-%% will lead to the duplication of messages. So after unsubscription, we need to wait
-%% some time until all streams are acked, and only then we disconnect from the leader.
-%%
-%% For this purpose we have the `scheduled_actions` map in the state of the module.
-%% We preserve there the streams that we need to wait for and collect their progress.
-%% We also use `scheduled_actions` for resubscriptions. If a client quickly resubscribes
-%% after unsubscription, we may still have the mentioned streams unacked. If we abandon
-%% them, just connect to the leader, then it may lease us the same streams again, but with
-%% the previous progress. So messages may duplicate.
-
--module(emqx_persistent_session_ds_shared_subs).
-
--include("emqx_mqtt.hrl").
--include("emqx.hrl").
--include("logger.hrl").
--include("session_internals.hrl").
-
--include_lib("snabbkaffe/include/trace.hrl").
-
--export([
-    new/1,
-    open/2,
-
-    on_subscribe/3,
-    on_unsubscribe/4,
-    on_disconnect/2,
-
-    on_streams_replay/2,
-    on_info/3,
-
-    pre_renew_streams/2,
-    renew_streams/2,
-    to_map/2
-]).
-
-%% Management API:
--export([
-    cold_get_subscription/2
-]).
-
--export([
-    format_lease_events/1,
-    format_stream_progresses/1
-]).
-
--define(schedule_subscribe, schedule_subscribe).
--define(schedule_unsubscribe, schedule_unsubscribe).
-
--type stream_key() :: {emqx_persistent_session_ds:id(), emqx_ds:stream()}.
-
--type scheduled_action_type() ::
-    {?schedule_subscribe, emqx_types:subopts()} | ?schedule_unsubscribe.
-
--type agent_stream_progress() :: #{
-    stream := emqx_ds:stream(),
-    progress := progress(),
-    use_finished := boolean()
-}.
-
--type progress() ::
-    #{
-        iterator := emqx_ds:iterator()
-    }.
-
--type scheduled_action() :: #{
-    type := scheduled_action_type(),
-    stream_keys_to_wait := [stream_key()],
-    progresses := [agent_stream_progress()]
-}.
-
--type t() :: #{
-    agent := emqx_persistent_session_ds_shared_subs_agent:t(),
-    scheduled_actions := #{
-        share_topic_filter() => scheduled_action()
-    }
-}.
--type share_topic_filter() :: emqx_persistent_session_ds:share_topic_filter().
--type opts() :: #{
-    session_id := emqx_persistent_session_ds:id()
-}.
-
--define(rank_x, rank_shared).
--define(rank_y, 0).
-
--export_type([
-    progress/0,
-    agent_stream_progress/0
-]).
-
-%%--------------------------------------------------------------------
-%% API
-%%--------------------------------------------------------------------
-
-%%--------------------------------------------------------------------
-%% new
-
--spec new(opts()) -> t().
-new(Opts) ->
-    #{
-        agent => emqx_persistent_session_ds_shared_subs_agent:new(
-            agent_opts(Opts)
-        ),
-        scheduled_actions => #{}
-    }.
-
-%%--------------------------------------------------------------------
-%% open
-
--spec open(emqx_persistent_session_ds_state:t(), opts()) ->
-    {ok, emqx_persistent_session_ds_state:t(), t()}.
-open(S0, Opts) ->
-    SharedSubscriptions = fold_shared_subs(
-        fun(#share{} = ShareTopicFilter, Sub, Acc) ->
-            [{ShareTopicFilter, to_agent_subscription(S0, Sub)} | Acc]
-        end,
-        [],
-        S0
-    ),
-    Agent = emqx_persistent_session_ds_shared_subs_agent:open(
-        SharedSubscriptions, agent_opts(Opts)
-    ),
-    SharedSubS = #{agent => Agent, scheduled_actions => #{}},
-    S1 = revoke_all_streams(S0),
-    {ok, S1, SharedSubS}.
-
-%%--------------------------------------------------------------------
-%% on_subscribe
-
--spec on_subscribe(
-    share_topic_filter(),
-    emqx_types:subopts(),
-    emqx_persistent_session_ds:session()
-) -> {ok, emqx_persistent_session_ds_state:t(), t()} | {error, emqx_types:reason_code()}.
-on_subscribe(#share{} = ShareTopicFilter, SubOpts, #{s := S} = Session) ->
-    Subscription = emqx_persistent_session_ds_state:get_subscription(ShareTopicFilter, S),
-    on_subscribe(Subscription, ShareTopicFilter, SubOpts, Session).
-
-%%--------------------------------------------------------------------
-%% on_subscribe internal functions
-
-on_subscribe(undefined, ShareTopicFilter, SubOpts, #{props := Props, s := S} = Session) ->
-    #{max_subscriptions := MaxSubscriptions} = Props,
-    case emqx_persistent_session_ds_state:n_subscriptions(S) < MaxSubscriptions of
-        true ->
-            create_new_subscription(ShareTopicFilter, SubOpts, Session);
-        false ->
-            {error, ?RC_QUOTA_EXCEEDED}
-    end;
-on_subscribe(Subscription, ShareTopicFilter, SubOpts, Session) ->
-    update_subscription(Subscription, ShareTopicFilter, SubOpts, Session).
-
--dialyzer({nowarn_function, create_new_subscription/3}).
-create_new_subscription(#share{topic = TopicFilter, group = Group} = ShareTopicFilter, SubOpts, #{
-    id := SessionId,
-    s := S0,
-    shared_sub_s := #{agent := Agent} = SharedSubS0,
-    props := Props
-}) ->
-    case
-        emqx_persistent_session_ds_shared_subs_agent:can_subscribe(
-            Agent, ShareTopicFilter, SubOpts
-        )
-    of
-        ok ->
-            ok = emqx_persistent_session_ds_router:do_add_route(TopicFilter, #share_dest{
-                session_id = SessionId, group = Group
-            }),
-            _ = emqx_external_broker:add_persistent_shared_route(TopicFilter, Group, SessionId),
-            #{upgrade_qos := UpgradeQoS} = Props,
-            {SubId, S1} = emqx_persistent_session_ds_state:new_id(S0),
-            {SStateId, S2} = emqx_persistent_session_ds_state:new_id(S1),
-            SState = #{
-                parent_subscription => SubId, upgrade_qos => UpgradeQoS, subopts => SubOpts
-            },
-            S3 = emqx_persistent_session_ds_state:put_subscription_state(
-                SStateId, SState, S2
-            ),
-            Subscription = #{
-                id => SubId,
-                current_state => SStateId,
-                start_time => now_ms()
-            },
-            S = emqx_persistent_session_ds_state:put_subscription(
-                ShareTopicFilter, Subscription, S3
-            ),
-
-            SharedSubS = schedule_subscribe(SharedSubS0, ShareTopicFilter, SubOpts),
-            {ok, S, SharedSubS};
-        {error, _} = Error ->
-            Error
-    end.
-
-update_subscription(
-    #{current_state := SStateId0, id := SubId} = Sub0, ShareTopicFilter, SubOpts, #{
-        s := S0, shared_sub_s := SharedSubS, props := Props
-    }
-) ->
-    #{upgrade_qos := UpgradeQoS} = Props,
-    SState = #{parent_subscription => SubId, upgrade_qos => UpgradeQoS, subopts => SubOpts},
-    case emqx_persistent_session_ds_state:get_subscription_state(SStateId0, S0) of
-        SState ->
-            %% Client resubscribed with the same parameters:
-            {ok, S0, SharedSubS};
-        _ ->
-            %% Subsription parameters changed:
-            {SStateId, S1} = emqx_persistent_session_ds_state:new_id(S0),
-            S2 = emqx_persistent_session_ds_state:put_subscription_state(
-                SStateId, SState, S1
-            ),
-            Sub = Sub0#{current_state => SStateId},
-            S = emqx_persistent_session_ds_state:put_subscription(ShareTopicFilter, Sub, S2),
-            {ok, S, SharedSubS}
-    end.
-
--dialyzer({nowarn_function, schedule_subscribe/3}).
-schedule_subscribe(
-    #{agent := Agent0, scheduled_actions := ScheduledActions0} = SharedSubS0,
-    ShareTopicFilter,
-    SubOpts
-) ->
-    case ScheduledActions0 of
-        #{ShareTopicFilter := ScheduledAction} ->
-            ScheduledActions1 = ScheduledActions0#{
-                ShareTopicFilter => ScheduledAction#{type => {?schedule_subscribe, SubOpts}}
-            },
-            ?tp(debug, shared_subs_schedule_subscribe_override, #{
-                share_topic_filter => ShareTopicFilter,
-                new_type => {?schedule_subscribe, SubOpts},
-                old_action => format_schedule_action(ScheduledAction)
-            }),
-            SharedSubS0#{scheduled_actions := ScheduledActions1};
-        _ ->
-            ?tp(debug, shared_subs_schedule_subscribe_new, #{
-                share_topic_filter => ShareTopicFilter, subopts => SubOpts
-            }),
-            Agent1 = emqx_persistent_session_ds_shared_subs_agent:on_subscribe(
-                Agent0, ShareTopicFilter, SubOpts
-            ),
-            SharedSubS0#{agent => Agent1}
-    end.
-
-%%--------------------------------------------------------------------
-%% on_unsubscribe
-
--spec on_unsubscribe(
-    emqx_persistent_session_ds:id(),
-    share_topic_filter(),
-    emqx_persistent_session_ds_state:t(),
-    t()
-) ->
-    {ok, emqx_persistent_session_ds_state:t(), t(), emqx_persistent_session_ds:subscription()}
-    | {error, emqx_types:reason_code()}.
-on_unsubscribe(
-    SessionId, #share{topic = TopicFilter, group = Group} = ShareTopicFilter, S0, SharedSubS0
-) ->
-    case lookup(ShareTopicFilter, S0) of
-        undefined ->
-            {error, ?RC_NO_SUBSCRIPTION_EXISTED};
-        #{id := SubId} = Subscription ->
-            ?tp(persistent_session_ds_subscription_delete, #{
-                session_id => SessionId, share_topic_filter => ShareTopicFilter
-            }),
-            _ = emqx_external_broker:delete_persistent_shared_route(TopicFilter, Group, SessionId),
-            ok = emqx_persistent_session_ds_router:do_delete_route(TopicFilter, #share_dest{
-                session_id = SessionId, group = Group
-            }),
-            S = emqx_persistent_session_ds_state:del_subscription(ShareTopicFilter, S0),
-            SharedSubS = schedule_unsubscribe(S, SharedSubS0, SubId, ShareTopicFilter),
-            {ok, S, SharedSubS, Subscription}
-    end.
-
-%%--------------------------------------------------------------------
-%% on_unsubscribe internal functions
-
-schedule_unsubscribe(
-    S, #{scheduled_actions := ScheduledActions0} = SharedSubS0, UnsubscridedSubId, ShareTopicFilter
-) ->
-    case ScheduledActions0 of
-        #{ShareTopicFilter := ScheduledAction0} ->
-            ScheduledAction1 = ScheduledAction0#{type => ?schedule_unsubscribe},
-            ScheduledActions1 = ScheduledActions0#{
-                ShareTopicFilter => ScheduledAction1
-            },
-            ?tp(debug, shared_subs_schedule_unsubscribe_override, #{
-                share_topic_filter => ShareTopicFilter,
-                new_type => ?schedule_unsubscribe,
-                old_action => format_schedule_action(ScheduledAction0)
-            }),
-            SharedSubS0#{scheduled_actions := ScheduledActions1};
-        _ ->
-            StreamKeys = stream_keys_by_sub_id(S, UnsubscridedSubId),
-            ScheduledActions1 = ScheduledActions0#{
-                ShareTopicFilter => #{
-                    type => ?schedule_unsubscribe,
-                    stream_keys_to_wait => StreamKeys,
-                    progresses => []
-                }
-            },
-            ?tp(debug, shared_subs_schedule_unsubscribe_new, #{
-                share_topic_filter => ShareTopicFilter,
-                stream_keys => format_stream_keys(StreamKeys)
-            }),
-            SharedSubS0#{scheduled_actions := ScheduledActions1}
-    end.
-
-%%--------------------------------------------------------------------
-%% pre_renew_streams
-
--spec pre_renew_streams(emqx_persistent_session_ds_state:t(), t()) ->
-    {emqx_persistent_session_ds_state:t(), t()}.
-pre_renew_streams(S, SharedSubS) ->
-    on_streams_replay(S, SharedSubS).
-
-%%--------------------------------------------------------------------
-%% renew_streams
-
--spec renew_streams(emqx_persistent_session_ds_state:t(), t()) ->
-    {emqx_persistent_session_ds_state:t(), t()}.
-renew_streams(S0, #{agent := Agent0, scheduled_actions := ScheduledActions} = SharedSubS0) ->
-    {StreamLeaseEvents, Agent1} = emqx_persistent_session_ds_shared_subs_agent:renew_streams(
-        Agent0
-    ),
-    StreamLeaseEvents =/= [] andalso
-        ?tp(debug, shared_subs_new_stream_lease_events, #{
-            stream_lease_events => format_lease_events(StreamLeaseEvents)
-        }),
-    S1 = lists:foldl(
-        fun
-            (#{type := lease} = Event, S) -> accept_stream(Event, S, ScheduledActions);
-            (#{type := revoke} = Event, S) -> revoke_stream(Event, S)
-        end,
-        S0,
-        StreamLeaseEvents
-    ),
-    SharedSubS1 = SharedSubS0#{agent => Agent1},
-    {S1, SharedSubS1}.
-
-%%--------------------------------------------------------------------
-%% renew_streams internal functions
-
-accept_stream(#{share_topic_filter := ShareTopicFilter} = Event, S, ScheduledActions) ->
-    %% If we have a pending action (subscribe or unsubscribe) for this topic filter,
-    %% we should not accept a stream and start replaying it. We won't use it anyway:
-    %% * if subscribe is pending, we will reset agent obtain a new lease
-    %% * if unsubscribe is pending, we will drop connection
-    case ScheduledActions of
-        #{ShareTopicFilter := _Action} ->
-            S;
-        _ ->
-            accept_stream(Event, S)
-    end.
-
-accept_stream(
-    #{
-        share_topic_filter := ShareTopicFilter,
-        stream := Stream,
-        progress := #{iterator := Iterator} = _Progress
-    } = _Event,
-    S0
-) ->
-    case emqx_persistent_session_ds_state:get_subscription(ShareTopicFilter, S0) of
-        undefined ->
-            %% We unsubscribed
-            S0;
-        #{id := SubId, current_state := SStateId} ->
-            Key = {SubId, Stream},
-            NeedCreateStream =
-                case emqx_persistent_session_ds_state:get_stream(Key, S0) of
-                    undefined ->
-                        true;
-                    #srs{unsubscribed = true} ->
-                        true;
-                    _SRS ->
-                        false
-                end,
-            case NeedCreateStream of
-                true ->
-                    NewSRS =
-                        #srs{
-                            rank_x = ?rank_x,
-                            rank_y = ?rank_y,
-                            it_begin = Iterator,
-                            it_end = Iterator,
-                            sub_state_id = SStateId
-                        },
-                    S1 = emqx_persistent_session_ds_state:put_stream(Key, NewSRS, S0),
-                    S1;
-                false ->
-                    S0
-            end
-    end.
-
-revoke_stream(
-    #{share_topic_filter := ShareTopicFilter, stream := Stream}, S0
-) ->
-    case emqx_persistent_session_ds_state:get_subscription(ShareTopicFilter, S0) of
-        undefined ->
-            %% This should not happen.
-            %% Agent should have received unsubscribe callback
-            %% and should not have revoked this stream
-            S0;
-        #{id := SubId} ->
-            Key = {SubId, Stream},
-            case emqx_persistent_session_ds_state:get_stream(Key, S0) of
-                undefined ->
-                    S0;
-                SRS0 ->
-                    SRS1 = SRS0#srs{unsubscribed = true},
-                    S1 = emqx_persistent_session_ds_state:put_stream(Key, SRS1, S0),
-                    S1
-            end
-    end.
-
-%%--------------------------------------------------------------------
-%% on_streams_replay
-
--spec on_streams_replay(
-    emqx_persistent_session_ds_state:t(),
-    t()
-) -> {emqx_persistent_session_ds_state:t(), t()}.
-on_streams_replay(S0, SharedSubS0) ->
-    {S1, #{agent := Agent0, scheduled_actions := ScheduledActions0} = SharedSubS1} =
-        renew_streams(S0, SharedSubS0),
-
-    Progresses = all_stream_progresses(S1, Agent0),
-    Agent1 = emqx_persistent_session_ds_shared_subs_agent:on_stream_progress(
-        Agent0, Progresses
-    ),
-    {Agent2, ScheduledActions1} = run_scheduled_actions(S1, Agent1, ScheduledActions0),
-    SharedSubS2 = SharedSubS1#{
-        agent => Agent2,
-        scheduled_actions => ScheduledActions1
-    },
-    {S1, SharedSubS2}.
-
-%%--------------------------------------------------------------------
-%% on_streams_replay internal functions
-
-all_stream_progresses(S, Agent) ->
-    all_stream_progresses(S, Agent, _NeedUnacked = false).
-
-all_stream_progresses(S, _Agent, NeedUnacked) ->
-    CommQos1 = emqx_persistent_session_ds_state:get_seqno(?committed(?QOS_1), S),
-    CommQos2 = emqx_persistent_session_ds_state:get_seqno(?committed(?QOS_2), S),
-    fold_shared_stream_states(
-        fun(ShareTopicFilter, Stream, SRS, ProgressesAcc0) ->
-            case
-                is_stream_started(CommQos1, CommQos2, SRS) and
-                    (NeedUnacked or is_stream_fully_acked(CommQos1, CommQos2, SRS))
-            of
-                true ->
-                    StreamProgress = stream_progress(CommQos1, CommQos2, Stream, SRS),
-                    maps:update_with(
-                        ShareTopicFilter,
-                        fun(Progresses) -> [StreamProgress | Progresses] end,
-                        [StreamProgress],
-                        ProgressesAcc0
-                    );
-                false ->
-                    ProgressesAcc0
-            end
-        end,
-        #{},
-        S
-    ).
-
-run_scheduled_actions(S, Agent, ScheduledActions) ->
-    maps:fold(
-        fun(ShareTopicFilter, Action0, {AgentAcc0, ScheduledActionsAcc}) ->
-            case run_scheduled_action(S, AgentAcc0, ShareTopicFilter, Action0) of
-                {ok, AgentAcc1} ->
-                    {AgentAcc1, maps:remove(ShareTopicFilter, ScheduledActionsAcc)};
-                {continue, Action1} ->
-                    {AgentAcc0, ScheduledActionsAcc#{ShareTopicFilter => Action1}}
-            end
-        end,
-        {Agent, ScheduledActions},
-        ScheduledActions
-    ).
-
-run_scheduled_action(
-    S,
-    Agent0,
-    ShareTopicFilter,
-    #{type := Type, stream_keys_to_wait := StreamKeysToWait0, progresses := Progresses0} = Action
-) ->
-    StreamKeysToWait1 = filter_unfinished_streams(S, StreamKeysToWait0),
-    Progresses1 = stream_progresses(S, StreamKeysToWait0 -- StreamKeysToWait1) ++ Progresses0,
-    case StreamKeysToWait1 of
-        [] ->
-            ?tp(debug, shared_subs_schedule_action_complete, #{
-                share_topic_filter => ShareTopicFilter,
-                progresses => format_stream_progresses(Progresses1),
-                type => Type
-            }),
-            %% Regular progress won't se unsubscribed streams, so we need to
-            %% send the progress explicitly.
-            Agent1 = emqx_persistent_session_ds_shared_subs_agent:on_stream_progress(
-                Agent0, #{ShareTopicFilter => Progresses1}
-            ),
-            case Type of
-                {?schedule_subscribe, SubOpts} ->
-                    {ok,
-                        emqx_persistent_session_ds_shared_subs_agent:on_subscribe(
-                            Agent1, ShareTopicFilter, SubOpts
-                        )};
-                ?schedule_unsubscribe ->
-                    {ok,
-                        emqx_persistent_session_ds_shared_subs_agent:on_unsubscribe(
-                            Agent1, ShareTopicFilter, Progresses1
-                        )}
-            end;
-        _ ->
-            Action1 = Action#{stream_keys_to_wait => StreamKeysToWait1, progresses => Progresses1},
-            ?tp(debug, shared_subs_schedule_action_continue, #{
-                share_topic_filter => ShareTopicFilter,
-                new_action => format_schedule_action(Action1)
-            }),
-            {continue, Action1}
-    end.
-
-filter_unfinished_streams(S, StreamKeysToWait) ->
-    CommQos1 = emqx_persistent_session_ds_state:get_seqno(?committed(?QOS_1), S),
-    CommQos2 = emqx_persistent_session_ds_state:get_seqno(?committed(?QOS_2), S),
-    lists:filter(
-        fun(Key) ->
-            case emqx_persistent_session_ds_state:get_stream(Key, S) of
-                undefined ->
-                    %% This should not happen: we should see any stream
-                    %% in completed state before deletion
-                    true;
-                SRS ->
-                    not is_stream_fully_acked(CommQos1, CommQos2, SRS)
-            end
-        end,
-        StreamKeysToWait
-    ).
-
-stream_progresses(S, StreamKeys) ->
-    CommQos1 = emqx_persistent_session_ds_state:get_seqno(?committed(?QOS_1), S),
-    CommQos2 = emqx_persistent_session_ds_state:get_seqno(?committed(?QOS_2), S),
-    lists:map(
-        fun({_SubId, Stream} = Key) ->
-            SRS = emqx_persistent_session_ds_state:get_stream(Key, S),
-            stream_progress(CommQos1, CommQos2, Stream, SRS)
-        end,
-        StreamKeys
-    ).
-
-%%--------------------------------------------------------------------
-%% on_disconnect
-
-on_disconnect(S0, #{agent := Agent0} = SharedSubS0) ->
-    S1 = revoke_all_streams(S0),
-    Progresses = all_stream_progresses(S1, Agent0, _NeedUnacked = true),
-    Agent1 = emqx_persistent_session_ds_shared_subs_agent:on_disconnect(Agent0, Progresses),
-    SharedSubS1 = SharedSubS0#{agent => Agent1, scheduled_actions => #{}},
-    {S1, SharedSubS1}.
-
-%%--------------------------------------------------------------------
-%% on_disconnect helpers
-
-revoke_all_streams(S0) ->
-    fold_shared_stream_states(
-        fun(ShareTopicFilter, Stream, _SRS, S) ->
-            revoke_stream(#{share_topic_filter => ShareTopicFilter, stream => Stream}, S)
-        end,
-        S0,
-        S0
-    ).
-
-%%--------------------------------------------------------------------
-%% on_info
-
--spec on_info(emqx_persistent_session_ds_state:t(), t(), term()) ->
-    {emqx_persistent_session_ds_state:t(), t()}.
-on_info(S, #{agent := Agent0} = SharedSubS0, Info) ->
-    Agent1 = emqx_persistent_session_ds_shared_subs_agent:on_info(Agent0, Info),
-    SharedSubS1 = SharedSubS0#{agent => Agent1},
-    {S, SharedSubS1}.
-
-%%--------------------------------------------------------------------
-%% to_map
-
--spec to_map(emqx_persistent_session_ds_state:t(), t()) -> map().
-to_map(S, _SharedSubS) ->
-    fold_shared_subs(
-        fun(ShareTopicFilter, _, Acc) -> Acc#{ShareTopicFilter => lookup(ShareTopicFilter, S)} end,
-        #{},
-        S
-    ).
-
-%%--------------------------------------------------------------------
-%% cold_get_subscription
-
--spec cold_get_subscription(emqx_persistent_session_ds:id(), share_topic_filter()) ->
-    emqx_persistent_session_ds:subscription() | undefined.
-cold_get_subscription(SessionId, ShareTopicFilter) ->
-    case emqx_persistent_session_ds_state:cold_get_subscription(SessionId, ShareTopicFilter) of
-        [Sub = #{current_state := SStateId}] ->
-            case
-                emqx_persistent_session_ds_state:cold_get_subscription_state(SessionId, SStateId)
-            of
-                [#{subopts := Subopts}] ->
-                    Sub#{subopts => Subopts};
-                _ ->
-                    undefined
-            end;
-        _ ->
-            undefined
-    end.
-
-%%--------------------------------------------------------------------
-%% Generic helpers
-%%--------------------------------------------------------------------
-
-lookup(ShareTopicFilter, S) ->
-    case emqx_persistent_session_ds_state:get_subscription(ShareTopicFilter, S) of
-        Sub = #{current_state := SStateId} ->
-            case emqx_persistent_session_ds_state:get_subscription_state(SStateId, S) of
-                #{subopts := SubOpts} ->
-                    Sub#{subopts => SubOpts};
-                undefined ->
-                    undefined
-            end;
-        undefined ->
-            undefined
-    end.
-
-stream_keys_by_sub_id(S, MatchSubId) ->
-    emqx_persistent_session_ds_state:fold_streams(
-        fun({SubId, _Stream} = StreamKey, _SRS, StreamKeys) ->
-            case SubId of
-                MatchSubId ->
-                    [StreamKey | StreamKeys];
-                _ ->
-                    StreamKeys
-            end
-        end,
-        [],
-        S
-    ).
-
-stream_progress(
-    CommQos1,
-    CommQos2,
-    Stream,
-    #srs{
-        it_end = EndIt,
-        it_begin = BeginIt
-    } = SRS
-) ->
-    Iterator =
-        case is_stream_fully_acked(CommQos1, CommQos2, SRS) of
-            true -> EndIt;
-            false -> BeginIt
-        end,
-    #{
-        stream => Stream,
-        progress => #{
-            iterator => Iterator
-        },
-        use_finished => is_use_finished(SRS)
-    }.
-
-fold_shared_subs(Fun, Acc, S) ->
-    emqx_persistent_session_ds_state:fold_subscriptions(
-        fun
-            (#share{} = ShareTopicFilter, Sub, Acc0) -> Fun(ShareTopicFilter, Sub, Acc0);
-            (_, _Sub, Acc0) -> Acc0
-        end,
-        Acc,
-        S
-    ).
-
-fold_shared_stream_states(Fun, Acc, S) ->
-    %% TODO
-    %% Optimize or cache
-    ShareTopicFilters = fold_shared_subs(
-        fun
-            (#share{} = ShareTopicFilter, #{id := Id} = _Sub, Acc0) ->
-                Acc0#{Id => ShareTopicFilter};
-            (_, _, Acc0) ->
-                Acc0
-        end,
-        #{},
-        S
-    ),
-    emqx_persistent_session_ds_state:fold_streams(
-        fun({SubId, Stream}, SRS, Acc0) ->
-            case ShareTopicFilters of
-                #{SubId := ShareTopicFilter} ->
-                    Fun(ShareTopicFilter, Stream, SRS, Acc0);
-                _ ->
-                    Acc0
-            end
-        end,
-        Acc,
-        S
-    ).
-
-to_agent_subscription(_S, Subscription) ->
-    maps:with([start_time], Subscription).
-
-agent_opts(#{session_id := SessionId}) ->
-    #{session_id => SessionId}.
-
--dialyzer({nowarn_function, now_ms/0}).
-now_ms() ->
-    erlang:system_time(millisecond).
-
-is_use_finished(#srs{unsubscribed = Unsubscribed}) ->
-    Unsubscribed.
-
-is_stream_started(CommQos1, CommQos2, #srs{first_seqno_qos1 = Q1, last_seqno_qos1 = Q2}) ->
-    (CommQos1 >= Q1) or (CommQos2 >= Q2).
-
-is_stream_fully_acked(_, _, #srs{
-    first_seqno_qos1 = Q1, last_seqno_qos1 = Q1, first_seqno_qos2 = Q2, last_seqno_qos2 = Q2
-}) ->
-    %% Streams where the last chunk doesn't contain any QoS1 and 2
-    %% messages are considered fully acked:
-    true;
-is_stream_fully_acked(Comm1, Comm2, #srs{last_seqno_qos1 = S1, last_seqno_qos2 = S2}) ->
-    (Comm1 >= S1) andalso (Comm2 >= S2).
-
-%%--------------------------------------------------------------------
-%% Formatters
-%%--------------------------------------------------------------------
-
-format_schedule_action(#{
-    type := Type, progresses := Progresses, stream_keys_to_wait := StreamKeysToWait
-}) ->
-    #{
-        type => Type,
-        progresses => format_stream_progresses(Progresses),
-        stream_keys_to_wait => format_stream_keys(StreamKeysToWait)
-    }.
-
-format_stream_progresses(Streams) ->
-    lists:map(
-        fun format_stream_progress/1,
-        Streams
-    ).
-
-format_stream_progress(#{stream := Stream, progress := Progress} = Value) ->
-    Value#{stream => format_opaque(Stream), progress => format_progress(Progress)}.
-
-format_progress(#{iterator := Iterator} = Progress) ->
-    Progress#{iterator => format_opaque(Iterator)}.
-
-format_stream_key(beginning) -> beginning;
-format_stream_key({SubId, Stream}) -> {SubId, format_opaque(Stream)}.
-
-format_stream_keys(StreamKeys) ->
-    lists:map(
-        fun format_stream_key/1,
-        StreamKeys
-    ).
-
-format_lease_events(Events) ->
-    lists:map(
-        fun format_lease_event/1,
-        Events
-    ).
-
-format_lease_event(#{stream := Stream, progress := Progress} = Event) ->
-    Event#{stream => format_opaque(Stream), progress => format_progress(Progress)};
-format_lease_event(#{stream := Stream} = Event) ->
-    Event#{stream => format_opaque(Stream)}.
-
-format_opaque(Opaque) ->
-    erlang:phash2(Opaque).

apps/emqx/src/emqx_persistent_session_ds/emqx_persistent_session_ds_shared_subs_agent.erl

@@ -1,138 +0,0 @@
-%%--------------------------------------------------------------------
-%% Copyright (c) 2024 EMQ Technologies Co., Ltd. All Rights Reserved.
-%%--------------------------------------------------------------------
-
--module(emqx_persistent_session_ds_shared_subs_agent).
-
--include("shared_subs_agent.hrl").
--include("emqx_session.hrl").
--include("session_internals.hrl").
-
--type session_id() :: emqx_persistent_session_ds:id().
-
--type subscription() :: #{
-    start_time := emqx_ds:time()
-}.
-
--type t() :: term().
--type share_topic_filter() :: emqx_persistent_session_ds:share_topic_filter().
-
--type opts() :: #{
-    session_id := session_id()
-}.
-
-%% TODO
-%% This records go through network, we better shrink them
-%% * use integer keys
-%% * somehow avoid passing stream and topic_filter — they both are part of the iterator
--type stream_lease() :: #{
-    type => lease,
-    %% Used as "external" subscription_id
-    share_topic_filter := share_topic_filter(),
-    stream := emqx_ds:stream(),
-    iterator := emqx_ds:iterator()
-}.
-
--type stream_revoke() :: #{
-    type => revoke,
-    share_topic_filter := share_topic_filter(),
-    stream := emqx_ds:stream()
-}.
-
--type stream_lease_event() :: stream_lease() | stream_revoke().
-
--type stream_progress() :: #{
-    share_topic_filter := share_topic_filter(),
-    stream := emqx_ds:stream(),
-    iterator := emqx_ds:iterator(),
-    use_finished := boolean()
-}.
-
--export_type([
-    t/0,
-    subscription/0,
-    session_id/0,
-    stream_lease_event/0,
-    opts/0
-]).
-
--export([
-    new/1,
-    open/2,
-    can_subscribe/3,
-
-    on_subscribe/3,
-    on_unsubscribe/3,
-    on_stream_progress/2,
-    on_info/2,
-    on_disconnect/2,
-
-    renew_streams/1
-]).
-
--export([
-    send/2,
-    send_after/3
-]).
-
-%%--------------------------------------------------------------------
-%% Behaviour
-%%--------------------------------------------------------------------
-
--callback new(opts()) -> t().
--callback open([{share_topic_filter(), subscription()}], opts()) -> t().
--callback can_subscribe(t(), share_topic_filter(), emqx_types:subopts()) -> ok | {error, term()}.
--callback on_subscribe(t(), share_topic_filter(), emqx_types:subopts()) -> t().
--callback on_unsubscribe(t(), share_topic_filter(), [stream_progress()]) -> t().
--callback on_disconnect(t(), [stream_progress()]) -> t().
--callback renew_streams(t()) -> {[stream_lease_event()], t()}.
--callback on_stream_progress(t(), #{share_topic_filter() => [stream_progress()]}) -> t().
--callback on_info(t(), term()) -> t().
-
-%%--------------------------------------------------------------------
-%% API
-%%--------------------------------------------------------------------
-
--spec new(opts()) -> t().
-new(Opts) ->
-    ?shared_subs_agent:new(Opts).
-
--spec open([{share_topic_filter(), subscription()}], opts()) -> t().
-open(Topics, Opts) ->
-    ?shared_subs_agent:open(Topics, Opts).
-
--spec can_subscribe(t(), share_topic_filter(), emqx_types:subopts()) -> ok | {error, term()}.
-can_subscribe(Agent, ShareTopicFilter, SubOpts) ->
-    ?shared_subs_agent:can_subscribe(Agent, ShareTopicFilter, SubOpts).
-
--spec on_subscribe(t(), share_topic_filter(), emqx_types:subopts()) -> t().
-on_subscribe(Agent, ShareTopicFilter, SubOpts) ->
-    ?shared_subs_agent:on_subscribe(Agent, ShareTopicFilter, SubOpts).
-
--spec on_unsubscribe(t(), share_topic_filter(), [stream_progress()]) -> t().
-on_unsubscribe(Agent, ShareTopicFilter, StreamProgresses) ->
-    ?shared_subs_agent:on_unsubscribe(Agent, ShareTopicFilter, StreamProgresses).
-
--spec on_disconnect(t(), #{share_topic_filter() => [stream_progress()]}) -> t().
-on_disconnect(Agent, StreamProgresses) ->
-    ?shared_subs_agent:on_disconnect(Agent, StreamProgresses).
-
--spec renew_streams(t()) -> {[stream_lease_event()], t()}.
-renew_streams(Agent) ->
-    ?shared_subs_agent:renew_streams(Agent).
-
--spec on_stream_progress(t(), #{share_topic_filter() => [stream_progress()]}) -> t().
-on_stream_progress(Agent, StreamProgress) ->
-    ?shared_subs_agent:on_stream_progress(Agent, StreamProgress).
-
--spec on_info(t(), term()) -> t().
-on_info(Agent, Info) ->
-    ?shared_subs_agent:on_info(Agent, Info).
-
--spec send(pid(), term()) -> term().
-send(Dest, Msg) ->
-    erlang:send(Dest, ?session_message(?shared_sub_message(Msg))).
-
--spec send_after(non_neg_integer(), pid(), term()) -> reference().
-send_after(Time, Dest, Msg) ->
-    erlang:send_after(Time, Dest, ?session_message(?shared_sub_message(Msg))).

apps/emqx/src/emqx_persistent_session_ds/emqx_persistent_session_ds_shared_subs_null_agent.erl

@@ -1,54 +0,0 @@
-%%--------------------------------------------------------------------
-%% Copyright (c) 2024 EMQ Technologies Co., Ltd. All Rights Reserved.
-%%--------------------------------------------------------------------
-
--module(emqx_persistent_session_ds_shared_subs_null_agent).
-
--include("emqx_mqtt.hrl").
-
--export([
-    new/1,
-    open/2,
-    can_subscribe/3,
-
-    on_subscribe/3,
-    on_unsubscribe/3,
-    on_stream_progress/2,
-    on_info/2,
-    on_disconnect/2,
-
-    renew_streams/1
-]).
-
--behaviour(emqx_persistent_session_ds_shared_subs_agent).
-
-%%--------------------------------------------------------------------
-%% API
-%%--------------------------------------------------------------------
-
-new(_Opts) ->
-    undefined.
-
-open(_Topics, _Opts) ->
-    undefined.
-
-can_subscribe(_Agent, _TopicFilter, _SubOpts) ->
-    {error, ?RC_SHARED_SUBSCRIPTIONS_NOT_SUPPORTED}.
-
-on_subscribe(Agent, _TopicFilter, _SubOpts) ->
-    Agent.
-
-on_unsubscribe(Agent, _TopicFilter, _Progresses) ->
-    Agent.
-
-on_disconnect(Agent, _) ->
-    Agent.
-
-renew_streams(Agent) ->
-    {[], Agent}.
-
-on_stream_progress(Agent, _StreamProgress) ->
-    Agent.
-
-on_info(Agent, _Info) ->
-    Agent.

apps/emqx/src/emqx_persistent_session_ds/emqx_ps_ds_int.hrl

@@ -21,7 +21,7 @@
 
 -record(ps_route, {
     topic :: binary(),
-    dest :: emqx_persistent_session_ds_router:dest() | '_'
+    dest :: emqx_persistent_session_ds:id() | '_'
 }).
 
 -record(ps_routeidx, {

apps/emqx/src/emqx_persistent_session_ds/shared_subs_agent.hrl

@@ -1,45 +0,0 @@
-%%--------------------------------------------------------------------
-%% Copyright (c) 2024 EMQ Technologies Co., Ltd. All Rights Reserved.
-%%--------------------------------------------------------------------
-
--ifndef(SHARED_SUBS_AGENT_HRL).
--define(SHARED_SUBS_AGENT_HRL, true).
-
--ifdef(EMQX_RELEASE_EDITION).
-
--if(?EMQX_RELEASE_EDITION == ee).
-
-%% agent from BSL app
-
--ifdef(TEST).
-
--define(shared_subs_agent, emqx_ds_shared_sub_agent).
-
-%% clause of -ifdef(TEST).
--else.
-
-%% Till full implementation we need to dispach to the null agent.
-%% It will report "not implemented" error for attempts to use shared subscriptions.
--define(shared_subs_agent, emqx_persistent_session_ds_shared_subs_null_agent).
-% -define(shared_subs_agent, emqx_ds_shared_sub_agent).
-
-%% end of -ifdef(TEST).
--endif.
-
-%% clause of -if(?EMQX_RELEASE_EDITION == ee).
--else.
-
--define(shared_subs_agent, emqx_persistent_session_ds_shared_subs_null_agent).
-
-%% end of -if(?EMQX_RELEASE_EDITION == ee).
--endif.
-
-%% clause of -ifdef(EMQX_RELEASE_EDITION).
--else.
-
--define(shared_subs_agent, emqx_persistent_session_ds_shared_subs_null_agent).
-
-%% end of -ifdef(EMQX_RELEASE_EDITION).
--endif.
-
--endif.

apps/emqx/src/emqx_persistent_session_ds_gc_worker.erl

@@ -21,7 +21,7 @@
 -include_lib("stdlib/include/qlc.hrl").
 -include_lib("stdlib/include/ms_transform.hrl").
 
--include("session_internals.hrl").
+-include("emqx_persistent_session_ds.hrl").
 
 %% API
 -export([