8c9d98b583
chore: LICENSE Copyright reserved
2022-01-13 16:40:08 +08:00
2939803215
refactor(api): telemetry api swagger spec
2022-01-13 15:53:47 +08:00
82e3565344
chore: major mode file variable for Emacs
2022-01-13 15:53:47 +08:00
683d1c3412
test: fix test cases
2022-01-13 14:27:36 +08:00
e2676bcbd8
fix: fix dep of epgsql
2022-01-13 11:39:48 +08:00
452f6e766a
fix: return error when parse failed
2022-01-13 11:15:08 +08:00
a4f2a9c51d
fix: fix dependency of epgsql
2022-01-13 10:40:22 +08:00
559a23c50f
chore: update tag of epgsql
2022-01-13 10:15:12 +08:00
8570df075c
refactor(emqx_telemetry): Decorate remote procedure calls
2022-01-13 00:35:49 +01:00
e513583e70
refactor(emqx_topic_metrics): Decorate remote procedure calls
2022-01-13 00:11:45 +01:00
64d594d1df
Merge pull request #6705 from k32/bpapi-conf
...
refactor(emqx_conf): Decorate remote procedure calls
2022-01-12 22:32:35 +01:00
1e795759ce
docs(bpapi): Add README
2022-01-12 21:36:24 +01:00
48366a80c8
refactor(emqx_conf): Decorate cluster RPCs
2022-01-12 21:28:24 +01:00
cc2ae5ed71
Merge pull request #6624 from HJianBo/fix-conf-name-prefix
...
Remove `emqx_` prefix for some config scopes
2022-01-12 20:36:52 +01:00
784ca5bf24
fix(emqx_map_lib): Fix underspec
2022-01-12 16:20:13 +01:00
d25258943b
feat(bpapi): Verify emqx cluster RPC
2022-01-12 16:19:46 +01:00
641fe64d00
docs: ensure authn schema ns for password-hash structs
2022-01-12 15:48:30 +01:00
04bac16741
fix(bpapi): Use argument types from the spec
2022-01-12 15:40:21 +01:00
7b65684c45
refactor(emqx_conf): Decorate remote procedure calls
2022-01-12 15:40:21 +01:00
6e0a248555
chore: add namespace for _schema.erl module
2022-01-12 15:01:00 +01:00
552ea7d2fc
Merge pull request #6696 from terry-xiaoyu/rule_metrics2
...
Improve rule metrics
2022-01-12 14:53:09 +08:00
b1959086d9
chore: fix elvis warnings
2022-01-12 13:51:37 +08:00
12cc9065f8
chore(limiter): change root name emqx_limiter > limiter
2022-01-12 13:51:37 +08:00
10b110447c
chore(exhook): change root name emqx_exhook > exhook
2022-01-12 13:51:37 +08:00
af2868e598
chore(dashboard): change root name emqx_dashboard > dashboard
2022-01-12 13:51:34 +08:00
2eb7346229
chore: update tag of epgsql
2022-01-12 13:49:26 +08:00
cad4eff283
refactor(persistent_session): Decorate API calls
2022-01-11 14:28:29 +01:00
6a1ada8623
Merge pull request #6691 from k32/bpapi-run-check
...
test(bpapi): Run static checks in CI
2022-01-11 13:25:06 +01:00
26f4b2495b
test(bpapi): Run verification in CI
2022-01-11 11:26:35 +01:00
6bb919b65c
chore(retainer): change root name emqx_retainer > retainer
2022-01-11 15:30:42 +08:00
9a03869bd7
chore(slow-subs): change root name emqx_slow_subs > slow_subs
2022-01-11 15:30:42 +08:00
19dd5a7c97
Merge pull request #6661 from HJianBo/fix-client-fuzzy-matching-for-5
...
chore: client searching support \[]()* chars
2022-01-11 15:03:44 +08:00
2a2a00e0ad
fix(rule): remove rules from all nodes in the cluster
2022-01-11 14:44:08 +08:00
ac631110cb
chore: remove useless field
2022-01-11 10:05:11 +08:00
2791052135
fix: fix errors caused by concurrent parsing of sql
2022-01-11 09:39:56 +08:00
13f0b12b45
Merge pull request #6689 from k32/bpapi-telemetry
...
fix(emqx_telemetry): Decorate RPC calls
2022-01-10 22:35:18 +01:00
a9673d7d2d
fix(emqx_telemetry): Decorate RPC calls
2022-01-10 18:43:44 +01:00
c154c8ae0c
Merge pull request #6686 from k32/bpapi-statsd
...
fix(emqx_statsd): Decorate RPC calls
2022-01-10 18:38:05 +01:00
3d26592e72
fix(emqx_statsd): Decorate RPC calls
2022-01-10 11:58:00 +01:00
31d68bfba9
Merge pull request #6684 from zhongwencool/rename-mgmt-ct
...
chore(test): rename mgmt_xxx_api_SUITE to mgmt_api_xxx_SUITE
2022-01-10 17:17:10 +08:00
81abf31bc4
chore(test): rename mgmt_xxx_api_SUITE to mgmt_api_xxx_SUITE
2022-01-10 15:52:00 +08:00
76695c9652
test: update epgsql branch to test
2022-01-10 15:00:08 +08:00
fcc0d4a2e4
chore: client searching support \[]()* chars
2022-01-10 09:07:53 +08:00
f4bf749134
Merge pull request #6679 from k32/bpapi-emqx
...
refactor(emqx): Decorate remote procedure calls
2022-01-07 19:52:45 +01:00
9602ce0250
Merge pull request #6678 from k32/broker-bpapi
...
refactor(emqx_broker): Decorate remote procedure calls
2022-01-07 16:23:12 +01:00
8c72eeb8d1
refactor(emqx): Decorate remote procedure calls
2022-01-07 12:59:10 +01:00
1754afdab0
refactor(emqx_broker): Decorate remote procedure calls
2022-01-07 12:07:29 +01:00
de89f7b253
fix(emqx_rpc): Add types and remove impossible clauses
2022-01-07 12:06:41 +01:00
2307040bec
fix(bpapi): Add more static checks exceptions
2022-01-07 10:57:53 +01:00
6ea51692c3
Merge pull request #6672 from zhongwencool/return-ok-when-trace-not-found
...
fix: delete error log when file enoent.
2022-01-07 15:36:03 +08:00
0ec111d4e0
fix(test): flaky emqx_connector_api_SUITE test case.
2022-01-07 14:45:47 +08:00
7dcb9567e7
fix(bridge): get bridges from all nodes crash
2022-01-07 14:34:59 +08:00
977b1bb7ec
chore(test): add snabbkaffe for create_trace test
2022-01-07 11:08:40 +08:00
07ba4ad05e
fix: delete error log when file enoent.
...
delete emqx_trace_api, replace LOG by SLOG
2022-01-07 10:24:26 +08:00
821b50a961
test(mongo): add test case for w_mode option
2022-01-07 09:52:15 +08:00
c33eb84cb6
fix(mongo): add r_mode and w_mode options
2022-01-07 09:52:15 +08:00
72d55c8c0d
fix(rules): improve the names of the metrics
2022-01-07 09:35:00 +08:00
67a60e1153
refactor(rule): add more metrics for rule and bridges
2022-01-07 09:34:54 +08:00
78aa0abd3d
fix(metrics): update the calls to emqx_plugin_libs_metrcis module
2022-01-07 09:34:48 +08:00
ab5ad22b1d
fix(metrics): update the calls to emqx_plugin_libs_metrcis module
2022-01-07 09:34:41 +08:00
c1212c4b6d
refactor(metrics): improve the metrics for bridges/rules
2022-01-07 09:34:31 +08:00
80a06c7201
Merge pull request #6654 from emqx/fix-unknown-calls
...
fix: rm unknown call (`ct:pal`)
2022-01-06 14:12:53 -03:00
9059f2005a
fix(elixir): put Patch in version and add missing deps
...
Elixir requires that we use version of the form `Major.Minor.Patch`.
Also, Mix requires dependecies to be declared in `rebar.config` so it
can include the header files correctly.
2022-01-06 10:54:45 -03:00
e9fb999236
Merge pull request #6667 from zmstone/chore-fix-copyright-update-script
...
chore: fix copyright update script to include more files
2022-01-06 13:45:24 +01:00
3bdfa183f3
Merge pull request #6666 from JimMoen/merge-5.0-beta.3-to-master
...
Merge 5.0 beta.3 to master
2022-01-06 18:20:30 +08:00
9f7b513a3f
chore: fix copyright update script to include more files
2022-01-06 08:44:35 +01:00
552165db26
test(authz): fix test suite based on release-5.0-beta.3
2022-01-06 15:05:52 +08:00
9a115b99a4
Merge remote-tracking branch 'emqx/release-5.0-beta.3' into merge-5.0-beta.3-to-master
2022-01-06 14:08:45 +08:00
67ba3a06ea
chore(gateway): update copyright
2022-01-05 20:55:00 +01:00
63167cea70
chore: update copyright
2022-01-05 20:55:00 +01:00
f4ed3ccdd7
chore(release): update emqx release version
2022-01-05 23:30:06 +08:00
b6efa2aa9c
Merge pull request #6629 from k32/bpapi
...
feat(bpapi): Add backplane API static checks
2022-01-05 15:26:11 +01:00
f4f5281b16
fix: authz headers default value
2022-01-05 22:06:50 +08:00
c882b08b08
fix: rm unknown call (`ct:pal`)
2022-01-05 10:37:45 -03:00
22bdcfa4b5
fix(bpapi): Apply remarks
2022-01-05 14:37:26 +01:00
d3d240e8d5
fix: revert hocon to 0.22.1
2022-01-05 19:50:11 +08:00
9c675194f5
fix(bpapi): Fix dialyzer warnings
2022-01-05 12:10:48 +01:00
7e48a4e6f5
fix: authz default should be a map
2022-01-05 19:04:51 +08:00
d39fafbed2
Merge pull request #6651 from DDDHuang/fix_update3
...
fix(prometheus): restart error
2022-01-05 17:37:50 +08:00
4588ace79f
fix(statsd): restart error
2022-01-05 17:34:20 +08:00
5e48f55eef
fix(prometheus): restart error
2022-01-05 17:32:09 +08:00
db0e4948a1
Merge pull request #6648 from DDDHuang/fix_update2
...
fix(config): restart app after config update in cluster
2022-01-05 17:14:40 +08:00
adca9e6f22
Merge pull request #6645 from zhongwencool/fix-authz-reboot-headers-atom
...
fix: make sure authz headers is binary.
2022-01-05 16:49:25 +08:00
6c574c08b8
fix(config): update config by emqx_conf
2022-01-05 16:11:55 +08:00
31aed3ea8e
fix(prometheus): stop app with error check & dialyzer
2022-01-05 15:59:17 +08:00
c6c7f70a30
chore(hocon): upgrade hocon to 0.22.3
2022-01-05 15:57:19 +08:00
47441fb747
fix(gw): fix bad default oom policy
2022-01-05 15:49:44 +08:00
a7325fe4d0
Merge pull request #6613 from JimMoen/update-dashobard
...
update dashboard version, fix connector api
2022-01-05 15:30:30 +08:00
303707d69d
fix: make sure authz headers is binary.
2022-01-05 15:11:16 +08:00
72713cb85f
fix(config): restart app after config update in cluster
2022-01-05 15:06:18 +08:00
4b4403354d
Merge pull request #6558 from JimMoen/fix-auth-http
...
authn and authz http query string percent encode in url field
2022-01-05 14:06:10 +08:00
21bf07a01c
fix(test): race conditions in connector_api_SUITE
2022-01-05 11:41:17 +08:00
81d862061a
Merge pull request #6557 from lafirest/fix/limiter
...
feat(emqx_limiter): improve burst implementation
2022-01-05 09:43:22 +08:00
d35b418ed6
Merge pull request #6616 from DDDHuang/emqx_prometheus_cluster
...
fix(prometheus): update config in cluster
2022-01-05 09:43:11 +08:00
a212592d0e
Merge pull request #6594 from lafirest/fix/default_value
...
fix(emqx_slow_subs): fix default expire value
2022-01-05 09:42:53 +08:00
6a80f8320d
Merge pull request #6622 from lafirest/fix/retainer_stats
...
fix(emqx_retainer): fix the stats function of retainer
2022-01-05 09:42:38 +08:00
eabede04f3
fix(test): emqx_connector_api_SUITE add sleep
2022-01-05 09:28:49 +08:00
20c5343f9b
fix(prometheus): dialyzer
2022-01-05 09:28:49 +08:00
e908973a86
fix(statsd): update config bug
2022-01-05 09:28:49 +08:00
7bc59969eb
fix(prometheus): update config in cluster
2022-01-05 09:28:49 +08:00
f5288e895f
Merge pull request #6617 from HJianBo/integrate_emqx_conf_into_modules
2022-01-05 09:23:52 +08:00
4f3f938d71
feat(bpapi): Introduce bpapi behavior
2022-01-05 01:43:18 +01:00
0f6ec9d646
fix(bpapi): Fix build
2022-01-05 01:28:34 +01:00
eaa71438b2
feat(bpapi): Typecheck function parameters
2022-01-05 01:28:34 +01:00
64378be9a0
fix(bpapi): Optimize BPAPI dump size
2022-01-05 01:28:34 +01:00
2c3af8d9fe
feat(bpapi): Move to emqx
...
Fix standalone build
2022-01-05 01:28:34 +01:00
96fdd0c31f
fix(bpapi): Fix build order
2022-01-05 01:28:34 +01:00
5c2a559991
feat(bpapi): Initial commit
2022-01-05 01:28:34 +01:00
6ee18b6104
refactor(broker): Don't use a macro
2022-01-05 01:28:31 +01:00
211b8e1b06
Merge remote-tracking branch 'origin/release-5.0-beta.3' into merge-5.0-beta.3-to-master
2022-01-04 22:48:25 +01:00
503bf54c77
test(authz): fix meck calls
...
f
2022-01-04 13:54:25 +01:00
fa25991c5c
test(authz): authnz acl query string use placehodler
2022-01-04 18:13:27 +08:00
6affb5aca1
fix(authn): authn http resource url query string
2022-01-04 18:13:27 +08:00
ab37c48860
fix(authz): authz http resource url query string
2022-01-04 18:13:27 +08:00
a593921137
fix(emqx_retainer): fix the stats function of retainer
2022-01-04 17:26:48 +08:00
aacdc5c2f7
fix(emqx_retainer): remove disc_only option
2022-01-04 14:40:11 +08:00
126924bc54
Merge pull request #6567 from HJianBo/gw-review-r4
2022-01-04 11:24:03 +08:00
2c67ec44f4
fix(topic-metrics): fix bad map for calculating metrics
2022-01-04 11:11:41 +08:00
aa4eec3127
Merge pull request #6591 from zhongwencool/api-key-update-unexpired
...
fix(api_key): set api_key unexpired when update expired_at=undefined
2022-01-04 10:54:05 +08:00
075669461c
fix: compile error
2022-01-04 09:53:50 +08:00
b5e7344752
build(emqx_plugin_libs): add rebar.config to help mix build
2022-01-04 01:00:09 +01:00
e3c8f67aaf
test: resource creation now checks health
...
adjust test case to work with new code behavior
2022-01-04 00:54:09 +01:00
7b478817bd
test: test authz against 'single' mogodb
2022-01-04 00:54:09 +01:00
6c99b64e4c
refactor(emqx_plugin_libs_pool): structured logging
2022-01-04 00:54:09 +01:00
719800914a
Merge branch 'ci-run-dialyzer-on-slef-hosted' into merge-5.0-beta.3-to-master
2022-01-03 16:23:11 +01:00
f866488bc2
test: fix mongodb tls suite
...
dryruns return error when local health check fails
2022-01-03 16:22:44 +01:00
b4048c2789
Merge pull request #6609 from k32/dev/sysmon-conf
...
fix(system_monitor): Unify configuration with sysmon
2022-01-03 14:03:32 +01:00
2fbe2dd0c3
fix(boot): ensure emqx_conf is the first app to boot
...
The first one to boot after emqx_machine
2022-01-03 12:53:49 +01:00
377ed03a20
fix(system_monitor): Unify configuration with sysmon
2022-01-03 12:09:37 +01:00
65b1ce80d9
chore: fix deps discrepancy
2022-01-03 11:47:43 +01:00
2898fa76e1
Merge remote-tracking branch 'origin/release-5.0-beta.3' into merge-5.0-beta.3-to-master
2022-01-03 11:39:06 +01:00
e00cf71911
Merge branch 'release-5.0-beta.3' into gw-review-r4
2022-01-03 16:05:46 +08:00
e95445728c
fix(test): wait until the bridge ready
2022-01-02 23:59:56 +08:00
11736dc1d7
fix(bridge): check health immediately after updated
2022-01-02 22:45:32 +08:00
a64b29ff76
fix(resource): re-create the helth checker if already exists
2022-01-02 20:36:30 +08:00
e1ab331a30
refactor(resource): support async create mode
2022-01-02 20:20:39 +08:00
2277b75b2f
refactor(resource): improve the process starting/stopping resource instances
2022-01-02 17:14:02 +08:00
95340b7baa
Merge pull request #6564 from EMQ-YangM/beta3
...
feat(emqx_resource): add health_ckeck process
2022-01-02 12:46:22 +08:00
33523d9294
Merge branch 'release-5.0-beta.3' into api-key-update-unexpired
2022-01-02 09:35:04 +08:00
808646c2a1
fix(bridge): prohibit deleting connectors that are in use
2022-01-01 22:10:13 +08:00
852033a955
Merge pull request #6525 from savonarola/authn-ssl-tests
...
chore(authn): test authn ssl settings
2022-01-01 13:41:37 +03:00
59e2614574
fix(dialyzer): unmatched results in emqx_statsd_api
2022-01-01 04:23:51 +08:00
925d46fe86
fix(connector): add testcase for binding egress mqtt bridge to rules
2022-01-01 04:12:20 +08:00
9a7452e1c5
fix(connector): add testcase for binding ingress mqtt bridge to rules
2022-01-01 03:07:31 +08:00
6858f496a7
chore(hocon): update hocon version
2021-12-31 14:13:39 -03:00
7643564ef1
Merge pull request #6597 from terry-xiaoyu/bridge_bug_fixes_2
...
Bridge bug fixes 2
2022-01-01 00:10:26 +08:00
384493369b
Merge pull request #6587 from savonarola/improve-authz-coverage-more
...
chore(authz): increase coverage
2021-12-31 18:58:21 +03:00
efec4564f0
fix(resource): update test cases on resource not_found
2021-12-31 22:25:45 +08:00
b74a9bfda1
fix(swagger): duplicate keys in swagger doc
2021-12-31 22:20:22 +08:00
658f819aab
fix(bridges): keep multiple bridges from affecting each other on crash
2021-12-31 21:28:32 +08:00
f65eca4c47
fix(authn): update testcase for resource not running
2021-12-31 21:08:07 +08:00
657ecef67b
fix(resource): don't crash on resource stopped
2021-12-31 20:57:34 +08:00
071b03b29c
refactor: statsd supervisor API no need to return error
...
Also to make dialyzer happy
2021-12-31 12:27:25 +01:00
2a0d8752bd
fix(statsd): already_started crash and diaylizer warning
2021-12-31 17:32:51 +08:00
d0e8285e93
fix(trace): download trace request not compelete but the zip file is delete sometimes
2021-12-31 17:32:07 +08:00
87bff075ad
fix(api_key): set api_key unexpired when update expired_at=undefined
2021-12-31 17:32:07 +08:00
231aeb6068
fix(statsd): fix dialyzer warnings
2021-12-31 16:41:35 +08:00
54ea7a5871
Merge pull request #6582 from DDDHuang/config_bugfix
...
fix(config): update configs in cluster
2021-12-31 16:03:41 +08:00
d27aecc985
Merge pull request #6590 from DDDHuang/delayed_b64
...
fix(delayed): base64 encode twice
2021-12-31 16:02:32 +08:00
6404efd0ec
fix(emqx_slow_subs): fix default expire value
2021-12-31 15:59:47 +08:00
e299d8d138
fix(rule): rules not triggered after the ingress mqtt bridge received some msg
2021-12-31 15:47:03 +08:00
b09d0d8e4c
Merge pull request #6586 from zmstone/docs-explain-layered-config-at-the-top
...
docs: explain layered config at the top
2021-12-31 08:10:15 +01:00
2411c22b42
fix(gw): fix bad listners field on http response
2021-12-31 14:59:17 +08:00
990514a048
fix(gw): stop xml_object_db process synchronously
2021-12-31 14:32:03 +08:00
2a20f110b9
fix(gw): use emqx_http_lib to parse uri
2021-12-31 14:32:03 +08:00
6cde540fd1
fix(test): close app at end_per_suite
2021-12-31 14:17:50 +08:00
388fdc6057
Merge pull request #6589 from DDDHuang/statsd_cluster_config
...
fix(statsd): update config in cluster
2021-12-31 14:09:05 +08:00
d18a2ab57c
fix(delayed): base64 encode twice
2021-12-31 14:07:34 +08:00
c7693246fe
feat(emqx_resource): add health_ckeck process, it will periodically perform health checks, and print error logs and generate alarms when the checks fail.
2021-12-30 21:53:51 -08:00
6e6643f974
fix: fix dialyzer warnings
2021-12-31 12:51:35 +08:00
ebbb473d7a
refactor(topic-metrics): cluster supported
2021-12-31 12:50:23 +08:00
3a38e8d68d
fix(statsd): update config in cluster
2021-12-31 12:48:24 +08:00
173ae46538
fix(auto_subscribe): bad test suite
2021-12-31 12:46:29 +08:00
a630044688
fix: update result by row_config
2021-12-31 12:46:29 +08:00
f0330d9334
fix(event_message): update config in cluster
2021-12-31 12:46:29 +08:00
6c52fb4806
fix: code format
2021-12-31 12:46:29 +08:00
23cf74d829
fix(delayed): update config in cluster
2021-12-31 12:46:29 +08:00
f19ccdfcde
fix(auto_subscribe): update config in cluster
2021-12-31 12:46:29 +08:00
9ba454a63d
fix(bridge): filter the topic of received msgs got from remote MQTT broker
2021-12-31 12:00:43 +08:00
14ee053a0e
Merge pull request #6563 from terry-xiaoyu/bridge_bug_fixes_1
...
Bridge bug fixes 1
2021-12-31 11:57:28 +08:00
922fc0ad9f
Merge pull request #6578 from lafirest/fix/retainer_config
...
fix(emqx_retainer): fix config update error
2021-12-31 11:13:44 +08:00
86001765cb
fix(emqx_retainer): fix config update error
2021-12-31 09:56:25 +08:00
2ffcaad41e
chore(authz): increase coverage
2021-12-31 01:24:18 +03:00
c29bc126ef
Merge pull request #6507 from emqx/build-with-mix-mkII
...
Build with Elixir Mix Release
2021-12-30 15:00:38 -03:00
d88a648092
docs: update config doc
...
Explain layered style at the very top of the doc
2021-12-30 18:38:01 +01:00
d191f7cf7e
chore: update to hocon 0.22.2
2021-12-30 18:36:26 +01:00
94a5965560
fix(rule): dead lock when update configs for rules
2021-12-31 00:03:03 +08:00
626a4c4713
fix(machine): some apps not restarted after joining into the cluster
2021-12-31 00:03:03 +08:00
a42ab3d9da
fix(rule): use emqx_conf:update/3 to make changes to all nodes
2021-12-31 00:03:03 +08:00
ea2d4674df
fix(resource): metrics were cleared after updating the resource
2021-12-31 00:03:03 +08:00
e2d899ad6e
fix(bridge): HTTP reqeust crash if using GET an DELETE method
2021-12-31 00:03:03 +08:00
9d733c2ec5
fix(resource): typos on restart a resource
2021-12-30 23:48:41 +08:00
d11cf6ad64
fix(bridges): store connector name and bridge name to config files
2021-12-30 23:48:41 +08:00
110ae62b24
fix(bridge): don't concat names into ids
2021-12-30 23:48:41 +08:00
14089a572e
fix(bridge): changes timeouts from 30s to 15s
2021-12-30 23:48:41 +08:00
aefcd6275b
fix(bridges): ingress MQTT bridges didn't increase counters on msg received
2021-12-30 23:48:41 +08:00
c23436166b
fix(bridge): HTTP connector should failed on non-200 status codes
2021-12-30 23:48:41 +08:00
ea1aaa9806
fix(bridge): remove clientid config from MQTT bridges
...
Don't allow the user provide the clientid for connecting the remote broker.
We generate the clientid using the bridge id and node name.
2021-12-30 23:48:41 +08:00
d16362af96
Merge pull request #6547 from zhongwencool/trace-formatter
...
feat(trace): replace logger_formatter by emqx_trace_formatter
2021-12-30 23:40:59 +08:00
489fb7f806
fix(trace): copy binary:encode_hex/2 from binary.erl
2021-12-30 21:38:23 +08:00
JimMoen