chore: make elvis checking happy

apps/emqx_auth_mnesia/src/emqx_authn_mnesia.erl

@@ -78,6 +78,8 @@
     {<<"is_superuser">>, atom}
 ]).
 
+-elvis([{elvis_style, nesting_level, disable}]).
+
 %%------------------------------------------------------------------------------
 %% Mnesia bootstrap
 %%------------------------------------------------------------------------------
@@ -175,10 +177,12 @@ import_users({PasswordType, Filename, FileData}, State) ->
     Convertor = convertor(PasswordType, State),
     try
         {_NewUsersCnt, Users} = parse_import_users(Filename, FileData, Convertor),
-        try
         case do_import_users(Users) of
-                ok -> ok;
+            ok ->
-                {error, Reason} -> error(Reason)
+                ok;
+            {error, Reason} ->
+                _ = do_clean_imported_users(Users),
+                error(Reason)
         end
     catch
         error:Reason1:Stk ->
@@ -191,21 +195,7 @@ import_users({PasswordType, Filename, FileData}, State) ->
                     stacktrace => Stk
                 }
             ),
-                _ = do_clean_imported_users(Users),
             {error, Reason1}
-        end
-    catch
-        error:Reason2:Stk2 ->
-            ?SLOG(
-                warning,
-                #{
-                    msg => "import_users_failed",
-                    type => PasswordType,
-                    filename => Filename,
-                    stacktrace => Stk2
-                }
-            ),
-            {error, Reason2}
     end.
 
 do_import_users(Users) ->
@@ -514,10 +504,7 @@ reader(json, Data, Convertor) when is_binary(Data) ->
 %% Example: data/user-credentials.csv
 reader(csv, Data, Convertor) when is_binary(Data) ->
     CSVData = csv_data(Data),
-    case get_csv_header(CSVData) of
+    Reader = fun _Iter(Headers, Lines) ->
-        {ok, Headers, CSVLines} ->
-            Reader =
-                fun _Iter(Lines) ->
         case csv_read_line(Lines) of
             {ok, Line, Rest} ->
                 %% XXX: not support ' ' for a field?
@@ -527,7 +514,7 @@ reader(csv, Data, Convertor) when is_binary(Data) ->
                 case length(Fields) == length(Headers) of
                     true ->
                         User = maps:from_list(lists:zip(Headers, Fields)),
-                                    {Convertor(User), fun() -> _Iter(Rest) end};
+                        {Convertor(User), fun() -> _Iter(Headers, Rest) end};
                     false ->
                         error(bad_format)
                 end;
@@ -535,7 +522,9 @@ reader(csv, Data, Convertor) when is_binary(Data) ->
                 eof
         end
     end,
-            fun() -> Reader(CSVLines) end;
+    case get_csv_header(CSVData) of
+        {ok, CSVHeaders, CSVLines} ->
+            fun() -> Reader(CSVHeaders, CSVLines) end;
         {error, Reason} ->
             error(Reason)
     end;