From faf5916ed6878111915aafecb3eee90a41e167a2 Mon Sep 17 00:00:00 2001
From: "Zaiming (Stone) Shi" <zmstone@gmail.com>
Date: Wed, 18 Jan 2023 07:52:28 +0100
Subject: [PATCH] test: relax recoverable/unrecoverable error check

for now, treat all other errors unrecoverable
---
 apps/emqx_resource/src/emqx_resource_worker.erl | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/apps/emqx_resource/src/emqx_resource_worker.erl b/apps/emqx_resource/src/emqx_resource_worker.erl
index 698d783f6..6b923f19d 100644
--- a/apps/emqx_resource/src/emqx_resource_worker.erl
+++ b/apps/emqx_resource/src/emqx_resource_worker.erl
@@ -1222,8 +1222,15 @@ mark_as_sent(?QUERY(From, Req, _)) ->
 
 is_unrecoverable_error({error, {unrecoverable_error, _}}) ->
     true;
+is_unrecoverable_error({error, {recoverable_error, _}}) ->
+    false;
 is_unrecoverable_error({async_return, Result}) ->
     is_unrecoverable_error(Result);
+is_unrecoverable_error({error, _}) ->
+    %% TODO: delete this clause.
+    %% Ideally all errors except for 'unrecoverable_error' should be
+    %% retried, including DB schema errors.
+    true;
 is_unrecoverable_error(_) ->
     false.