yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: use meck in olp tests 

avoid flaky test results by using mecks.
This commit is contained in:
William Yang 2023-05-25 17:26:51 +02:00
parent 6b5b9fc8b8
commit f2e54c9a6e
1 changed files with 12 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
apps/emqx/test/emqx_olp_SUITE.erl
View File

@ -19,8 +19,6 @@
-compile(export_all). -compile(export_all).
-compile(nowarn_export_all). -compile(nowarn_export_all).
-include_lib("emqx/include/emqx.hrl").
-include_lib("emqx/include/emqx_mqtt.hrl").
-include_lib("eunit/include/eunit.hrl"). -include_lib("eunit/include/eunit.hrl").
-include_lib("common_test/include/ct.hrl"). -include_lib("common_test/include/ct.hrl").
-include_lib("lc/include/lc.hrl"). -include_lib("lc/include/lc.hrl").
@ -61,61 +59,41 @@ t_disable_enable(_Config) ->
ok = emqx_olp:disable(), ok = emqx_olp:disable(),
?assert(not is_process_alive(Old)), ?assert(not is_process_alive(Old)),
{ok, Pid} = emqx_olp:enable(), {ok, Pid} = emqx_olp:enable(),
timer:sleep(1000),
?assert(is_process_alive(Pid)). ?assert(is_process_alive(Pid)).
%% Test that overload detection works %% Test that overload detection works
t_is_overloaded(_Config) -> t_is_overloaded(_Config) ->
P = burst_runq(), meck:new(load_ctl, [passthrough]),
timer:sleep(3000), meck:expect(load_ctl, is_overloaded, fun() -> true end),
?assert(emqx_olp:is_overloaded()), ?assert(emqx_olp:is_overloaded()),
exit(P, kill), meck:expect(load_ctl, is_overloaded, fun() -> false end),
timer:sleep(3000), ?assert(not emqx_olp:is_overloaded()),
?assert(not emqx_olp:is_overloaded()). meck:unload(load_ctl).
%% Test that new conn is rejected when olp is enabled %% Test that new conn is rejected when olp is enabled
t_overloaded_conn(_Config) -> t_overloaded_conn(_Config) ->
process_flag(trap_exit, true), process_flag(trap_exit, true),
?assert(erlang:is_process_alive(load_ctl:whereis_runq_flagman())), ?assert(erlang:is_process_alive(load_ctl:whereis_runq_flagman())),
emqx_config:put([overload_protection, enable], true), emqx_config:put([overload_protection, enable], true),
P = burst_runq(), meck:new(load_ctl, [passthrough]),
timer:sleep(1000), meck:expect(load_ctl, is_overloaded, fun() -> true end),
?assert(emqx_olp:is_overloaded()), ?assert(emqx_olp:is_overloaded()),
true = emqx:is_running(node()), true = emqx:is_running(node()),
{ok, C} = emqtt:start_link([{host, "localhost"}, {clientid, "myclient"}]), {ok, C} = emqtt:start_link([{host, "localhost"}, {clientid, "myclient"}]),
?assertNotMatch({ok, _Pid}, emqtt:connect(C)), ?assertNotMatch({ok, _Pid}, emqtt:connect(C)),
exit(P, kill). meck:unload(load_ctl).
%% Test that new conn is rejected when olp is enabled %% Test that new conn is rejected when olp is enabled
t_overload_cooldown_conn(Config) -> t_overload_cooldown_conn(Config) ->
t_overloaded_conn(Config), t_overloaded_conn(Config),
timer:sleep(1000), meck:new(load_ctl, [passthrough]),
meck:expect(load_ctl, is_overloaded, fun() -> false end),
?assert(not emqx_olp:is_overloaded()), ?assert(not emqx_olp:is_overloaded()),
true = emqx:is_running(node()), true = emqx:is_running(node()),
{ok, C} = emqtt:start_link([{host, "localhost"}, {clientid, "myclient"}]), {ok, C} = emqtt:start_link([{host, "localhost"}, {clientid, "myclient"}]),
?assertMatch({ok, _Pid}, emqtt:connect(C)), ?assertMatch({ok, _Pid}, emqtt:connect(C)),
emqtt:stop(C). emqtt:stop(C),
meck:unload(load_ctl).
-spec burst_runq() -> ParentToKill :: pid().
burst_runq() ->
NProc = erlang:system_info(schedulers_online),
spawn(?MODULE, worker_parent, [NProc * 1000, {?MODULE, busy_loop, []}]).
%% internal helpers
worker_parent(N, {M, F, A}) ->
lists:foreach(
fun(_) ->
proc_lib:spawn_link(fun() -> apply(M, F, A) end)
end,
lists:seq(1, N)
),
receive
stop -> ok
end.
busy_loop() ->
erlang:yield(),
busy_loop().
wait_for(_Fun, 0) -> wait_for(_Fun, 0) ->
false; false;