feat: add custom callback for creating connector from bridge V1 config

apps/emqx_bridge/src/emqx_action_info.erl

@@ -28,6 +28,8 @@
     registered_schema_modules/0,
     connector_action_config_to_bridge_v1_config/3,
     has_custom_connector_action_config_to_bridge_v1_config/1,
+    bridge_v1_config_to_connector_config/2,
+    has_custom_bridge_v1_config_to_connector_config/1,
     bridge_v1_config_to_action_config/3,
     has_custom_bridge_v1_config_to_action_config/1,
     transform_bridge_v1_config_to_action_config/4
@@ -41,6 +43,8 @@
 -callback connector_action_config_to_bridge_v1_config(
     ConnectorConfig :: map(), ActionConfig :: map()
 ) -> map().
+%% Define this if the automatic config upgrade is not enough for the connector.
+-callback bridge_v1_config_to_connector_config(BridgeV1Config :: map()) -> map().
 %% Define this if the automatic config upgrade is not enough for the bridge.
 %% If you want to make use of the automatic config upgrade, you can call
 %% emqx_action_info:transform_bridge_v1_config_to_action_config/4 in your
@@ -51,6 +55,7 @@
 -optional_callbacks([
     bridge_v1_type_name/0,
     connector_action_config_to_bridge_v1_config/2,
+    bridge_v1_config_to_connector_config/1,
     bridge_v1_config_to_action_config/2
 ]).
 
@@ -139,6 +144,15 @@ connector_action_config_to_bridge_v1_config(ActionOrBridgeType, ConnectorConfig,
     %% should only be called if defined
     Module:connector_action_config_to_bridge_v1_config(ConnectorConfig, ActionConfig).
 
+has_custom_bridge_v1_config_to_connector_config(ActionOrBridgeType) ->
+    Module = get_action_info_module(ActionOrBridgeType),
+    erlang:function_exported(Module, bridge_v1_config_to_connector_config, 1).
+
+bridge_v1_config_to_connector_config(ActionOrBridgeType, BridgeV1Config) ->
+    Module = get_action_info_module(ActionOrBridgeType),
+    %% should only be called if defined
+    Module:bridge_v1_config_to_connector_config(BridgeV1Config).
+
 has_custom_bridge_v1_config_to_action_config(ActionOrBridgeType) ->
     Module = get_action_info_module(ActionOrBridgeType),
     erlang:function_exported(Module, bridge_v1_config_to_action_config, 2).

apps/emqx_connector/src/schema/emqx_connector_schema.erl

@@ -103,24 +103,34 @@ bridge_configs_to_transform(
 split_bridge_to_connector_and_action(
     {ConnectorsMap, {BridgeType, BridgeName, BridgeV1Conf, ConnectorFields, PreviousRawConfig}}
 ) ->
-    %% Get connector fields from bridge config
+    ConnectorMap =
-    ConnectorMap = lists:foldl(
+        case emqx_action_info:has_custom_bridge_v1_config_to_connector_config(BridgeType) of
-        fun({ConnectorFieldName, _Spec}, ToTransformSoFar) ->
+            true ->
-            case maps:is_key(to_bin(ConnectorFieldName), BridgeV1Conf) of
+                emqx_action_info:bridge_v1_config_to_connector_config(
-                true ->
+                    BridgeType, BridgeV1Conf
-                    NewToTransform = maps:put(
+                );
-                        to_bin(ConnectorFieldName),
+            false ->
-                        maps:get(to_bin(ConnectorFieldName), BridgeV1Conf),
+                %% We do an automatic transfomation to get the connector config
-                        ToTransformSoFar
+                %% if the callback is not defined.
-                    ),
+                %% Get connector fields from bridge config
-                    NewToTransform;
+                lists:foldl(
-                false ->
+                    fun({ConnectorFieldName, _Spec}, ToTransformSoFar) ->
-                    ToTransformSoFar
+                        case maps:is_key(to_bin(ConnectorFieldName), BridgeV1Conf) of
-            end
+                            true ->
+                                NewToTransform = maps:put(
+                                    to_bin(ConnectorFieldName),
+                                    maps:get(to_bin(ConnectorFieldName), BridgeV1Conf),
+                                    ToTransformSoFar
+                                ),
+                                NewToTransform;
+                            false ->
+                                ToTransformSoFar
+                        end
+                    end,
+                    #{},
+                    ConnectorFields
+                )
         end,
-        #{},
-        ConnectorFields
-    ),
     %% Generate a connector name, if needed.  Avoid doing so if there was a previous config.
     ConnectorName =
         case PreviousRawConfig of