yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore(dsrepl): update few outdated comments / TODOs

This commit is contained in:
Andrew Mayorov 2024-04-07 22:41:44 +02:00
parent 6293efb995
commit ecaad348a7
No known key found for this signature in database
GPG Key ID: 2837C62ACFBFED5D
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
apps/emqx_durable_storage/src/emqx_ds_replication_layer_shard.erl
View File

@ -98,13 +98,11 @@ get_servers_leader_preferred(DB, Shard) ->
Servers = ra_leaderboard:lookup_members(ClusterName), Servers = ra_leaderboard:lookup_members(ClusterName),
[Leader | lists:delete(Leader, Servers)]; [Leader | lists:delete(Leader, Servers)];
undefined -> undefined ->
%% TODO: Dynamic membership.
get_shard_servers(DB, Shard) get_shard_servers(DB, Shard)
end. end.
get_server_local_preferred(DB, Shard) -> get_server_local_preferred(DB, Shard) ->
%% NOTE: Contact random replica that is not a known leader. %% NOTE: Contact either local server or a random replica.
%% TODO: Replica may be down, so we may need to retry.
ClusterName = get_cluster_name(DB, Shard), ClusterName = get_cluster_name(DB, Shard),
case ra_leaderboard:lookup_members(ClusterName) of case ra_leaderboard:lookup_members(ClusterName) of
Servers when is_list(Servers) -> Servers when is_list(Servers) ->
@ -113,15 +111,14 @@ get_server_local_preferred(DB, Shard) ->
%% TODO %% TODO
%% Leader is unkonwn if there are no servers of this group on the %% Leader is unkonwn if there are no servers of this group on the
%% local node. We want to pick a replica in that case as well. %% local node. We want to pick a replica in that case as well.
%% TODO: Dynamic membership.
pick_random(get_shard_servers(DB, Shard)) pick_random(get_shard_servers(DB, Shard))
end. end.
pick_local(Servers) -> pick_local(Servers) ->
case lists:dropwhile(fun({_Name, Node}) -> Node =/= node() end, Servers) of case lists:keyfind(node(), 2, Servers) of
[Local | _] -> Local when is_tuple(Local) ->
Local; Local;
[] -> false ->
pick_random(Servers) pick_random(Servers)
end. end.
@ -215,6 +212,7 @@ member_info(readiness, Server, Leader) ->
member_readiness(maps:get(Server, Cluster, #{})). member_readiness(maps:get(Server, Cluster, #{})).
current_leader(Server) -> current_leader(Server) ->
%% NOTE: This call will block until the leader is known, or until the timeout.
case ra:members(Server) of case ra:members(Server) of
{ok, _Servers, Leader} -> {ok, _Servers, Leader} ->
Leader; Leader;