diff --git a/apps/emqx/src/emqx_channel.erl b/apps/emqx/src/emqx_channel.erl index 90e8b1ad4..7df7cd42d 100644 --- a/apps/emqx/src/emqx_channel.erl +++ b/apps/emqx/src/emqx_channel.erl @@ -178,7 +178,7 @@ info(timers, #channel{timers = Timers}) -> Timers. set_conn_state(ConnState, Channel) -> Channel#channel{conn_state = ConnState}. -set_session(Session, Channel = Channel = #channel{conninfo = ConnInfo, clientinfo = ClientInfo}) -> +set_session(Session, Channel = #channel{conninfo = ConnInfo, clientinfo = ClientInfo}) -> %% Assume that this is also an updated session. Allow side effect. Session1 = emqx_persistent_session:persist(ClientInfo, ConnInfo, Session), Channel#channel{session = Session1}. diff --git a/apps/emqx/src/emqx_session.erl b/apps/emqx/src/emqx_session.erl index f5ecad865..12b3002c3 100644 --- a/apps/emqx/src/emqx_session.erl +++ b/apps/emqx/src/emqx_session.erl @@ -676,7 +676,7 @@ terminate(ClientInfo, discarded, Session) -> run_hook('session.discarded', [ClientInfo, info(Session)]); terminate(ClientInfo, takeovered, Session) -> run_hook('session.takeovered', [ClientInfo, info(Session)]); -terminate(#{clientid :=_ClientId} = ClientInfo, Reason, Session) -> +terminate(ClientInfo, Reason, Session) -> run_hook('session.terminated', [ClientInfo, Reason, info(Session)]). -compile({inline, [run_hook/2]}). diff --git a/apps/emqx/test/emqx_persistent_session_SUITE.erl b/apps/emqx/test/emqx_persistent_session_SUITE.erl index f3a80280d..040628cf4 100644 --- a/apps/emqx/test/emqx_persistent_session_SUITE.erl +++ b/apps/emqx/test/emqx_persistent_session_SUITE.erl @@ -256,7 +256,7 @@ do_publish(Payloads = [_|_], PublishFun, Config) -> {ok, Client} = emqtt:start_link([ {proto_ver, v5} | Config]), {ok, _} = emqtt:ConnFun(Client), - lists:foreach(fun(Payload) -> PublishFun(Client, Payload)end, Payloads), + lists:foreach(fun(Payload) -> PublishFun(Client, Payload) end, Payloads), ok = emqtt:disconnect(Client) end), receive