From e6bfc14cc9f8f7c792dc55c96fe81e38f9acb237 Mon Sep 17 00:00:00 2001
From: JimMoen <LnJimMoen@outlook.com>
Date: Wed, 31 Jul 2024 09:26:44 +0800
Subject: [PATCH] fix: try-catch optional `on_config_changed/2` plugin app
 callback

---
 apps/emqx_plugins/src/emqx_plugins.erl | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/apps/emqx_plugins/src/emqx_plugins.erl b/apps/emqx_plugins/src/emqx_plugins.erl
index 56a88d7cb..94c6aa4e1 100644
--- a/apps/emqx_plugins/src/emqx_plugins.erl
+++ b/apps/emqx_plugins/src/emqx_plugins.erl
@@ -380,7 +380,18 @@ maybe_call_on_config_changed(NameVsn, NewConf) ->
         {ok, PluginAppModule} ?= app_module_name(NameVsn),
         true ?= erlang:function_exported(PluginAppModule, FuncName, 2),
         {ok, OldConf} = get_config(NameVsn),
-        _ = erlang:apply(PluginAppModule, FuncName, [OldConf, NewConf])
+        try erlang:apply(PluginAppModule, FuncName, [OldConf, NewConf]) of
+            _ -> ok
+        catch
+            Class:CatchReason:Stacktrace ->
+                ?SLOG(error, #{
+                    msg => "failed_to_call_on_config_changed",
+                    exception => Class,
+                    reason => CatchReason,
+                    stacktrace => Stacktrace
+                }),
+                ok
+        end
     else
         {error, Reason} ->
             ?SLOG(info, #{msg => "failed_to_call_on_config_changed", reason => Reason});