From e341387837786188fa2919ebf6ae2106702818a3 Mon Sep 17 00:00:00 2001
From: z8674558 <own7000hr@gmail.com>
Date: Fri, 19 Feb 2021 16:13:44 +0900
Subject: [PATCH] chore(emqx_auth_mnesia): fix dialyzer warnings
 (do_update_user only receives Login and NewPassword)'

---
 apps/emqx_auth_mnesia/src/emqx_auth_mnesia_cli.erl | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/apps/emqx_auth_mnesia/src/emqx_auth_mnesia_cli.erl b/apps/emqx_auth_mnesia/src/emqx_auth_mnesia_cli.erl
index e7c9d982b..aeed5b85c 100644
--- a/apps/emqx_auth_mnesia/src/emqx_auth_mnesia_cli.erl
+++ b/apps/emqx_auth_mnesia/src/emqx_auth_mnesia_cli.erl
@@ -59,12 +59,12 @@ insert_user(User = #emqx_user{login = Login}) ->
 %% @doc Update User
 -spec(update_user(tuple(), binary()) -> ok | {error, any()}).
 update_user(Login, NewPassword) ->
-    User = #emqx_user{login = Login, password = encrypted_data(NewPassword)},
-    ret(mnesia:transaction(fun do_update_user/1, [User])).
+    ret(mnesia:transaction(fun do_update_user/2, [Login, encrypted_data(NewPassword)])).
 
-do_update_user(User = #emqx_user{login = Login}) ->
+do_update_user(Login, NewPassword) ->
     case mnesia:read(?TABLE, Login) of
-        [{?TABLE, Login, _, CreateAt}] -> mnesia:write(User#emqx_user{created_at = CreateAt});
+        [#emqx_user{} = User] ->
+            mnesia:write(User#emqx_user{password = NewPassword});
         [] -> mnesia:abort(noexisted)
     end.