yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore(route-sync): turn TODO into comment

This commit is contained in:
Andrew Mayorov 2024-01-11 18:55:39 +01:00
parent 8f4758d9d4
commit e21a3497c7
No known key found for this signature in database
GPG Key ID: 2837C62ACFBFED5D
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
apps/emqx/src/emqx_router_syncer.erl
View File

@ -184,7 +184,12 @@ run_batch_loop(Incoming, State = #{stash := Stash0}) ->
Status = #{} ->
ok = send_replies(Status, Batch),
NState = cancel_retry_timer(State#{stash := Stash3}),
%% TODO: postpone if only ?PRIO_BG operations left?
%% NOTE
%% We could postpone batches where only `?PRIO_BG` operations left, which
%% would allow to do less work in situations when there are intermittently
%% reconnecting clients with moderately unique subscriptions. However, this
%% would also require us to forego the idempotency of batch syncs (see
%% `merge_route_op/2`).
case is_stash_empty(Stash3) of
true ->
NState;