diff --git a/Makefile b/Makefile index ab0bbeac0..69682f29c 100644 --- a/Makefile +++ b/Makefile @@ -53,11 +53,6 @@ coveralls: $(REBAR) .PHONY: $(REL_PROFILES) $(REL_PROFILES:%=%): $(REBAR) get-dashboard -ifneq ($(shell echo $(@) |grep edge),) - @export EMQX_DESC="$${EMQX_DESC} Edge" -else - @export EMQX_DESC="$${EMQX_DESC} Broker" -endif @$(REBAR) as $(@) release ## Not calling rebar3 clean because diff --git a/data/emqx_vars b/data/emqx_vars index ea566d3ee..8081badbe 100644 --- a/data/emqx_vars +++ b/data/emqx_vars @@ -16,7 +16,7 @@ RUNNER_USER="{{ runner_user }}" LIB_EKKA_DIR="${RUNNER_LIB_DIR}/ekka-$(grep ekka "${RUNNER_ROOT_DIR}/releases/RELEASES" | awk -F '\"' '{print $2}')" EMQX_LICENSE_CONF='' -EMQX_DESCRIPTION="{{ emqx_description }}" +export EMQX_DESCRIPTION='{{ emqx_description }}' ## computed vars REL_NAME="emqx" diff --git a/src/emqx.app.src b/src/emqx.app.src index ce90feb1f..a9ae81cac 100644 --- a/src/emqx.app.src +++ b/src/emqx.app.src @@ -1,5 +1,6 @@ {application, emqx, [{id, "emqx"}, + {description, "EMQ X"}, {vsn, "4.3.0"}, % strict semver, bump manually! {modules, []}, {registered, []}, diff --git a/src/emqx.app.src.script b/src/emqx.app.src.script deleted file mode 100644 index 8495ca9bd..000000000 --- a/src/emqx.app.src.script +++ /dev/null @@ -1,6 +0,0 @@ -[{application, Name, Opts}] = CONFIG, -Desc = case os:getenv("EMQX_DESC") of - [_ | _] = D -> D; - _ -> "EMQ X test" - end, -[{application, Name, [{description, Desc} | Opts]}]. diff --git a/src/emqx_app.erl b/src/emqx_app.erl index 3d08cf668..4f8d47390 100644 --- a/src/emqx_app.erl +++ b/src/emqx_app.erl @@ -20,6 +20,7 @@ -export([ start/2 , stop/1 + , get_description/0 , get_release/0 ]). @@ -59,8 +60,15 @@ print_banner() -> io:format("Starting ~s on node ~s~n", [?APP, node()]). print_vsn() -> - {ok, Descr} = application:get_key(description), - io:format("~s ~s is running now!~n", [Descr, get_release()]). + io:format("~s ~s is running now!~n", [get_description(), get_release()]). + +get_description() -> + {ok, Descr0} = application:get_key(?APP, description), + case os:getenv("EMQX_DESCRIPTION") of + false -> Descr0; + "" -> Descr0; + Str -> string:strip(Str, both, $\n) + end. -ifdef(TEST). %% When testing, the 'cover' compiler stripps aways compile info diff --git a/src/emqx_sys.erl b/src/emqx_sys.erl index 9b256df0b..5542566a5 100644 --- a/src/emqx_sys.erl +++ b/src/emqx_sys.erl @@ -85,13 +85,11 @@ stop() -> %% @doc Get sys version -spec(version() -> string()). -version() -> - {ok, Version} = application:get_key(?APP, vsn), Version. +version() -> emqx_app:get_release(). %% @doc Get sys description -spec(sysdescr() -> string()). -sysdescr() -> - {ok, Descr} = application:get_key(?APP, description), Descr. +sysdescr() -> emqx_app:get_description(). %% @doc Get sys uptime -spec(uptime() -> string()).