From dfb7faf6a8a8a011c07f429b595c55011b7c3bb2 Mon Sep 17 00:00:00 2001
From: Andrew Mayorov <encube.ul@gmail.com>
Date: Wed, 3 May 2023 18:53:18 +0300
Subject: [PATCH] fix(tpl): ensure rough backward compat in `emqx_prometheus`

But also emit warning when job name template renders with errors.
---
 apps/emqx_prometheus/src/emqx_prometheus.app.src |  2 +-
 apps/emqx_prometheus/src/emqx_prometheus.erl     | 10 +++++++++-
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/apps/emqx_prometheus/src/emqx_prometheus.app.src b/apps/emqx_prometheus/src/emqx_prometheus.app.src
index c4abbec27..4631fec8b 100644
--- a/apps/emqx_prometheus/src/emqx_prometheus.app.src
+++ b/apps/emqx_prometheus/src/emqx_prometheus.app.src
@@ -2,7 +2,7 @@
 {application, emqx_prometheus, [
     {description, "Prometheus for EMQX"},
     % strict semver, bump manually!
-    {vsn, "5.0.16"},
+    {vsn, "5.0.17"},
     {modules, []},
     {registered, [emqx_prometheus_sup]},
     {applications, [kernel, stdlib, prometheus, emqx, emqx_management]},
diff --git a/apps/emqx_prometheus/src/emqx_prometheus.erl b/apps/emqx_prometheus/src/emqx_prometheus.erl
index fa9a39cc6..41dec9ee9 100644
--- a/apps/emqx_prometheus/src/emqx_prometheus.erl
+++ b/apps/emqx_prometheus/src/emqx_prometheus.erl
@@ -113,10 +113,18 @@ handle_info(_Msg, State) ->
 
 push_to_push_gateway(Uri, Headers, JobName) when is_list(Headers) ->
     [Name, Ip] = string:tokens(atom_to_list(node()), "@"),
-    JobName1 = emqx_connector_template:render_strict(
+    % NOTE: allowing errors here to keep rough backward compatibility
+    {JobName1, Errors} = emqx_connector_template:render(
         emqx_connector_template:parse(JobName),
         #{<<"name">> => Name, <<"host">> => Ip}
     ),
+    _ =
+        Errors == [] orelse
+            ?SLOG(warning, #{
+                msg => "prometheus_job_name_template_invalid",
+                errors => Errors,
+                template => JobName
+            }),
     Data = prometheus_text_format:format(),
     Url = lists:concat([Uri, "/metrics/job/", unicode:characters_to_list(JobName1)]),
     case httpc:request(post, {Url, Headers, "text/plain", Data}, ?HTTP_OPTIONS, []) of