From dfab9492c600360216bebefb6ff36129d03adba9 Mon Sep 17 00:00:00 2001
From: Zaiming Shi <zmstone@gmail.com>
Date: Tue, 18 May 2021 09:48:12 +0200
Subject: [PATCH] fix(emqx_connection): do not log einval error

einval happens when trying to send data to a closed socket.
---
 src/emqx.appup.src      | 2 ++
 src/emqx_connection.erl | 5 ++++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/emqx.appup.src b/src/emqx.appup.src
index 7e21ef4ed..ce5ddb08e 100644
--- a/src/emqx.appup.src
+++ b/src/emqx.appup.src
@@ -2,6 +2,7 @@
 {VSN,
  [
    {"4.3.1", [
+     {load_module, emqx_connection, brutal_purge, soft_purge, []},
      {load_module, emqx_congestion, brutal_purge, soft_purge, []},
      {load_module, emqx_node_dump, brutal_purge, soft_purge, []}
    ]},
@@ -18,6 +19,7 @@
  ],
  [
    {"4.3.1", [
+     {load_module, emqx_connection, brutal_purge, soft_purge, []},
      {load_module, emqx_congestion, brutal_purge, soft_purge, []},
      {load_module, emqx_node_dump, brutal_purge, soft_purge, []}
    ]},
diff --git a/src/emqx_connection.erl b/src/emqx_connection.erl
index 89bb06e12..8b4940308 100644
--- a/src/emqx_connection.erl
+++ b/src/emqx_connection.erl
@@ -683,7 +683,10 @@ handle_info(activate_socket, State = #state{sockstate = OldSst}) ->
     end;
 
 handle_info({sock_error, Reason}, State) ->
-    Reason =/= closed andalso ?LOG(error, "Socket error: ~p", [Reason]),
+    case Reason =/= closed andalso Reason =/= einval of
+        true -> ?LOG(warning, "socket_error: ~p", [Reason]);
+        false -> ok
+    end,
     handle_info({sock_closed, Reason}, close_socket(State));
 
 handle_info(Info, State) ->