yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore(gw): fix dialyzer warnings

This commit is contained in:
JianBo He 2021-09-01 15:21:07 +08:00
parent fd12a7ac9c
commit dc05cdc586
3 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/emqx_gateway/src/emqx_gateway_api_clients.erl
View File

@ -117,7 +117,7 @@ clients_insta(delete, #{ bindings := #{name := GwName0,
}) -> }) ->
GwName = binary_to_existing_atom(GwName0), GwName = binary_to_existing_atom(GwName0),
ClientId = emqx_mgmt_util:urldecode(ClientId0), ClientId = emqx_mgmt_util:urldecode(ClientId0),
emqx_gateway_http:kickout_client(GwName, ClientId), _ = emqx_gateway_http:kickout_client(GwName, ClientId),
{200}. {200}.
%% FIXME: %% FIXME:

5
apps/emqx_gateway/src/emqx_gateway_http.erl
View File

@ -101,7 +101,8 @@ listener_name(GwName, Type, LisName) ->
%% Mgmt APIs - clients %% Mgmt APIs - clients
%%-------------------------------------------------------------------- %%--------------------------------------------------------------------
-spec lookup_client(gateway_name(), emqx_type:clientid(), function()) -> list(). -spec lookup_client(gateway_name(),
emqx_type:clientid(), {atom(), atom()}) -> list().
lookup_client(GwName, ClientId, FormatFun) -> lookup_client(GwName, ClientId, FormatFun) ->
lists:append([lookup_client(Node, GwName, {clientid, ClientId}, FormatFun) lists:append([lookup_client(Node, GwName, {clientid, ClientId}, FormatFun)
|| Node <- ekka_mnesia:running_nodes()]). || Node <- ekka_mnesia:running_nodes()]).
@ -185,7 +186,7 @@ with_channel(GwName, ClientId, Fun) ->
%% Utils %% Utils
%%-------------------------------------------------------------------- %%--------------------------------------------------------------------
-spec return_http_error(integer(), binary()) -> binary(). -spec return_http_error(integer(), binary()) -> {integer(), binary()}.
return_http_error(Code, Msg) -> return_http_error(Code, Msg) ->
{Code, emqx_json:encode( {Code, emqx_json:encode(
#{code => codestr(Code), #{code => codestr(Code),

4
apps/emqx_gateway/src/mqttsn/emqx_sn_channel.erl
View File

@ -23,7 +23,6 @@
-include_lib("emqx/include/emqx_mqtt.hrl"). -include_lib("emqx/include/emqx_mqtt.hrl").
-include_lib("emqx/include/logger.hrl"). -include_lib("emqx/include/logger.hrl").
%% API %% API
-export([ info/1 -export([ info/1
, info/2 , info/2
@ -1108,6 +1107,9 @@ handle_call({subscribe, _Topic, _Subopts}, Channel) ->
handle_call({unsubscribe, _Topic}, Channel) -> handle_call({unsubscribe, _Topic}, Channel) ->
reply({error, not_supported_now}, Channel); reply({error, not_supported_now}, Channel);
handle_call(subscriptions, Channel) ->
reply({error, not_supported_now}, Channel);
handle_call(kick, Channel) -> handle_call(kick, Channel) ->
NChannel = ensure_disconnected(kicked, Channel), NChannel = ensure_disconnected(kicked, Channel),
shutdown_and_reply(kicked, ok, NChannel); shutdown_and_reply(kicked, ok, NChannel);