yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: reinstate transactions

This commit is contained in:
Thales Macedo Garitezi 2023-08-16 16:05:08 -03:00
parent 65085d012b
commit dbfacae283
1 changed files with 45 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
apps/emqx_durable_storage/src/emqx_ds.erl
View File

@ -136,20 +136,29 @@ message_stats() ->
%% the broker. %% the broker.
-spec session_open(emqx_types:clientid()) -> {_New :: boolean(), session_id()}. -spec session_open(emqx_types:clientid()) -> {_New :: boolean(), session_id()}.
session_open(ClientID) -> session_open(ClientID) ->
case mnesia:dirty_read(?SESSION_TAB, ClientID) of {atomic, Res} =
mria:transaction(?DS_SHARD, fun() ->
case mnesia:read(?SESSION_TAB, ClientID, write) of
[#session{}] -> [#session{}] ->
{false, ClientID}; {false, ClientID};
[] -> [] ->
Session = #session{id = ClientID}, Session = #session{id = ClientID},
mria:dirty_write(?SESSION_TAB, Session), mnesia:write(?SESSION_TAB, Session, write),
{true, ClientID} {true, ClientID}
end. end
end),
Res.
%% @doc Called when a client reconnects with `clean session=true' or %% @doc Called when a client reconnects with `clean session=true' or
%% during session GC %% during session GC
-spec session_drop(emqx_types:clientid()) -> ok. -spec session_drop(emqx_types:clientid()) -> ok.
session_drop(ClientID) -> session_drop(ClientID) ->
ok = mria:dirty_delete({?SESSION_TAB, ClientID}), {atomic, ok} = mria:transaction(
?DS_SHARD,
fun() ->
mnesia:delete({?SESSION_TAB, ClientID})
end
),
ok. ok.
%% @doc Called when a client disconnects. This function terminates all %% @doc Called when a client disconnects. This function terminates all
@ -164,7 +173,9 @@ session_suspend(_SessionId) ->
{ok, iterator_id(), time(), _IsNew :: boolean()}. {ok, iterator_id(), time(), _IsNew :: boolean()}.
session_add_iterator(DSSessionId, TopicFilter) -> session_add_iterator(DSSessionId, TopicFilter) ->
IteratorRefId = {DSSessionId, TopicFilter}, IteratorRefId = {DSSessionId, TopicFilter},
case mnesia:dirty_read(?ITERATOR_REF_TAB, IteratorRefId) of {atomic, Res} =
mria:transaction(?DS_SHARD, fun() ->
case mnesia:read(?ITERATOR_REF_TAB, IteratorRefId, write) of
[] -> [] ->
{IteratorId, StartMS} = new_iterator_id(DSSessionId), {IteratorId, StartMS} = new_iterator_id(DSSessionId),
IteratorRef = #iterator_ref{ IteratorRef = #iterator_ref{
@ -172,7 +183,7 @@ session_add_iterator(DSSessionId, TopicFilter) ->
it_id = IteratorId, it_id = IteratorId,
start_time = StartMS start_time = StartMS
}, },
ok = mria:dirty_write(?ITERATOR_REF_TAB, IteratorRef), ok = mnesia:write(?ITERATOR_REF_TAB, IteratorRef, write),
?tp( ?tp(
ds_session_subscription_added, ds_session_subscription_added,
#{iterator_id => IteratorId, session_id => DSSessionId} #{iterator_id => IteratorId, session_id => DSSessionId}
@ -186,7 +197,9 @@ session_add_iterator(DSSessionId, TopicFilter) ->
), ),
IsNew = false, IsNew = false,
{ok, IteratorId, StartMS, IsNew} {ok, IteratorId, StartMS, IsNew}
end. end
end),
Res.
%% @doc Called when a client unsubscribes from a topic. Returns `true' %% @doc Called when a client unsubscribes from a topic. Returns `true'
%% if the session contained the subscription or `false' if it wasn't %% if the session contained the subscription or `false' if it wasn't