yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve testcases for emqx_logger

This commit is contained in:
terry-xiaoyu 2019-11-01 18:21:46 +08:00
parent 19033b38d9
commit d946848d42
2 changed files with 29 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/emqx_logger.erl
View File

@ -43,6 +43,7 @@
, set_primary_log_level/1 , set_primary_log_level/1
, set_log_handler_level/2 , set_log_handler_level/2
, set_log_level/1 , set_log_level/1
, set_all_log_handlers_level/1
]). ]).
-export([ get_primary_log_level/0 -export([ get_primary_log_level/0

31
test/emqx_logger_SUITE.erl
View File

@ -31,6 +31,12 @@
"-compile({parse_transform, logger_header}).\n" "-compile({parse_transform, logger_header}).\n"
"run() -> '$logger_header'()."). "run() -> '$logger_header'().").
-define(PARSE_TRANS_TEST_CODE2,
"-module(mytest).\n"
"-export([run/0]).\n"
"-compile({parse_transform, logger_header}).\n"
"run() -> '$logger_header'().").
all() -> emqx_ct:all(?MODULE). all() -> emqx_ct:all(?MODULE).
init_per_testcase(_TestCase, Config) -> init_per_testcase(_TestCase, Config) ->
@ -90,6 +96,9 @@ t_set_log_level(_) ->
?assertMatch({error, _Error}, ?LOGGER:set_log_level(for_test)), ?assertMatch({error, _Error}, ?LOGGER:set_log_level(for_test)),
?assertEqual(ok, ?LOGGER:set_log_level(debug)). ?assertEqual(ok, ?LOGGER:set_log_level(debug)).
t_set_all_log_handlers_level(_) ->
?assertMatch({error, _Error}, ?LOGGER:set_all_log_handlers_level(for_test)).
t_parse_transform(_) -> t_parse_transform(_) ->
{ok, Toks, _EndLine} = erl_scan:string(?PARSE_TRANS_TEST_CODE), {ok, Toks, _EndLine} = erl_scan:string(?PARSE_TRANS_TEST_CODE),
FormToks = split_toks_at_dot(Toks), FormToks = split_toks_at_dot(Toks),
@ -101,9 +110,25 @@ t_parse_transform(_) ->
end end
|| Ts <- FormToks], || Ts <- FormToks],
ct:log("=====: ~p", [Forms]), ct:log("=====: ~p", [Forms]),
AST = emqx_logger:parse_transform(Forms, []), AST1 = emqx_logger:parse_transform(Forms, []),
ct:log("=====: ~p", [AST]), ct:log("=====: ~p", [AST1]),
?assertNotEqual(false, lists:keyfind('$logger_header', 3, AST)). ?assertNotEqual(false, lists:keyfind('$logger_header', 3, AST1)).
t_parse_transform_empty_header(_) ->
{ok, Toks, _EndLine} = erl_scan:string(?PARSE_TRANS_TEST_CODE2),
FormToks = split_toks_at_dot(Toks),
Forms = [case erl_parse:parse_form(Ts) of
{ok, Form} ->
Form;
{error, Reason} ->
erlang:error({parse_form_error, Ts, Reason})
end
|| Ts <- FormToks],
ct:log("=====: ~p", [Forms]),
AST2 = emqx_logger:parse_transform(Forms++[{eof, 15}], []),
ct:log("=====: ~p", [AST2]),
?assertNotEqual(false, lists:keyfind('$logger_header', 3, AST2)).
t_set_metadata_peername(_) -> t_set_metadata_peername(_) ->
?assertEqual(ok, ?LOGGER:set_metadata_peername("for_test")). ?assertEqual(ok, ?LOGGER:set_metadata_peername("for_test")).