From d7254cdc7f08811c985dcb289b08764ff0436277 Mon Sep 17 00:00:00 2001
From: Feng Lee <feng@emqx.io>
Date: Fri, 4 Jan 2019 17:17:43 +0800
Subject: [PATCH] Add more macros for logger

---
 include/logger.hrl         | 50 +++++++++++++++++++++++++++++++-------
 src/emqx_connection.erl    |  3 ---
 src/emqx_protocol.erl      |  2 --
 src/emqx_session.erl       |  3 ---
 src/emqx_ws_connection.erl |  2 --
 5 files changed, 41 insertions(+), 19 deletions(-)

diff --git a/include/logger.hrl b/include/logger.hrl
index 71f1a3bb6..6a94d6bc9 100644
--- a/include/logger.hrl
+++ b/include/logger.hrl
@@ -1,10 +1,42 @@
-%%--------------------------------------------------------------------
-%% The args are put into report_cb for lazy evaluation.
-%%--------------------------------------------------------------------
--define(LOG_LZ(Level, Format, Args),
+%% Copyright (c) 2018 EMQ Technologies Co., Ltd. All Rights Reserved.
+%%
+%% Licensed under the Apache License, Version 2.0 (the "License");
+%% you may not use this file except in compliance with the License.
+%% You may obtain a copy of the License at
+%%
+%%     http://www.apache.org/licenses/LICENSE-2.0
+%%
+%% Unless required by applicable law or agreed to in writing, software
+%% distributed under the License is distributed on an "AS IS" BASIS,
+%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+%% See the License for the specific language governing permissions and
+%% limitations under the License.
+
+%% debug | info | notice | warning | error | critical | alert | emergency
+
+-define(DEBUG(Format), ?LOG(debug, Format, [])).
+-define(DEBUG(Format, Args), ?LOG(debug, Format, Args)).
+
+-define(INFO(Format), ?LOG(info, Format, [])).
+-define(INFO(Format, Args), ?LOG(info, Format, Args)).
+
+-define(NOTICE(Format), ?LOG(notice, Format, [])).
+-define(NOTICE(Format, Args), ?LOG(notice, Format, Args)).
+
+-define(WARN(Format), ?LOG(warning, Format, [])).
+-define(WARN(Format, Args), ?LOG(warning, Format, [])).
+
+-define(ERROR(Format), ?LOG(error, Format, [])).
+-define(ERROR(Format, Args), ?LOG(error, Format, Args)).
+
+-define(CRITICAL(Format), ?LOG(critical, Format, [])).
+-define(CRITICAL(Format, Args), ?LOG(critical, Format, Args)).
+
+-define(ALERT(Format), ?LOG(alert, Format, [])).
+-define(ALERT(Format, Args), ?LOG(alert, Format, Args)).
+
+-define(LOG(Level, Format, Args),
         begin
-          (logger:log(Level,#{},#{report_cb =>
-                                    fun(_) ->
-                                        {(Format), (Args)}
-                                    end}))
-        end).
\ No newline at end of file
+          (logger:log(Level,#{},#{report_cb => fun(_) -> {(Format), (Args)} end}))
+        end).
+
diff --git a/src/emqx_connection.erl b/src/emqx_connection.erl
index 47162b009..8859a7152 100644
--- a/src/emqx_connection.erl
+++ b/src/emqx_connection.erl
@@ -18,7 +18,6 @@
 
 -include("emqx.hrl").
 -include("emqx_mqtt.hrl").
-
 -include("logger.hrl").
 
 -export([start_link/3]).
@@ -52,8 +51,6 @@
 -define(DEFAULT_ACTIVE_N, 100).
 -define(SOCK_STATS, [recv_oct, recv_cnt, send_oct, send_cnt, send_pend]).
 
--define(LOG(Level, Format, Args), ?LOG_LZ(Level, "[MQTT] " ++ Format, Args)).
-
 start_link(Transport, Socket, Options) ->
     {ok, proc_lib:spawn_link(?MODULE, init, [[Transport, Socket, Options]])}.
 
diff --git a/src/emqx_protocol.erl b/src/emqx_protocol.erl
index f76d2a322..19d1d9d09 100644
--- a/src/emqx_protocol.erl
+++ b/src/emqx_protocol.erl
@@ -77,8 +77,6 @@
 
 -define(NO_PROPS, undefined).
 
--define(LOG(Level, Format, Args), ?LOG_LZ(Level, "[MQTT] " ++ Format, Args)).
-
 %%------------------------------------------------------------------------------
 %% Init
 %%------------------------------------------------------------------------------
diff --git a/src/emqx_session.erl b/src/emqx_session.erl
index 8375a6e02..966ff738d 100644
--- a/src/emqx_session.erl
+++ b/src/emqx_session.erl
@@ -42,7 +42,6 @@
 
 -include("emqx.hrl").
 -include("emqx_mqtt.hrl").
-
 -include("logger.hrl").
 
 -export([start_link/1]).
@@ -157,8 +156,6 @@
 
 -export_type([attr/0]).
 
--define(LOG(Level, Format, Args), ?LOG_LZ(Level, "[Session] " ++ Format, Args)).
-
 %% @doc Start a session proc.
 -spec(start_link(SessAttrs :: map()) -> {ok, pid()}).
 start_link(SessAttrs) ->
diff --git a/src/emqx_ws_connection.erl b/src/emqx_ws_connection.erl
index df23f50ca..69a3849fe 100644
--- a/src/emqx_ws_connection.erl
+++ b/src/emqx_ws_connection.erl
@@ -46,8 +46,6 @@
 
 -define(SOCK_STATS, [recv_oct, recv_cnt, send_oct, send_cnt]).
 
--define(LOG(Level, Format, Args), ?LOG_LZ(Level, "[MQTT-WS] " ++ Format, Args)).
-
 %%------------------------------------------------------------------------------
 %% API
 %%------------------------------------------------------------------------------