yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(emqx_mod_topic_metrics): Dialyzer warnings

This commit is contained in:
Zaiming Shi 2020-11-06 15:09:51 +01:00
parent 0f0ca1e9fd
commit d47a2294ca
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/emqx_mod_topic_metrics.erl
View File

@ -102,14 +102,14 @@
load(_Env) -> load(_Env) ->
emqx_mod_sup:start_child(?MODULE, worker), emqx_mod_sup:start_child(?MODULE, worker),
emqx:hook('message.publish', {?MODULE, on_message_publish, []}), emqx_hooks:put('message.publish', {?MODULE, on_message_publish, []}),
emqx:hook('message.dropped', {?MODULE, on_message_dropped, []}), emqx_hooks:put('message.dropped', {?MODULE, on_message_dropped, []}),
emqx:hook('message.delivered', {?MODULE, on_message_delivered, []}). emqx_hooks:put('message.delivered', {?MODULE, on_message_delivered, []}).
unload(_Env) -> unload(_Env) ->
emqx:unhook('message.publish', {?MODULE, on_message_publish}), emqx_hooks:del('message.publish', {?MODULE, on_message_publish}),
emqx:unhook('message.dropped', {?MODULE, on_message_dropped}), emqx_hooks:del('message.dropped', {?MODULE, on_message_dropped}),
emqx:unhook('message.delivered', {?MODULE, on_message_delivered}), emqx_hooks:del('message.delivered', {?MODULE, on_message_delivered}),
emqx_mod_sup:stop_child(?MODULE). emqx_mod_sup:stop_child(?MODULE).
description() -> description() ->
@ -118,7 +118,7 @@ description() ->
on_message_publish(#message{topic = Topic, qos = QoS}) -> on_message_publish(#message{topic = Topic, qos = QoS}) ->
case is_registered(Topic) of case is_registered(Topic) of
true -> true ->
inc(Topic, 'messages.in'), try_inc(Topic, 'messages.in'),
case QoS of case QoS of
?QOS_0 -> inc(Topic, 'messages.qos0.in'); ?QOS_0 -> inc(Topic, 'messages.qos0.in');
?QOS_1 -> inc(Topic, 'messages.qos1.in'); ?QOS_1 -> inc(Topic, 'messages.qos1.in');
@ -131,7 +131,7 @@ on_message_publish(#message{topic = Topic, qos = QoS}) ->
on_message_delivered(_, #message{topic = Topic, qos = QoS}) -> on_message_delivered(_, #message{topic = Topic, qos = QoS}) ->
case is_registered(Topic) of case is_registered(Topic) of
true -> true ->
inc(Topic, 'messages.out'), try_inc(Topic, 'messages.out'),
case QoS of case QoS of
?QOS_0 -> inc(Topic, 'messages.qos0.out'); ?QOS_0 -> inc(Topic, 'messages.qos0.out');
?QOS_1 -> inc(Topic, 'messages.qos1.out'); ?QOS_1 -> inc(Topic, 'messages.qos1.out');
@ -155,6 +155,10 @@ start_link() ->
stop() -> stop() ->
gen_server:stop(?MODULE). gen_server:stop(?MODULE).
try_inc(Topic, Metric) ->
_ = inc(Topic, Metric),
ok.
inc(Topic, Metric) -> inc(Topic, Metric) ->
inc(Topic, Metric, 1). inc(Topic, Metric, 1).