From d214ae8772b0d1e0fb86ecd7c5614454bfbd0faf Mon Sep 17 00:00:00 2001 From: Kjell Winblad Date: Mon, 20 Nov 2023 18:59:57 +0100 Subject: [PATCH] fix: problems found by @thalesmg in code review Co-authored-by: Thales Macedo Garitezi --- .../src/emqx_bridge_azure_event_hub_action_info.erl | 2 +- apps/emqx_bridge_kafka/src/emqx_bridge_kafka_action_info.erl | 1 - apps/emqx_connector/src/schema/emqx_connector_schema.erl | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/apps/emqx_bridge_azure_event_hub/src/emqx_bridge_azure_event_hub_action_info.erl b/apps/emqx_bridge_azure_event_hub/src/emqx_bridge_azure_event_hub_action_info.erl index cd35a7dda..c4f395041 100644 --- a/apps/emqx_bridge_azure_event_hub/src/emqx_bridge_azure_event_hub_action_info.erl +++ b/apps/emqx_bridge_azure_event_hub/src/emqx_bridge_azure_event_hub_action_info.erl @@ -29,4 +29,4 @@ connector_action_config_to_bridge_v1_config(ConnectorConfig, ActionConfig) -> ). bridge_v1_config_to_action_config(BridgeV1Conf, ConnectorName) -> - bridge_v1_config_to_action_config(BridgeV1Conf, ConnectorName). + emqx_bridge_kafka_action_info:bridge_v1_config_to_action_config(BridgeV1Conf, ConnectorName). diff --git a/apps/emqx_bridge_kafka/src/emqx_bridge_kafka_action_info.erl b/apps/emqx_bridge_kafka/src/emqx_bridge_kafka_action_info.erl index 154371807..38b57a2b2 100644 --- a/apps/emqx_bridge_kafka/src/emqx_bridge_kafka_action_info.erl +++ b/apps/emqx_bridge_kafka/src/emqx_bridge_kafka_action_info.erl @@ -29,7 +29,6 @@ connector_action_config_to_bridge_v1_config(ConnectorConfig, ActionConfig) -> emqx_utils_maps:rename(<<"parameters">>, <<"kafka">>, BridgeV1Config2). bridge_v1_config_to_action_config(BridgeV1Conf, ConnectorName) -> - BridgeV1Conf, Config0 = emqx_action_info:transform_bridge_v1_config_to_action_config( BridgeV1Conf, ConnectorName, schema_module(), kafka_producer ), diff --git a/apps/emqx_connector/src/schema/emqx_connector_schema.erl b/apps/emqx_connector/src/schema/emqx_connector_schema.erl index 10bf583c3..7c826085c 100644 --- a/apps/emqx_connector/src/schema/emqx_connector_schema.erl +++ b/apps/emqx_connector/src/schema/emqx_connector_schema.erl @@ -183,7 +183,7 @@ transform_bridge_v1_config_to_action_config( (not maps:is_key(ConnectorFieldNameBin, TopKeysMap)) of true -> - maps:remove(to_bin(ConnectorFieldName), ToTransformSoFar); + maps:remove(ConnectorFieldNameBin, ToTransformSoFar); false -> ToTransformSoFar end