From ce6411532b46b8b9cf963852d4cab6171e1e9eba Mon Sep 17 00:00:00 2001
From: zhanghongtong <rory-z@outlook.com>
Date: Sat, 19 Dec 2020 10:51:11 +0800
Subject: [PATCH] test(emqx): fix test case error for emqx

---
 .github/workflows/run_test_cases.yaml | 4 ++--
 test/emqx_mod_sup_SUITE.erl           | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/run_test_cases.yaml b/.github/workflows/run_test_cases.yaml
index d4434a87f..38b470508 100644
--- a/.github/workflows/run_test_cases.yaml
+++ b/.github/workflows/run_test_cases.yaml
@@ -73,9 +73,9 @@ jobs:
         - uses: actions/upload-artifact@v1
           if: failure()
           with:
-            name: logs
+            name: logs_mysql${{ matrix.mysql_vsn }}_reids${{ matrix.redis_vsn }}_mongo${{ matrix.mongo_vsn }}_pgsql${{ matrix.pgsql_vsn }}_ldap${{ matrix.ldap_vsn }}
             path: _build/test/logs
         - uses: actions/upload-artifact@v1
           with:
-            name: cover
+            name: cover_mysql${{ matrix.mysql_vsn }}_reids${{ matrix.redis_vsn }}_mongo${{ matrix.mongo_vsn }}_pgsql${{ matrix.pgsql_vsn }}_ldap${{ matrix.ldap_vsn }}
             path: _build/test/cover
diff --git a/test/emqx_mod_sup_SUITE.erl b/test/emqx_mod_sup_SUITE.erl
index cd4c868ee..230c5ab1d 100644
--- a/test/emqx_mod_sup_SUITE.erl
+++ b/test/emqx_mod_sup_SUITE.erl
@@ -42,8 +42,8 @@ t_start_child(_) ->
              modules => [Mod]},
 
     {ok, _} = emqx_mod_sup:start_link(),
-    {ok, _} = emqx_mod_sup:start_child(Mod, worker),
-    {error, {already_started, _}} = emqx_mod_sup:start_child(Spec),
+    ok  = emqx_mod_sup:start_child(Mod, worker),
+    ?assertError({already_started, _}, emqx_mod_sup:start_child(Spec)),
 
     ok = emqx_mod_sup:stop_child(Mod),
     {error, not_found} = emqx_mod_sup:stop_child(Mod),