From ca973db2fccc01986460e1f7f9843bccc377b4e2 Mon Sep 17 00:00:00 2001
From: Thales Macedo Garitezi <thalesmg@gmail.com>
Date: Tue, 8 Nov 2022 09:58:05 -0300
Subject: [PATCH] refactor: split list comprehension over fn calls

---
 src/emqx_crl_cache.erl | 21 +++++++++++++++------
 1 file changed, 15 insertions(+), 6 deletions(-)

diff --git a/src/emqx_crl_cache.erl b/src/emqx_crl_cache.erl
index d4e35ede4..8dab8d5f1 100644
--- a/src/emqx_crl_cache.erl
+++ b/src/emqx_crl_cache.erl
@@ -180,9 +180,18 @@ ensure_timer(URL, State = #state{refresh_timers = RefreshTimers0}, Timeout) ->
     State#state{refresh_timers = RefreshTimers}.
 
 collect_urls(Listeners) ->
-    lists:usort([URL
-                 || #{proto := ssl, opts := Opts} <- Listeners,
-                    {crl_options, CRLOpts} <- Opts,
-                    proplists:get_bool(crl_cache_enabled, CRLOpts),
-                    {crl_cache_urls, URLs} <- CRLOpts,
-                    URL <- URLs]).
+    CRLOpts0 = [CRLOpts || #{proto := ssl, opts := Opts} <- Listeners,
+                           {crl_options, CRLOpts} <- Opts],
+    CRLOpts1 =
+        lists:filter(
+          fun(CRLOpts) ->
+            proplists:get_bool(crl_cache_enabled, CRLOpts)
+          end,
+          CRLOpts0),
+    CRLURLs =
+        lists:flatmap(
+          fun(CRLOpts) ->
+            proplists:get_value(crl_cache_urls, CRLOpts, [])
+          end,
+          CRLOpts1),
+    lists:usort(CRLURLs).