yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Add more PR templates

This commit is contained in:
Zaiming (Stone) Shi 2022-12-20 09:17:52 +01:00
parent 71d40c0490
commit ca75322302
4 changed files with 21 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.github/PULL_REQUEST_TEMPLATE/ci.md vendored Normal file
View File

@ -0,0 +1,7 @@
Fixes <issue-or-jira-number>
## PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
- [ ] If changed package build ci, pass [this action](https://github.com/emqx/emqx/actions/workflows/build_packages.yaml) (manual trigger)
- [ ] Change log has been added to `changes/` dir for user-facing artifacts update

1
.github/PULL_REQUEST_TEMPLATE/doc.md vendored Normal file
View File

@ -0,0 +1 @@
Fixes <issue-or-jira-number>

11
.github/PULL_REQUEST_TEMPLATE.md → .github/PULL_REQUEST_TEMPLATE/v4.md vendored
View File

@ -1,7 +1,4 @@
<!-- Please describe the current behavior and link to a relevant issue. --> Fixes <issue-or-jira-number>
Fixes <issue-number>
**If your build fails** due to your commit message not passing the build checks, please review the guidelines here: https://github.com/emqx/emqx/blob/master/CONTRIBUTING.md.
## PR Checklist ## PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked: Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
@ -9,11 +6,7 @@ Please convert it to a draft if any of the following conditions are not met. Rev
- [ ] Added tests for the changes - [ ] Added tests for the changes
- [ ] Changed lines covered in coverage report - [ ] Changed lines covered in coverage report
- [ ] Change log has been added to `changes/` dir - [ ] Change log has been added to `changes/` dir
- [ ] For EMQX 4.x: `appup` files updated (execute `scripts/update-appup.sh emqx`) - [ ] `appup` files updated (execute `scripts/update-appup.sh emqx`)
- [ ] For internal contributor: there is a jira ticket to track this change - [ ] For internal contributor: there is a jira ticket to track this change
- [ ] If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up - [ ] If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
- [ ] In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in **Backward Compatibility** section - [ ] In case of non-backward compatible changes, reviewer should check this item as a write-off, and add details in **Backward Compatibility** section
## Backward Compatibility
## More information

11
.github/PULL_REQUEST_TEMPLATE/v5.md vendored Normal file
View File

@ -0,0 +1,11 @@
Fixes <issue-or-jira-number>
## PR Checklist
Please convert it to a draft if any of the following conditions are not met. Reviewers may skip over until all the items are checked:
- [ ] Added tests for the changes
- [ ] Changed lines covered in coverage report
- [ ] Change log has been added to `changes/` dir
- [ ] For internal contributor: there is a jira ticket to track this change
- [ ] If there should be document changes, a PR to emqx-docs.git is sent, or a jira ticket is created to follow up
- [ ] Schema changes are backward compatible