yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

wip(dsrepl): avoid contacting offline nodes prematurely

This commit is contained in:
Andrew Mayorov 2024-03-26 18:13:30 +01:00
parent 0b69c8b7f3
commit c6085a6ab0
No known key found for this signature in database
GPG Key ID: 2837C62ACFBFED5D
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
apps/emqx_durable_storage/src/emqx_ds_replication_layer_shard.erl
View File

@ -82,7 +82,7 @@ get_servers_leader_preferred(DB, Shard) ->
[Leader | lists:delete(Leader, Servers)];
undefined ->
%% TODO: Dynamic membership.
get_shard_servers(DB, Shard)
get_online_servers(DB, Shard)
end.
get_server_local_preferred(DB, Shard) ->
@ -97,9 +97,27 @@ get_server_local_preferred(DB, Shard) ->
%% Leader is unkonwn if there are no servers of this group on the
%% local node. We want to pick a replica in that case as well.
%% TODO: Dynamic membership.
pick_random(get_shard_servers(DB, Shard))
pick_random(get_online_servers(DB, Shard))
end.
get_online_servers(DB, Shard) ->
filter_online(get_shard_servers(DB, Shard)).
filter_online(Servers) ->
case lists:filter(fun is_server_online/1, Servers) of
[] ->
%% FIXME
Servers;
Online ->
Online
end.
is_server_online({_Name, Node}) ->
is_node_online(Node).
is_node_online(Node) ->
Node == node() orelse lists:member(Node, nodes()).
pick_local(Servers) ->
case lists:dropwhile(fun({_Name, Node}) -> Node =/= node() end, Servers) of
[Local | _] ->