From c54847b6e9033bf422d273e819cd58a64f757617 Mon Sep 17 00:00:00 2001
From: Jim Moen <LnJimMoen@outlook.com>
Date: Wed, 1 Sep 2021 14:40:10 +0800
Subject: [PATCH] refactor(mqtt_frame): Avoid duplicate variable when frame
 assembling.

---
 apps/emqx/src/emqx_frame.erl | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/apps/emqx/src/emqx_frame.erl b/apps/emqx/src/emqx_frame.erl
index 082801bad..79a740bed 100644
--- a/apps/emqx/src/emqx_frame.erl
+++ b/apps/emqx/src/emqx_frame.erl
@@ -100,14 +100,10 @@ parse(<<Type:4, Dup:1, QoS:2, Retain:1, Rest/binary>>,
     StrictMode andalso validate_header(Type, Dup, QoS, Retain),
     Header = #mqtt_packet_header{type   = Type,
                                  dup    = bool(Dup),
-                                 qos    = QoS,
+                                 qos    = fixqos(Type, QoS),
                                  retain = bool(Retain)
                                 },
-    Header1 = case fixqos(Type, QoS) of
-                  QoS      -> Header;
-                  FixedQoS -> Header#mqtt_packet_header{qos = FixedQoS}
-              end,
-    parse_remaining_len(Rest, Header1, Options);
+    parse_remaining_len(Rest, Header, Options);
 
 parse(Bin, {{len, #{hdr := Header,
                     len := {Multiplier, Length}}