From de10149133ba43de6bf46b060000d3434ac3e597 Mon Sep 17 00:00:00 2001
From: DDDHuang <44492639+DDDHuang@users.noreply.github.com>
Date: Tue, 14 Jun 2022 17:20:13 +0800
Subject: [PATCH] fix: user change pwd failed, response 400

---
 apps/emqx_dashboard/src/emqx_dashboard_api.erl | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/apps/emqx_dashboard/src/emqx_dashboard_api.erl b/apps/emqx_dashboard/src/emqx_dashboard_api.erl
index 412530c5e..1edd31bbf 100644
--- a/apps/emqx_dashboard/src/emqx_dashboard_api.erl
+++ b/apps/emqx_dashboard/src/emqx_dashboard_api.erl
@@ -154,12 +154,10 @@ schema("/users/:username/change_pwd") ->
             'requestBody' => fields([old_pwd, new_pwd]),
             responses => #{
                 204 => <<"Update user password successfully">>,
-                401 => emqx_dashboard_swagger:error_codes(
-                    [?WRONG_USERNAME_OR_PWD, ?ERROR_PWD_NOT_MATCH], ?DESC(login_failed401)
-                ),
                 404 => response_schema(404),
                 400 => emqx_dashboard_swagger:error_codes(
-                    [?BAD_REQUEST], ?DESC(login_failed_response400)
+                    [?BAD_REQUEST, ?ERROR_PWD_NOT_MATCH],
+                    ?DESC(login_failed_response400)
                 )
             }
         }
@@ -308,7 +306,7 @@ change_pwd(put, #{bindings := #{username := Username}, body := Params}) ->
                     {404, ?USER_NOT_FOUND, <<"User not found">>};
                 {error, <<"password_error">>} ->
                     ?SLOG(error, LogMeta#{result => failed, reason => "error old pwd"}),
-                    {401, ?ERROR_PWD_NOT_MATCH, <<"Old password not match">>};
+                    {400, ?ERROR_PWD_NOT_MATCH, <<"Old password not match">>};
                 {error, Reason} ->
                     ?SLOG(error, LogMeta#{result => failed, reason => Reason}),
                     {400, ?BAD_REQUEST, Reason}