From c43f17920469eabc1b3a366369b345cefbcf622b Mon Sep 17 00:00:00 2001
From: firest <blankalupo@163.com>
Date: Tue, 22 Mar 2022 18:09:06 +0800
Subject: [PATCH] fix(mod_subscription): improve the log information

---
 lib-ce/emqx_modules/src/emqx_mod_subscription.erl | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/lib-ce/emqx_modules/src/emqx_mod_subscription.erl b/lib-ce/emqx_modules/src/emqx_mod_subscription.erl
index 76b4b1ac9..1b6a2c1c7 100644
--- a/lib-ce/emqx_modules/src/emqx_mod_subscription.erl
+++ b/lib-ce/emqx_modules/src/emqx_mod_subscription.erl
@@ -47,10 +47,14 @@ on_client_connected(#{clientid := ClientId, username := Username}, _ConnInfo = #
 
     Fold = fun({Topic, SubOpts}, Acc) ->
                    case rep(Topic, ClientId, Username) of
-                       {error, _} ->
+                       {error, Reason} ->
+                           ?LOG(warning, "auto subscribe ignored, topic filter:~ts reason:~p~n",
+                                [Topic, Reason]),
                            Acc;
                        <<>> ->
-                           ?LOG(warning, "Topic can't be empty when auto subscribe"),
+                           ?LOG(warning, "auto subscribe ignored, topic filter:~ts"
+                                " reason: topic can't be empty~n",
+                                [Topic]),
                            Acc;
                        NewTopic ->
                            [{NewTopic, OptFun(SubOpts)} | Acc]
@@ -82,7 +86,6 @@ rep([<<"%c">> | T], ClientId, Username, Acc) ->
         Username,
         [ClientId | Acc]);
 rep([<<"%u">> | _], _, undefined, _) ->
-    ?LOG(error, "Username undefined when auto subscribe"),
     {error, username_undefined};
 rep([<<"%u">> | T], ClientId, Username, Acc) ->
     rep(T,