From c43b3eb535395c531a633a06ddd967f440912bf8 Mon Sep 17 00:00:00 2001 From: ieQu1 <99872536+ieQu1@users.noreply.github.com> Date: Wed, 6 Dec 2023 15:36:51 +0100 Subject: [PATCH] fix(sessds): Add debug logs for the session garbage collection --- apps/emqx/src/emqx_persistent_session_ds_gc_worker.erl | 2 +- apps/emqx_durable_storage/src/emqx_ds.erl | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/emqx/src/emqx_persistent_session_ds_gc_worker.erl b/apps/emqx/src/emqx_persistent_session_ds_gc_worker.erl index bf607804f..af387d2ca 100644 --- a/apps/emqx/src/emqx_persistent_session_ds_gc_worker.erl +++ b/apps/emqx/src/emqx_persistent_session_ds_gc_worker.erl @@ -82,7 +82,7 @@ try_gc() -> CoreNodes = mria_membership:running_core_nodelist(), Res = global:trans( {?MODULE, self()}, - fun() -> ?tp_span(ds_session_gc, #{}, start_gc()) end, + fun() -> ?tp_span(debug, ds_session_gc, #{}, start_gc()) end, CoreNodes, %% Note: we set retries to 1 here because, in rare occasions, GC might start at the %% same time in more than one node, and each one will abort the other. By allowing diff --git a/apps/emqx_durable_storage/src/emqx_ds.erl b/apps/emqx_durable_storage/src/emqx_ds.erl index 649341eb5..6b371cf79 100644 --- a/apps/emqx_durable_storage/src/emqx_ds.erl +++ b/apps/emqx_durable_storage/src/emqx_ds.erl @@ -195,7 +195,7 @@ store_batch(DB, Msgs) -> %% replay. This function returns stream together with its %% "coordinate": `stream_rank()'. %% -%% Stream rank is a tuple of two integers, let's call them X and Y. If +%% Stream rank is a tuple of two terms, let's call them X and Y. If %% X coordinate of two streams is different, they are independent and %% can be replayed in parallel. If it's the same, then the stream with %% smaller Y coordinate should be replayed first. If Y coordinates are