From c21a2cf4c6e12acd662ed56452d834965a9839a7 Mon Sep 17 00:00:00 2001 From: JimMoen Date: Thu, 20 Oct 2022 17:44:02 +0800 Subject: [PATCH] test(rule_engine): test some unicode chars as rule id --- .../test/emqx_rule_engine_SUITE.erl | 57 +++++++++++++++++ .../test/emqx_rule_test_lib.erl | 61 +++++++++++++++++++ 2 files changed, 118 insertions(+) diff --git a/apps/emqx_rule_engine/test/emqx_rule_engine_SUITE.erl b/apps/emqx_rule_engine/test/emqx_rule_engine_SUITE.erl index df1164204..b8ee6b981 100644 --- a/apps/emqx_rule_engine/test/emqx_rule_engine_SUITE.erl +++ b/apps/emqx_rule_engine/test/emqx_rule_engine_SUITE.erl @@ -28,6 +28,14 @@ -include("emqx_rule_test.hrl"). -import(emqx_rule_test_lib, [make_simple_resource_type/1]). +%% API request funcs +-import(emqx_rule_test_lib, + [ request_api/4 + , request_api/5 + , auth_header_/0 + , api_path/1 + ]). + %%-define(PROPTEST(M,F), true = proper:quickcheck(M:F())). all() -> @@ -62,6 +70,7 @@ groups() -> ]}, {api, [], [t_crud_rule_api, + t_rule_api_unicode_ids, t_list_actions_api, t_show_action_api, t_crud_resources_api, @@ -227,6 +236,10 @@ init_per_testcase(Test, Config) {conn_event, TriggerConnEvent}, {connsql, SQL} | Config]; +init_per_testcase(t_rule_api_unicode_ids, Config) -> + ok = emqx_dashboard_admin:mnesia(boot), + emqx_ct_helpers:start_apps([emqx_management, emqx_dashboard]), + Config; init_per_testcase(_TestCase, Config) -> ok = emqx_rule_registry:register_resource_types( [make_simple_debug_resource_type()]), @@ -249,6 +262,10 @@ end_per_testcase(Test, Config) emqtt:stop(?config(subclient, Config)), emqtt:stop(?config(connclient, Config)), Config; +end_per_testcase(t_rule_api_unicode_ids, _Config) -> + application:stop(emqx_dashboard), + application:stop(emqx_management), + ok; end_per_testcase(_TestCase, _Config) -> ok. @@ -523,6 +540,46 @@ t_crud_rule_api(_Config) -> ?assertMatch({ok, #{code := 404, message := _Message}}, NotFound), ok. +-define(PRED(Elem), fun(Elem) -> true; (_) -> false end). + +t_rule_api_unicode_ids(_Config) -> + UData = + fun(Description) -> + #{<<"name">> => <<"debug-rule">>, + <<"rawsql">> => <<"select * from \"t/a\"">>, + <<"actions">> => [#{<<"name">> => <<"do_nothing">>, + <<"params">> => []} + ], + <<"description">> => Description} + end, + CData = fun(Id, Description) -> maps:put(<<"id">>, Id, UData(Description)) end, + + CDes = <<"Creating rules description">>, + UDes = <<"Updating rules description">>, + + %% create rule + CFun = fun(Id) -> {ok, Return} = request_api(post, api_path(["rules"]), [], auth_header_(), CData(Id, CDes)), Return end, + %% update rule + UFun = fun(Id) -> {ok, Return} = request_api(put, api_path(["rules", cow_uri:urlencode(Id)]), [], auth_header_(), UData(UDes)), Return end, + %% show rule + SFun = fun(Id) -> {ok, Return} = request_api(get, api_path(["rules", cow_uri:urlencode(Id)]), [], auth_header_()), Return end, + %% delete rule + DFun = fun(Id) -> {ok, Return} = request_api(delete, api_path(["rules", cow_uri:urlencode(Id)]), [], auth_header_()), Return end, + + Ids = [unicode:characters_to_binary([Char]) || Char <- lists:seq(0, 1000) -- [46]] ++ [<<"%2e">>], + + Ress = [begin + {?assertMatch(#{<<"code">> := 0, <<"data">> := #{<<"description">> := CDes}}, decode_to_map(CFun(Id))), + ?assertMatch(#{<<"code">> := 0}, decode_to_map(UFun(Id))), + ?assertMatch(#{<<"code">> := 0, <<"data">> := #{<<"description">> := UDes}}, decode_to_map(SFun(Id))), + ?assertMatch(#{<<"code">> := 0}, decode_to_map(DFun(Id)))} + end || Id <- Ids], + + ?assertEqual(true, lists:all(?PRED(true), [?PRED({ok, ok, ok, ok})(Res) || Res <- Ress ])). + +decode_to_map(ResponseBody) -> + jiffy:decode(list_to_binary(ResponseBody), [return_maps]). + t_list_rule_api(_Config) -> AddIds = lists:map(fun(Seq) -> diff --git a/apps/emqx_rule_engine/test/emqx_rule_test_lib.erl b/apps/emqx_rule_engine/test/emqx_rule_test_lib.erl index 24550fbc7..e4ef2f5f5 100644 --- a/apps/emqx_rule_engine/test/emqx_rule_test_lib.erl +++ b/apps/emqx_rule_engine/test/emqx_rule_test_lib.erl @@ -128,6 +128,67 @@ make_simple_resource_type(ResTypeName) -> init_events_counters() -> ets:new(events_record_tab, [named_table, bag, public]). +%%------------------------------------------------------------------------------ +%% rule test helper funcs +%%------------------------------------------------------------------------------ + +-define(HOST, "http://127.0.0.1:18083/"). + +-define(API_VERSION, "v4"). + +-define(BASE_PATH, "api"). + +request_api(Method, Url, Auth) -> + request_api(Method, Url, [], Auth, []). + +request_api(Method, Url, QueryParams, Auth) -> + request_api(Method, Url, QueryParams, Auth, []). + +request_api(Method, Url, QueryParams, Auth, []) -> + NewUrl = case QueryParams of + "" -> Url; + _ -> Url ++ "?" ++ QueryParams + end, + Headers = case Auth of + no_auth -> []; + Header -> [Header] + end, + do_request_api(Method, {NewUrl, Headers}); +request_api(Method, Url, QueryParams, Auth, Body) -> + NewUrl = case QueryParams of + "" -> Url; + _ -> Url ++ "?" ++ QueryParams + end, + Headers = case Auth of + no_auth -> []; + Header -> [Header] + end, + do_request_api(Method, {NewUrl, Headers, "application/json", emqx_json:encode(Body)}). + +do_request_api(Method, Request)-> + %% ct:pal("Method: ~p, Request: ~p", [Method, Request]), + case httpc:request(Method, Request, [], []) of + {error, socket_closed_remotely} -> + {error, socket_closed_remotely}; + {ok, {{"HTTP/1.1", Code, _}, _, Return} } + when Code =:= 200 orelse Code =:= 201 -> + {ok, Return}; + {ok, {Reason, _, _}} -> + {error, Reason} + end. + +auth_header_() -> + AppId = <<"admin">>, + AppSecret = <<"public">>, + auth_header_(binary_to_list(AppId), binary_to_list(AppSecret)). + +auth_header_(User, Pass) -> + Encoded = base64:encode_to_string(lists:append([User,":",Pass])), + {"Authorization","Basic " ++ Encoded}. + +api_path(Parts)-> + ?HOST ++ filename:join([?BASE_PATH, ?API_VERSION] ++ Parts). + %%------------------------------------------------------------------------------ %% Internal helper funcs %%------------------------------------------------------------------------------