From be2ce93a2c1d812280e6f2d39ebc872fa3d58863 Mon Sep 17 00:00:00 2001
From: turtleDeng <turtled@emqtt.io>
Date: Wed, 31 Jul 2019 21:56:28 +0800
Subject: [PATCH] Change log level (#2739)

* Change log level
---
 src/emqx_channel.erl | 2 +-
 src/emqx_rpc.erl     | 2 +-
 src/emqx_session.erl | 4 ++--
 src/emqx_sm.erl      | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/emqx_channel.erl b/src/emqx_channel.erl
index 5aaa62b30..c12015c4b 100644
--- a/src/emqx_channel.erl
+++ b/src/emqx_channel.erl
@@ -356,7 +356,7 @@ handle(info, {timeout, Timer, emit_stats},
     end;
 
 handle(info, {shutdown, discard, {ClientId, ByPid}}, State) ->
-    ?LOG(error, "Discarded by ~s:~p", [ClientId, ByPid]),
+    ?LOG(warning, "Discarded by ~s:~p", [ClientId, ByPid]),
     shutdown(discard, State);
 
 handle(info, {shutdown, conflict, {ClientId, NewPid}}, State) ->
diff --git a/src/emqx_rpc.erl b/src/emqx_rpc.erl
index 5d0370240..d577abbdc 100644
--- a/src/emqx_rpc.erl
+++ b/src/emqx_rpc.erl
@@ -32,7 +32,7 @@ cast(Node, Mod, Fun, Args) ->
     filter_result(?RPC:cast(rpc_node(Node), Mod, Fun, Args)).
 
 rpc_node(Node) ->
-    {ok, ClientNum} = application:get_env(gen_rpc, tcp_client_num),
+    ClientNum = application:get_env(gen_rpc, tcp_client_num, 32),
     {Node, rand:uniform(ClientNum)}.
 
 rpc_nodes(Nodes) ->
diff --git a/src/emqx_session.erl b/src/emqx_session.erl
index 7cdcbece3..543596955 100644
--- a/src/emqx_session.erl
+++ b/src/emqx_session.erl
@@ -401,11 +401,11 @@ handle_call(stats, _From, State) ->
     reply(stats(State), State);
 
 handle_call({discard, ByPid}, _From, State = #state{conn_pid = undefined}) ->
-    ?LOG(warning, "Discarded by ~p", [ByPid]),
+    ?LOG(notice, "Discarded by ~p", [ByPid]),
     {stop, {shutdown, discarded}, ok, State};
 
 handle_call({discard, ByPid}, _From, State = #state{client_id = ClientId, conn_pid = ConnPid}) ->
-    ?LOG(warning, "Conn ~p is discarded by ~p", [ConnPid, ByPid]),
+    ?LOG(notice, "Conn ~p is discarded by ~p", [ConnPid, ByPid]),
     ConnPid ! {shutdown, discard, {ClientId, ByPid}},
     {stop, {shutdown, discarded}, ok, State};
 
diff --git a/src/emqx_sm.erl b/src/emqx_sm.erl
index f6f2fbf47..2befecbd0 100644
--- a/src/emqx_sm.erl
+++ b/src/emqx_sm.erl
@@ -117,7 +117,7 @@ discard_session(ClientId, ConnPid) when is_binary(ClientId) ->
           catch
               _:Error:_Stk ->
                   unregister_session(ClientId, SessPid),
-                  ?LOG(warning, "Failed to discard ~p: ~p", [SessPid, Error])
+                  ?LOG(notice, "Failed to discard ~p: ~p", [SessPid, Error])
           end
       end, lookup_session_pids(ClientId)).