From 34dfc327f36ad8ae3ba9635d94ed8bcce84e896b Mon Sep 17 00:00:00 2001 From: DDDHuang <44492639+DDDHuang@users.noreply.github.com> Date: Wed, 29 Dec 2021 19:32:05 +0800 Subject: [PATCH 1/2] fix(api): auth failed with basic type check --- apps/emqx_dashboard/src/emqx_dashboard.erl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/emqx_dashboard/src/emqx_dashboard.erl b/apps/emqx_dashboard/src/emqx_dashboard.erl index 0c7c03f63..a85db870c 100644 --- a/apps/emqx_dashboard/src/emqx_dashboard.erl +++ b/apps/emqx_dashboard/src/emqx_dashboard.erl @@ -151,9 +151,9 @@ authorize(Req) -> ok -> ok; {error, token_timeout} -> - return_unauthorized(<<"TOKEN_TIME_OUT">>, <<"POST '/login', get new token">>); + {401, <<"TOKEN_TIME_OUT">>, <<"POST '/login', get new token">>}; {error, not_found} -> - return_unauthorized(<<"BAD_TOKEN">>, <<"POST '/login'">>) + {401, <<"BAD_TOKEN">>, <<"POST '/login', get new token">>} end; _ -> return_unauthorized(<<"AUTHORIZATION_HEADER_ERROR">>, From db9d26903435d6e4372489f697bbdc19e55da868 Mon Sep 17 00:00:00 2001 From: DDDHuang <44492639+DDDHuang@users.noreply.github.com> Date: Thu, 30 Dec 2021 10:29:20 +0800 Subject: [PATCH 2/2] fix(dashboard): batter auth failed response message --- apps/emqx_dashboard/src/emqx_dashboard.erl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/apps/emqx_dashboard/src/emqx_dashboard.erl b/apps/emqx_dashboard/src/emqx_dashboard.erl index a85db870c..e79b0210c 100644 --- a/apps/emqx_dashboard/src/emqx_dashboard.erl +++ b/apps/emqx_dashboard/src/emqx_dashboard.erl @@ -151,9 +151,9 @@ authorize(Req) -> ok -> ok; {error, token_timeout} -> - {401, <<"TOKEN_TIME_OUT">>, <<"POST '/login', get new token">>}; + {401, <<"TOKEN_TIME_OUT">>, <<"Token expired, get new token by POST /login">>}; {error, not_found} -> - {401, <<"BAD_TOKEN">>, <<"POST '/login', get new token">>} + {401, <<"BAD_TOKEN">>, <<"Get a token by POST /login">>} end; _ -> return_unauthorized(<<"AUTHORIZATION_HEADER_ERROR">>,