yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #12170 from thalesmg/feat-bump-actions-failed-unk-r54-20231214 

feat(rule_engine): also bump `unknown` counter for unrecoverable action errors
This commit is contained in:
Thales Macedo Garitezi 2023-12-15 09:40:03 -03:00 committed by GitHub
parent bce35b2dd8 57a8f2351d
commit b703b671eb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
apps/emqx_bridge/test/emqx_bridge_v2_SUITE.erl
View File

@ -968,7 +968,8 @@ t_rule_pointing_to_non_operational_channel(_Config) ->
counters :=
#{
matched := 1,
'actions.failed' := 1
'actions.failed' := 1,
'actions.failed.unknown' := 1
}
},
emqx_metrics_worker:get_metrics(rule_metrics, RuleId)

3
apps/emqx_rule_engine/src/emqx_rule_runtime.erl
View File

@ -580,7 +580,8 @@ inc_action_metrics(RuleId, Result) ->
do_inc_action_metrics(RuleId, {error, {recoverable_error, _}}) ->
emqx_metrics_worker:inc(rule_metrics, RuleId, 'actions.failed.out_of_service');
do_inc_action_metrics(RuleId, {error, {unrecoverable_error, _}}) ->
emqx_metrics_worker:inc(rule_metrics, RuleId, 'actions.failed');
emqx_metrics_worker:inc(rule_metrics, RuleId, 'actions.failed'),
emqx_metrics_worker:inc(rule_metrics, RuleId, 'actions.failed.unknown');
do_inc_action_metrics(RuleId, R) ->
case is_ok_result(R) of
false ->