From adaf238131e530117db4d6091f3b70e1f188d793 Mon Sep 17 00:00:00 2001 From: JianBo He Date: Fri, 24 May 2024 12:51:44 +0800 Subject: [PATCH] fix(s3): fix the convert function if the mode is missing --- apps/emqx_bridge_s3/src/emqx_bridge_s3_upload.erl | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/emqx_bridge_s3/src/emqx_bridge_s3_upload.erl b/apps/emqx_bridge_s3/src/emqx_bridge_s3_upload.erl index 8b7c3216e..6c5ee5d0e 100644 --- a/apps/emqx_bridge_s3/src/emqx_bridge_s3_upload.erl +++ b/apps/emqx_bridge_s3/src/emqx_bridge_s3_upload.erl @@ -238,12 +238,12 @@ convert_actions(undefined, _) -> convert_action(Conf = #{<<"parameters">> := Params, <<"resource_opts">> := ResourceOpts}, _) -> case Params of - #{<<"mode">> := <<"direct">>} -> + #{<<"mode">> := <<"aggregated">>} -> + Conf; + #{} -> %% NOTE: Disable batching for direct uploads. NResourceOpts = ResourceOpts#{<<"batch_size">> => 1, <<"batch_time">> => 0}, - Conf#{<<"resource_opts">> := NResourceOpts}; - #{} -> - Conf + Conf#{<<"resource_opts">> := NResourceOpts} end. %% Interpreting options