From ab51684b36eccb5c7dca4cd8df7ce29bad999582 Mon Sep 17 00:00:00 2001
From: zhongwencool <zhongwencool@gmail.com>
Date: Fri, 28 Oct 2022 14:41:19 +0800
Subject: [PATCH] chore: add more test for emqx_dashboard

---
 lib-ce/emqx_dashboard/etc/emqx_dashboard.conf |  2 +-
 .../src/emqx_dashboard_admin.erl              |  2 +-
 .../emqx_dashboard_admin_bootstrap_user.erl   | 89 +++++++++++++++++++
 3 files changed, 91 insertions(+), 2 deletions(-)
 create mode 100644 lib-ce/emqx_dashboard/test/emqx_dashboard_admin_bootstrap_user.erl

diff --git a/lib-ce/emqx_dashboard/etc/emqx_dashboard.conf b/lib-ce/emqx_dashboard/etc/emqx_dashboard.conf
index 7de3dbbf4..5bcebfc4d 100644
--- a/lib-ce/emqx_dashboard/etc/emqx_dashboard.conf
+++ b/lib-ce/emqx_dashboard/etc/emqx_dashboard.conf
@@ -24,7 +24,7 @@ dashboard.default_user.password = public
 ##username1:password1
 ##username2:password2
 ## ```
-dashboard.bootstrap_users_file = {{ platform_etc_dir }}/bootstrap_users.txt
+# dashboard.bootstrap_users_file = {{ platform_etc_dir }}/bootstrap_users.txt
 
 ##--------------------------------------------------------------------
 ## HTTP Listener
diff --git a/lib-ce/emqx_dashboard/src/emqx_dashboard_admin.erl b/lib-ce/emqx_dashboard/src/emqx_dashboard_admin.erl
index 5ebe18221..402f3e304 100644
--- a/lib-ce/emqx_dashboard/src/emqx_dashboard_admin.erl
+++ b/lib-ce/emqx_dashboard/src/emqx_dashboard_admin.erl
@@ -212,7 +212,7 @@ add_bootstrap_users(File, 0) ->
                 ok -> ok;
                 Error ->
                     %% if failed add bootstrap users, we should clear all bootstrap users
-                    mnesia:transaction(fun clear_bootstrap_users/0, []),
+                    {atomic, ok} = mnesia:transaction(fun clear_bootstrap_users/0, []),
                     Error
                     end;
         {error, Reason} = Error ->
diff --git a/lib-ce/emqx_dashboard/test/emqx_dashboard_admin_bootstrap_user.erl b/lib-ce/emqx_dashboard/test/emqx_dashboard_admin_bootstrap_user.erl
new file mode 100644
index 000000000..452cfc25a
--- /dev/null
+++ b/lib-ce/emqx_dashboard/test/emqx_dashboard_admin_bootstrap_user.erl
@@ -0,0 +1,89 @@
+%%--------------------------------------------------------------------
+%% Copyright (c) 2020-2022 EMQ Technologies Co., Ltd. All Rights Reserved.
+%%
+%% Licensed under the Apache License, Version 2.0 (the "License");
+%% you may not use this file except in compliance with the License.
+%% You may obtain a copy of the License at
+%%
+%%     http://www.apache.org/licenses/LICENSE-2.0
+%%
+%% Unless required by applicable law or agreed to in writing, software
+%% distributed under the License is distributed on an "AS IS" BASIS,
+%% WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+%% See the License for the specific language governing permissions and
+%% limitations under the License.
+%%--------------------------------------------------------------------
+
+-module(emqx_dashboard_admin_bootstrap_user).
+
+-compile(export_all).
+-compile(nowarn_export_all).
+-import(emqx_dashboard_SUITE, [http_post/2]).
+
+-include_lib("common_test/include/ct.hrl").
+-include_lib("eunit/include/eunit.hrl").
+-include_lib("emqx/include/emqx.hrl").
+
+%%--------------------------------------------------------------------
+%% Setups
+%%--------------------------------------------------------------------
+
+all() ->
+    emqx_ct:all(?MODULE).
+
+init_per_suite(Config) ->
+    Config.
+
+end_per_suite(_) ->
+    ok.
+
+%%--------------------------------------------------------------------
+%% Test cases
+%%--------------------------------------------------------------------
+
+t_load_ok(_) ->
+    Bin = <<"test-1:password-1\ntest-2:password-2">>,
+    File = "./bootstrap_users.txt",
+    ok = file:write_file(File, Bin),
+    _ = mnesia:clear_table(emqx_admin),
+    application:set_env(emqx_dashboard, bootstrap_users_file, File),
+    emqx_ct_helpers:start_apps([emqx_dashboard]),
+    ?assertEqual(#{<<"code">> => 0}, check_auth(<<"test-1">>, <<"password-1">>)),
+    ?assertEqual(#{<<"code">> => 0}, check_auth(<<"test-2">>, <<"password-2">>)),
+    ?assertEqual(#{<<"message">> => <<"Username/Password error">>},
+        check_auth(<<"test-2">>, <<"password-1">>)),
+    emqx_ct_helpers:stop_apps([emqx_dashboard]).
+
+t_bootstrap_user_file_not_found(_) ->
+    File = "./bootstrap_users_not_exist.txt",
+    check_load_failed(File),
+    ok.
+
+t_load_invalid_username_failed(_) ->
+    Bin = <<"test-1:password-1\ntest&2:password-2">>,
+    File = "./bootstrap_users.txt",
+    ok = file:write_file(File, Bin),
+    check_load_failed(File),
+    ok.
+
+t_load_invalid_format_failed(_) ->
+    Bin = <<"test-1:password-1\ntest-2password-2">>,
+    File = "./bootstrap_users.txt",
+    ok = file:write_file(File, Bin),
+    check_load_failed(File),
+    ok.
+
+check_load_failed(File) ->
+    _ = mnesia:clear_table(emqx_admin),
+    application:set_env(emqx_dashboard, bootstrap_users_file, File),
+    ?assertError(_, emqx_ct_helpers:start_apps([emqx_dashboard])),
+    ?assertNot(lists:member(emqx_dashboard, application:which_applications())),
+    ?assertEqual(0, mnesia:table_info(mqtt_admin, size)).
+
+
+check_auth(Username, Password) ->
+    {ok, Res} = http_post("auth", #{<<"username">> => Username, <<"password">> => Password}),
+    json(Res).
+
+json(Data) ->
+    {ok, Jsx} = emqx_json:safe_decode(Data, [return_maps]), Jsx.