refactor(session): drop `lookup/1` session API

Due to the fact it's not used for anything right now.
This commit is contained in:
Andrew Mayorov 2023-09-15 12:42:15 +04:00
parent 97881ff3ca
commit ab1c4c4222
No known key found for this signature in database
GPG Key ID: 2837C62ACFBFED5D
3 changed files with 7 additions and 33 deletions

View File

@ -22,14 +22,10 @@
-include("emqx_mqtt.hrl"). -include("emqx_mqtt.hrl").
%% Session API %% Session API
-export([
lookup/1,
destroy/1
]).
-export([ -export([
create/3, create/3,
open/2 open/2,
destroy/1
]). ]).
-export([ -export([
@ -106,10 +102,6 @@ create(#{clientid := ClientID}, _ConnInfo, Conf) ->
open(#{clientid := ClientID}, _ConnInfo) -> open(#{clientid := ClientID}, _ConnInfo) ->
open_session(ClientID). open_session(ClientID).
-spec lookup(emqx_types:clientinfo()) -> none.
lookup(_ClientInfo) ->
'TODO'.
-spec destroy(session() | clientinfo()) -> ok. -spec destroy(session() | clientinfo()) -> ok.
destroy(#{clientid := ClientID}) -> destroy(#{clientid := ClientID}) ->
emqx_ds:session_drop(ClientID). emqx_ds:session_drop(ClientID).

View File

@ -57,11 +57,7 @@
-export([ -export([
create/2, create/2,
open/2, open/2,
destroy/1 destroy/1,
]).
-export([
lookup/2,
destroy/2 destroy/2
]). ]).
@ -145,8 +141,8 @@
}. }.
-type t() :: -type t() ::
emqx_session_mem:t() emqx_session_mem:session()
| emqx_session_ds:t(). | emqx_persistent_session_ds:session().
-define(INFO_KEYS, [ -define(INFO_KEYS, [
id, id,
@ -198,10 +194,6 @@ get_mqtt_conf(Zone, Key) ->
%% Existing sessions %% Existing sessions
%% ------------------------------------------------------------------- %% -------------------------------------------------------------------
-spec lookup(clientinfo(), conninfo()) -> t() | none.
lookup(ClientInfo, ConnInfo) ->
(choose_impl_mod(ConnInfo)):lookup(ClientInfo).
-spec destroy(clientinfo(), conninfo()) -> ok. -spec destroy(clientinfo(), conninfo()) -> ok.
destroy(ClientInfo, ConnInfo) -> destroy(ClientInfo, ConnInfo) ->
(choose_impl_mod(ConnInfo)):destroy(ClientInfo). (choose_impl_mod(ConnInfo)):destroy(ClientInfo).

View File

@ -55,14 +55,10 @@
-compile(nowarn_export_all). -compile(nowarn_export_all).
-endif. -endif.
-export([
lookup/1,
destroy/1
]).
-export([ -export([
create/3, create/3,
open/2 open/2,
destroy/1
]). ]).
-export([ -export([
@ -185,12 +181,6 @@ get_mqtt_conf(Zone, Key) ->
get_mqtt_conf(Zone, Key, Default) -> get_mqtt_conf(Zone, Key, Default) ->
emqx_config:get_zone_conf(Zone, [mqtt, Key], Default). emqx_config:get_zone_conf(Zone, [mqtt, Key], Default).
-spec lookup(emqx_types:clientinfo()) -> none.
lookup(_ClientInfo) ->
% NOTE
% This is a stub. This session impl has no backing store, thus always `none`.
none.
-spec destroy(session() | clientinfo()) -> ok. -spec destroy(session() | clientinfo()) -> ok.
destroy(_Session) -> destroy(_Session) ->
% NOTE % NOTE