From a947df1ea3312b188ec11d2bce4ccc507e835227 Mon Sep 17 00:00:00 2001
From: ieQu1 <99872536+ieQu1@users.noreply.github.com>
Date: Tue, 11 Apr 2023 13:59:08 +0200
Subject: [PATCH] fix(emqx_management): Ignore results from the nodes that are
 down

---
 .../emqx_management/src/emqx_mgmt_api_stats.erl | 17 +++++++++++++----
 changes/ce/fix-10369.en.md                      |  6 ++++++
 2 files changed, 19 insertions(+), 4 deletions(-)
 create mode 100644 changes/ce/fix-10369.en.md

diff --git a/apps/emqx_management/src/emqx_mgmt_api_stats.erl b/apps/emqx_management/src/emqx_mgmt_api_stats.erl
index 1e752aaac..080a37b4d 100644
--- a/apps/emqx_management/src/emqx_mgmt_api_stats.erl
+++ b/apps/emqx_management/src/emqx_mgmt_api_stats.erl
@@ -127,10 +127,19 @@ list(get, #{query_string := Qs}) ->
         true ->
             {200, emqx_mgmt:get_stats()};
         _ ->
-            Data = [
-                maps:from_list(emqx_mgmt:get_stats(Node) ++ [{node, Node}])
-             || Node <- running_nodes()
-            ],
+            Data = lists:foldl(
+                fun(Node, Acc) ->
+                    case emqx_mgmt:get_stats(Node) of
+                        {error, _Err} ->
+                            Acc;
+                        Stats when is_list(Stats) ->
+                            Data = maps:from_list([{node, Node} | Stats]),
+                            [Data | Acc]
+                    end
+                end,
+                [],
+                mria:running_nodes()
+            ),
             {200, Data}
     end.
 
diff --git a/changes/ce/fix-10369.en.md b/changes/ce/fix-10369.en.md
new file mode 100644
index 000000000..594e91fc9
--- /dev/null
+++ b/changes/ce/fix-10369.en.md
@@ -0,0 +1,6 @@
+Fix error `/api/v5/monitor_current` API endpoint when some EMQX nodes are down.
+
+Prior to this fix, sometimes the request returned HTTP code 500 and the following message:
+```
+{"code":"INTERNAL_ERROR","message":"error, badarg, [{erlang,'++',[{error,nodedown},[{node,'emqx@10.42.0.150'}]], ...
+```