yuanbiao
/
emqx
1
0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: fix flaky test cm_SUITE open session racecondition

This commit is contained in:
Zaiming Shi 2021-10-07 11:51:40 +02:00
parent 5369eb231b
commit a882a8c496
1 changed files with 21 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
apps/emqx/test/emqx_cm_SUITE.erl
View File

@ -141,11 +141,8 @@ t_open_session_race_condition(_) ->
end end
end, end,
N = 1000, N = 1000,
[spawn( Pids = lists:flatten([[spawn_monitor(OpenASession), spawn_monitor(OpenASession)] ||
fun() -> _ <- lists:seq(1, N)]),
spawn(OpenASession),
spawn(OpenASession)
end) || _ <- lists:seq(1, N)],
WaitingRecv = fun _Wr(N1, N2, 0) -> WaitingRecv = fun _Wr(N1, N2, 0) ->
{N1, N2}; {N1, N2};
@ -158,14 +155,29 @@ t_open_session_race_condition(_) ->
{Succeeded, Failed} = WaitingRecv(0, 0, 2 * N), {Succeeded, Failed} = WaitingRecv(0, 0, 2 * N),
ct:pal("Race condition status: succeeded=~p failed=~p~n", [Succeeded, Failed]), ct:pal("Race condition status: succeeded=~p failed=~p~n", [Succeeded, Failed]),
?assertEqual(2 * N, length(Pids)),
WaitForDowns =
fun _Wd([{Pid, _Ref}]) -> Pid;
_Wd(Pids0) ->
receive
{'DOWN', DownRef, process, DownPid, _} ->
?assert(lists:member({DownPid, DownRef}, Pids0)),
_Wd(lists:delete({DownPid, DownRef}, Pids0))
after
10000 ->
exit(timeout)
end
end,
Winner = WaitForDowns(Pids),
?assertMatch([_], ets:lookup(emqx_channel, ClientId)), ?assertMatch([_], ets:lookup(emqx_channel, ClientId)),
[Pid] = emqx_cm:lookup_channels(ClientId), ?assertEqual([Winner], emqx_cm:lookup_channels(ClientId)),
?assertMatch([_], ets:lookup(emqx_channel_conn, {ClientId, Pid})), ?assertMatch([_], ets:lookup(emqx_channel_conn, {ClientId, Winner})),
?assertMatch([_], ets:lookup(emqx_channel_registry, ClientId)), ?assertMatch([_], ets:lookup(emqx_channel_registry, ClientId)),
exit(Pid, kill), exit(Winner, kill),
timer:sleep(100), %% TODO deterministic receive {'DOWN', _, process, Winner, _} -> ok end,
ignored = gen_server:call(emqx_cm, ignore, infinity), %% sync
?assertEqual([], emqx_cm:lookup_channels(ClientId)). ?assertEqual([], emqx_cm:lookup_channels(ClientId)).
t_discard_session(_) -> t_discard_session(_) ->