From a78a3892069fae3f00fba0fc8c0924198c8105b6 Mon Sep 17 00:00:00 2001 From: JianBo He Date: Fri, 1 Jul 2022 12:02:17 +0800 Subject: [PATCH] chore: using standard log format --- apps/emqx_resource/src/emqx_resource.app.src | 4 ++-- apps/emqx_resource/src/emqx_resource.appup.src | 7 +++++++ apps/emqx_resource/src/emqx_resource_manager.erl | 6 +++++- 3 files changed, 14 insertions(+), 3 deletions(-) create mode 100644 apps/emqx_resource/src/emqx_resource.appup.src diff --git a/apps/emqx_resource/src/emqx_resource.app.src b/apps/emqx_resource/src/emqx_resource.app.src index 56391713f..1bfd02323 100644 --- a/apps/emqx_resource/src/emqx_resource.app.src +++ b/apps/emqx_resource/src/emqx_resource.app.src @@ -1,7 +1,7 @@ %% -*- mode: erlang -*- {application, emqx_resource, [ - {description, "An OTP application"}, - {vsn, "0.1.0"}, + {description, "Manager for all external resources"}, + {vsn, "0.1.1"}, {registered, []}, {mod, {emqx_resource_app, []}}, {applications, [ diff --git a/apps/emqx_resource/src/emqx_resource.appup.src b/apps/emqx_resource/src/emqx_resource.appup.src new file mode 100644 index 000000000..764c12dcf --- /dev/null +++ b/apps/emqx_resource/src/emqx_resource.appup.src @@ -0,0 +1,7 @@ +%% -*- mode: erlang -*- +%% Unless you know what you are doing, DO NOT edit manually!! +{VSN, + [{"0.1.0",[{load_module,emqx_resource_manager,brutal_purge,soft_purge,[]}]} + ], + [{"0.1.0",[{load_module,emqx_resource_manager,brutal_purge,soft_purge,[]}]} + ]}. diff --git a/apps/emqx_resource/src/emqx_resource_manager.erl b/apps/emqx_resource/src/emqx_resource_manager.erl index ddee2fe8d..3a1afd27c 100644 --- a/apps/emqx_resource/src/emqx_resource_manager.erl +++ b/apps/emqx_resource/src/emqx_resource_manager.erl @@ -484,7 +484,11 @@ handle_connected_health_check(Data) -> Actions = [{state_timeout, ?HEALTHCHECK_INTERVAL, health_check}], {keep_state, UpdatedData, Actions}; (Status, UpdatedData) -> - logger:error("health check for ~p failed: ~p", [Data#data.id, Status]), + ?SLOG(error, #{ + msg => health_check_failed, + id => Data#data.id, + status => Status + }), {next_state, Status, UpdatedData} end ).